Re: [PATCH -next] video: fbdev: atmel_lcdfb: remove set but not used variable 'pdata'

2019-04-11 Thread Bartlomiej Zolnierkiewicz 

On 04/03/2019 10:20 AM, nicolas.fe...@microchip.com wrote:
> On 03/04/2019 at 09:24, YueHaibing wrote:
>> External E-Mail
>>
>>
>> Fixes gcc '-Wunused-but-set-variable' warning:
>>
>> drivers/video/fbdev/atmel_lcdfb.c: In function 'atmel_lcdfb_remove':
>> drivers/video/fbdev/atmel_lcdfb.c:1255:28: warning:
>>   variable 'pdata' set but not used [-Wunused-but-set-variable]
>>
>> It's not used since commit 42110e91de7f ("video: atmel_lcdfb: introduce
>> atmel_lcdfb_power_control")
>>
>> Signed-off-by: YueHaibing 
> 
> Indeed:
> Acked-by: Nicolas Ferre 

Patch queued for v5.2, thanks.

Best regards,
--
Bartlomiej Zolnierkiewicz
Samsung R Institute Poland
Samsung Electronics
___
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel

Re: [PATCH -next] video: fbdev: atmel_lcdfb: remove set but not used variable 'pdata'

2019-04-04 Thread Nicolas.Ferre 
On 03/04/2019 at 09:24, YueHaibing wrote:
> External E-Mail
> 
> 
> Fixes gcc '-Wunused-but-set-variable' warning:
> 
> drivers/video/fbdev/atmel_lcdfb.c: In function 'atmel_lcdfb_remove':
> drivers/video/fbdev/atmel_lcdfb.c:1255:28: warning:
>   variable 'pdata' set but not used [-Wunused-but-set-variable]
> 
> It's not used since commit 42110e91de7f ("video: atmel_lcdfb: introduce
> atmel_lcdfb_power_control")
> 
> Signed-off-by: YueHaibing 

Indeed:
Acked-by: Nicolas Ferre 

Thanks!

> ---
>   drivers/video/fbdev/atmel_lcdfb.c | 2 --
>   1 file changed, 2 deletions(-)
> 
> diff --git a/drivers/video/fbdev/atmel_lcdfb.c 
> b/drivers/video/fbdev/atmel_lcdfb.c
> index b8786ff62b87..e67dfd94bf1d 100644
> --- a/drivers/video/fbdev/atmel_lcdfb.c
> +++ b/drivers/video/fbdev/atmel_lcdfb.c
> @@ -1252,12 +1252,10 @@ static int __exit atmel_lcdfb_remove(struct 
> platform_device *pdev)
>   struct device *dev = >dev;
>   struct fb_info *info = dev_get_drvdata(dev);
>   struct atmel_lcdfb_info *sinfo;
> - struct atmel_lcdfb_pdata *pdata;
>   
>   if (!info || !info->par)
>   return 0;
>   sinfo = info->par;
> - pdata = >pdata;
>   
>   cancel_work_sync(>task);
>   exit_backlight(sinfo);
> 
> 
> 
> 
> 


-- 
Nicolas Ferre
___
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel