Re: [PATCH 05/10] drm: move intel_lpe_audio.h under include/drm/intel

2024-04-11 Thread Jani Nikula
On Thu, 11 Apr 2024, Andi Shyti  wrote:
> Hi Jani,
>
> On Wed, Apr 10, 2024 at 01:05:12PM +0300, Jani Nikula wrote:
>> Clean up the top level include/drm directory by grouping all the Intel
>> specific files under a common subdirectory.
>> 
>> Cc: Daniel Vetter 
>> Cc: Dave Airlie 
>> Cc: Lucas De Marchi 
>> Cc: Jaroslav Kysela 
>> Cc: Takashi Iwai 
>> Signed-off-by: Jani Nikula 
>> ---
>>  drivers/gpu/drm/i915/display/intel_hdmi.c  | 2 +-
>>  drivers/gpu/drm/i915/display/intel_lpe_audio.c | 2 +-
>>  include/drm/{ => intel}/intel_lpe_audio.h  | 0
>
> strange thing here is that we have two different
> intel_lpe_audio.h. Can't they be merged?

Not so strange. The one in i915 is internal to i915, and the one in
include/drm is shared with sound/x86/intel_hdmi_audio.c.

> And, perhaps, we could also think of dropping the intel_ prefix
> for the files inside drm/intel/.

This series was scripted, so I didn't go into manual stuff like that
(yet). :)

BR,
Jani.

>
> In any case,
>
> Reviewed-by: Andi Shyti 
>
> Thanks,
> Andi

-- 
Jani Nikula, Intel


Re: [PATCH 05/10] drm: move intel_lpe_audio.h under include/drm/intel

2024-04-11 Thread Andi Shyti
Hi Jani,

On Wed, Apr 10, 2024 at 01:05:12PM +0300, Jani Nikula wrote:
> Clean up the top level include/drm directory by grouping all the Intel
> specific files under a common subdirectory.
> 
> Cc: Daniel Vetter 
> Cc: Dave Airlie 
> Cc: Lucas De Marchi 
> Cc: Jaroslav Kysela 
> Cc: Takashi Iwai 
> Signed-off-by: Jani Nikula 
> ---
>  drivers/gpu/drm/i915/display/intel_hdmi.c  | 2 +-
>  drivers/gpu/drm/i915/display/intel_lpe_audio.c | 2 +-
>  include/drm/{ => intel}/intel_lpe_audio.h  | 0

strange thing here is that we have two different
intel_lpe_audio.h. Can't they be merged?

And, perhaps, we could also think of dropping the intel_ prefix
for the files inside drm/intel/.

In any case,

Reviewed-by: Andi Shyti 

Thanks,
Andi