Re: [PATCH 05/12] drm/msm/dpu: Stop copying around mode->private_flags
On Thu, Feb 20, 2020 at 05:33:09PM +0200, Ville Syrjälä wrote: > On Thu, Feb 20, 2020 at 11:24:20AM +, Emil Velikov wrote: > > On Wed, 19 Feb 2020 at 20:36, Ville Syrjala > > wrote: > > > > > > From: Ville Syrjälä > > > > > > The driver never sets mode->private_flags so copying > > > it back and forth is entirely pointless. Stop doing it. > > > > > > Also drop private_flags from the tracepoint. > > > > > > Cc: Rob Clark > > > Cc: Sean Paul > > > Cc: linux-arm-...@vger.kernel.org > > > Cc: freedr...@lists.freedesktop.org > > > Signed-off-by: Ville Syrjälä > > > > Perhaps the msm team has a WIP which makes use of it ? > > Maybe if it's one of them five year projects. But anyways, > with an atomic driver there are certainly better ways to > handle this. Yeah with atomic you have your display mode in drm_crtc_state, which you're subposed to subclass so that you can have terabytes of private state. At least in theory :-) ->private_flags was really only useful in pre-atomic drivers. -Daniel -- Daniel Vetter Software Engineer, Intel Corporation http://blog.ffwll.ch ___ dri-devel mailing list dri-devel@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/dri-devel
Re: [PATCH 05/12] drm/msm/dpu: Stop copying around mode->private_flags
On Thu, Feb 20, 2020 at 11:24:20AM +, Emil Velikov wrote: > On Wed, 19 Feb 2020 at 20:36, Ville Syrjala > wrote: > > > > From: Ville Syrjälä > > > > The driver never sets mode->private_flags so copying > > it back and forth is entirely pointless. Stop doing it. > > > > Also drop private_flags from the tracepoint. > > > > Cc: Rob Clark > > Cc: Sean Paul > > Cc: linux-arm-...@vger.kernel.org > > Cc: freedr...@lists.freedesktop.org > > Signed-off-by: Ville Syrjälä > > Perhaps the msm team has a WIP which makes use of it ? Maybe if it's one of them five year projects. But anyways, with an atomic driver there are certainly better ways to handle this. -- Ville Syrjälä Intel ___ dri-devel mailing list dri-devel@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/dri-devel
Re: [PATCH 05/12] drm/msm/dpu: Stop copying around mode->private_flags
On Wed, 19 Feb 2020 at 20:36, Ville Syrjala wrote: > > From: Ville Syrjälä > > The driver never sets mode->private_flags so copying > it back and forth is entirely pointless. Stop doing it. > > Also drop private_flags from the tracepoint. > > Cc: Rob Clark > Cc: Sean Paul > Cc: linux-arm-...@vger.kernel.org > Cc: freedr...@lists.freedesktop.org > Signed-off-by: Ville Syrjälä Perhaps the msm team has a WIP which makes use of it ? Otherwise: Reviewed-by: Emil Velikov -Emil ___ dri-devel mailing list dri-devel@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/dri-devel
