Re: [PATCH 1/2] backlight: Remove s6e63m0 driver

2018-05-01 Thread Daniel Thompson
On Mon, Apr 30, 2018 at 07:29:44PM +0200, Krzysztof Kozlowski wrote:
> The driver for S6E63M0 AMOLED LCD panel is not used.  It does not
> support DeviceTree and respective possible users (S5Pv210 Aquila and
> Goni boards) are DeviceTree-only.
> 
> Suggested-by: Marek Szyprowski 
> Cc: Marek Szyprowski 
> Cc: Inki Dae 
> Signed-off-by: Krzysztof Kozlowski 

No objections to this on my side, however this patch (unlike the other)
doesn't say this driver is *replaced* by an alternative, sounds more
like it has merely bit rotted to the point it becomes unreachable.

So it has my ack but I'll happliy to withdraw it if an interested party
feels they need to devicetreeize it.
Acked-by: Daniel Thompson 


Daniel.


> ---
>  drivers/video/backlight/Kconfig |   8 -
>  drivers/video/backlight/Makefile|   1 -
>  drivers/video/backlight/s6e63m0.c   | 857 
> 
>  drivers/video/backlight/s6e63m0_gamma.h | 266 --
>  4 files changed, 1132 deletions(-)
>  delete mode 100644 drivers/video/backlight/s6e63m0.c
>  delete mode 100644 drivers/video/backlight/s6e63m0_gamma.h
> 
> diff --git a/drivers/video/backlight/Kconfig b/drivers/video/backlight/Kconfig
> index 5d2d0d7e8100..be0c130b6597 100644
> --- a/drivers/video/backlight/Kconfig
> +++ b/drivers/video/backlight/Kconfig
> @@ -111,14 +111,6 @@ config LCD_HP700
> If you have an HP Jornada 700 series handheld (710/720/728)
> say Y to enable LCD control driver.
>  
> -config LCD_S6E63M0
> - tristate "S6E63M0 AMOLED LCD Driver"
> - depends on SPI && BACKLIGHT_CLASS_DEVICE
> - default n
> - help
> -   If you have an S6E63M0 LCD Panel, say Y to enable its
> -   LCD control driver.
> -
>  config LCD_LD9040
>   tristate "LD9040 AMOLED LCD Driver"
>   depends on SPI && BACKLIGHT_CLASS_DEVICE
> diff --git a/drivers/video/backlight/Makefile 
> b/drivers/video/backlight/Makefile
> index 19da71d518bf..8773fdd64e99 100644
> --- a/drivers/video/backlight/Makefile
> +++ b/drivers/video/backlight/Makefile
> @@ -14,7 +14,6 @@ obj-$(CONFIG_LCD_LMS283GF05)+= lms283gf05.o
>  obj-$(CONFIG_LCD_LMS501KF03) += lms501kf03.o
>  obj-$(CONFIG_LCD_LTV350QV)   += ltv350qv.o
>  obj-$(CONFIG_LCD_PLATFORM)   += platform_lcd.o
> -obj-$(CONFIG_LCD_S6E63M0)+= s6e63m0.o
>  obj-$(CONFIG_LCD_TDO24M) += tdo24m.o
>  obj-$(CONFIG_LCD_TOSA)   += tosa_lcd.o
>  obj-$(CONFIG_LCD_VGG2432A4)  += vgg2432a4.o
> diff --git a/drivers/video/backlight/s6e63m0.c 
> b/drivers/video/backlight/s6e63m0.c
> deleted file mode 100644
> index 3c4a22a3063a..
> --- a/drivers/video/backlight/s6e63m0.c
> +++ /dev/null
> @@ -1,857 +0,0 @@
> -/*
> - * S6E63M0 AMOLED LCD panel driver.
> - *
> - * Author: InKi Dae  
> - *
> - * Derived from drivers/video/omap/lcd-apollon.c
> - *
> - * This program is free software; you can redistribute it and/or modify it
> - * under the terms of the GNU General Public License as published by the
> - * Free Software Foundation; either version 2 of the License, or (at your
> - * option) any later version.
> - */
> -
> -#include 
> -#include 
> -#include 
> -#include 
> -#include 
> -#include 
> -#include 
> -#include 
> -#include 
> -#include 
> -#include 
> -
> -#include "s6e63m0_gamma.h"
> -
> -#define SLEEPMSEC0x1000
> -#define ENDDEF   0x2000
> -#define  DEFMASK 0xFF00
> -#define COMMAND_ONLY 0xFE
> -#define DATA_ONLY0xFF
> -
> -#define MIN_BRIGHTNESS   0
> -#define MAX_BRIGHTNESS   10
> -
> -struct s6e63m0 {
> - struct device   *dev;
> - struct spi_device   *spi;
> - unsigned intpower;
> - unsigned intcurrent_brightness;
> - unsigned intgamma_mode;
> - unsigned intgamma_table_count;
> - struct lcd_device   *ld;
> - struct backlight_device *bd;
> - struct lcd_platform_data*lcd_pd;
> -};
> -
> -static const unsigned short seq_panel_condition_set[] = {
> - 0xF8, 0x01,
> - DATA_ONLY, 0x27,
> - DATA_ONLY, 0x27,
> - DATA_ONLY, 0x07,
> - DATA_ONLY, 0x07,
> - DATA_ONLY, 0x54,
> - DATA_ONLY, 0x9f,
> - DATA_ONLY, 0x63,
> - DATA_ONLY, 0x86,
> - DATA_ONLY, 0x1a,
> - DATA_ONLY, 0x33,
> - DATA_ONLY, 0x0d,
> - DATA_ONLY, 0x00,
> - DATA_ONLY, 0x00,
> -
> - ENDDEF, 0x
> -};
> -
> -static const unsigned short seq_display_condition_set[] = {
> - 0xf2, 0x02,
> - DATA_ONLY, 0x03,
> - DATA_ONLY, 0x1c,
> - DATA_ONLY, 0x10,
> - DATA_ONLY, 0x10,
> -
> - 0xf7, 0x03,
> - DATA_ONLY, 0x00,
> - DATA_ONLY, 0x00,
> -
> - ENDDEF, 0x
> -};
> -
> -static const unsigned short seq_gamma_setting[] = {
> - 0xfa, 0x00,
> - DATA_ONLY, 0x18,
> - DATA_ONLY, 0x08,
> -

Re: [PATCH 1/2] backlight: Remove s6e63m0 driver

2018-04-30 Thread Jingoo Han
On Monday, April 30, 2018 1:30 PM, Krzysztof Kozlowski wrote:
> 
> The driver for S6E63M0 AMOLED LCD panel is not used.  It does not
> support DeviceTree and respective possible users (S5Pv210 Aquila and
> Goni boards) are DeviceTree-only.
> 
> Suggested-by: Marek Szyprowski 
> Cc: Marek Szyprowski 
> Cc: Inki Dae 
> Signed-off-by: Krzysztof Kozlowski 
> ---
>  drivers/video/backlight/Kconfig |   8 -
>  drivers/video/backlight/Makefile|   1 -
>  drivers/video/backlight/s6e63m0.c   | 857

> 

Acked-by: Jingoo Han 

Best regards,
Jingoo Han

[.]


___
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel