Hi Maxime,
I love your patch! Yet something to improve:
[auto build test ERROR on sunxi/sunxi/for-next]
[also build test ERROR on soc/for-next xlnx/master linus/master v5.8-rc7
next-20200728]
[cannot apply to mripard/sunxi/for-next]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch]
url:
https://github.com/0day-ci/linux/commits/Maxime-Ripard/drm-sun4i-backend-Support-alpha-property-on-lowest-plane/20200729-033432
base: https://git.kernel.org/pub/scm/linux/kernel/git/sunxi/linux.git
sunxi/for-next
config: arm-defconfig (attached as .config)
compiler: arm-linux-gnueabi-gcc (GCC) 9.3.0
reproduce (this is a W=1 build):
wget
https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O
~/bin/make.cross
chmod +x ~/bin/make.cross
# save the attached .config to linux build tree
COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-9.3.0 make.cross ARCH=arm
If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot
All errors (new ones prefixed by >>):
drivers/gpu/drm/sun4i/sun4i_backend.c: In function
'sun4i_backend_atomic_check':
>> drivers/gpu/drm/sun4i/sun4i_backend.c:592:57: error: expected statement
>> before ')' token
592 | (plane_states[0]->alpha != DRM_BLEND_ALPHA_OPAQUE)))
| ^
vim +592 drivers/gpu/drm/sun4i/sun4i_backend.c
dd63250c55bf26 Maxime Ripard 2018-01-22 484
96180dde23b799 Maxime Ripard 2018-01-22 485 static int
sun4i_backend_atomic_check(struct sunxi_engine *engine,
96180dde23b799 Maxime Ripard 2018-01-22 486
struct drm_crtc_state *crtc_state)
96180dde23b799 Maxime Ripard 2018-01-22 487 {
8f1f25534fff09 Maxime Ripard 2018-02-16 488struct drm_plane_state
*plane_states[SUN4I_BACKEND_NUM_LAYERS] = { 0 };
dcf496a6a60873 Paul Kocialkowski 2018-07-19 489struct sun4i_backend
*backend = engine_to_sun4i_backend(engine);
96180dde23b799 Maxime Ripard 2018-01-22 490struct drm_atomic_state
*state = crtc_state->state;
96180dde23b799 Maxime Ripard 2018-01-22 491struct drm_device *drm
= state->dev;
96180dde23b799 Maxime Ripard 2018-01-22 492struct drm_plane *plane;
65f7fa3a3fcbdb Maxime Ripard 2017-06-26 493unsigned int num_planes
= 0;
65f7fa3a3fcbdb Maxime Ripard 2017-06-26 494unsigned int
num_alpha_planes = 0;
96180dde23b799 Maxime Ripard 2018-01-22 495unsigned int
num_frontend_planes = 0;
dcf496a6a60873 Paul Kocialkowski 2018-07-19 496unsigned int
num_alpha_planes_max = 1;
32463556a634f3 Maxime Ripard 2018-03-01 497unsigned int
num_yuv_planes = 0;
8f1f25534fff09 Maxime Ripard 2018-02-16 498unsigned int
current_pipe = 0;
8f1f25534fff09 Maxime Ripard 2018-02-16 499unsigned int i;
96180dde23b799 Maxime Ripard 2018-01-22 500
96180dde23b799 Maxime Ripard 2018-01-22 501
DRM_DEBUG_DRIVER("Starting checking our planes\n");
96180dde23b799 Maxime Ripard 2018-01-22 502
96180dde23b799 Maxime Ripard 2018-01-22 503if
(!crtc_state->planes_changed)
96180dde23b799 Maxime Ripard 2018-01-22 504return 0;
96180dde23b799 Maxime Ripard 2018-01-22 505
96180dde23b799 Maxime Ripard 2018-01-22 506
drm_for_each_plane_mask(plane, drm, crtc_state->plane_mask) {
96180dde23b799 Maxime Ripard 2018-01-22 507struct
drm_plane_state *plane_state =
96180dde23b799 Maxime Ripard 2018-01-22 508
drm_atomic_get_plane_state(state, plane);
96180dde23b799 Maxime Ripard 2018-01-22 509struct
sun4i_layer_state *layer_state =
96180dde23b799 Maxime Ripard 2018-01-22 510
state_to_sun4i_layer_state(plane_state);
65f7fa3a3fcbdb Maxime Ripard 2017-06-26 511struct
drm_framebuffer *fb = plane_state->fb;
65f7fa3a3fcbdb Maxime Ripard 2017-06-26 512struct
drm_format_name_buf format_name;
96180dde23b799 Maxime Ripard 2018-01-22 513
ab6985108a53d5 Paul Kocialkowski 2018-11-23 514if
(!sun4i_backend_plane_is_supported(plane_state,
ab6985108a53d5 Paul Kocialkowski 2018-11-23 515
_state->uses_frontend))
ab6985108a53d5 Paul Kocialkowski 2018-11-23 516return
-EINVAL;
ab6985108a53d5 Paul Kocialkowski 2018-11-23 517
ab6985108a53d5 Paul Kocialkowski 2018-11-23 518if
(layer_state->uses_frontend) {
96180dde23b799 Maxime Ripard 2018-01-22 519
DRM_DEBUG_DRIVER("Using the frontend for plane %d\n",
96180dde23b799 Maxime Ripard 2018-01-22 520
