Re: [PATCH 1/4] drm/radeon: remove unneeded header include path
On Tue, Mar 24, 2020 at 9:14 PM Masahiro Yamada wrote: > > On Wed, Mar 25, 2020 at 4:42 AM Alex Deucher wrote: > > > > On Tue, Mar 24, 2020 at 12:48 PM Masahiro Yamada > > wrote: > > > > > > Hi, > > > > > > I think this series is a good clean-up. > > > > > > Could you take a look at this please? > > > > Can you resend? I don't seem to have gotten it. Must have ended up > > getting flagged a spam or something. > > > Can you take it from patchwork ? (4 patches) > > https://lore.kernel.org/patchwork/project/lkml/list/?series=429491 Applied. thanks! Alex > > > Thanks. > > > > > > > > Alex > > > > > > > > > > > > > > On Fri, Feb 14, 2020 at 12:40 AM Masahiro Yamada > > > wrote: > > > > > > > > A header include path without $(srctree)/ is suspicious because it does > > > > not work with O= builds. > > > > > > > > You can build drivers/gpu/drm/radeon/ without this include path. > > > > > > > > Signed-off-by: Masahiro Yamada > > > > --- > > > > > > > > drivers/gpu/drm/radeon/Makefile | 2 -- > > > > 1 file changed, 2 deletions(-) > > > > > > > > diff --git a/drivers/gpu/drm/radeon/Makefile > > > > b/drivers/gpu/drm/radeon/Makefile > > > > index c693b2ca0329..9d5d3dc1011f 100644 > > > > --- a/drivers/gpu/drm/radeon/Makefile > > > > +++ b/drivers/gpu/drm/radeon/Makefile > > > > @@ -3,8 +3,6 @@ > > > > # Makefile for the drm device driver. This driver provides support > > > > for the > > > > # Direct Rendering Infrastructure (DRI) in XFree86 4.1.0 and higher. > > > > > > > > -ccflags-y := -Idrivers/gpu/drm/amd/include > > > > - > > > > hostprogs := mkregtable > > > > clean-files := rn50_reg_safe.h r100_reg_safe.h r200_reg_safe.h > > > > rv515_reg_safe.h r300_reg_safe.h r420_reg_safe.h rs600_reg_safe.h > > > > r600_reg_safe.h evergreen_reg_safe.h cayman_reg_safe.h > > > > > > > > -- > > > > 2.17.1 > > > > > > > > > > > > > -- > > > Best Regards > > > Masahiro Yamada > > > ___ > > > dri-devel mailing list > > > dri-devel@lists.freedesktop.org > > > https://lists.freedesktop.org/mailman/listinfo/dri-devel > > > > -- > Best Regards > Masahiro Yamada > ___ > amd-gfx mailing list > amd-...@lists.freedesktop.org > https://lists.freedesktop.org/mailman/listinfo/amd-gfx ___ dri-devel mailing list dri-devel@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/dri-devel
Re: [PATCH 1/4] drm/radeon: remove unneeded header include path
On Wed, Mar 25, 2020 at 4:42 AM Alex Deucher wrote: > > On Tue, Mar 24, 2020 at 12:48 PM Masahiro Yamada wrote: > > > > Hi, > > > > I think this series is a good clean-up. > > > > Could you take a look at this please? > > Can you resend? I don't seem to have gotten it. Must have ended up > getting flagged a spam or something. Can you take it from patchwork ? (4 patches) https://lore.kernel.org/patchwork/project/lkml/list/?series=429491 Thanks. > Alex > > > > > > > > > On Fri, Feb 14, 2020 at 12:40 AM Masahiro Yamada > > wrote: > > > > > > A header include path without $(srctree)/ is suspicious because it does > > > not work with O= builds. > > > > > > You can build drivers/gpu/drm/radeon/ without this include path. > > > > > > Signed-off-by: Masahiro Yamada > > > --- > > > > > > drivers/gpu/drm/radeon/Makefile | 2 -- > > > 1 file changed, 2 deletions(-) > > > > > > diff --git a/drivers/gpu/drm/radeon/Makefile > > > b/drivers/gpu/drm/radeon/Makefile > > > index c693b2ca0329..9d5d3dc1011f 100644 > > > --- a/drivers/gpu/drm/radeon/Makefile > > > +++ b/drivers/gpu/drm/radeon/Makefile > > > @@ -3,8 +3,6 @@ > > > # Makefile for the drm device driver. This driver provides support for > > > the > > > # Direct Rendering Infrastructure (DRI) in XFree86 4.1.0 and higher. > > > > > > -ccflags-y := -Idrivers/gpu/drm/amd/include > > > - > > > hostprogs := mkregtable > > > clean-files := rn50_reg_safe.h r100_reg_safe.h r200_reg_safe.h > > > rv515_reg_safe.h r300_reg_safe.h r420_reg_safe.h rs600_reg_safe.h > > > r600_reg_safe.h evergreen_reg_safe.h cayman_reg_safe.h > > > > > > -- > > > 2.17.1 > > > > > > > > > -- > > Best Regards > > Masahiro Yamada > > ___ > > dri-devel mailing list > > dri-devel@lists.freedesktop.org > > https://lists.freedesktop.org/mailman/listinfo/dri-devel -- Best Regards Masahiro Yamada ___ dri-devel mailing list dri-devel@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/dri-devel
Re: [PATCH 1/4] drm/radeon: remove unneeded header include path
On Tue, Mar 24, 2020 at 12:48 PM Masahiro Yamada wrote: > > Hi, > > I think this series is a good clean-up. > > Could you take a look at this please? Can you resend? I don't seem to have gotten it. Must have ended up getting flagged a spam or something. Alex > > > > On Fri, Feb 14, 2020 at 12:40 AM Masahiro Yamada wrote: > > > > A header include path without $(srctree)/ is suspicious because it does > > not work with O= builds. > > > > You can build drivers/gpu/drm/radeon/ without this include path. > > > > Signed-off-by: Masahiro Yamada > > --- > > > > drivers/gpu/drm/radeon/Makefile | 2 -- > > 1 file changed, 2 deletions(-) > > > > diff --git a/drivers/gpu/drm/radeon/Makefile > > b/drivers/gpu/drm/radeon/Makefile > > index c693b2ca0329..9d5d3dc1011f 100644 > > --- a/drivers/gpu/drm/radeon/Makefile > > +++ b/drivers/gpu/drm/radeon/Makefile > > @@ -3,8 +3,6 @@ > > # Makefile for the drm device driver. This driver provides support for the > > # Direct Rendering Infrastructure (DRI) in XFree86 4.1.0 and higher. > > > > -ccflags-y := -Idrivers/gpu/drm/amd/include > > - > > hostprogs := mkregtable > > clean-files := rn50_reg_safe.h r100_reg_safe.h r200_reg_safe.h > > rv515_reg_safe.h r300_reg_safe.h r420_reg_safe.h rs600_reg_safe.h > > r600_reg_safe.h evergreen_reg_safe.h cayman_reg_safe.h > > > > -- > > 2.17.1 > > > > > -- > Best Regards > Masahiro Yamada > ___ > dri-devel mailing list > dri-devel@lists.freedesktop.org > https://lists.freedesktop.org/mailman/listinfo/dri-devel ___ dri-devel mailing list dri-devel@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/dri-devel
Re: [PATCH 1/4] drm/radeon: remove unneeded header include path
Hi, I think this series is a good clean-up. Could you take a look at this please? On Fri, Feb 14, 2020 at 12:40 AM Masahiro Yamada wrote: > > A header include path without $(srctree)/ is suspicious because it does > not work with O= builds. > > You can build drivers/gpu/drm/radeon/ without this include path. > > Signed-off-by: Masahiro Yamada > --- > > drivers/gpu/drm/radeon/Makefile | 2 -- > 1 file changed, 2 deletions(-) > > diff --git a/drivers/gpu/drm/radeon/Makefile b/drivers/gpu/drm/radeon/Makefile > index c693b2ca0329..9d5d3dc1011f 100644 > --- a/drivers/gpu/drm/radeon/Makefile > +++ b/drivers/gpu/drm/radeon/Makefile > @@ -3,8 +3,6 @@ > # Makefile for the drm device driver. This driver provides support for the > # Direct Rendering Infrastructure (DRI) in XFree86 4.1.0 and higher. > > -ccflags-y := -Idrivers/gpu/drm/amd/include > - > hostprogs := mkregtable > clean-files := rn50_reg_safe.h r100_reg_safe.h r200_reg_safe.h > rv515_reg_safe.h r300_reg_safe.h r420_reg_safe.h rs600_reg_safe.h > r600_reg_safe.h evergreen_reg_safe.h cayman_reg_safe.h > > -- > 2.17.1 > -- Best Regards Masahiro Yamada ___ dri-devel mailing list dri-devel@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/dri-devel
