Re: [PATCH v2 1/2] dt-bindings: display: panel: panel-simple: Add compatible property for waveshare 7inch touchscreen panel
On Tue, Jan 16, 2024 at 09:40:21AM +, Shengyang Chen wrote: > Hi, Conor > > Thanks for comment. > > > -Original Message- > > From: Conor Dooley > > Sent: 2024年1月10日 0:32 > > To: Shengyang Chen > > Cc: devicet...@vger.kernel.org; dri-devel@lists.freedesktop.org; > > neil.armstr...@linaro.org; quic_jessz...@quicinc.com; s...@ravnborg.org; > > airl...@gmail.com; dan...@ffwll.ch; maarten.lankho...@linux.intel.com; > > mrip...@kernel.org; tzimmerm...@suse.de; robh...@kernel.org; > > krzysztof.kozlowski...@linaro.org; conor...@kernel.org; wahre...@gmx.net; > > dave.steven...@raspberrypi.com; thierry.red...@gmail.com; Changhuang > > Liang ; Keith Zhao > > ; Jack Zhu ; > > linux-ker...@vger.kernel.org > > Subject: Re: [PATCH v2 1/2] dt-bindings: display: panel: panel-simple: Add > > compatible property for waveshare 7inch touchscreen panel > > > > On Tue, Jan 09, 2024 at 03:09:48PM +0800, Shengyang Chen wrote: > > > The waveshare 7" 800x480 panel is a clone of Raspberry Pi 7" 800x480 > > > panel It can be drived by Raspberry Pi panel's process but it needs > > > different timing from Raspberry Pi panel. Add compatible property for it. > > > > > > Signed-off-by: Keith Zhao > > > Signed-off-by: Shengyang Chen > > > --- > > > .../devicetree/bindings/display/panel/panel-simple.yaml | 2 ++ > > > 1 file changed, 2 insertions(+) > > > > > > diff --git > > > a/Documentation/devicetree/bindings/display/panel/panel-simple.yaml > > > b/Documentation/devicetree/bindings/display/panel/panel-simple.yaml > > > index 11422af3477e..02f6b1b2ddc9 100644 > > > --- > > > a/Documentation/devicetree/bindings/display/panel/panel-simple.yaml > > > +++ b/Documentation/devicetree/bindings/display/panel/panel-simple.yam > > > +++ l > > > @@ -335,6 +335,8 @@ properties: > > >- vivax,tpc9150-panel > > > # VXT 800x480 color TFT LCD panel > > >- vxt,vl050-8048nt-c01 > > > +# Waveshare 7" (800x480) touchscreen LCD panel > > > + - waveshare,7inch-touchscreen > > > > Is "7inch-touchscreen" really a specific enough identifier for this device? > > > > Referring to official website[1] and Neil's suggestion, maybe I should change > to > "7inch-touchscreen-dsi-lcd" or "waveshare,7inch-dsi-sku19885" if the next > patch version is needed. The one with the sku certainly seems more specific, if a next version is needed I would use that. Thanks, Conor. signature.asc Description: PGP signature
RE: [PATCH v2 1/2] dt-bindings: display: panel: panel-simple: Add compatible property for waveshare 7inch touchscreen panel
> -Original Message- > From: neil.armstr...@linaro.org > Sent: 2024年1月10日 17:06 > To: Conor Dooley ; Shengyang Chen > > Cc: devicet...@vger.kernel.org; dri-devel@lists.freedesktop.org; > quic_jessz...@quicinc.com; s...@ravnborg.org; airl...@gmail.com; > dan...@ffwll.ch; maarten.lankho...@linux.intel.com; mrip...@kernel.org; > tzimmerm...@suse.de; robh...@kernel.org; > krzysztof.kozlowski...@linaro.org; conor...@kernel.org; wahre...@gmx.net; > dave.steven...@raspberrypi.com; thierry.red...@gmail.com; Changhuang > Liang ; Keith Zhao > ; Jack Zhu ; > linux-ker...@vger.kernel.org > Subject: Re: [PATCH v2 1/2] dt-bindings: display: panel: panel-simple: Add > compatible property for waveshare 7inch touchscreen panel > > On 09/01/2024 17:32, Conor Dooley wrote: > > On Tue, Jan 09, 2024 at 03:09:48PM +0800, Shengyang Chen wrote: > >> The waveshare 7" 800x480 panel is a clone of Raspberry Pi 7" 800x480 > >> panel It can be drived by Raspberry Pi panel's process but it needs > >> different timing from Raspberry Pi panel. Add compatible property for it. > >> > >> Signed-off-by: Keith Zhao > >> Signed-off-by: Shengyang Chen > >> --- > >> .../devicetree/bindings/display/panel/panel-simple.yaml | 2 ++ > >> 1 file changed, 2 insertions(+) > >> > >> diff --git > >> a/Documentation/devicetree/bindings/display/panel/panel-simple.yaml > >> b/Documentation/devicetree/bindings/display/panel/panel-simple.yaml > >> index 11422af3477e..02f6b1b2ddc9 100644 > >> --- > >> a/Documentation/devicetree/bindings/display/panel/panel-simple.yaml > >> +++ b/Documentation/devicetree/bindings/display/panel/panel-simple.ya > >> +++ ml > >> @@ -335,6 +335,8 @@ properties: > >> - vivax,tpc9150-panel > >> # VXT 800x480 color TFT LCD panel > >> - vxt,vl050-8048nt-c01 > >> +# Waveshare 7" (800x480) touchscreen LCD panel > >> + - waveshare,7inch-touchscreen > > > > Is "7inch-touchscreen" really a specific enough identifier for this > > device? > > Waveshare has very precise SKUs, this should be something like > waveshare,7inch-dsi-sku19885 perhaps > > Neil thanks for mention, It will be checked if next version is needed. > > > > >> # Winstar Display Corporation 3.5" QVGA (320x240) TFT LCD > panel > >> - winstar,wf35ltiacd > >> # Yes Optoelectronics YTC700TLAG-05-201C 7" TFT LCD panel > >> -- > >> 2.17.1 > >>
RE: [PATCH v2 1/2] dt-bindings: display: panel: panel-simple: Add compatible property for waveshare 7inch touchscreen panel
Hi, Conor Thanks for comment. > -Original Message- > From: Conor Dooley > Sent: 2024年1月10日 0:32 > To: Shengyang Chen > Cc: devicet...@vger.kernel.org; dri-devel@lists.freedesktop.org; > neil.armstr...@linaro.org; quic_jessz...@quicinc.com; s...@ravnborg.org; > airl...@gmail.com; dan...@ffwll.ch; maarten.lankho...@linux.intel.com; > mrip...@kernel.org; tzimmerm...@suse.de; robh...@kernel.org; > krzysztof.kozlowski...@linaro.org; conor...@kernel.org; wahre...@gmx.net; > dave.steven...@raspberrypi.com; thierry.red...@gmail.com; Changhuang > Liang ; Keith Zhao > ; Jack Zhu ; > linux-ker...@vger.kernel.org > Subject: Re: [PATCH v2 1/2] dt-bindings: display: panel: panel-simple: Add > compatible property for waveshare 7inch touchscreen panel > > On Tue, Jan 09, 2024 at 03:09:48PM +0800, Shengyang Chen wrote: > > The waveshare 7" 800x480 panel is a clone of Raspberry Pi 7" 800x480 > > panel It can be drived by Raspberry Pi panel's process but it needs > > different timing from Raspberry Pi panel. Add compatible property for it. > > > > Signed-off-by: Keith Zhao > > Signed-off-by: Shengyang Chen > > --- > > .../devicetree/bindings/display/panel/panel-simple.yaml | 2 ++ > > 1 file changed, 2 insertions(+) > > > > diff --git > > a/Documentation/devicetree/bindings/display/panel/panel-simple.yaml > > b/Documentation/devicetree/bindings/display/panel/panel-simple.yaml > > index 11422af3477e..02f6b1b2ddc9 100644 > > --- > > a/Documentation/devicetree/bindings/display/panel/panel-simple.yaml > > +++ b/Documentation/devicetree/bindings/display/panel/panel-simple.yam > > +++ l > > @@ -335,6 +335,8 @@ properties: > >- vivax,tpc9150-panel > > # VXT 800x480 color TFT LCD panel > >- vxt,vl050-8048nt-c01 > > +# Waveshare 7" (800x480) touchscreen LCD panel > > + - waveshare,7inch-touchscreen > > Is "7inch-touchscreen" really a specific enough identifier for this device? > Referring to official website[1] and Neil's suggestion, maybe I should change to "7inch-touchscreen-dsi-lcd" or "waveshare,7inch-dsi-sku19885" if the next patch version is needed. [1]: https://www.waveshare.com/7inch-dsi-lcd.htm > > # Winstar Display Corporation 3.5" QVGA (320x240) TFT LCD panel > >- winstar,wf35ltiacd > > # Yes Optoelectronics YTC700TLAG-05-201C 7" TFT LCD panel > > -- > > 2.17.1 > > Best Regards, Shengyang
Re: [PATCH v2 1/2] dt-bindings: display: panel: panel-simple: Add compatible property for waveshare 7inch touchscreen panel
On 09/01/2024 17:32, Conor Dooley wrote: On Tue, Jan 09, 2024 at 03:09:48PM +0800, Shengyang Chen wrote: The waveshare 7" 800x480 panel is a clone of Raspberry Pi 7" 800x480 panel It can be drived by Raspberry Pi panel's process but it needs different timing from Raspberry Pi panel. Add compatible property for it. Signed-off-by: Keith Zhao Signed-off-by: Shengyang Chen --- .../devicetree/bindings/display/panel/panel-simple.yaml | 2 ++ 1 file changed, 2 insertions(+) diff --git a/Documentation/devicetree/bindings/display/panel/panel-simple.yaml b/Documentation/devicetree/bindings/display/panel/panel-simple.yaml index 11422af3477e..02f6b1b2ddc9 100644 --- a/Documentation/devicetree/bindings/display/panel/panel-simple.yaml +++ b/Documentation/devicetree/bindings/display/panel/panel-simple.yaml @@ -335,6 +335,8 @@ properties: - vivax,tpc9150-panel # VXT 800x480 color TFT LCD panel - vxt,vl050-8048nt-c01 +# Waveshare 7" (800x480) touchscreen LCD panel + - waveshare,7inch-touchscreen Is "7inch-touchscreen" really a specific enough identifier for this device? Waveshare has very precise SKUs, this should be something like waveshare,7inch-dsi-sku19885 perhaps Neil # Winstar Display Corporation 3.5" QVGA (320x240) TFT LCD panel - winstar,wf35ltiacd # Yes Optoelectronics YTC700TLAG-05-201C 7" TFT LCD panel -- 2.17.1
Re: [PATCH v2 1/2] dt-bindings: display: panel: panel-simple: Add compatible property for waveshare 7inch touchscreen panel
On Tue, Jan 09, 2024 at 03:09:48PM +0800, Shengyang Chen wrote: > The waveshare 7" 800x480 panel is a clone of Raspberry Pi 7" 800x480 panel > It can be drived by Raspberry Pi panel's process but it needs different > timing from Raspberry Pi panel. Add compatible property for it. > > Signed-off-by: Keith Zhao > Signed-off-by: Shengyang Chen > --- > .../devicetree/bindings/display/panel/panel-simple.yaml | 2 ++ > 1 file changed, 2 insertions(+) > > diff --git > a/Documentation/devicetree/bindings/display/panel/panel-simple.yaml > b/Documentation/devicetree/bindings/display/panel/panel-simple.yaml > index 11422af3477e..02f6b1b2ddc9 100644 > --- a/Documentation/devicetree/bindings/display/panel/panel-simple.yaml > +++ b/Documentation/devicetree/bindings/display/panel/panel-simple.yaml > @@ -335,6 +335,8 @@ properties: >- vivax,tpc9150-panel > # VXT 800x480 color TFT LCD panel >- vxt,vl050-8048nt-c01 > +# Waveshare 7" (800x480) touchscreen LCD panel > + - waveshare,7inch-touchscreen Is "7inch-touchscreen" really a specific enough identifier for this device? > # Winstar Display Corporation 3.5" QVGA (320x240) TFT LCD panel >- winstar,wf35ltiacd > # Yes Optoelectronics YTC700TLAG-05-201C 7" TFT LCD panel > -- > 2.17.1 > signature.asc Description: PGP signature
