Re: [PATCH v3] drm/panel: simple: add SGD GKTW70SDAD1SD

2021-02-05 Thread Marco Felsch 
On 21-02-04 19:15, Oliver Graute wrote:
> On 02/02/21, Marco Felsch wrote:
> > Hi Oliver,
> > 
> > On 21-02-02 18:35, Oliver Graute wrote:
> > > Add support for the Solomon Goldentek Display Model: GKTW70SDAD1SD
> > > to panel-simple.
> > > 
> > > The panel spec from Variscite can be found at:
> > > https://www.variscite.com/wp-content/uploads/2017/12/VLCD-CAP-GLD-RGB.pdf
> > > 
> > > Signed-off-by: Oliver Graute 
> > > Cc: Marco Felsch 
> > > Cc: Fabio Estevam 
> > > ---
> > > 
> > > v3:
> > > 
> > > - added flags
> > > - added delay
> > 
> > Thanks, did you test the changes?
> > I just picked it from the datasheet.
> 
> yes, it didn't break anything. 

Feel free to add my:

Reviewed-by: Marco Felsch 

PS:
+1 for Fabio's comment ^^

Regards,
  Marco

> 
> Best regards,
> 
> Oliver
> 

-- 
Pengutronix e.K.   | |
Steuerwalder Str. 21   | http://www.pengutronix.de/  |
31137 Hildesheim, Germany  | Phone: +49-5121-206917-0|
Amtsgericht Hildesheim, HRA 2686   | Fax:   +49-5121-206917- |
___
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel

Re: [PATCH v3] drm/panel: simple: add SGD GKTW70SDAD1SD

2021-02-04 Thread Oliver Graute 
On 02/02/21, Marco Felsch wrote:
> Hi Oliver,
> 
> On 21-02-02 18:35, Oliver Graute wrote:
> > Add support for the Solomon Goldentek Display Model: GKTW70SDAD1SD
> > to panel-simple.
> > 
> > The panel spec from Variscite can be found at:
> > https://www.variscite.com/wp-content/uploads/2017/12/VLCD-CAP-GLD-RGB.pdf
> > 
> > Signed-off-by: Oliver Graute 
> > Cc: Marco Felsch 
> > Cc: Fabio Estevam 
> > ---
> > 
> > v3:
> > 
> > - added flags
> > - added delay
> 
> Thanks, did you test the changes?
> I just picked it from the datasheet.

yes, it didn't break anything. 

Best regards,

Oliver
___
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel

Re: [PATCH v3] drm/panel: simple: add SGD GKTW70SDAD1SD

2021-02-04 Thread Fabio Estevam 
Hi Oliver,

On Tue, Feb 2, 2021 at 2:35 PM Oliver Graute  wrote:

> +static const struct panel_desc sgd_gktw70sdad1sd = {
> +   .timings = _gktw70sdad1sd_timing,
> +   .num_timings = 1,
> +   .bpc = 6,
> +   .size = {
> +   .width = 153,
> +   .height = 86,
> +   },
> +   .delay = {
> +   .prepare = 20 + 20 + 10 + 10,

Adding the datasheet label like Marco suggested make it clearer where
these numbers come from : /* T0 + T2 + T3 + T4 */

Glad you got it working on your imx6ul board:

Reviewed-by: Fabio Estevam 
___
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel

Re: [PATCH v3] drm/panel: simple: add SGD GKTW70SDAD1SD

2021-02-02 Thread Marco Felsch 
Hi Oliver,

On 21-02-02 18:35, Oliver Graute wrote:
> Add support for the Solomon Goldentek Display Model: GKTW70SDAD1SD
> to panel-simple.
> 
> The panel spec from Variscite can be found at:
> https://www.variscite.com/wp-content/uploads/2017/12/VLCD-CAP-GLD-RGB.pdf
> 
> Signed-off-by: Oliver Graute 
> Cc: Marco Felsch 
> Cc: Fabio Estevam 
> ---
> 
> v3:
> 
> - added flags
> - added delay

Thanks, did you test the changes?
I just picked it from the datasheet.

Regards,
  Marco
___
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel