Re: [PATCH v3 1/7] drm/dp_helper: Add helper to check DSC support with given o/p format

2023-03-24 Thread Maarten Lankhorst

ack

On 2023-03-20 09:59, Jani Nikula wrote:

Thomas, Maxime, Maarten, ack for merging this one via drm-intel?

BR,
Jani.



On Thu, 09 Mar 2023, Suraj Kandpal  wrote:

From: Ankit Nautiyal 

Add helper to check if the DP sink supports DSC with the given
o/p format.

v2: Add documentation for the helper. (Uma Shankar)

v3: /** instead of  /* (Uma Shankar)

Signed-off-by: Ankit Nautiyal 
Reviewed-by: Uma Shankar 
---
  include/drm/display/drm_dp_helper.h | 13 +
  1 file changed, 13 insertions(+)

diff --git a/include/drm/display/drm_dp_helper.h 
b/include/drm/display/drm_dp_helper.h
index ab55453f2d2c..533d3ee7fe05 100644
--- a/include/drm/display/drm_dp_helper.h
+++ b/include/drm/display/drm_dp_helper.h
@@ -194,6 +194,19 @@ drm_dp_dsc_sink_max_slice_width(const u8 
dsc_dpcd[DP_DSC_RECEIVER_CAP_SIZE])
DP_DSC_SLICE_WIDTH_MULTIPLIER;
  }
  
+/**

+ * drm_dp_dsc_sink_supports_format() - check if sink supports DSC with given 
output format
+ * @dsc_dpcd : DSC-capability DPCDs of the sink
+ * @output_format: output_format which is to be checked
+ *
+ * Returns true if the sink supports DSC with the given output_format, false 
otherwise.
+ */
+static inline bool
+drm_dp_dsc_sink_supports_format(const u8 dsc_dpcd[DP_DSC_RECEIVER_CAP_SIZE], 
u8 output_format)
+{
+   return dsc_dpcd[DP_DSC_DEC_COLOR_FORMAT_CAP - DP_DSC_SUPPORT] & 
output_format;
+}
+
  /* Forward Error Correction Support on DP 1.4 */
  static inline bool
  drm_dp_sink_supports_fec(const u8 fec_capable)


Re: [PATCH v3 1/7] drm/dp_helper: Add helper to check DSC support with given o/p format

2023-03-20 Thread Jani Nikula


Thomas, Maxime, Maarten, ack for merging this one via drm-intel?

BR,
Jani.



On Thu, 09 Mar 2023, Suraj Kandpal  wrote:
> From: Ankit Nautiyal 
>
> Add helper to check if the DP sink supports DSC with the given
> o/p format.
>
> v2: Add documentation for the helper. (Uma Shankar)
>
> v3: /** instead of  /* (Uma Shankar)
>
> Signed-off-by: Ankit Nautiyal 
> Reviewed-by: Uma Shankar 
> ---
>  include/drm/display/drm_dp_helper.h | 13 +
>  1 file changed, 13 insertions(+)
>
> diff --git a/include/drm/display/drm_dp_helper.h 
> b/include/drm/display/drm_dp_helper.h
> index ab55453f2d2c..533d3ee7fe05 100644
> --- a/include/drm/display/drm_dp_helper.h
> +++ b/include/drm/display/drm_dp_helper.h
> @@ -194,6 +194,19 @@ drm_dp_dsc_sink_max_slice_width(const u8 
> dsc_dpcd[DP_DSC_RECEIVER_CAP_SIZE])
>   DP_DSC_SLICE_WIDTH_MULTIPLIER;
>  }
>  
> +/**
> + * drm_dp_dsc_sink_supports_format() - check if sink supports DSC with given 
> output format
> + * @dsc_dpcd : DSC-capability DPCDs of the sink
> + * @output_format: output_format which is to be checked
> + *
> + * Returns true if the sink supports DSC with the given output_format, false 
> otherwise.
> + */
> +static inline bool
> +drm_dp_dsc_sink_supports_format(const u8 dsc_dpcd[DP_DSC_RECEIVER_CAP_SIZE], 
> u8 output_format)
> +{
> + return dsc_dpcd[DP_DSC_DEC_COLOR_FORMAT_CAP - DP_DSC_SUPPORT] & 
> output_format;
> +}
> +
>  /* Forward Error Correction Support on DP 1.4 */
>  static inline bool
>  drm_dp_sink_supports_fec(const u8 fec_capable)

-- 
Jani Nikula, Intel Open Source Graphics Center