Re: [PATCH v9 00/11] vgaarb: Rework default VGA device selection
I have no objection :) Huacai On Thu, Mar 10, 2022 at 12:29 AM Bjorn Helgaas wrote: > > On Fri, Feb 25, 2022 at 04:15:23PM -0600, Bjorn Helgaas wrote: > > On Thu, Feb 24, 2022 at 04:47:42PM -0600, Bjorn Helgaas wrote: > > > From: Bjorn Helgaas > > > > > > Current default VGA device selection fails in some cases because part of > > > it > > > is done in the vga_arb_device_init() subsys_initcall, and some arches > > > enumerate PCI devices in pcibios_init(), which runs *after* that. > > > > > > The big change from the v8 posting is that this moves vgaarb.c from > > > drivers/gpu/vga to drivers/pci because it really has nothing to do with > > > GPUs or DRM. > > > > I provisionally applied this to pci/vga and put it into -next just > > to get a little runtime on it. > > > > But I'd prefer not to unilaterally yank this out of drivers/gpu > > without a consensus from the GPU folks that this is the right thing to > > do. > > > > Any thoughts? If it seems OK to you, I think patch 1/11 (the move > > itself) is all you would need to look at, although of course I would > > still be grateful for any review and feedback on the rest. > > > > After it's in drivers/pci, all the blame for any issues would come my > > way. > > Ping? This has been in -next since the Feb 28 tree, and I plan to > ask Linus to include it during the v5.18 merge window (which will > probably open Mar 13) unless somebody objects. > > Bjorn
Re: [PATCH v9 00/11] vgaarb: Rework default VGA device selection
On Fri, Feb 25, 2022 at 04:15:23PM -0600, Bjorn Helgaas wrote: > On Thu, Feb 24, 2022 at 04:47:42PM -0600, Bjorn Helgaas wrote: > > From: Bjorn Helgaas > > > > Current default VGA device selection fails in some cases because part of it > > is done in the vga_arb_device_init() subsys_initcall, and some arches > > enumerate PCI devices in pcibios_init(), which runs *after* that. > > > > The big change from the v8 posting is that this moves vgaarb.c from > > drivers/gpu/vga to drivers/pci because it really has nothing to do with > > GPUs or DRM. > > I provisionally applied this to pci/vga and put it into -next just > to get a little runtime on it. > > But I'd prefer not to unilaterally yank this out of drivers/gpu > without a consensus from the GPU folks that this is the right thing to > do. > > Any thoughts? If it seems OK to you, I think patch 1/11 (the move > itself) is all you would need to look at, although of course I would > still be grateful for any review and feedback on the rest. > > After it's in drivers/pci, all the blame for any issues would come my > way. Ping? This has been in -next since the Feb 28 tree, and I plan to ask Linus to include it during the v5.18 merge window (which will probably open Mar 13) unless somebody objects. Bjorn
Re: [PATCH v9 00/11] vgaarb: Rework default VGA device selection
On Thu, Feb 24, 2022 at 04:47:42PM -0600, Bjorn Helgaas wrote: > From: Bjorn Helgaas > > Current default VGA device selection fails in some cases because part of it > is done in the vga_arb_device_init() subsys_initcall, and some arches > enumerate PCI devices in pcibios_init(), which runs *after* that. > > The big change from the v8 posting is that this moves vgaarb.c from > drivers/gpu/vga to drivers/pci because it really has nothing to do with > GPUs or DRM. I provisionally applied this to pci/vga and put it into -next just to get a little runtime on it. But I'd prefer not to unilaterally yank this out of drivers/gpu without a consensus from the GPU folks that this is the right thing to do. Any thoughts? If it seems OK to you, I think patch 1/11 (the move itself) is all you would need to look at, although of course I would still be grateful for any review and feedback on the rest. After it's in drivers/pci, all the blame for any issues would come my way. Bjorn
