Re: [PATCHv3 00/30] drm/omap: miscallaneous improvements
On 29/03/17 15:09, Laurent Pinchart wrote: > Hi Tomi, > > On Tuesday 28 Mar 2017 16:07:46 Tomi Valkeinen wrote: >> This is the third revision of this series. Note that this series depends on >> "drm/atomic: Introduce drm_atomic_helper_shutdown" which has not yet been >> merged to drm-next. > > I've reviewed all patches but the omapdss-base split. While it doesn't look > bad to me, it's hard to judge whether the code is correctly architectured > without seeing the omapdss6 driver. Thanks. I think time will tell if it's correctly done, but I'm quite confident that it can't mess up much. It consists really of two parts: separating the common base stuff into a separate module, and the dispc_ops. While the common module could use some cleanup, I think it makes sense. The dispc_ops really just change from calling functions directly to use function pointers. You can find dss6 driver from https://git.ti.com/ti-linux-kernel/ti-linux-kernel/trees/ti-linux-4.9.y/drivers/gpu/drm/omapdrm/dss The dss6 and dispc6 files. But it's really just a smaller, cleaner (well, the driver is not clean yet) version of dss5. Conceptually the same, different registers. Tomi signature.asc Description: OpenPGP digital signature ___ dri-devel mailing list dri-devel@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/dri-devel
Re: [PATCHv3 00/30] drm/omap: miscallaneous improvements
Hi Tomi, On Tuesday 28 Mar 2017 16:07:46 Tomi Valkeinen wrote: > This is the third revision of this series. Note that this series depends on > "drm/atomic: Introduce drm_atomic_helper_shutdown" which has not yet been > merged to drm-next. I've reviewed all patches but the omapdss-base split. While it doesn't look bad to me, it's hard to judge whether the code is correctly architectured without seeing the omapdss6 driver. > The main changes in v3: > > - improve variable names in 'work-around for errata i886' > - drop 'Init fbdev emulation only when we have displays' > - drop 'Create fbdev emulation only for the first DRM connector' > - add 'use drm_atomic_helper_shutdown' > - change 'fix crash on module unload' based on drm_atomic_helper_shutdown > change. > > The main changes in v2: > > - Interrupt based HPD removed, as there's a race issue which needs to be > fixed > - Added patch to fix module unload crash, introduced in drm-next > - Drop changes affecting userspace APIs > > > Hemant Hariyani (1): > drm/omap: Add support for render nodes > > Peter Ujfalusi (6): > drm/omap: dss: Functions to check components in the display/output > list > drm/omap: dss: Support for detecting display stack readiness > drm/omap: Use omapdss_stack_is_ready() to check that the display stack > is up > drm/omap: display: Add displays in sorted order to the panel_list > drm/omap: poll only connectors where the connect/disconnect can be > checked > drm/omap: displays: panel-dpi: Support for handling backlight devices > > Tomi Valkeinen (23): > drm/omap: work-around for errata i886 > drm/omap: refactor CRTC HW property setup > drm/omap: remove divider constraint from hsdiv > drm/omap: decrease min width & height > drm/omap: improve DPI clock selection on DRA7xx > drm/omap: fix HDMI sync polarities > drm/omap: add omapdss-base.ko > drm/omap: move dss_initialized to omapdss-base > drm/omap: output: use dev_err instead of DSSERR > drm/omap: display: don't use dsi_get_pixel_size() > drm/omap: move display, dss-of, output to omapdss-base > drm/omap: move dispc related dss-feat funcs to dispc > drm/omap: add dispc_ops > drm/omap: fill dispc_ops > drm/omap: use dispc_ops > drm/omap: remove all EXPORT_SYMBOLs from dispc.c > drm/omap: remove unused dispc_wb_enable & dispc_wb_is_enabled > drm/omap: fix replication logic > drm/omap: fix plane update warning when crtc is disabled > drm/omap: dispc: improve debug print of display flags > drm/omap: fix display SYNC/DE flags > drm/omap: use drm_atomic_helper_shutdown() > drm/omap: fix crash on module unload > > drivers/gpu/drm/omapdrm/displays/panel-dpi.c | 37 +- > drivers/gpu/drm/omapdrm/dss/Kconfig | 4 + > drivers/gpu/drm/omapdrm/dss/Makefile | 8 +- > drivers/gpu/drm/omapdrm/dss/base.c | 140 +++ > drivers/gpu/drm/omapdrm/dss/dispc.c | 165 +++- > drivers/gpu/drm/omapdrm/dss/display.c| 36 +- > drivers/gpu/drm/omapdrm/dss/dpi.c| 55 ++--- > drivers/gpu/drm/omapdrm/dss/dsi.c| 2 +- > drivers/gpu/drm/omapdrm/dss/dss-of.c | 3 +- > drivers/gpu/drm/omapdrm/dss/dss.c| 13 +-- > drivers/gpu/drm/omapdrm/dss/dss.h| 17 +-- > drivers/gpu/drm/omapdrm/dss/dss_features.c | 3 - > drivers/gpu/drm/omapdrm/dss/dss_features.h | 4 + > drivers/gpu/drm/omapdrm/dss/hdmi_wp.c| 12 +- > drivers/gpu/drm/omapdrm/dss/omapdss.h| 95 +-- > drivers/gpu/drm/omapdrm/dss/output.c | 27 - > drivers/gpu/drm/omapdrm/dss/pll.c| 17 +-- > drivers/gpu/drm/omapdrm/omap_connector.c | 12 +- > drivers/gpu/drm/omapdrm/omap_crtc.c | 87 ++ > drivers/gpu/drm/omapdrm/omap_drv.c | 45 +--- > drivers/gpu/drm/omapdrm/omap_drv.h | 2 + > drivers/gpu/drm/omapdrm/omap_irq.c | 47 +++- > drivers/gpu/drm/omapdrm/omap_plane.c | 20 +++- > 23 files changed, 588 insertions(+), 263 deletions(-) > create mode 100644 drivers/gpu/drm/omapdrm/dss/base.c -- Regards, Laurent Pinchart ___ dri-devel mailing list dri-devel@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/dri-devel
