Re: [PULL] drm-intel-gt-next
Quoting Joonas Lahtinen (2024-02-16 11:41:44) > (+ Jonathan) > > Quoting Dave Airlie (2024-02-16 04:58:03) > > On Thu, 15 Feb 2024 at 20:06, Tvrtko Ursulin > > wrote: > > > > > > Hi Dave, Daniel, > > > > > > First pull request for 6.9 with probably one more coming in one to two > > > weeks. > > > > > > Nothing to interesting in this one, mostly a sprinkle of small fixes in > > > GuC, HuC, Perf/OA, a tiny bit of prep work for future platforms and some > > > code cleanups. > > > > > > One new uapi in the form of a GuC submission version query which Mesa > > > wants for implementing Vulkan async compute queues. > > > > > > Regards, > > > > > > Tvrtko > > > > > > drm-intel-gt-next-2024-02-15: > > > UAPI Changes: > > > > > > - Add GuC submission interface version query (Tvrtko Ursulin) > > > > > > Driver Changes: > > > > > > Fixes/improvements/new stuff: > > > > > > - Atomically invalidate userptr on mmu-notifier (Jonathan Cavitt) > > > > I've pulled this, but the above patch is triggering my this seems > > wrong spider sense. > > > > This and probably the preceeding patch that this references seem to > > move i915 to a long term pinning of userptr in memory with what I can > > see no accounting, and away from what the desired behaviour for > > drivers should be. > > I asked Thomas to take a more detailed look. Jonathan, Thomas really should > have been Cc'd in the original patch as the patch was explicitly referred > in the text even. > > > It also feels like the authorship on this might be lies which also worries > > me. > > Fear not. This can probably be blamed on the i915 maintainers. > > When we have an internal patch which has many revisions and is then > essentially rewritten for upstreaming, we specifically asked NOT to keep > the "From:" line intact, but instead swap in person who rewrote the patch[1]. Just to state the obvious for the public record: This should never be done lightly or without reaching out to the original author. This should only be for the exceptional cases where the patch has significantly changed. This was just the explanation why it's not an immediate red flag to see such a patch. Based on the discussion around the topic we should be more explicit if such a case has happened or if there simply has been an error in the patch handling. So we'll work on clarifying the instructions here. Regards, Joonas > To document credits/involvement of the original author we've recommended > to keep the Signed-off-by line however. "Co-developed-by" does not really > express the situation correctly. "Based on patch by" style pure textual > credit reference was also discussed but is hard to grep. > > Discussed with Sima who suggested if we should consider something like > "Original-patch-by:" tag to better express this situation? > > Regards, Joonas > > [1] If the "From: " line is not updated, it sometimes leads to > situation where you can see a patch with "From:" pointing to you, that > doesn't contain a single unmodified line anymore. > > > > > Dave.
Re: [PULL] drm-intel-gt-next
(+ Jonathan) Quoting Dave Airlie (2024-02-16 04:58:03) > On Thu, 15 Feb 2024 at 20:06, Tvrtko Ursulin > wrote: > > > > Hi Dave, Daniel, > > > > First pull request for 6.9 with probably one more coming in one to two > > weeks. > > > > Nothing to interesting in this one, mostly a sprinkle of small fixes in > > GuC, HuC, Perf/OA, a tiny bit of prep work for future platforms and some > > code cleanups. > > > > One new uapi in the form of a GuC submission version query which Mesa > > wants for implementing Vulkan async compute queues. > > > > Regards, > > > > Tvrtko > > > > drm-intel-gt-next-2024-02-15: > > UAPI Changes: > > > > - Add GuC submission interface version query (Tvrtko Ursulin) > > > > Driver Changes: > > > > Fixes/improvements/new stuff: > > > > - Atomically invalidate userptr on mmu-notifier (Jonathan Cavitt) > > I've pulled this, but the above patch is triggering my this seems > wrong spider sense. > > This and probably the preceeding patch that this references seem to > move i915 to a long term pinning of userptr in memory with what I can > see no accounting, and away from what the desired behaviour for > drivers should be. I asked Thomas to take a more detailed look. Jonathan, Thomas really should have been Cc'd in the original patch as the patch was explicitly referred in the text even. > It also feels like the authorship on this might be lies which also worries me. Fear not. This can probably be blamed on the i915 maintainers. When we have an internal patch which has many revisions and is then essentially rewritten for upstreaming, we specifically asked NOT to keep the "From:" line intact, but instead swap in person who rewrote the patch[1]. To document credits/involvement of the original author we've recommended to keep the Signed-off-by line however. "Co-developed-by" does not really express the situation correctly. "Based on patch by" style pure textual credit reference was also discussed but is hard to grep. Discussed with Sima who suggested if we should consider something like "Original-patch-by:" tag to better express this situation? Regards, Joonas [1] If the "From: " line is not updated, it sometimes leads to situation where you can see a patch with "From:" pointing to you, that doesn't contain a single unmodified line anymore. > > Dave.
Re: [PULL] drm-intel-gt-next
On Fri, 2024-02-16 at 10:31 +0100, Thomas Hellström wrote: > Hi, Dave > > On Fri, 2024-02-16 at 12:58 +1000, Dave Airlie wrote: > > On Thu, 15 Feb 2024 at 20:06, Tvrtko Ursulin > > wrote: > > > > > > Hi Dave, Daniel, > > > > > > First pull request for 6.9 with probably one more coming in one > > > to > > > two > > > weeks. > > > > > > Nothing to interesting in this one, mostly a sprinkle of small > > > fixes in > > > GuC, HuC, Perf/OA, a tiny bit of prep work for future platforms > > > and > > > some > > > code cleanups. > > > > > > One new uapi in the form of a GuC submission version query which > > > Mesa > > > wants for implementing Vulkan async compute queues. > > > > > > Regards, > > > > > > Tvrtko > > > > > > drm-intel-gt-next-2024-02-15: > > > UAPI Changes: > > > > > > - Add GuC submission interface version query (Tvrtko Ursulin) > > > > > > Driver Changes: > > > > > > Fixes/improvements/new stuff: > > > > > > - Atomically invalidate userptr on mmu-notifier (Jonathan Cavitt) > > > > I've pulled this, but the above patch is triggering my this seems > > wrong spider sense. > > > > This and probably the preceeding patch that this references seem to > > move i915 to a long term pinning of userptr in memory with what I > > can > > see no accounting, and away from what the desired behaviour for > > drivers should be. > > I can only answer for the first patch there, It was some time ago it > was written, but at that point the pinning was held both by > get_pages() > and by submission. I removed the submission pinning and instead moved > get_pages() to start of submission. So no significant change in > pinning > time there. For some reason I can't clearly remember the submission > pinning got in the way of the vm_bind implementation. That said, the > pinning AFAIR is released in the gem shrinker. And it's different > from > what other drivers are doing. i915 never got to the point where it > completely dropped the pinning after the binding. (And with the first patch I mean "Simplify userptr locking") /Thomas > > /Thomas > > > > > > It also feels like the authorship on this might be lies which also > > worries me. > > > > Dave. >
Re: [PULL] drm-intel-gt-next
Hi, Dave On Fri, 2024-02-16 at 12:58 +1000, Dave Airlie wrote: > On Thu, 15 Feb 2024 at 20:06, Tvrtko Ursulin > wrote: > > > > Hi Dave, Daniel, > > > > First pull request for 6.9 with probably one more coming in one to > > two > > weeks. > > > > Nothing to interesting in this one, mostly a sprinkle of small > > fixes in > > GuC, HuC, Perf/OA, a tiny bit of prep work for future platforms and > > some > > code cleanups. > > > > One new uapi in the form of a GuC submission version query which > > Mesa > > wants for implementing Vulkan async compute queues. > > > > Regards, > > > > Tvrtko > > > > drm-intel-gt-next-2024-02-15: > > UAPI Changes: > > > > - Add GuC submission interface version query (Tvrtko Ursulin) > > > > Driver Changes: > > > > Fixes/improvements/new stuff: > > > > - Atomically invalidate userptr on mmu-notifier (Jonathan Cavitt) > > I've pulled this, but the above patch is triggering my this seems > wrong spider sense. > > This and probably the preceeding patch that this references seem to > move i915 to a long term pinning of userptr in memory with what I can > see no accounting, and away from what the desired behaviour for > drivers should be. I can only answer for the first patch there, It was some time ago it was written, but at that point the pinning was held both by get_pages() and by submission. I removed the submission pinning and instead moved get_pages() to start of submission. So no significant change in pinning time there. For some reason I can't clearly remember the submission pinning got in the way of the vm_bind implementation. That said, the pinning AFAIR is released in the gem shrinker. And it's different from what other drivers are doing. i915 never got to the point where it completely dropped the pinning after the binding. /Thomas > > It also feels like the authorship on this might be lies which also > worries me. > > Dave.
Re: [PULL] drm-intel-gt-next
On Thu, 15 Feb 2024 at 20:06, Tvrtko Ursulin wrote: > > Hi Dave, Daniel, > > First pull request for 6.9 with probably one more coming in one to two > weeks. > > Nothing to interesting in this one, mostly a sprinkle of small fixes in > GuC, HuC, Perf/OA, a tiny bit of prep work for future platforms and some > code cleanups. > > One new uapi in the form of a GuC submission version query which Mesa > wants for implementing Vulkan async compute queues. > > Regards, > > Tvrtko > > drm-intel-gt-next-2024-02-15: > UAPI Changes: > > - Add GuC submission interface version query (Tvrtko Ursulin) > > Driver Changes: > > Fixes/improvements/new stuff: > > - Atomically invalidate userptr on mmu-notifier (Jonathan Cavitt) I've pulled this, but the above patch is triggering my this seems wrong spider sense. This and probably the preceeding patch that this references seem to move i915 to a long term pinning of userptr in memory with what I can see no accounting, and away from what the desired behaviour for drivers should be. It also feels like the authorship on this might be lies which also worries me. Dave.
Re: [PULL] drm-intel-gt-next
On Thu, Apr 06, 2023 at 03:34:04PM +0300, Jani Nikula wrote: > On Thu, 06 Apr 2023, Maarten Lankhorst > wrote: > > Hi Dave, Daniel, > > Pull request to avoid backmerges. ;) > > Cheers, > > ~Maarten > > Not using dim for this? Is the subject line copy-pasted from another > pull request? :) dim did at least manage to eat it all correctly I think :-) Pulled, thanks > > BR, > Jani. > > > > > drm-misc-next-2023-04-06: > > drm-misc-next for v6.4-rc1: > > > > UAPI Changes: > > > > Cross-subsystem Changes: > > - Document port and rotation dt bindings better. > > - For panel timing DT bindings, document that vsync and hsync are > >first, rather than last in image. > > - Fix video/aperture typos. > > > > Core Changes: > > - Reject prime DMA-Buf attachment if get_sg_table is missing. > >(For self-importing dma-buf only.) > > - Add prime import/export to vram-helper. > > - Fix oops in drm/vblank when init is not called. > > - Fixup xres/yres_virtual and other fixes in fb helper. > > - Improve SCDC debugs. > > - Skip setting deadline on modesets. > > - Assorted TTM fixes. > > > > Driver Changes: > > - Add lima usage stats. > > - Assorted fixes to bridge/lt8192b, tc358767, ivpu, > >bridge/ti-sn65dsi83, ps8640. > > - Use pci aperture helpers in drm/ast lynxfb, radeonfb. > > - Revert some lima patches, as they required a commit that has been > >reverted upstream. > > - Add AUO NE135FBM-N41 v8.1 eDP panel. > > - Add QAIC accel driver. > > The following changes since commit 7d690f936e9bc9fbd6394fb3d4ad181af03ee393: > > > >drm/panfrost: Add basic support for speed binning (2023-03-31 11:44:11 > > +0200) > > > > are available in the Git repository at: > > > >git://anongit.freedesktop.org/drm/drm-misc tags/drm-misc-next-2023-04-06 > > > > for you to fetch changes up to e44f18c6ff8beef7b2b10592287f0a9766376d9b: > > > >drm/ttm: Make the call to ttm_tt_populate() interruptible when faulting > > (2023-04-06 10:01:42 +0200) > > > > > > drm-misc-next for v6.4-rc1: > > > > UAPI Changes: > > > > Cross-subsystem Changes: > > - Document port and rotation dt bindings better. > > - For panel timing DT bindings, document that vsync and hsync are > >first, rather than last in image. > > - Fix video/aperture typos. > > > > Core Changes: > > - Reject prime DMA-Buf attachment if get_sg_table is missing. > >(For self-importing dma-buf only.) > > - Add prime import/export to vram-helper. > > - Fix oops in drm/vblank when init is not called. > > - Fixup xres/yres_virtual and other fixes in fb helper. > > - Improve SCDC debugs. > > - Skip setting deadline on modesets. > > - Assorted TTM fixes. > > > > Driver Changes: > > - Add lima usage stats. > > - Assorted fixes to bridge/lt8192b, tc358767, ivpu, > >bridge/ti-sn65dsi83, ps8640. > > - Use pci aperture helpers in drm/ast lynxfb, radeonfb. > > - Revert some lima patches, as they required a commit that has been > >reverted upstream. > > - Add AUO NE135FBM-N41 v8.1 eDP panel. > > - Add QAIC accel driver. > > > > > > Alexander Stein (2): > >drm/bridge: ti-sn65dsi83: use dev_err_probe if host attach failed > >drm/bridge: ti-sn65dsi86: Allow GPIO operations to sleep > > > > AngeloGioacchino Del Regno (1): > >drm/panel-edp: Add AUO NE135FBM-N41 v8.1 panel entry > > > > Daniel Vetter (7): > >drm/ast: Use drm_aperture_remove_conflicting_pci_framebuffers > >staging/lynxfb: Use pci aperture helper > >fbdev/radeon: use pci aperture helpers > >drm/fb-helper: set x/yres_virtual in drm_fb_helper_check_var > >drm/fb-helper: drop redundant pixclock check from > > drm_fb_helper_set_par() > >drm/fb-helper: fix input validation gaps in check_var > >drm/atomic-helper: Don't set deadline for modesets > > > > Erico Nunes (3): > >drm/lima: add usage counting method to ctx_mgr > >drm/lima: allocate unique id per drm_file > >drm/lima: add show_fdinfo for drm usage stats > > > > Francesco Dolcini (1): > >drm/bridge: lt8912b: Fix DSI Video Mode > > > > Harshit Mogalapalli (1): > >drm/lima/lima_drv: Add missing unwind goto in lima_pdev_probe() > > > > Jeffrey Hugo (7): > >accel/qaic: Add documentation for AIC100 accelerator driver > >accel/qaic: Add uapi and core driver file > >accel/qaic: Add MHI controller > >accel/qaic: Add control path > >accel/qaic: Add datapath > >accel/qaic: Add qaic driver to the build system > >MAINTAINERS: Add entry for QAIC driver > > > > Karol Wachowski (1): > >accel/ivpu: Remove D3hot delay for Meteorlake > > > > Krzysztof Kozlowski (5): > >dt-bindings: display: sitronix,st7789v: document dc-gpios > >dt-bindings: display: xinpeng,xpp055c272: document port > >dt-bindings: display: feiyang,fy07024di26a30d:
Re: [PULL] drm-intel-gt-next
On Thu, Apr 06, 2023 at 11:18:06AM +0300, Joonas Lahtinen wrote: > Hi Dave & Daniel, > > Here goes the final drm-intel-gt-next pull request for v6.4. > > As top items we have a fix for context runtime accounting, Meteorlake > enabling, DMAR error noise elimination due to GPU error capture, BAR > resizing forcewake fix and memory contents clearing fix for discrete. > More robust GuC loading on systems with IFWI that leaves GPU to slow > frequency and a potential UAF closed on perf add_config IOCTL. > > There is also change to the uAPI headers to eliminate flexible-array > member kernel-wide request, which does not impact binaries and also > should not impact compilation. > > Then the usual amount of smaller fixes and cleanups. A good amount of > kerneldoc fixes included. > > Best Regards, Joonas > > *** > > drm-intel-gt-next-2023-04-06: > > UAPI Changes: > > - (Build-time only, should not have any impact) > drm/i915/uapi: Replace fake flex-array with flexible-array member > > "Zero-length arrays as fake flexible arrays are deprecated and we are > moving towards adopting C99 flexible-array members instead." > > This is on core kernel request moving towards GCC 13. > > Driver Changes: > > - Fix context runtime accounting on sysfs fdinfo for heavy workloads (Tvrtko) > - Add support for OA media units on MTL (Umesh) > - Add new workarounds for Meteorlake (Daniele, Radhakrishna, Haridhar) > - Fix sysfs to read actual frequency for MTL and Gen6 and earlier > (Ashutosh) > - Synchronize i915/BIOS on C6 enabling on MTL (Vinay) > - Fix DMAR error noise due to GPU error capture (Andrej) > - Fix forcewake during BAR resize on discrete (Andrzej) > - Flush lmem contents after construction on discrete (Chris) > - Fix GuC loading timeout on systems where IFWI programs low boot > frequency (John) > - Fix race condition UAF in i915_perf_add_config_ioctl (Min) > > - Sanitycheck MMIO access early in driver load and during forcewake > (Matt) > - Wakeref fixes for GuC RC error scenario and active VM tracking (Chris) > - Cancel HuC delayed load timer on reset (Daniele) > - Limit double GT reset to pre-MTL (Daniele) > - Use i915 instead of dev_priv insied the file_priv structure (Andi) > - Improve GuC load error reporting (John) > - Simplify VCS/BSD engine selection logic (Tvrtko) > - Perform uc late init after probe error injection (Andrzej) > - Fix format for perf_limit_reasons in debugfs (Vinay) > - Create per-gt debugfs files (Andi) > > - Documentation and kerneldoc fixes (Nirmoy, Lee) > - Selftest improvements (Fei, Jonathan) > > The following changes since commit d2a9692ad4295e227e3352fdbf14b8491b01e1c9: > > drm/i915/gt: make kobj attributes const (2023-03-15 12:20:11 +0200) > > are available in the Git repository at: > > git://anongit.freedesktop.org/drm/drm-intel > tags/drm-intel-gt-next-2023-04-06 > > for you to fetch changes up to 4b51210f98c2b89ce37aede5b8dc5105be0572c6: > > drm/i915/mtl: Add Wa_14017856879 (2023-04-05 07:59:12 -0700) Pulled, thanks > > > UAPI Changes: > > - (Build-time only, should not have any impact) > drm/i915/uapi: Replace fake flex-array with flexible-array member > > "Zero-length arrays as fake flexible arrays are deprecated and we are > moving towards adopting C99 flexible-array members instead." > > This is on core kernel request moving towards GCC 13. > > Driver Changes: > > - Fix context runtime accounting on sysfs fdinfo for heavy workloads (Tvrtko) > - Add support for OA media units on MTL (Umesh) > - Add new workarounds for Meteorlake (Daniele, Radhakrishna, Haridhar) > - Fix sysfs to read actual frequency for MTL and Gen6 and earlier > (Ashutosh) > - Synchronize i915/BIOS on C6 enabling on MTL (Vinay) > - Fix DMAR error noise due to GPU error capture (Andrej) > - Fix forcewake during BAR resize on discrete (Andrzej) > - Flush lmem contents after construction on discrete (Chris) > - Fix GuC loading timeout on systems where IFWI programs low boot > frequency (John) > - Fix race condition UAF in i915_perf_add_config_ioctl (Min) > > - Sanitycheck MMIO access early in driver load and during forcewake > (Matt) > - Wakeref fixes for GuC RC error scenario and active VM tracking (Chris) > - Cancel HuC delayed load timer on reset (Daniele) > - Limit double GT reset to pre-MTL (Daniele) > - Use i915 instead of dev_priv insied the file_priv structure (Andi) > - Improve GuC load error reporting (John) > - Simplify VCS/BSD engine selection logic (Tvrtko) > - Perform uc late init after probe error injection (Andrzej) > - Fix format for perf_limit_reasons in debugfs (Vinay) > - Create per-gt debugfs files (Andi) > > - Documentation and kerneldoc fixes (Nirmoy, Lee) > - Selftest improvements (Fei, Jonathan) > > > Andi Shyti (3): > drm/i915/gt: Create per-gt debugfs files > drm/i915/debugfs: Enable
Re: [PULL] drm-intel-gt-next
On Thu, 06 Apr 2023, Maarten Lankhorst wrote: > Hi Dave, Daniel, > Pull request to avoid backmerges. ;) > Cheers, > ~Maarten Not using dim for this? Is the subject line copy-pasted from another pull request? :) BR, Jani. > > drm-misc-next-2023-04-06: > drm-misc-next for v6.4-rc1: > > UAPI Changes: > > Cross-subsystem Changes: > - Document port and rotation dt bindings better. > - For panel timing DT bindings, document that vsync and hsync are >first, rather than last in image. > - Fix video/aperture typos. > > Core Changes: > - Reject prime DMA-Buf attachment if get_sg_table is missing. >(For self-importing dma-buf only.) > - Add prime import/export to vram-helper. > - Fix oops in drm/vblank when init is not called. > - Fixup xres/yres_virtual and other fixes in fb helper. > - Improve SCDC debugs. > - Skip setting deadline on modesets. > - Assorted TTM fixes. > > Driver Changes: > - Add lima usage stats. > - Assorted fixes to bridge/lt8192b, tc358767, ivpu, >bridge/ti-sn65dsi83, ps8640. > - Use pci aperture helpers in drm/ast lynxfb, radeonfb. > - Revert some lima patches, as they required a commit that has been >reverted upstream. > - Add AUO NE135FBM-N41 v8.1 eDP panel. > - Add QAIC accel driver. > The following changes since commit 7d690f936e9bc9fbd6394fb3d4ad181af03ee393: > >drm/panfrost: Add basic support for speed binning (2023-03-31 11:44:11 > +0200) > > are available in the Git repository at: > >git://anongit.freedesktop.org/drm/drm-misc tags/drm-misc-next-2023-04-06 > > for you to fetch changes up to e44f18c6ff8beef7b2b10592287f0a9766376d9b: > >drm/ttm: Make the call to ttm_tt_populate() interruptible when faulting > (2023-04-06 10:01:42 +0200) > > > drm-misc-next for v6.4-rc1: > > UAPI Changes: > > Cross-subsystem Changes: > - Document port and rotation dt bindings better. > - For panel timing DT bindings, document that vsync and hsync are >first, rather than last in image. > - Fix video/aperture typos. > > Core Changes: > - Reject prime DMA-Buf attachment if get_sg_table is missing. >(For self-importing dma-buf only.) > - Add prime import/export to vram-helper. > - Fix oops in drm/vblank when init is not called. > - Fixup xres/yres_virtual and other fixes in fb helper. > - Improve SCDC debugs. > - Skip setting deadline on modesets. > - Assorted TTM fixes. > > Driver Changes: > - Add lima usage stats. > - Assorted fixes to bridge/lt8192b, tc358767, ivpu, >bridge/ti-sn65dsi83, ps8640. > - Use pci aperture helpers in drm/ast lynxfb, radeonfb. > - Revert some lima patches, as they required a commit that has been >reverted upstream. > - Add AUO NE135FBM-N41 v8.1 eDP panel. > - Add QAIC accel driver. > > > Alexander Stein (2): >drm/bridge: ti-sn65dsi83: use dev_err_probe if host attach failed >drm/bridge: ti-sn65dsi86: Allow GPIO operations to sleep > > AngeloGioacchino Del Regno (1): >drm/panel-edp: Add AUO NE135FBM-N41 v8.1 panel entry > > Daniel Vetter (7): >drm/ast: Use drm_aperture_remove_conflicting_pci_framebuffers >staging/lynxfb: Use pci aperture helper >fbdev/radeon: use pci aperture helpers >drm/fb-helper: set x/yres_virtual in drm_fb_helper_check_var >drm/fb-helper: drop redundant pixclock check from > drm_fb_helper_set_par() >drm/fb-helper: fix input validation gaps in check_var >drm/atomic-helper: Don't set deadline for modesets > > Erico Nunes (3): >drm/lima: add usage counting method to ctx_mgr >drm/lima: allocate unique id per drm_file >drm/lima: add show_fdinfo for drm usage stats > > Francesco Dolcini (1): >drm/bridge: lt8912b: Fix DSI Video Mode > > Harshit Mogalapalli (1): >drm/lima/lima_drv: Add missing unwind goto in lima_pdev_probe() > > Jeffrey Hugo (7): >accel/qaic: Add documentation for AIC100 accelerator driver >accel/qaic: Add uapi and core driver file >accel/qaic: Add MHI controller >accel/qaic: Add control path >accel/qaic: Add datapath >accel/qaic: Add qaic driver to the build system >MAINTAINERS: Add entry for QAIC driver > > Karol Wachowski (1): >accel/ivpu: Remove D3hot delay for Meteorlake > > Krzysztof Kozlowski (5): >dt-bindings: display: sitronix,st7789v: document dc-gpios >dt-bindings: display: xinpeng,xpp055c272: document port >dt-bindings: display: feiyang,fy07024di26a30d: document port >dt-bindings: display: elida,kd35t133: document port and rotation >dt-bindings: display: sitronix,st7701: document port and rotation > > Luca Ceresoli (2): >drm: bridge: ldb: add missing \n in dev_warn() string >drm: bridge: ldb: add support for using channel 1 only > > Marek Vasut (3): >drm/bridge: tc358767: Enable DSI burst mode, LPM, non-continuous
Re: [PULL] drm-intel-gt-next
On Wed, Jan 18, 2023 at 11:24:44AM +, Tvrtko Ursulin wrote: > Hi Dave, Daniel, > > Here goes the first pull request for 6.3. > > What sticks out most is the amount of fixes, majority of which if not all > would have already landed via gt/next fixes pull requests though, so I > will only mention them here briefly. > > Most impactful ones are probably in the area of DG2 TLB invalidation, > followed by eviction, both platform agnostic (userspace crashes due > eviction failures after object locking changes) and a couple DG2 ones > (visual glitches due CCS aux data not always handled). > > Then we have a bunch of crashes and simiar issues fixed which would have > been triggerable under more like edge conditions. On older platforms, > RC6p gets disabled on Sandybridge to avoid GPU hangs and visual glitches. > > Finally there is a bunch of log noise getting disabled, mostly over- > zealouos log level use or misleadingly logging failures which are > otherwise handled. > > In terms of new features there isn't that much. We have some new > workarounds which can affect performance and an improvement to suspend- > resume times especially significant on modern slow CPU systems like some > Chromebooks. > > Outside of immediate visibility to end users, early enablement for > Meteorlake and Ponte Vecchio is carrying on. Former especially has had > support for loading the GSC firmware, OA and initial GT workarounds added. > > And of course as always there are some random cleanups, selftest tweaks > and misc refactorings, which feels less than the usual amount in this > round. > > Regards, > > Tvrtko > > drm-intel-gt-next-2023-01-18: > Driver Changes: > > Fixes/improvements/new stuff: > > - Fix workarounds on Gen2-3 (Tvrtko Ursulin) > - Fix HuC delayed load memory leaks (Daniele Ceraolo Spurio) > - Fix a BUG caused by impendance mismatch in dma_fence_wait_timeout and GuC > (Janusz Krzysztofik) > - Add DG2 workarounds Wa_18018764978 and Wa_18019271663 (Matt Atwood) > - Apply recommended L3 hashing mask tuning parameters (Gen12+) (Matt Roper) > - Improve suspend / resume times with VT-d scanout workaround active (Andi > Shyti, Chris Wilson) > - Silence misleading "mailbox access failed" warning in snb_pcode_read > (Ashutosh Dixit) > - Fix null pointer dereference on HSW perf/OA (Umesh Nerlige Ramappa) > - Avoid trampling the ring during buffer migration (and selftests) (Chris > Wilson, Matthew Auld) > - Fix DG2 visual corruption on small BAR systems by not forgetting to copy > CCS aux state (Matthew Auld) > - More fixing of DG2 visual corruption by not forgetting to copy CCS aux > state of backup objects (Matthew Auld) > - Fix TLB invalidation for Gen12.50 video and compute engines (Andrzej Hajda) > - Limit Wa_22012654132 to just specific steppings (Matt Roper) > - Fix userspace crashes due eviction not working under lock contention after > the object locking conversion (Matthew Auld) > - Avoid double free is user deploys a corrupt GuC firmware (John Harrison) > - Fix 32-bit builds by using "%zu" to format size_t (Nirmoy Das) > - Fix a possible BUG in TTM async unbind due not reserving enough fence slots > (Nirmoy Das) > - Fix potential use after free by not exposing the GEM context id to > userspace too early (Rob Clark) > - Show clamped PL1 limit to the user (hwmon) (Ashutosh Dixit) > - Workaround unreliable reset on Jasperlake (Chris Wilson) > - Cover rest of SVG unit MCR registers (Gustavo Sousa) > - Avoid PXP log spam on platforms which do not support the feature (Alan > Previn) > - Re-disable RC6p on Sandy Bridge to avoid GPU hangs and visual glitches > (Sasa Dragic) > > Future platform enablement: > > - Manage uncore->lock while waiting on MCR register (Matt Roper) > - Enable Idle Messaging for GSC CS (Vinay Belgaumkar) > - Only initialize GSC in tile 0 (José Roberto de Souza) > - Media GT and Render GT share common GGTT (Aravind Iddamsetty) > - Add dedicated MCR lock (Matt Roper) > - Implement recommended caching policy (PVC) (Wayne Boyer) > - Add hardware-level lock for steering (Matt Roper) > - Check full IP version when applying hw steering semaphore (Matt Roper) > - Enable GuC GGTT invalidation from the start (Daniele Ceraolo Spurio) > - MTL GSC firmware support (Daniele Ceraolo Spurio, Jonathan Cavitt) > - MTL OA support (Umesh Nerlige Ramappa) > - MTL initial gt workarounds (Matt Roper) > > Driver refactors: > > - Hold forcewake and MCR lock over PPAT setup (Matt Roper) > - Acquire fw before loop in intel_uncore_read64_2x32 (Umesh Nerlige Ramappa) > - GuC filename cleanups and use submission API version number (John Harrison) > - Promote pxp subsystem to top-level of i915 (Alan Previn) > - Finish proofing the code agains object size overflows (Chris Wilson, > Gwan-gyeong Mun) > - Start adding module oriented dmesg output (John Harrison) > > Miscellaneous: > > - Correct kerneldoc for intel_gt_mcr_wait_for_reg() (Matt Roper) > - Bump up sample period for busy stats selftest
Re: [PULL] drm-intel-gt-next
On Mon, 31 Oct 2022 at 21:07, Joonas Lahtinen wrote: > > Hi Dave & Daniel, > > Here goes first drm-intel-gt-next pull req towards 6.2. > > We have a fix for #6222 (kernel memory corruption issue) and fix for > display regression after resume. A missing W/A for Gen12 iGPUs and > extension of compute pre-emption timeout to 7.5 seconds to account for > compute corner cases. Improvements to GuC compute error capture, > scheduling hysteresis and SLPC. Fixes to EHL MOCS tables. Better docs > for I915_PARAM_HUC_STATUS and pre-emption control policy. Extending the > grace period for full GPU reset timeout to 60 seconds to better capture > logs or recover, as opposed to just giving up on whole device in 5 seconds. > > We're starting to add HWMON metrics for recent devices. More MTL > enabling, DG2 workarounds, DG2 HuC support, OA for DG2 is enabled. Small > bar enabling, PS64 support added for DG2 page tables. ptrace support for > local memory objects, local-memory migration for display surfaces. > > Note that there is drm/drm-next backmerge and then MEI subsystem patches > around GSC/PXP which are intertwined with i915 change so merged here as > agreed with Tomas and Greg. > > Additionally the usual amount of refactoring, cleanups, debugging > improvements and static checker fixes. Fails to build with clang here. CC [M] drivers/gpu/drm/i915/i915_hwmon.o /home/airlied/devel/kernel/dim/src/drivers/gpu/drm/i915/i915_hwmon.c:115:16: error: result of comparison of constant 18446744073709551615 with expression of type 'typeof (_Generic((field_msk), char: (unsigned char)0, unsigned char: (unsigned char)0, signed char: (unsigned char)0, unsigned short: (unsigned short)0, short: (unsigned short)0, unsigned int: (unsigned int)0, int: (unsigned int)0, unsigned long: (unsigned long)0, long: (unsigned long)0, unsigned long long: (unsigned long long)0, long long: (unsigned long long)0, default: (field_msk)))' (aka 'unsigned int') is always false [-Werror,-Wtautological-constant-out-of-range-compare] bits_to_set = FIELD_PREP(field_msk, nval); ^~~ /home/airlied/devel/kernel/dim/src/include/linux/bitfield.h:114:3: note: expanded from macro 'FIELD_PREP' __BF_FIELD_CHECK(_mask, 0ULL, _val, "FIELD_PREP: ");\ ^~~ /home/airlied/devel/kernel/dim/src/include/linux/bitfield.h:71:53: note: expanded from macro '__BF_FIELD_CHECK' BUILD_BUG_ON_MSG(__bf_cast_unsigned(_mask, _mask) > \ ~~^~~ /home/airlied/devel/kernel/dim/src/include/linux/build_bug.h:39:58: note: expanded from macro 'BUILD_BUG_ON_MSG' #define BUILD_BUG_ON_MSG(cond, msg) compiletime_assert(!(cond), msg) ~^~~ /home/airlied/devel/kernel/dim/src/include/linux/compiler_types.h:357:22: note: expanded from macro 'compiletime_assert' _compiletime_assert(condition, msg, __compiletime_assert_, __COUNTER__) ^~~ /home/airlied/devel/kernel/dim/src/include/linux/compiler_types.h:345:23: note: expanded from macro '_compiletime_assert' __compiletime_assert(condition, msg, prefix, suffix) ~^~~ /home/airlied/devel/kernel/dim/src/include/linux/compiler_types.h:337:9: note: expanded from macro '__compiletime_assert' if (!(condition)) \ ^ 1 error generated. clang -v clang version 14.0.5 (Fedora 14.0.5-1.fc36) Dave.
Re: [PULL] drm-intel-gt-next
On Wed, 2022-07-13 at 17:31 -0400, Rodrigo Vivi wrote: > Hi Dave and Daniel, > > On behalf of Tvrtko, who is recovering from Covid, > here goes the latest drm-intel-gt-next pull request > targeting 5.20. Hi Folks, any particular issue with this pull request? We just realized it is not yet part of the drm-next. Thanks, Rodrigo. > > Thanks, > Rodrigo. > > Driver uAPI changes: > - All related to the Small BAR support: (and all by Matt Auld) > * add probed_cpu_visible_size > * expose the avail memory region tracking > * apply ALLOC_GPU only by default > * add NEEDS_CPU_ACCESS hint > * tweak error capture on recoverable contexts > > Driver highlights: > - Add Small BAR support (Matt) > - Add MeteorLake support (RK) > - Add support for LMEM PCIe resizable BAR (Akeem) > > Driver important fixes: > - ttm related fixes (Matt Auld) > - Fix a performance regression related to waitboost (Chris) > - Fix GT resets (Chris) > > Driver others: > - Adding GuC SLPC selftest (Vinay) > - Fix ADL-N GuC load (Daniele) > - Add platform workaround (Gustavo, Matt Roper) > - DG2 and ATS-M device ID updates (Matt Roper) > - Add VM_BIND doc rfc with uAPI documentation (Niranjana) > - Fix user-after-free in vma destruction (Thomas) > - Async flush of GuC log regions (Alan) > - Fixes in selftests (Chris, Dan, Andrzej) > - Convert to drm_dbg (Umesh) > - Disable OA sseu config param for newer hardware (Umesh) > - Multi-cast register steering changes (Matt Roper) > - Add lmem_bar_size modparam (Priyanka) > > Thanks, > Rodrigo. > > The following changes since commit > a06968563775181690125091f470a8655742dcbf: > > drm/i915: Fix a lockdep warning at error capture (2022-06-29 > 14:52:50 +0530) > > are available in the Git repository at: > > git://anongit.freedesktop.org/drm/drm-intel tags/drm-intel-gt-next- > 2022-07-13 > > for you to fetch changes up to > 17cd10a44a8962860ff4ba351b2a290e752dbbde: > > drm/i915: Add lmem_bar_size modparam (2022-07-13 17:47:51 +0100) > > > Driver uAPI changes: > - All related to the Small BAR support: (and all by Matt Auld) > * add probed_cpu_visible_size > * expose the avail memory region tracking > * apply ALLOC_GPU only by default > * add NEEDS_CPU_ACCESS hint > * tweak error capture on recoverable contexts > > Driver highlights: > - Add Small BAR support (Matt) > - Add MeteorLake support (RK) > - Add support for LMEM PCIe resizable BAR (Akeem) > > Driver important fixes: > - ttm related fixes (Matt Auld) > - Fix a performance regression related to waitboost (Chris) > - Fix GT resets (Chris) > > Driver others: > - Adding GuC SLPC selftest (Vinay) > - Fix ADL-N GuC load (Daniele) > - Add platform workaround (Gustavo, Matt Roper) > - DG2 and ATS-M device ID updates (Matt Roper) > - Add VM_BIND doc rfc with uAPI documentation (Niranjana) > - Fix user-after-free in vma destruction (Thomas) > - Async flush of GuC log regions (Alan) > - Fixes in selftests (Chris, Dan, Andrzej) > - Convert to drm_dbg (Umesh) > - Disable OA sseu config param for newer hardware (Umesh) > - Multi-cast register steering changes (Matt Roper) > - Add lmem_bar_size modparam (Priyanka) > > > Akeem G Abodunrin (1): > drm/i915: Add support for LMEM PCIe resizable bar > > Alan Previn (1): > drm/i915/guc: Asynchronous flush of GuC log regions > > Andrzej Hajda (1): > drm/i915/selftests: fix subtraction overflow bug > > Chris Wilson (6): > drm/i915/selftests: Grab the runtime pm in shrink_thp > drm/i915/gt: Serialize GRDOM access between multiple engine > resets > drm/i915/gt: Serialize TLB invalidates with GT resets > drm/i915/gem: Look for waitboosting across the whole object > prior to individual waits > drm/i915: Bump GT idling delay to 2 jiffies > drm/i915/gt: Only kick the signal worker if there's been an > update > > Dan Carpenter (1): > drm/i915/selftests: fix a couple IS_ERR() vs NULL tests > > Daniele Ceraolo Spurio (1): > drm/i915/guc: ADL-N should use the same GuC FW as ADL-S > > Gustavo Sousa (1): > drm/i915/pvc: Implement w/a 16016694945 > > Matt Roper (4): > drm/i915: DG2 and ATS-M device ID updates > drm/i915/gt: Add general DSS steering iterator to intel_gt_mcr > drm/i915/dg2: Add Wa_15010599737 > drm/i915: Correct ss -> steering calculation for pre-Xe_HP > platforms > > Matthew Auld (15): > drm/doc: add rfc section for small BAR uapi > drm/i915/uapi: add probed_cpu_visible_size > drm/i915/uapi: expose the avail tracking > drm/i915: remove intel_memory_region avail > drm/i915/uapi: apply ALLOC_GPU_ONLY by default > drm/i915/uapi: add NEEDS_CPU_ACCESS hint > drm/i915/error: skip non-mappable pages > drm/i915/uapi: tweak error capture on recoverable contexts > drm/i915/selftests: skip the mman tests for
Re: [PULL] drm-intel-gt-next
On Tue, 2022-02-22 at 11:44 -0800, Lucas De Marchi wrote: > On Mon, Feb 21, 2022 at 11:21:35AM +0200, Jani Nikula wrote: > > On Mon, 21 Feb 2022, Dave Airlie wrote: > > > On Thu, 17 Feb 2022 at 20:26, Joonas Lahtinen > > > wrote: > > > > > > > > Hi Dave & Daniel, > > > > > > > > Here is the first drm-intel-gt-next feature PR towards v5.18. > > > > > > Am I missing some previous drm-intel pull? > > > > > > /home/airlied/devel/kernel/dim/src/drivers/gpu/drm/i915/gt/intel_ > > > workarounds.c: > > > In function ‘rcs_engine_wa_init’: > > > /home/airlied/devel/kernel/dim/src/drivers/gpu/drm/i915/gt/intel_ > > > workarounds.c:2051:40: > > > error: ‘XEHP_DIS_BBL_SYSPIPE’ undeclared (first use in this > > > function) > > > 2051 | wa_masked_en(wal, GEN9_ROW_CHICKEN4, > > > XEHP_DIS_BBL_SYSPIPE); > > > | > > > ^~~~ > > > /home/airlied/devel/kernel/dim/src/drivers/gpu/drm/i915/gt/intel_ > > > workarounds.c:2051:40: > > > note: each undeclared identifier is reported only once for each > > > function it appears in > > > > There's apparently a silent conflict between changes in drm-intel- > > next > > and drm-intel-gt-next. There's a fixup patch in drm-rerere: > > fixups/drm-intel-gt-next.patch. With ack from Dave on #dri-devel, I've applied this pull request to drm-intel-next. Then I used this big fixup on the merge resolution. Now I'm going to prepare a drm-intel-next pull request towards drm- next. Then for the next rounds we check if we are doing cross merges, or the other way around and get drm-intel-next into drm-intel-gt-next Thanks, Rodrigo. > yeah, with all header refactors landing in drm-intel-next there were > quite a few conflict lately. Just taking fixups/drm-intel-gt- > next.patch > doesn't fix it though as we'd need to follow the merge order drm-tip > is > doing, i.e. first get a pull request for drm-intel-next in, and then > drm-intel-gt-next. Or the octopus merge > > For this merge only I believe the fixup is: > > git show 064030837c5b:fixups/drm-intel-gt-next.patch | patch > -p1 > > with 064030837c5b being the commit in drm-rerere. Cc'ing Matt Roper > > Lucas De Marchi > > > > > We opted to sync the branches via drm-next pulls and backmerges, > > but I'm > > afraid that means you'd have to use the fixups when merging. I > > guess we > > failed to communicate that. The alternative would've been cross- > > merges > > within drm-intel. > > > > > > BR, > > Jani. > > > > > > > > > > Dave. > > > > > > > > For DG2 adds subplatform G12, missing workarounds and fixes GuC > > > > loading on ARM64. C0/D0 stepping info added for RPL-S. > > > > > > > > For uAPI enables support for simple parallel submission with > > > > execlists which was previously enabled only for GuC. > > > > > > > > Further fixes for PMU metrics when GuC is enabled, better error > > > > reporting for GuC loading failures. Fix for PXP unbind splat. > > > > Updates to GuC version 69.0.3 with improvements to GT reset > > > > scenarios. > > > > > > > > The rest is mostly refactoring of the memory management code, > > > > as highlights introduction of async unbinding/migration and > > > > removal of short-term pinning in execbuf. > > > > > > > > Then a few selftest and coding style fixes. > > > > > > > > Regards, Joonas > > > > > > > > *** > > > > > > > > drm-intel-gt-next-2022-02-17: > > > > > > > > UAPI Changes: > > > > > > > > - Weak parallel submission support for execlists > > > > > > > > Minimal implementation of the parallel submission support for > > > > execlists backend that was previously only implemented for > > > > GuC. > > > > Support one sibling non-virtual engine. > > > > > > > > Core Changes: > > > > > > > > - Two backmerges of drm/drm-next for header file > > > > renames/changes and > > > > i915_regs reorganization > > > > > > > > Driver Changes: > > > > > > > > - Add new DG2 subplatform: DG2-G12 (Matt R) > > > > - Add new DG2 workarounds (Matt R, Ram, Bruce) > > > > - Handle pre-programmed WOPCM registers for DG2+ (Daniele) > > > > - Update guc shim control programming on XeHP SDV+ (Daniele) > > > > - Add RPL-S C0/D0 stepping information (Anusha) > > > > - Improve GuC ADS initialization to work on ARM64 on dGFX > > > > (Lucas) > > > > > > > > - Fix KMD and GuC race on accessing PMU busyness (Umesh) > > > > - Use PM timestamp instead of RING TIMESTAMP for reference in > > > > PMU with GuC (Umesh) > > > > - Report error on invalid reset notification from GuC (John) > > > > - Avoid WARN splat by holding RPM wakelock during PXP unbind > > > > (Juston) > > > > - Fixes to parallel submission implementation (Matt B.) > > > > - Improve GuC loading status check/error reports (John) > > > > - Tweak TTM LRU priority hint selection (Matt A.) > > > > - Align the plane_vma to min_page_size of stolen mem (Ram) > > > > > > > > - Introduce vma resources and implement async unbinding > > > > (Thomas) > > > > - Use struct
Re: [PULL] drm-intel-gt-next
On Mon, Feb 21, 2022 at 11:21:35AM +0200, Jani Nikula wrote: On Mon, 21 Feb 2022, Dave Airlie wrote: On Thu, 17 Feb 2022 at 20:26, Joonas Lahtinen wrote: Hi Dave & Daniel, Here is the first drm-intel-gt-next feature PR towards v5.18. Am I missing some previous drm-intel pull? /home/airlied/devel/kernel/dim/src/drivers/gpu/drm/i915/gt/intel_workarounds.c: In function ‘rcs_engine_wa_init’: /home/airlied/devel/kernel/dim/src/drivers/gpu/drm/i915/gt/intel_workarounds.c:2051:40: error: ‘XEHP_DIS_BBL_SYSPIPE’ undeclared (first use in this function) 2051 | wa_masked_en(wal, GEN9_ROW_CHICKEN4, XEHP_DIS_BBL_SYSPIPE); |^~~~ /home/airlied/devel/kernel/dim/src/drivers/gpu/drm/i915/gt/intel_workarounds.c:2051:40: note: each undeclared identifier is reported only once for each function it appears in There's apparently a silent conflict between changes in drm-intel-next and drm-intel-gt-next. There's a fixup patch in drm-rerere: fixups/drm-intel-gt-next.patch. yeah, with all header refactors landing in drm-intel-next there were quite a few conflict lately. Just taking fixups/drm-intel-gt-next.patch doesn't fix it though as we'd need to follow the merge order drm-tip is doing, i.e. first get a pull request for drm-intel-next in, and then drm-intel-gt-next. Or the octopus merge For this merge only I believe the fixup is: git show 064030837c5b:fixups/drm-intel-gt-next.patch | patch -p1 with 064030837c5b being the commit in drm-rerere. Cc'ing Matt Roper Lucas De Marchi We opted to sync the branches via drm-next pulls and backmerges, but I'm afraid that means you'd have to use the fixups when merging. I guess we failed to communicate that. The alternative would've been cross-merges within drm-intel. BR, Jani. Dave. For DG2 adds subplatform G12, missing workarounds and fixes GuC loading on ARM64. C0/D0 stepping info added for RPL-S. For uAPI enables support for simple parallel submission with execlists which was previously enabled only for GuC. Further fixes for PMU metrics when GuC is enabled, better error reporting for GuC loading failures. Fix for PXP unbind splat. Updates to GuC version 69.0.3 with improvements to GT reset scenarios. The rest is mostly refactoring of the memory management code, as highlights introduction of async unbinding/migration and removal of short-term pinning in execbuf. Then a few selftest and coding style fixes. Regards, Joonas *** drm-intel-gt-next-2022-02-17: UAPI Changes: - Weak parallel submission support for execlists Minimal implementation of the parallel submission support for execlists backend that was previously only implemented for GuC. Support one sibling non-virtual engine. Core Changes: - Two backmerges of drm/drm-next for header file renames/changes and i915_regs reorganization Driver Changes: - Add new DG2 subplatform: DG2-G12 (Matt R) - Add new DG2 workarounds (Matt R, Ram, Bruce) - Handle pre-programmed WOPCM registers for DG2+ (Daniele) - Update guc shim control programming on XeHP SDV+ (Daniele) - Add RPL-S C0/D0 stepping information (Anusha) - Improve GuC ADS initialization to work on ARM64 on dGFX (Lucas) - Fix KMD and GuC race on accessing PMU busyness (Umesh) - Use PM timestamp instead of RING TIMESTAMP for reference in PMU with GuC (Umesh) - Report error on invalid reset notification from GuC (John) - Avoid WARN splat by holding RPM wakelock during PXP unbind (Juston) - Fixes to parallel submission implementation (Matt B.) - Improve GuC loading status check/error reports (John) - Tweak TTM LRU priority hint selection (Matt A.) - Align the plane_vma to min_page_size of stolen mem (Ram) - Introduce vma resources and implement async unbinding (Thomas) - Use struct vma_resource instead of struct vma_snapshot (Thomas) - Return some TTM accel move errors instead of trying memcpy move (Thomas) - Fix a race between vma / object destruction and unbinding (Thomas) - Remove short-term pins from execbuf (Maarten) - Update to GuC version 69.0.3 (John, Michal Wa.) - Improvements to GT reset paths in GuC backend (Matt B.) - Use shrinker_release_pages instead of writeback in shmem object hooks (Matt A., Tvrtko) - Use trylock instead of blocking lock when freeing GEM objects (Maarten) - Allocate intel_engine_coredump_alloc with ALLOW_FAIL (Matt B.) - Fixes to object unmapping and purging (Matt A) - Check for wedged device in GuC backend (John) - Avoid lockdep splat by locking dpt_obj around set_cache_level (Maarten) - Allow dead vm to unbind vma's without lock (Maarten) - s/engine->i915/i915/ for DG2 engine workarounds (Matt R) - Use to_gt() helper for GGTT accesses (Michal Wi.) - Selftest improvements (Matt B., Thomas, Ram) - Coding style and compiler warning fixes (Matt B., Jasmine, Andi, Colin, Gustavo, Dan) The following changes since commit 53dbee4926d3706ca9e03f3928fa85b5ec3bc0cc: Merge tag 'drm-misc-next-2022-01-27' of
Re: [PULL] drm-intel-gt-next
On Mon, 21 Feb 2022, Dave Airlie wrote: > On Thu, 17 Feb 2022 at 20:26, Joonas Lahtinen > wrote: >> >> Hi Dave & Daniel, >> >> Here is the first drm-intel-gt-next feature PR towards v5.18. > > Am I missing some previous drm-intel pull? > > /home/airlied/devel/kernel/dim/src/drivers/gpu/drm/i915/gt/intel_workarounds.c: > In function ‘rcs_engine_wa_init’: > /home/airlied/devel/kernel/dim/src/drivers/gpu/drm/i915/gt/intel_workarounds.c:2051:40: > error: ‘XEHP_DIS_BBL_SYSPIPE’ undeclared (first use in this function) > 2051 | wa_masked_en(wal, GEN9_ROW_CHICKEN4, XEHP_DIS_BBL_SYSPIPE); > |^~~~ > /home/airlied/devel/kernel/dim/src/drivers/gpu/drm/i915/gt/intel_workarounds.c:2051:40: > note: each undeclared identifier is reported only once for each > function it appears in There's apparently a silent conflict between changes in drm-intel-next and drm-intel-gt-next. There's a fixup patch in drm-rerere: fixups/drm-intel-gt-next.patch. We opted to sync the branches via drm-next pulls and backmerges, but I'm afraid that means you'd have to use the fixups when merging. I guess we failed to communicate that. The alternative would've been cross-merges within drm-intel. BR, Jani. > > Dave. >> >> For DG2 adds subplatform G12, missing workarounds and fixes GuC >> loading on ARM64. C0/D0 stepping info added for RPL-S. >> >> For uAPI enables support for simple parallel submission with >> execlists which was previously enabled only for GuC. >> >> Further fixes for PMU metrics when GuC is enabled, better error >> reporting for GuC loading failures. Fix for PXP unbind splat. >> Updates to GuC version 69.0.3 with improvements to GT reset >> scenarios. >> >> The rest is mostly refactoring of the memory management code, >> as highlights introduction of async unbinding/migration and >> removal of short-term pinning in execbuf. >> >> Then a few selftest and coding style fixes. >> >> Regards, Joonas >> >> *** >> >> drm-intel-gt-next-2022-02-17: >> >> UAPI Changes: >> >> - Weak parallel submission support for execlists >> >> Minimal implementation of the parallel submission support for >> execlists backend that was previously only implemented for GuC. >> Support one sibling non-virtual engine. >> >> Core Changes: >> >> - Two backmerges of drm/drm-next for header file renames/changes and >> i915_regs reorganization >> >> Driver Changes: >> >> - Add new DG2 subplatform: DG2-G12 (Matt R) >> - Add new DG2 workarounds (Matt R, Ram, Bruce) >> - Handle pre-programmed WOPCM registers for DG2+ (Daniele) >> - Update guc shim control programming on XeHP SDV+ (Daniele) >> - Add RPL-S C0/D0 stepping information (Anusha) >> - Improve GuC ADS initialization to work on ARM64 on dGFX (Lucas) >> >> - Fix KMD and GuC race on accessing PMU busyness (Umesh) >> - Use PM timestamp instead of RING TIMESTAMP for reference in PMU with GuC >> (Umesh) >> - Report error on invalid reset notification from GuC (John) >> - Avoid WARN splat by holding RPM wakelock during PXP unbind (Juston) >> - Fixes to parallel submission implementation (Matt B.) >> - Improve GuC loading status check/error reports (John) >> - Tweak TTM LRU priority hint selection (Matt A.) >> - Align the plane_vma to min_page_size of stolen mem (Ram) >> >> - Introduce vma resources and implement async unbinding (Thomas) >> - Use struct vma_resource instead of struct vma_snapshot (Thomas) >> - Return some TTM accel move errors instead of trying memcpy move (Thomas) >> - Fix a race between vma / object destruction and unbinding (Thomas) >> - Remove short-term pins from execbuf (Maarten) >> - Update to GuC version 69.0.3 (John, Michal Wa.) >> - Improvements to GT reset paths in GuC backend (Matt B.) >> - Use shrinker_release_pages instead of writeback in shmem object hooks >> (Matt A., Tvrtko) >> - Use trylock instead of blocking lock when freeing GEM objects (Maarten) >> - Allocate intel_engine_coredump_alloc with ALLOW_FAIL (Matt B.) >> - Fixes to object unmapping and purging (Matt A) >> - Check for wedged device in GuC backend (John) >> - Avoid lockdep splat by locking dpt_obj around set_cache_level (Maarten) >> - Allow dead vm to unbind vma's without lock (Maarten) >> - s/engine->i915/i915/ for DG2 engine workarounds (Matt R) >> >> - Use to_gt() helper for GGTT accesses (Michal Wi.) >> - Selftest improvements (Matt B., Thomas, Ram) >> - Coding style and compiler warning fixes (Matt B., Jasmine, Andi, Colin, >> Gustavo, Dan) >> >> The following changes since commit 53dbee4926d3706ca9e03f3928fa85b5ec3bc0cc: >> >> Merge tag 'drm-misc-next-2022-01-27' of >> git://anongit.freedesktop.org/drm/drm-misc into drm-next (2022-02-01 >> 19:02:41 +1000) >> >> are available in the Git repository at: >> >> git://anongit.freedesktop.org/drm/drm-intel >> tags/drm-intel-gt-next-2022-02-17 >> >> for you to fetch changes up to 154cfae6158141b18d65abb0db679bb51a8294e7: >> >> drm/i915/dg2: Add Wa_22011100796 (2022-02-11 17:11:44
Re: [PULL] drm-intel-gt-next
On Thu, 17 Feb 2022 at 20:26, Joonas Lahtinen wrote: > > Hi Dave & Daniel, > > Here is the first drm-intel-gt-next feature PR towards v5.18. Am I missing some previous drm-intel pull? /home/airlied/devel/kernel/dim/src/drivers/gpu/drm/i915/gt/intel_workarounds.c: In function ‘rcs_engine_wa_init’: /home/airlied/devel/kernel/dim/src/drivers/gpu/drm/i915/gt/intel_workarounds.c:2051:40: error: ‘XEHP_DIS_BBL_SYSPIPE’ undeclared (first use in this function) 2051 | wa_masked_en(wal, GEN9_ROW_CHICKEN4, XEHP_DIS_BBL_SYSPIPE); |^~~~ /home/airlied/devel/kernel/dim/src/drivers/gpu/drm/i915/gt/intel_workarounds.c:2051:40: note: each undeclared identifier is reported only once for each function it appears in Dave. > > For DG2 adds subplatform G12, missing workarounds and fixes GuC > loading on ARM64. C0/D0 stepping info added for RPL-S. > > For uAPI enables support for simple parallel submission with > execlists which was previously enabled only for GuC. > > Further fixes for PMU metrics when GuC is enabled, better error > reporting for GuC loading failures. Fix for PXP unbind splat. > Updates to GuC version 69.0.3 with improvements to GT reset > scenarios. > > The rest is mostly refactoring of the memory management code, > as highlights introduction of async unbinding/migration and > removal of short-term pinning in execbuf. > > Then a few selftest and coding style fixes. > > Regards, Joonas > > *** > > drm-intel-gt-next-2022-02-17: > > UAPI Changes: > > - Weak parallel submission support for execlists > > Minimal implementation of the parallel submission support for > execlists backend that was previously only implemented for GuC. > Support one sibling non-virtual engine. > > Core Changes: > > - Two backmerges of drm/drm-next for header file renames/changes and > i915_regs reorganization > > Driver Changes: > > - Add new DG2 subplatform: DG2-G12 (Matt R) > - Add new DG2 workarounds (Matt R, Ram, Bruce) > - Handle pre-programmed WOPCM registers for DG2+ (Daniele) > - Update guc shim control programming on XeHP SDV+ (Daniele) > - Add RPL-S C0/D0 stepping information (Anusha) > - Improve GuC ADS initialization to work on ARM64 on dGFX (Lucas) > > - Fix KMD and GuC race on accessing PMU busyness (Umesh) > - Use PM timestamp instead of RING TIMESTAMP for reference in PMU with GuC > (Umesh) > - Report error on invalid reset notification from GuC (John) > - Avoid WARN splat by holding RPM wakelock during PXP unbind (Juston) > - Fixes to parallel submission implementation (Matt B.) > - Improve GuC loading status check/error reports (John) > - Tweak TTM LRU priority hint selection (Matt A.) > - Align the plane_vma to min_page_size of stolen mem (Ram) > > - Introduce vma resources and implement async unbinding (Thomas) > - Use struct vma_resource instead of struct vma_snapshot (Thomas) > - Return some TTM accel move errors instead of trying memcpy move (Thomas) > - Fix a race between vma / object destruction and unbinding (Thomas) > - Remove short-term pins from execbuf (Maarten) > - Update to GuC version 69.0.3 (John, Michal Wa.) > - Improvements to GT reset paths in GuC backend (Matt B.) > - Use shrinker_release_pages instead of writeback in shmem object hooks (Matt > A., Tvrtko) > - Use trylock instead of blocking lock when freeing GEM objects (Maarten) > - Allocate intel_engine_coredump_alloc with ALLOW_FAIL (Matt B.) > - Fixes to object unmapping and purging (Matt A) > - Check for wedged device in GuC backend (John) > - Avoid lockdep splat by locking dpt_obj around set_cache_level (Maarten) > - Allow dead vm to unbind vma's without lock (Maarten) > - s/engine->i915/i915/ for DG2 engine workarounds (Matt R) > > - Use to_gt() helper for GGTT accesses (Michal Wi.) > - Selftest improvements (Matt B., Thomas, Ram) > - Coding style and compiler warning fixes (Matt B., Jasmine, Andi, Colin, > Gustavo, Dan) > > The following changes since commit 53dbee4926d3706ca9e03f3928fa85b5ec3bc0cc: > > Merge tag 'drm-misc-next-2022-01-27' of > git://anongit.freedesktop.org/drm/drm-misc into drm-next (2022-02-01 19:02:41 > +1000) > > are available in the Git repository at: > > git://anongit.freedesktop.org/drm/drm-intel > tags/drm-intel-gt-next-2022-02-17 > > for you to fetch changes up to 154cfae6158141b18d65abb0db679bb51a8294e7: > > drm/i915/dg2: Add Wa_22011100796 (2022-02-11 17:11:44 +0530) > > > UAPI Changes: > > - Weak parallel submission support for execlists > > Minimal implementation of the parallel submission support for > execlists backend that was previously only implemented for GuC. > Support one sibling non-virtual engine. > > Core Changes: > > - Two backmerges of drm/drm-next for header file renames/changes and > i915_regs reorganization > > Driver Changes: > > - Add new DG2 subplatform: DG2-G12 (Matt R) > - Add new DG2 workarounds (Matt R, Ram, Bruce) > - Handle
Re: [PULL] drm-intel-gt-next
Quoting Joonas Lahtinen (2021-08-06 13:06:17) > Hi Dave & Daniel, > > Sorry for the big PR in advance. Had the summer vacations and did not > notice until tool late how many patches were in already before leaving. > > As requested, there is a lot of refactoring to increase the use of TTM > allocator and prep for DRM scheduler. Note that at times the patches trade > simplicity for performance and revert optimizations not seen as critical. > So some performance regressions are expected. > > As an example is dropping of faster GPU relocation path for older platforms, > which should be mitigated by updating to the latest UMD versions to regain > the perf. > > This PR drops various bits of uAPI where userspace has dropped the ball after > reviews > have been completed on both sides (Thanks Jason for doing the > due-diligence!). [1] > Due to the complexity of tracing back who used what, I think we could do > better in the > future to avoid such situations to begin with. See below for my suggestion > [2]. > > In addition to the refactoring and uAPI cleanup there is preliminay code for > ADL-P/XeHP and DG2 platforms. Fixes for ADL-S and removal of CNL code. > A couple of fixes that have been Cc: stable already. Removing unnecessary > workarounds per stepping and adding missing for Gen12 iGFX. > > I915_MMAP_OFFSET_FIXED is also added to to align with the static/fixed caching > mode per BO instead of per-mapping mode (for dGFX only). There is GuC firmware > interface update and backend code major rework that unblock enabling GuC on > Gen11 > (not on by default). Then there is the addition of the GuCRC power management > feature which can be enabled for Gen12+ when submission is enabled. There is also addition of I915_USERPTR_PROBE with userspace changes in: https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/12044 Regards, Joonas > > Then there is finally the drm-next backmerge and 3 topic branch merges. > > I think that is mostly all. I tried to summarize much in the tag description > so > it should hopefully not be horribly long... > > Regards, Joonas > > [1] Given that Jason is only human and there is no way to automate this > analysis, we > may have to bring something back as fixes if we find breakage (like with the > MMAP IOCTL). > > [2] As we first require to merge the kernel code, should we introduce some > further rules > that the userspace has to land their code before the final kernel version > release? If > that is not followed through, we would neuter the new uAPI with as small > patch as possible > in the final release candidate and then remove it in next release. Thoughts? > > *** > > drm-intel-gt-next-2021-08-06-1: > > UAPI Changes: > > - Add I915_MMAP_OFFSET_FIXED > > On devices with local memory `I915_MMAP_OFFSET_FIXED` is the only valid > type. On devices without local memory, this caching mode is invalid. > > As caching mode when specifying `I915_MMAP_OFFSET_FIXED`, WC or WB will > be used, depending on the object placement on creation. WB will be used > when the object can only exist in system memory, WC otherwise. > > Userspace: https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/11888 > > - Reinstate the mmap ioctl for (already released) integrated Gen12 platforms > > Rationale: Otherwise media driver breaks eg. for ADL-P. Long term goal is > still to sunset the IOCTL even for integrated and require using mmap_offset. > > - Reject caching/set_domain IOCTLs on discrete > > Expected to become immutable property of the BO > > - Disallow changing context parameters after first use on Gen12 and earlier > - Require setting context parameters at creation on platforms after Gen12 > > Rationale (for both): Allow less dynamic changes to the context to simplify > the implementation and avoid user shooting theirselves in the foot. > > - Drop I915_CONTEXT_PARAM_RINGSIZE > > Userspace PR for compute-driver has not been merged > > - Drop I915_CONTEXT_PARAM_NO_ZEROMAP > > Userspace PR for libdrm / Beignet was never landed > > - Drop CONTEXT_CLONE API > > Userspace PR for Mesa was never landed > > - Drop getparam support for I915_CONTEXT_PARAM_ENGINES > > Only existed for symmetry wrt. setparam, never used. > > - Disallow bonding of virtual engines > > Drop the prep work, no hardware has been released needing it. > > - (Implicit) Disable gpu relocations > > Media userspace was the last userspace to still use them. They > have converted so performance can be regained with an update. > > Core Changes: > > - Merge topic branch 'topic/i915-ttm-2021-06-11' (from Maarten) > - Merge topic branch 'topic/revid_steppings' (from Matt R) > - Merge topic branch 'topic/xehp-dg2-definitions-2021-07-21' (from Matt R) > - Backmerges drm-next (Rodrigo) > > Driver Changes: > > - Initial workarounds for ADL-P (Clint) > - Preliminary code for XeHP/DG2 (Stuart, Umesh, Matt R, Prathap, Ram, > Venkata, Akeem, Tvrtko, John, Lucas)
Re: [PULL] drm-intel-gt-next
On Wed, 2 Jun 2021 at 14:17, Dave Airlie wrote: > > On Wed, 2 Jun 2021 at 10:28, Dave Airlie wrote: > > > > This has these two patches applied, and it doesn't build. > > > > drm/i915: drop the __i915_active_call pointer packing > > drm/i915: Fix crash in auto_retire > > > > The latter patch shouldn't be necessary after the former, please fix > > that up and resend and please build test trees before I get them in > > future. > > Oh maybe this is an unresolved conflict, not sure why drm-tip doesn't > catch this though, or is this next tree not in next? Oh looks like tip did catch it, I just didn't see it was done with a fixup. Dave.
Re: [PULL] drm-intel-gt-next
On Wed, 2 Jun 2021 at 10:28, Dave Airlie wrote: > > This has these two patches applied, and it doesn't build. > > drm/i915: drop the __i915_active_call pointer packing > drm/i915: Fix crash in auto_retire > > The latter patch shouldn't be necessary after the former, please fix > that up and resend and please build test trees before I get them in > future. Oh maybe this is an unresolved conflict, not sure why drm-tip doesn't catch this though, or is this next tree not in next? That would explain it then. I've pulled it with an fix in the merge commit. Dave. > > Dave. > > > On Fri, 28 May 2021 at 17:27, Joonas Lahtinen > wrote: > > > > Quoting Joonas Lahtinen (2021-05-28 10:25:57) > > > Hi Dave & Daniel, > > > > > > Here's drm-intel-gt-next pull request. > > > > > > Most notably it has the reworked DG1 uAPI (behind CONFIG_BROKEN) > > > as requested. Important fix for Gitlab issues #3293 and #3450 and > > > one another kernel crash. Adds missing workarounds for Gen11 and > > > Gen12. Hiding of modparams for compiled-out features. Conversion > > > to use trylock shrinking for BSW VT-d and BXT. > > > > > > Then there are the uAPI kerneldoc improvements as part of the DG1 > > > uAPI rework. Usual amount smaller fixes, code refactoring and > > > cleanups as prep for upcoming patches. > > > > And includes tag 'topic/intel-gen-to-ver-2021-04-19' (but that is > > already merged to drm-next). > > > > Regards, Joonas > > > > > Regards, Joonas > > > > > > *** > > > > > > drm-intel-gt-next-2021-05-28: > > > > > > UAPI Changes: > > > - Add reworked uAPI for DG1 behind CONFIG_BROKEN (Matt A, Abdiel) > > > > > > Driver Changes: > > > > > > - Fix for Gitlab issues #3293 and #3450: > > > Avoid kernel crash on older L-shape memory machines > > > > > > - Hide modparams for compiled-out features (Tvrtko) > > > - Add Wa_14010733141 (VDBox SFC reset) for Gen11+ (Aditya) > > > - Fix crash in auto_retire active retire callback due to > > > misalignment (Stephane) > > > - Use trylock in shrinker for GGTT on BSW VT-d and BXT (Maarten) > > > - Fix overlay active retire callback alignment (Tvrtko) > > > - Eliminate need to align active retire callbacks (Matt A, Ville, > > > Daniel) > > > - Program FF_MODE2 tuning value for all Gen12 platforms (Caz) > > > - Add Wa_14011060649 for TGL,RKL,DG1 and ADLS (Swathi) > > > - Create stolen memory region from local memory on DG1 (CQ) > > > - Place PD in LMEM on dGFX (Matt A) > > > - Use WC when default state object is allocated in LMEM (Venkata) > > > - Determine the coherent map type based on object location (Venkata) > > > - Use lmem physical addresses for fb_mmap() on discrete (Mohammed) > > > - Bypass aperture on fbdev when LMEM is available (Anusha) > > > - Return error value when displayable BO not in LMEM for dGFX (Mohammed) > > > - Do release kernel context if breadcrumb measure fails (Janusz) > > > - Apply Wa_22010271021 for all Gen11 platforms (Caz) > > > - Fix unlikely ref count race in arming the watchdog timer (Tvrtko) > > > - Check actual RC6 enable status in PMU (Tvrtko) > > > - Fix a double free in gen8_preallocate_top_level_pdp (Lv) > > > - Remove erroneous i915_is_ggtt check for > > > I915_GEM_OBJECT_UNBIND_VM_TRYLOCK (Maarten) > > > > > > - Convert uAPI headers to real kerneldoc (Matt A) > > > - Clean up kerneldoc warnings headers (Matt A, Maarten) > > > - Fail driver if LMEM training failed (Matt R) > > > - Avoid div-by-zero on Gen2 (Ville) > > > - Read C0DRB3/C1DRB3 as 16 bits again and add _BW suffix (Ville) > > > - Remove reference to struct drm_device.pdev (Thomas) > > > - Increase separation between GuC and execlists code (Chris, Matt B) > > > > > > - Use might_alloc() (Bernard) > > > - Split DGFX_FEATURES from GEN12_FEATURES (Lucas) > > > - Deduplicate Wa_22010271021 programming on (Jose) > > > - Drop duplicate WaDisable4x2SubspanOptimization:hsw (Tvrtko) > > > - Selftest improvements (Chris, Hsin-Yi, Tvrtko) > > > - Shuffle around init_memory_region for stolen (Matt) > > > - Typo fixes (wengjianfeng) > > > > > > The following changes since commit > > > 425390c5dce6da76578389629d19517fcd79c959: > > > > > > drm/i915: split dgfx features from gen 12 (2021-04-14 13:05:06 +0300) > > > > > > are available in the Git repository at: > > > > > > git://anongit.freedesktop.org/drm/drm-intel > > > tags/drm-intel-gt-next-2021-05-28 > > > > > > for you to fetch changes up to 5b26d57fdb499c2363f3d895ef008e73ec02eb9b: > > > > > > drm/i915: Add Wa_14010733141 (2021-05-27 11:05:09 -0700) > > > > > > > > > UAPI Changes: > > > - Add reworked uAPI for DG1 behind CONFIG_BROKEN (Matt A, Abdiel) > > > > > > Driver Changes: > > > > > > - Fix for Gitlab issues #3293 and #3450: > > > Avoid kernel crash on older L-shape memory machines > > > > > > - Add Wa_14010733141 (VDBox SFC reset) for Gen11+ (Aditya) > > > - Fix crash in auto_retire active retire callback due to > > > misalignment (Stephane) > > >
Re: [PULL] drm-intel-gt-next
This has these two patches applied, and it doesn't build. drm/i915: drop the __i915_active_call pointer packing drm/i915: Fix crash in auto_retire The latter patch shouldn't be necessary after the former, please fix that up and resend and please build test trees before I get them in future. Dave. On Fri, 28 May 2021 at 17:27, Joonas Lahtinen wrote: > > Quoting Joonas Lahtinen (2021-05-28 10:25:57) > > Hi Dave & Daniel, > > > > Here's drm-intel-gt-next pull request. > > > > Most notably it has the reworked DG1 uAPI (behind CONFIG_BROKEN) > > as requested. Important fix for Gitlab issues #3293 and #3450 and > > one another kernel crash. Adds missing workarounds for Gen11 and > > Gen12. Hiding of modparams for compiled-out features. Conversion > > to use trylock shrinking for BSW VT-d and BXT. > > > > Then there are the uAPI kerneldoc improvements as part of the DG1 > > uAPI rework. Usual amount smaller fixes, code refactoring and > > cleanups as prep for upcoming patches. > > And includes tag 'topic/intel-gen-to-ver-2021-04-19' (but that is > already merged to drm-next). > > Regards, Joonas > > > Regards, Joonas > > > > *** > > > > drm-intel-gt-next-2021-05-28: > > > > UAPI Changes: > > - Add reworked uAPI for DG1 behind CONFIG_BROKEN (Matt A, Abdiel) > > > > Driver Changes: > > > > - Fix for Gitlab issues #3293 and #3450: > > Avoid kernel crash on older L-shape memory machines > > > > - Hide modparams for compiled-out features (Tvrtko) > > - Add Wa_14010733141 (VDBox SFC reset) for Gen11+ (Aditya) > > - Fix crash in auto_retire active retire callback due to > > misalignment (Stephane) > > - Use trylock in shrinker for GGTT on BSW VT-d and BXT (Maarten) > > - Fix overlay active retire callback alignment (Tvrtko) > > - Eliminate need to align active retire callbacks (Matt A, Ville, > > Daniel) > > - Program FF_MODE2 tuning value for all Gen12 platforms (Caz) > > - Add Wa_14011060649 for TGL,RKL,DG1 and ADLS (Swathi) > > - Create stolen memory region from local memory on DG1 (CQ) > > - Place PD in LMEM on dGFX (Matt A) > > - Use WC when default state object is allocated in LMEM (Venkata) > > - Determine the coherent map type based on object location (Venkata) > > - Use lmem physical addresses for fb_mmap() on discrete (Mohammed) > > - Bypass aperture on fbdev when LMEM is available (Anusha) > > - Return error value when displayable BO not in LMEM for dGFX (Mohammed) > > - Do release kernel context if breadcrumb measure fails (Janusz) > > - Apply Wa_22010271021 for all Gen11 platforms (Caz) > > - Fix unlikely ref count race in arming the watchdog timer (Tvrtko) > > - Check actual RC6 enable status in PMU (Tvrtko) > > - Fix a double free in gen8_preallocate_top_level_pdp (Lv) > > - Remove erroneous i915_is_ggtt check for > > I915_GEM_OBJECT_UNBIND_VM_TRYLOCK (Maarten) > > > > - Convert uAPI headers to real kerneldoc (Matt A) > > - Clean up kerneldoc warnings headers (Matt A, Maarten) > > - Fail driver if LMEM training failed (Matt R) > > - Avoid div-by-zero on Gen2 (Ville) > > - Read C0DRB3/C1DRB3 as 16 bits again and add _BW suffix (Ville) > > - Remove reference to struct drm_device.pdev (Thomas) > > - Increase separation between GuC and execlists code (Chris, Matt B) > > > > - Use might_alloc() (Bernard) > > - Split DGFX_FEATURES from GEN12_FEATURES (Lucas) > > - Deduplicate Wa_22010271021 programming on (Jose) > > - Drop duplicate WaDisable4x2SubspanOptimization:hsw (Tvrtko) > > - Selftest improvements (Chris, Hsin-Yi, Tvrtko) > > - Shuffle around init_memory_region for stolen (Matt) > > - Typo fixes (wengjianfeng) > > > > The following changes since commit 425390c5dce6da76578389629d19517fcd79c959: > > > > drm/i915: split dgfx features from gen 12 (2021-04-14 13:05:06 +0300) > > > > are available in the Git repository at: > > > > git://anongit.freedesktop.org/drm/drm-intel > > tags/drm-intel-gt-next-2021-05-28 > > > > for you to fetch changes up to 5b26d57fdb499c2363f3d895ef008e73ec02eb9b: > > > > drm/i915: Add Wa_14010733141 (2021-05-27 11:05:09 -0700) > > > > > > UAPI Changes: > > - Add reworked uAPI for DG1 behind CONFIG_BROKEN (Matt A, Abdiel) > > > > Driver Changes: > > > > - Fix for Gitlab issues #3293 and #3450: > > Avoid kernel crash on older L-shape memory machines > > > > - Add Wa_14010733141 (VDBox SFC reset) for Gen11+ (Aditya) > > - Fix crash in auto_retire active retire callback due to > > misalignment (Stephane) > > - Fix overlay active retire callback alignment (Tvrtko) > > - Eliminate need to align active retire callbacks (Matt A, Ville, > > Daniel) > > - Program FF_MODE2 tuning value for all Gen12 platforms (Caz) > > - Add Wa_14011060649 for TGL,RKL,DG1 and ADLS (Swathi) > > - Create stolen memory region from local memory on DG1 (CQ) > > - Place PD in LMEM on dGFX (Matt A) > > - Use WC when default state object is allocated in LMEM (Venkata) > > - Determine the coherent map type based on object
Re: [PULL] drm-intel-gt-next
Quoting Joonas Lahtinen (2021-05-28 10:25:57) > Hi Dave & Daniel, > > Here's drm-intel-gt-next pull request. > > Most notably it has the reworked DG1 uAPI (behind CONFIG_BROKEN) > as requested. Important fix for Gitlab issues #3293 and #3450 and > one another kernel crash. Adds missing workarounds for Gen11 and > Gen12. Hiding of modparams for compiled-out features. Conversion > to use trylock shrinking for BSW VT-d and BXT. > > Then there are the uAPI kerneldoc improvements as part of the DG1 > uAPI rework. Usual amount smaller fixes, code refactoring and > cleanups as prep for upcoming patches. And includes tag 'topic/intel-gen-to-ver-2021-04-19' (but that is already merged to drm-next). Regards, Joonas > Regards, Joonas > > *** > > drm-intel-gt-next-2021-05-28: > > UAPI Changes: > - Add reworked uAPI for DG1 behind CONFIG_BROKEN (Matt A, Abdiel) > > Driver Changes: > > - Fix for Gitlab issues #3293 and #3450: > Avoid kernel crash on older L-shape memory machines > > - Hide modparams for compiled-out features (Tvrtko) > - Add Wa_14010733141 (VDBox SFC reset) for Gen11+ (Aditya) > - Fix crash in auto_retire active retire callback due to > misalignment (Stephane) > - Use trylock in shrinker for GGTT on BSW VT-d and BXT (Maarten) > - Fix overlay active retire callback alignment (Tvrtko) > - Eliminate need to align active retire callbacks (Matt A, Ville, > Daniel) > - Program FF_MODE2 tuning value for all Gen12 platforms (Caz) > - Add Wa_14011060649 for TGL,RKL,DG1 and ADLS (Swathi) > - Create stolen memory region from local memory on DG1 (CQ) > - Place PD in LMEM on dGFX (Matt A) > - Use WC when default state object is allocated in LMEM (Venkata) > - Determine the coherent map type based on object location (Venkata) > - Use lmem physical addresses for fb_mmap() on discrete (Mohammed) > - Bypass aperture on fbdev when LMEM is available (Anusha) > - Return error value when displayable BO not in LMEM for dGFX (Mohammed) > - Do release kernel context if breadcrumb measure fails (Janusz) > - Apply Wa_22010271021 for all Gen11 platforms (Caz) > - Fix unlikely ref count race in arming the watchdog timer (Tvrtko) > - Check actual RC6 enable status in PMU (Tvrtko) > - Fix a double free in gen8_preallocate_top_level_pdp (Lv) > - Remove erroneous i915_is_ggtt check for > I915_GEM_OBJECT_UNBIND_VM_TRYLOCK (Maarten) > > - Convert uAPI headers to real kerneldoc (Matt A) > - Clean up kerneldoc warnings headers (Matt A, Maarten) > - Fail driver if LMEM training failed (Matt R) > - Avoid div-by-zero on Gen2 (Ville) > - Read C0DRB3/C1DRB3 as 16 bits again and add _BW suffix (Ville) > - Remove reference to struct drm_device.pdev (Thomas) > - Increase separation between GuC and execlists code (Chris, Matt B) > > - Use might_alloc() (Bernard) > - Split DGFX_FEATURES from GEN12_FEATURES (Lucas) > - Deduplicate Wa_22010271021 programming on (Jose) > - Drop duplicate WaDisable4x2SubspanOptimization:hsw (Tvrtko) > - Selftest improvements (Chris, Hsin-Yi, Tvrtko) > - Shuffle around init_memory_region for stolen (Matt) > - Typo fixes (wengjianfeng) > > The following changes since commit 425390c5dce6da76578389629d19517fcd79c959: > > drm/i915: split dgfx features from gen 12 (2021-04-14 13:05:06 +0300) > > are available in the Git repository at: > > git://anongit.freedesktop.org/drm/drm-intel > tags/drm-intel-gt-next-2021-05-28 > > for you to fetch changes up to 5b26d57fdb499c2363f3d895ef008e73ec02eb9b: > > drm/i915: Add Wa_14010733141 (2021-05-27 11:05:09 -0700) > > > UAPI Changes: > - Add reworked uAPI for DG1 behind CONFIG_BROKEN (Matt A, Abdiel) > > Driver Changes: > > - Fix for Gitlab issues #3293 and #3450: > Avoid kernel crash on older L-shape memory machines > > - Add Wa_14010733141 (VDBox SFC reset) for Gen11+ (Aditya) > - Fix crash in auto_retire active retire callback due to > misalignment (Stephane) > - Fix overlay active retire callback alignment (Tvrtko) > - Eliminate need to align active retire callbacks (Matt A, Ville, > Daniel) > - Program FF_MODE2 tuning value for all Gen12 platforms (Caz) > - Add Wa_14011060649 for TGL,RKL,DG1 and ADLS (Swathi) > - Create stolen memory region from local memory on DG1 (CQ) > - Place PD in LMEM on dGFX (Matt A) > - Use WC when default state object is allocated in LMEM (Venkata) > - Determine the coherent map type based on object location (Venkata) > - Use lmem physical addresses for fb_mmap() on discrete (Mohammed) > - Bypass aperture on fbdev when LMEM is available (Anusha) > - Return error value when displayable BO not in LMEM for dGFX (Mohammed) > - Do release kernel context if breadcrumb measure fails (Janusz) > - Hide modparams for compiled-out features (Tvrtko) > - Apply Wa_22010271021 for all Gen11 platforms (Caz) > - Fix unlikely ref count race in arming the watchdog timer (Tvrtko) > - Check actual RC6 enable status in PMU (Tvrtko) > - Fix a double free in
