Re: [RFC PATCH 3/3] drm/file: drop DRM_MINOR_CONTROL
Hi
Am 14.07.23 um 16:37 schrieb Simon Ser:
On Friday, July 14th, 2023 at 16:28, Thomas Zimmermann
wrote:
Hi Simon
Am 14.07.23 um 12:46 schrieb Simon Ser:
This entry should never be used by the kernel. Record the historical
context in a comment.
Signed-off-by: Simon Ser
Cc: Christian König
Cc: James Zhu
Cc: Marek Olšák
Cc: Daniel Vetter
---
include/drm/drm_file.h | 4 +++-
1 file changed, 3 insertions(+), 1 deletion(-)
diff --git a/include/drm/drm_file.h b/include/drm/drm_file.h
index 010239392adf..a23cc2f6163f 100644
--- a/include/drm/drm_file.h
+++ b/include/drm/drm_file.h
@@ -53,12 +53,14 @@ struct file;
/* Note that the values of this enum are ABI (it determines
* /dev/dri/renderD* numbers).
*
+ * There used to be a DRM_MINOR_CONTROL = 1 entry, but such nodes were never
+ * exposed. Still, some user-space has logic to handle them.
+ *
* Setting DRM_MINOR_ACCEL to 32 gives enough space for more drm minors to
* be implemented before we hit any future
*/
enum drm_minor_type {
DRM_MINOR_PRIMARY = 0,
- DRM_MINOR_CONTROL = 1,
Maybe rather leave this line in and comment it with "// obsolete".
Otherwise someone might accidentally use 1 for something.
Yeah... That's why I added the comment. But maybe better to leave the entry
indeed, even if we risk someone accidentally using it.
You could still out-comment the line as a whole. Simply having it there
will warn potential users.
Best regards
Thomas
In any case
Reviewed-by: Thomas Zimmermann
for the whole series.
Thanks for the review!
--
Thomas Zimmermann
Graphics Driver Developer
SUSE Software Solutions Germany GmbH
Frankenstrasse 146, 90461 Nuernberg, Germany
GF: Ivo Totev, Andrew Myers, Andrew McDonald, Boudien Moerman
HRB 36809 (AG Nuernberg)
OpenPGP_signature
Description: OpenPGP digital signature
Re: [RFC PATCH 3/3] drm/file: drop DRM_MINOR_CONTROL
On Friday, July 14th, 2023 at 16:28, Thomas Zimmermann
wrote:
> Hi Simon
>
> Am 14.07.23 um 12:46 schrieb Simon Ser:
> > This entry should never be used by the kernel. Record the historical
> > context in a comment.
> >
> > Signed-off-by: Simon Ser
> > Cc: Christian König
> > Cc: James Zhu
> > Cc: Marek Olšák
> > Cc: Daniel Vetter
> > ---
> > include/drm/drm_file.h | 4 +++-
> > 1 file changed, 3 insertions(+), 1 deletion(-)
> >
> > diff --git a/include/drm/drm_file.h b/include/drm/drm_file.h
> > index 010239392adf..a23cc2f6163f 100644
> > --- a/include/drm/drm_file.h
> > +++ b/include/drm/drm_file.h
> > @@ -53,12 +53,14 @@ struct file;
> > /* Note that the values of this enum are ABI (it determines
> >* /dev/dri/renderD* numbers).
> >*
> > + * There used to be a DRM_MINOR_CONTROL = 1 entry, but such nodes were
> > never
> > + * exposed. Still, some user-space has logic to handle them.
> > + *
> >* Setting DRM_MINOR_ACCEL to 32 gives enough space for more drm minors to
> >* be implemented before we hit any future
> >*/
> > enum drm_minor_type {
> > DRM_MINOR_PRIMARY = 0,
> > - DRM_MINOR_CONTROL = 1,
>
> Maybe rather leave this line in and comment it with "// obsolete".
> Otherwise someone might accidentally use 1 for something.
Yeah... That's why I added the comment. But maybe better to leave the entry
indeed, even if we risk someone accidentally using it.
> In any case
>
> Reviewed-by: Thomas Zimmermann
>
> for the whole series.
Thanks for the review!
Re: [RFC PATCH 3/3] drm/file: drop DRM_MINOR_CONTROL
Hi Simon
Am 14.07.23 um 12:46 schrieb Simon Ser:
This entry should never be used by the kernel. Record the historical
context in a comment.
Signed-off-by: Simon Ser
Cc: Christian König
Cc: James Zhu
Cc: Marek Olšák
Cc: Daniel Vetter
---
include/drm/drm_file.h | 4 +++-
1 file changed, 3 insertions(+), 1 deletion(-)
diff --git a/include/drm/drm_file.h b/include/drm/drm_file.h
index 010239392adf..a23cc2f6163f 100644
--- a/include/drm/drm_file.h
+++ b/include/drm/drm_file.h
@@ -53,12 +53,14 @@ struct file;
/* Note that the values of this enum are ABI (it determines
* /dev/dri/renderD* numbers).
*
+ * There used to be a DRM_MINOR_CONTROL = 1 entry, but such nodes were never
+ * exposed. Still, some user-space has logic to handle them.
+ *
* Setting DRM_MINOR_ACCEL to 32 gives enough space for more drm minors to
* be implemented before we hit any future
*/
enum drm_minor_type {
DRM_MINOR_PRIMARY = 0,
- DRM_MINOR_CONTROL = 1,
Maybe rather leave this line in and comment it with "// obsolete".
Otherwise someone might accidentally use 1 for something.
In any case
Reviewed-by: Thomas Zimmermann
for the whole series.
Best regards
Thomas
DRM_MINOR_RENDER = 2,
DRM_MINOR_ACCEL = 32,
};
--
Thomas Zimmermann
Graphics Driver Developer
SUSE Software Solutions Germany GmbH
Frankenstrasse 146, 90461 Nuernberg, Germany
GF: Ivo Totev, Andrew Myers, Andrew McDonald, Boudien Moerman
HRB 36809 (AG Nuernberg)
OpenPGP_signature
Description: OpenPGP digital signature
