Re: Need a pair decrement for fence's refcount if ttm_bo_add_move_fence failed?
Am 09.04.19 um 10:21 schrieb 易林:
>
>
>
>> Am 07.04.19 um 13:44 schrieb 易林:
>>> Hi, all:
>>> when analyzing v5.1 source code, I notice that in
>>> ttm_bo_add_move_fence,
>>> when reservation_object_reserve_shared failed and return ENOMEM,
>>> the fence's refcount increased without a pair decrement even after return
>>> to ttm_bo_add_move_fence's caller ttm_bo_mem_force_space:
>>>
>>> static int ttm_bo_add_move_fence(struct ttm_buffer_object *bo,
>>> struct ttm_mem_type_manager *man,
>>> struct ttm_mem_reg *mem)
>>> {
>>> ..
>>> fence = dma_fence_get(man->move);
>>> spin_unlock(>move_lock);
>>>
>>> if (fence) {
>>> reservation_object_add_shared_fence(bo->resv, fence);
>>>
>>> ret = reservation_object_reserve_shared(bo->resv, 1);
>>> if (unlikely(ret))
>>> return ret;
>>>
>>> dma_fence_put(bo->moving);
>>> bo->moving = fence;
>>> }
>>>
>>> return 0;
>>> }
>>>
>>> can this lead to the imbalance of the fence's refcount? though the ENOMEN
>>> almost won't be trigger.
>> Yeah, the fence is leaked in the error path. Feel free to provide a
>> patch to fix this.
>>
>> Otherwise I will provide one in the next merge window.
>>
>> Thanks,
>> Christian.
>>
>>> Best Regards
>>>
>>> Lin Yi
> when I git clone your maintained subsystem from
> 'git://people.freedesktop.org/~agd5f/linux' provided on Maintainer list, why
> all the commits is below 2011?
>
> so where can I get the newest subsystem version?
That URL looks correct to me. Our development branch is
amd-staging-drm-next. No idea why you only see old commits.
See here for example:
https://cgit.freedesktop.org/~agd5f/linux/log/?h=amd-staging-drm-next
Alex updates that one from an internal server every few days.
Regards,
Christian.
>
> Thanks,
> Lin Yi.
___
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel
Re: Re: Need a pair decrement for fence's refcount if ttm_bo_add_move_fence failed?
> Am 07.04.19 um 13:44 schrieb 易林:
> > Hi, all:
> > when analyzing v5.1 source code, I notice that in
> > ttm_bo_add_move_fence,
> > when reservation_object_reserve_shared failed and return ENOMEM,
> > the fence's refcount increased without a pair decrement even after return
> > to ttm_bo_add_move_fence's caller ttm_bo_mem_force_space:
> >
> > static int ttm_bo_add_move_fence(struct ttm_buffer_object *bo,
> > struct ttm_mem_type_manager *man,
> > struct ttm_mem_reg *mem)
> > {
> > ..
> > fence = dma_fence_get(man->move);
> > spin_unlock(>move_lock);
> >
> > if (fence) {
> > reservation_object_add_shared_fence(bo->resv, fence);
> >
> > ret = reservation_object_reserve_shared(bo->resv, 1);
> > if (unlikely(ret))
> > return ret;
> >
> > dma_fence_put(bo->moving);
> > bo->moving = fence;
> > }
> >
> > return 0;
> > }
> >
> > can this lead to the imbalance of the fence's refcount? though the ENOMEN
> > almost won't be trigger.
>
> Yeah, the fence is leaked in the error path. Feel free to provide a
> patch to fix this.
>
> Otherwise I will provide one in the next merge window.
>
> Thanks,
> Christian.
>
> >
> > Best Regards
> >
> > Lin Yi
>
when I git clone your maintained subsystem from
'git://people.freedesktop.org/~agd5f/linux' provided on Maintainer list, why
all the commits is below 2011?
so where can I get the newest subsystem version?
Thanks,
Lin Yi.
___
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel
Re: Need a pair decrement for fence's refcount if ttm_bo_add_move_fence failed?
Am 07.04.19 um 13:44 schrieb 易林:
> Hi, all:
> when analyzing v5.1 source code, I notice that in ttm_bo_add_move_fence,
> when reservation_object_reserve_shared failed and return ENOMEM,
> the fence's refcount increased without a pair decrement even after return to
> ttm_bo_add_move_fence's caller ttm_bo_mem_force_space:
>
> static int ttm_bo_add_move_fence(struct ttm_buffer_object *bo,
>struct ttm_mem_type_manager *man,
>struct ttm_mem_reg *mem)
> {
> ..
> fence = dma_fence_get(man->move);
> spin_unlock(>move_lock);
>
> if (fence) {
> reservation_object_add_shared_fence(bo->resv, fence);
>
> ret = reservation_object_reserve_shared(bo->resv, 1);
> if (unlikely(ret))
> return ret;
>
> dma_fence_put(bo->moving);
> bo->moving = fence;
> }
>
> return 0;
> }
>
> can this lead to the imbalance of the fence's refcount? though the ENOMEN
> almost won't be trigger.
Yeah, the fence is leaked in the error path. Feel free to provide a
patch to fix this.
Otherwise I will provide one in the next merge window.
Thanks,
Christian.
>
> Best Regards
>
> Lin Yi
___
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel
