Re: Fix for handling return value from class_create and class_device_create in drivers/char/drm/drm_sys.c
On 5/17/06, Chris Lesiak <[EMAIL PROTECTED]> wrote: This patch fixes the mishandling of the return values of class_create and class_device_create in drivers/char/drm/drm_sys.c. These two functions do not return NULL on error. --- linux-2.6/drivers/char/drm/drm_sysfs.c.orig +++ linux-2.6/drivers/char/drm/drm_sysfs.c @@ -45,7 +45,7 @@ struct class *drm_sysfs_create(struct mo struct class *class; class = class_create(owner, name); - if (!class) + if (IS_ERR(class)) return class; Shouldnt you also change this line to "return NULL;" or "return 0;"? class_create_file(class, &class_attr_version); @@ -103,8 +103,8 @@ struct class_device *drm_sysfs_device_ad MKDEV(DRM_MAJOR, head->minor), &(head->dev->pdev)->dev, "card%d", head->minor); - if (!class_dev) - return NULL; + if (IS_ERR(class_dev)) + return class_dev; Same here class_set_devdata(class_dev, head); --- All the advantages of Linux Managed Hosting--Without the Cost and Risk! Fully trained technicians. The highest number of Red Hat certifications in the hosting industry. Fanatical Support. Click to learn more http://sel.as-us.falkag.net/sel?cmd=lnk&kid7521&bid$8729&dat1642 -- ___ Dri-devel mailing list Dri-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/dri-devel
Re: Quake4 benchmarks
http://www.nuclearelephant.com/papers/s3tc.html http://homepage.hispeed.ch/rscheidegger/dri_experimental/s3tc_index.html And I has problems with one ATI mobile r300 and Xorg 6.8.2 from Fedora 4, and now with Xorg 7.0 it works quite right, and I try to see what is the trick and appears to me not just disabling dri but disable ACCEL render! . On Tue, 2006-05-23 at 19:18 -0400, Adam K Kirchhoff wrote: > FYI, > > I downloaded the hwspirit timedemo for quake4 yesterday and decided > to compare the framerate between the fglrx, r200, and xig drivers with > my Radeon 9000: > > 9000 - xig - 14.7 > 9000 - fgl - 11.3 > 9000 - xorg - 16.2 > > Today I decided to give it a shot with my 9600. The fglrx drivers > gave me 16.8 FPS, and the r300 drivers gave me this: > > http://68.44.156.246/quake4-screenshot.png > > As you can see, everything is quite shiny (but not quite as washed out > as the screenshot shows... I had to brighten it a little to make it > visible). This is with both page flipping and color tiling enabled > (though I tried without page flipping and got the same results). And I > have the libtxc_dxtn library compiled and installed. If I remove that > library, quake4 completely refuses to start: > > ..using GL_ARB_multitexture > ...using GL_ARB_texture_env_combine > ...using GL_ARB_texture_cube_map > ...using GL_ARB_texture_env_dot3 > ...using GL_ARB_texture_env_add > X..GL_ARB_texture_non_power_of_two not found > ...using GL_NV_blend_square > ...using GL_ARB_texture_compression > X..GL_EXT_texture_compression_s3tc not found > signal caught: Segmentation fault > si_code 1 > Trying to exit gracefully.. > > Any ideas? > > > --- > All the advantages of Linux Managed Hosting--Without the Cost and Risk! > Fully trained technicians. The highest number of Red Hat certifications in > the hosting industry. Fanatical Support. Click to learn more > http://sel.as-us.falkag.net/sel?cmd=lnk&kid=107521&bid=248729&dat=121642 > -- > ___ > Dri-devel mailing list > Dri-devel@lists.sourceforge.net > https://lists.sourceforge.net/lists/listinfo/dri-devel -- Sérgio M. B. smime.p7s Description: S/MIME cryptographic signature
[Bug 6242] [mach64] Use private DMA buffers (only)
Please do not reply to this email: if you want to comment on the bug, go to the URL shown below and enter yourcomments there. https://bugs.freedesktop.org/show_bug.cgi?id=6242 --- Additional Comments From [EMAIL PROTECTED] 2006-05-25 07:16 --- I'd like to review your patches. Someone needs to kick my b*tt so I get a card and try this stuff. I also got a private email from someone interested in mach64. I suggested to try your patches. Give me a few weekends and don't forget to remind me every once in a while. ;-) -- Configure bugmail: https://bugs.freedesktop.org/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug, or are watching the assignee. --- All the advantages of Linux Managed Hosting--Without the Cost and Risk! Fully trained technicians. The highest number of Red Hat certifications in the hosting industry. Fanatical Support. Click to learn more http://sel.as-us.falkag.net/sel?cmd=lnk&kid=107521&bid=248729&dat=121642 -- ___ Dri-devel mailing list Dri-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/dri-devel
