Re: R200 minor cleanups
Oliver McFadden wrote: My thoughts are, we should unify the really common stuff... but I don't think it's possible to unify r200_tex.c and r300_tex.c. The hardware is different, and the file would end up with an #ifdef on every 3rd line; it doesn't make sense here. Just for really common code it does. I don't know what is going to happen with TTM. Maybe we should hack the r300 driver for TTM (and someone else can do R200 and R128 (radeon) if they like) or maybe we should start a new DRI driver completely from scratch, with TTM and good state handling in mind from the beginning. Then we just take the code we need from R300 and merge it into the new DRI driver. Regarding indenting, I indented the driver with the Linux kernel style because that is what matched most (but not all) of the code. The indenting was a little inconsistent. If you like, fell free indent the R200 or R128 (radeon) code, too. I guess for TTM we'll have to wait and see what happens... Just letting you know I've been doing a bit of thinking about the Mesa driver model lately, and I think there's room to pull a lot of stuff up and out of the drivers. Regarding textures - almost all of the texture handling for *all* of the drivers could effectively be handled by the miptree mechanism in the i915tex driver - basically everything could be made device-independent, but with the driver specifying how to lay mipmaps out within rectangular regions that are then managed in a device-independent way. The driver also provides some utilities like CopyBlit, etc, and helpers for choosing formats. I think there are a bunch of similar pieces of functionality that have built up in the drivers, simply because we aren't providing the right level of support in core mesa. Keith - This SF.net email is sponsored by DB2 Express Download DB2 Express C - the FREE version of DB2 express and take control of your XML. No limits. Just data. Click to get it now. http://sourceforge.net/powerbar/db2/ -- ___ Dri-devel mailing list Dri-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/dri-devel
Re: R300 cleanup questions
Keith Whitwell wrote: Oliver McFadden wrote: I'd like some input on the VBO stuff in r300. In r300_context.h we have the following. /* KW: Disable this code. Driver should hook into vbo module * directly, see i965 driver for example. */ /* #define RADEON_VTXFMT_A */ #ifdef RADEON_VTXFMT_A #define HW_VBOS #endif So the VTXFMT (radeon_vtxfmt_a.c) code is disabled anyway. This also disables hardware VBOs. I guess this has been done since the new VBO branch was merged. So, the question is, should this dead code be removed? I think all drivers are (or should be) moving to the new VBO code anyway. I've already made a patch for this, but I'm not committing until I get the okay from a few people. Yes, the old code should go. I guess there might be some starting points in there for beginning the vbo work, that's about the only reason to keep it. Hmm, I just took a look through the r300 code, and was surprised to see myself listed as the author of several of the files?? I'm pretty sure I haven't done any work on that driver... I think I'd prefer to have a line that says based on xxx by Keith Whitwell, or even just remove my name from the r300_* files and give credit instead to the people who've really been working on that code... Keith - This SF.net email is sponsored by DB2 Express Download DB2 Express C - the FREE version of DB2 express and take control of your XML. No limits. Just data. Click to get it now. http://sourceforge.net/powerbar/db2/ -- ___ Dri-devel mailing list Dri-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/dri-devel
[Bug 3272] Resume from suspend to disk causes crash (suspend2)
http://bugs.freedesktop.org/show_bug.cgi?id=3272 [EMAIL PROTECTED] changed: What|Removed |Added CC||[EMAIL PROTECTED] --- Comment #3 from [EMAIL PROTECTED] 2007-05-15 14:32 PST --- I'm having the same issue on my laptop ; but I'm using debian/unstable with normal packages, and it's with an ati card. lspci -vvv says : 01:00.0 VGA compatible controller: ATI Technologies Inc M9+ 5C61 [Radeon Mobility 9200 (AGP)] (rev 01) (prog-if 00 [VGA]) Subsystem: ASUSTeK Computer Inc. Unknown device 1811 Control: I/O+ Mem+ BusMaster+ SpecCycle- MemWINV- VGASnoop- ParErr- Stepping- SERR+ FastB2B- Status: Cap+ 66MHz+ UDF- FastB2B+ ParErr- DEVSEL=medium TAbort- TAbort- MAbort- SERR- PERR- Latency: 64 (2000ns min), Cache Line Size: 256 bytes Interrupt: pin A routed to IRQ 10 Region 0: Memory at c000 (32-bit, prefetchable) [size=128M] Region 1: I/O ports at d000 [size=256] Region 2: Memory at feaf (32-bit, non-prefetchable) [size=64K] Expansion ROM at feac [disabled] [size=128K] Capabilities: access denied what can I do to solve the issue ? -- Configure bugmail: http://bugs.freedesktop.org/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug, or are watching the assignee. - This SF.net email is sponsored by DB2 Express Download DB2 Express C - the FREE version of DB2 express and take control of your XML. No limits. Just data. Click to get it now. http://sourceforge.net/powerbar/db2/ -- ___ Dri-devel mailing list Dri-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/dri-devel
