[PATCH] drm/kms: Force full modeset if depth/bpp changes.
From: Michel Dänzer daen...@vmware.com Signed-off-by: Michel Dänzer daen...@vmware.com --- drivers/gpu/drm/drm_crtc_helper.c |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/drivers/gpu/drm/drm_crtc_helper.c b/drivers/gpu/drm/drm_crtc_helper.c index ff447f1..eaed0f5 100644 --- a/drivers/gpu/drm/drm_crtc_helper.c +++ b/drivers/gpu/drm/drm_crtc_helper.c @@ -762,7 +762,7 @@ int drm_crtc_helper_set_config(struct drm_mode_set *set) } else if ((set-fb-bits_per_pixel != set-crtc-fb-bits_per_pixel) || set-fb-depth != set-crtc-fb-depth) - fb_changed = true; + mode_changed = true; else fb_changed = true; } -- 1.6.3.3 -- Come build with us! The BlackBerryreg; Developer Conference in SF, CA is the only developer event you need to attend this year. Jumpstart your developing skills, take BlackBerry mobile applications to market and stay ahead of the curve. Join us from November 9#45;12, 2009. Register now#33; http://p.sf.net/sfu/devconf -- ___ Dri-devel mailing list Dri-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/dri-devel
Re: [PATCH] drm/kms: Force full modeset if depth/bpp changes.
2009/9/16 Michel Dänzer mic...@daenzer.net: From: Michel Dänzer daen...@vmware.com This one confuses me, the bit depth and stuff should all be setup in the set base function, I wonder is there a bug somewhere that we aren't dealing with. Dave. Signed-off-by: Michel Dänzer daen...@vmware.com --- drivers/gpu/drm/drm_crtc_helper.c | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/drivers/gpu/drm/drm_crtc_helper.c b/drivers/gpu/drm/drm_crtc_helper.c index ff447f1..eaed0f5 100644 --- a/drivers/gpu/drm/drm_crtc_helper.c +++ b/drivers/gpu/drm/drm_crtc_helper.c @@ -762,7 +762,7 @@ int drm_crtc_helper_set_config(struct drm_mode_set *set) } else if ((set-fb-bits_per_pixel != set-crtc-fb-bits_per_pixel) || set-fb-depth != set-crtc-fb-depth) - fb_changed = true; + mode_changed = true; else fb_changed = true; } -- 1.6.3.3 -- Come build with us! The BlackBerryreg; Developer Conference in SF, CA is the only developer event you need to attend this year. Jumpstart your developing skills, take BlackBerry mobile applications to market and stay ahead of the curve. Join us from November 9#45;12, 2009. Register now#33; http://p.sf.net/sfu/devconf -- ___ Dri-devel mailing list Dri-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/dri-devel
Re: [PATCH] drm/kms: Force full modeset if depth/bpp changes.
On Wed, 2009-09-16 at 08:02 +1000, Dave Airlie wrote: 2009/9/16 Michel Dänzer mic...@daenzer.net: From: Michel Dänzer daen...@vmware.com This one confuses me, the bit depth and stuff should all be setup in the set base function, I wonder is there a bug somewhere that we aren't dealing with. There's definitely a bug somewhere. Without this, with fbcon at depth 16 the X server visibly stays in 16 bpp mode with 32 bpp data - funky effect. -- Earthling Michel Dänzer |http://www.vmware.com Libre software enthusiast | Debian, X and DRI developer -- Come build with us! The BlackBerryreg; Developer Conference in SF, CA is the only developer event you need to attend this year. Jumpstart your developing skills, take BlackBerry mobile applications to market and stay ahead of the curve. Join us from November 9#45;12, 2009. Register now#33; http://p.sf.net/sfu/devconf -- ___ Dri-devel mailing list Dri-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/dri-devel
Re: [PATCH] drm/kms: Force full modeset if depth/bpp changes.
On Wed, 16 Sep 2009 00:12:21 +0200 Michel Dänzer mic...@daenzer.net wrote: On Wed, 2009-09-16 at 08:02 +1000, Dave Airlie wrote: 2009/9/16 Michel Dänzer mic...@daenzer.net: From: Michel Dänzer daen...@vmware.com This one confuses me, the bit depth and stuff should all be setup in the set base function, I wonder is there a bug somewhere that we aren't dealing with. There's definitely a bug somewhere. Without this, with fbcon at depth 16 the X server visibly stays in 16 bpp mode with 32 bpp data - funky effect. We had a similar bug on the intel side; turned out our pipe base function wasn't masking out the depth bits, just or'ing them in, so the correct setting wouldn't take effect if the depth changed in some cases. Not that I've looked at the radeon bits... -- Jesse Barnes, Intel Open Source Technology Center -- Come build with us! The BlackBerryreg; Developer Conference in SF, CA is the only developer event you need to attend this year. Jumpstart your developing skills, take BlackBerry mobile applications to market and stay ahead of the curve. Join us from November 9#45;12, 2009. Register now#33; http://p.sf.net/sfu/devconf -- ___ Dri-devel mailing list Dri-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/dri-devel
