Re: [PATCH] drm: edid revision 0 is valid
Kyle McMartin wrote:
- if (edid-revision = 0 || edid-revision 3) {
+ if (edid-revision 3) {
DRM_ERROR(EDID has minor version %d, which is not between
0-3\n, edid-revision);
goto bad;
Ahem. EDID version 1.4 exists too, in fact it's the current version.
EDID 1.5+ doesn't exist, but it should be backward compatible when it does.
I'm doing a lot of work on another EDID parser, including full DMT and
CEA-861 mode tables, monitor hotplug, all quirks from Xorg and the
kernel, EDID 1.4 support w/ CVT calculation, etc. right now for an
embedded Linux video project. Would there be any interest
incorporating parts of that work?
-- Jamie
--
Apps built with the Adobe(R) Flex(R) framework and Flex Builder(TM) are
powering Web 2.0 with engaging, cross-platform capabilities. Quickly and
easily build your RIAs with Flex Builder, the Eclipse(TM)based development
software that enables intelligent coding and step-through debugging.
Download the free 60 day trial. http://p.sf.net/sfu/www-adobe-com
--
___
Dri-devel mailing list
Dri-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/dri-devel
Re: [PATCH] drm: edid revision 0 is valid
On Wed, 2009-03-11 at 02:56 +, Jamie Lokier wrote:
Kyle McMartin wrote:
- if (edid-revision = 0 || edid-revision 3) {
+ if (edid-revision 3) {
DRM_ERROR(EDID has minor version %d, which is not between
0-3\n, edid-revision);
goto bad;
Ahem. EDID version 1.4 exists too, in fact it's the current version.
EDID 1.5+ doesn't exist, but it should be backward compatible when it does.
I'm doing a lot of work on another EDID parser, including full DMT and
CEA-861 mode tables, monitor hotplug, all quirks from Xorg and the
kernel, EDID 1.4 support w/ CVT calculation, etc. right now for an
embedded Linux video project. Would there be any interest
incorporating parts of that work?
There's work going on for CEA-861 and syncing KMS against UMS. But
certainly we love fixes when we don't even have to write them ourselves.
--
Eric Anholt
e...@anholt.net eric.anh...@intel.com
signature.asc
Description: This is a digitally signed message part
--
Apps built with the Adobe(R) Flex(R) framework and Flex Builder(TM) are
powering Web 2.0 with engaging, cross-platform capabilities. Quickly and
easily build your RIAs with Flex Builder, the Eclipse(TM)based development
software that enables intelligent coding and step-through debugging.
Download the free 60 day trial. http://p.sf.net/sfu/www-adobe-com--
___
Dri-devel mailing list
Dri-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/dri-devel
Re: [PATCH] drm: edid revision 0 is valid
On Tuesday, February 24, 2009 5:31:53 pm Kyle McMartin wrote: From: Kyle McMartin k...@redhat.com edid-revision == 0 should be valid (at least, so the error message indicates. :) and wikipedia seems to indicate that EDID 1.0 existed. We can dump the entire check, since edid-revision is a u8, so it can't ever be less than 0. Marko reports in RH bz#476735 that his monitor claims to be EDID 1.0, and therefore hits the check and is stuck at 800x600 because of it. Reported-by: Marko Ristola marko.rist...@kolumbus.fi Signed-off-by: Kyle McMartin k...@redhat.com Heh, yeah this makes the code correct *and* match the message. Thanks. Acked-by: Jesse Barnes jbar...@virtuousgek.org -- Jesse Barnes, Intel Open Source Technology Center -- Open Source Business Conference (OSBC), March 24-25, 2009, San Francisco, CA -OSBC tackles the biggest issue in open source: Open Sourcing the Enterprise -Strategies to boost innovation and cut costs with open source participation -Receive a $600 discount off the registration fee with the source code: SFAD http://p.sf.net/sfu/XcvMzF8H -- ___ Dri-devel mailing list Dri-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/dri-devel
[PATCH] drm: edid revision 0 is valid
From: Kyle McMartin k...@redhat.com
edid-revision == 0 should be valid (at least, so the error message
indicates. :) and wikipedia seems to indicate that EDID 1.0 existed.
We can dump the entire check, since edid-revision is a u8, so
it can't ever be less than 0.
Marko reports in RH bz#476735 that his monitor claims to be
EDID 1.0, and therefore hits the check and is stuck at 800x600 because
of it.
Reported-by: Marko Ristola marko.rist...@kolumbus.fi
Signed-off-by: Kyle McMartin k...@redhat.com
---
diff --git a/drivers/gpu/drm/drm_edid.c b/drivers/gpu/drm/drm_edid.c
index 5a4d324..ec14dd8 100644
--- a/drivers/gpu/drm/drm_edid.c
+++ b/drivers/gpu/drm/drm_edid.c
@@ -125,7 +125,7 @@ static bool edid_is_valid(struct edid *edid)
DRM_ERROR(EDID has major version %d, instead of 1\n,
edid-version);
goto bad;
}
- if (edid-revision = 0 || edid-revision 3) {
+ if (edid-revision 3) {
DRM_ERROR(EDID has minor version %d, which is not between
0-3\n, edid-revision);
goto bad;
}
--
Open Source Business Conference (OSBC), March 24-25, 2009, San Francisco, CA
-OSBC tackles the biggest issue in open source: Open Sourcing the Enterprise
-Strategies to boost innovation and cut costs with open source participation
-Receive a $600 discount off the registration fee with the source code: SFAD
http://p.sf.net/sfu/XcvMzF8H
--
___
Dri-devel mailing list
Dri-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/dri-devel
