Re: [PATCH] staging: qlge: unify multi-line string
On Sat, 2020-02-22 at 00:20 +0530, Kaaira Gupta wrote:
> Fix checkpatch.pl warning of 'quoted string split across lines' in
> qlge_dbg.c by merging the strings in one line. Fixing this warning is
> necessary to ease grep-ing the source for printk.
[]
> diff --git a/drivers/staging/qlge/qlge_dbg.c b/drivers/staging/qlge/qlge_dbg.c
[]
> @@ -1333,16 +1333,16 @@ void ql_mpi_core_to_log(struct work_struct *work)
>"Core is dumping to log file!\n");
>
> for (i = 0; i < count; i += 8) {
> - pr_err("%.08x: %.08x %.08x %.08x %.08x %.08x "
> - "%.08x %.08x %.08x\n", i,
> - tmp[i + 0],
> - tmp[i + 1],
> - tmp[i + 2],
> - tmp[i + 3],
> - tmp[i + 4],
> - tmp[i + 5],
> - tmp[i + 6],
> - tmp[i + 7]);
> + pr_err("%.08x: %.08x %.08x %.08x %.08x %.08x %.08x %.08x
> %.08x\n",
> +i,
> +tmp[i + 0],
> +tmp[i + 1],
> +tmp[i + 2],
> +tmp[i + 3],
> +tmp[i + 4],
> +tmp[i + 5],
> +tmp[i + 6],
> +tmp[i + 7]);
This should probably instead use
print_hex_dump(KERN_DEBUG, "", DUMP_PREFIX_OFFSET, 32, 4,
qdev->mpi_coredump, sizeof(*qdev->mpi_coredump), false);
So that the debug and the dump are emitted at the
same KERN_ and the code is simpler.
> msleep(5);
And the msleep seems unnecessary.
> }
> }
Perhaps:
---
drivers/staging/qlge/qlge_dbg.c | 19 ++-
1 file changed, 2 insertions(+), 17 deletions(-)
diff --git a/drivers/staging/qlge/qlge_dbg.c b/drivers/staging/qlge/qlge_dbg.c
index 8cf3961..a4cd91 100644
--- a/drivers/staging/qlge/qlge_dbg.c
+++ b/drivers/staging/qlge/qlge_dbg.c
@@ -1324,27 +1324,12 @@ void ql_mpi_core_to_log(struct work_struct *work)
{
struct ql_adapter *qdev =
container_of(work, struct ql_adapter, mpi_core_to_log.work);
- u32 *tmp, count;
- int i;
- count = sizeof(struct ql_mpi_coredump) / sizeof(u32);
- tmp = (u32 *)qdev->mpi_coredump;
netif_printk(qdev, drv, KERN_DEBUG, qdev->ndev,
"Core is dumping to log file!\n");
- for (i = 0; i < count; i += 8) {
- pr_err("%.08x: %.08x %.08x %.08x %.08x %.08x "
- "%.08x %.08x %.08x\n", i,
- tmp[i + 0],
- tmp[i + 1],
- tmp[i + 2],
- tmp[i + 3],
- tmp[i + 4],
- tmp[i + 5],
- tmp[i + 6],
- tmp[i + 7]);
- msleep(5);
- }
+ print_hex_dump(KERN_DEBUG, "", DUMP_PREFIX_OFFSET, 32, 4,
+ qdev->mpi_coredump, sizeof(*qdev->mpi_coredump), false);
}
#ifdef QL_REG_DUMP
___
devel mailing list
de...@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
Re: [PATCH] staging: qlge: add braces on all arms of if-else
On 2/21/20 14:29, Kaaira Gupta wrote:
> fix all checkpatch.pl warnings of 'braces {} should be used on all arms
> of this statement' in the file qlge_ethtool.c by adding the braces.
>
> Signed-off-by: Kaaira Gupta
Acked-by: Gustavo A. R. Silva
Thanks for you patch.
--
Gustavo
> ---
> drivers/staging/qlge/qlge_ethtool.c | 18 --
> 1 file changed, 12 insertions(+), 6 deletions(-)
>
> diff --git a/drivers/staging/qlge/qlge_ethtool.c
> b/drivers/staging/qlge/qlge_ethtool.c
> index 790997aff995..592ca7edfc44 100644
> --- a/drivers/staging/qlge/qlge_ethtool.c
> +++ b/drivers/staging/qlge/qlge_ethtool.c
> @@ -259,8 +259,9 @@ static void ql_update_stats(struct ql_adapter *qdev)
> "Error reading status register 0x%.04x.\n",
> i);
> goto end;
> - } else
> + } else {
> *iter = data;
> + }
> iter++;
> }
>
> @@ -273,8 +274,9 @@ static void ql_update_stats(struct ql_adapter *qdev)
> "Error reading status register 0x%.04x.\n",
> i);
> goto end;
> - } else
> + } else {
> *iter = data;
> + }
> iter++;
> }
>
> @@ -290,8 +292,9 @@ static void ql_update_stats(struct ql_adapter *qdev)
> "Error reading status register 0x%.04x.\n",
> i);
> goto end;
> - } else
> + } else {
> *iter = data;
> + }
> iter++;
> }
>
> @@ -304,8 +307,9 @@ static void ql_update_stats(struct ql_adapter *qdev)
> "Error reading status register 0x%.04x.\n",
> i);
> goto end;
> - } else
> + } else {
> *iter = data;
> + }
> iter++;
> }
>
> @@ -316,8 +320,9 @@ static void ql_update_stats(struct ql_adapter *qdev)
> netif_err(qdev, drv, qdev->ndev,
> "Error reading status register 0x%.04x.\n", i);
> goto end;
> - } else
> + } else {
> *iter = data;
> + }
> end:
> ql_sem_unlock(qdev, qdev->xg_sem_mask);
> quit:
> @@ -488,8 +493,9 @@ static int ql_start_loopback(struct ql_adapter *qdev)
> if (netif_carrier_ok(qdev->ndev)) {
> set_bit(QL_LB_LINK_UP, >flags);
> netif_carrier_off(qdev->ndev);
> - } else
> + } else {
> clear_bit(QL_LB_LINK_UP, >flags);
> + }
> qdev->link_config |= CFG_LOOPBACK_PCS;
> return ql_mb_set_port_cfg(qdev);
> }
>
___
devel mailing list
de...@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
Re: [GIT PULL] Staging driver fixes for 5.6-rc3
The pull request you sent on Fri, 21 Feb 2020 12:39:52 +0100: > git://git.kernel.org/pub/scm/linux/kernel/git/gregkh/staging.git > tags/staging-5.6-rc3 has been merged into torvalds/linux.git: https://git.kernel.org/torvalds/c/e5553ac71e584c3aa443e211ca2afded6071b5b6 Thank you! -- Deet-doot-dot, I am a bot. https://korg.wiki.kernel.org/userdoc/prtracker ___ devel mailing list de...@linuxdriverproject.org http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
[PATCH] staging: qlge: add braces on all arms of if-else
fix all checkpatch.pl warnings of 'braces {} should be used on all arms
of this statement' in the file qlge_ethtool.c by adding the braces.
Signed-off-by: Kaaira Gupta
---
drivers/staging/qlge/qlge_ethtool.c | 18 --
1 file changed, 12 insertions(+), 6 deletions(-)
diff --git a/drivers/staging/qlge/qlge_ethtool.c
b/drivers/staging/qlge/qlge_ethtool.c
index 790997aff995..592ca7edfc44 100644
--- a/drivers/staging/qlge/qlge_ethtool.c
+++ b/drivers/staging/qlge/qlge_ethtool.c
@@ -259,8 +259,9 @@ static void ql_update_stats(struct ql_adapter *qdev)
"Error reading status register 0x%.04x.\n",
i);
goto end;
- } else
+ } else {
*iter = data;
+ }
iter++;
}
@@ -273,8 +274,9 @@ static void ql_update_stats(struct ql_adapter *qdev)
"Error reading status register 0x%.04x.\n",
i);
goto end;
- } else
+ } else {
*iter = data;
+ }
iter++;
}
@@ -290,8 +292,9 @@ static void ql_update_stats(struct ql_adapter *qdev)
"Error reading status register 0x%.04x.\n",
i);
goto end;
- } else
+ } else {
*iter = data;
+ }
iter++;
}
@@ -304,8 +307,9 @@ static void ql_update_stats(struct ql_adapter *qdev)
"Error reading status register 0x%.04x.\n",
i);
goto end;
- } else
+ } else {
*iter = data;
+ }
iter++;
}
@@ -316,8 +320,9 @@ static void ql_update_stats(struct ql_adapter *qdev)
netif_err(qdev, drv, qdev->ndev,
"Error reading status register 0x%.04x.\n", i);
goto end;
- } else
+ } else {
*iter = data;
+ }
end:
ql_sem_unlock(qdev, qdev->xg_sem_mask);
quit:
@@ -488,8 +493,9 @@ static int ql_start_loopback(struct ql_adapter *qdev)
if (netif_carrier_ok(qdev->ndev)) {
set_bit(QL_LB_LINK_UP, >flags);
netif_carrier_off(qdev->ndev);
- } else
+ } else {
clear_bit(QL_LB_LINK_UP, >flags);
+ }
qdev->link_config |= CFG_LOOPBACK_PCS;
return ql_mb_set_port_cfg(qdev);
}
--
2.17.1
___
devel mailing list
de...@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
[PATCH] staging: qlge: add braces around macro arguments
Fix checkpatch.pl warnings of adding braces around macro arguments to
prevent precedence issues by adding braces in qlge_dbg.c
Signed-off-by: Kaaira Gupta
---
drivers/staging/qlge/qlge_dbg.c | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/drivers/staging/qlge/qlge_dbg.c b/drivers/staging/qlge/qlge_dbg.c
index 8cf39615c520..c7af2548d119 100644
--- a/drivers/staging/qlge/qlge_dbg.c
+++ b/drivers/staging/qlge/qlge_dbg.c
@@ -1525,7 +1525,7 @@ void ql_dump_regs(struct ql_adapter *qdev)
#ifdef QL_STAT_DUMP
#define DUMP_STAT(qdev, stat) \
- pr_err("%s = %ld\n", #stat, (unsigned long)qdev->nic_stats.stat)
+ pr_err("%s = %ld\n", #stat, (unsigned long)(qdev)->nic_stats.stat)
void ql_dump_stat(struct ql_adapter *qdev)
{
@@ -1578,12 +1578,12 @@ void ql_dump_stat(struct ql_adapter *qdev)
#ifdef QL_DEV_DUMP
#define DUMP_QDEV_FIELD(qdev, type, field) \
- pr_err("qdev->%-24s = " type "\n", #field, qdev->field)
+ pr_err("qdev->%-24s = " type "\n", #field, (qdev)->(field))
#define DUMP_QDEV_DMA_FIELD(qdev, field) \
pr_err("qdev->%-24s = %llx\n", #field, (unsigned long long)qdev->field)
#define DUMP_QDEV_ARRAY(qdev, type, array, index, field) \
pr_err("%s[%d].%s = " type "\n", \
- #array, index, #field, qdev->array[index].field);
+ #array, index, #field, (qdev)->array[index].field);
void ql_dump_qdev(struct ql_adapter *qdev)
{
int i;
--
2.17.1
___
devel mailing list
de...@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
[PATCH] staging: qlge: unify multi-line string
Fix checkpatch.pl warning of 'quoted string split across lines' in
qlge_dbg.c by merging the strings in one line. Fixing this warning is
necessary to ease grep-ing the source for printk.
Signed-off-by: Kaaira Gupta
---
drivers/staging/qlge/qlge_dbg.c | 20 ++--
1 file changed, 10 insertions(+), 10 deletions(-)
diff --git a/drivers/staging/qlge/qlge_dbg.c b/drivers/staging/qlge/qlge_dbg.c
index 8cf39615c520..28d8649ab384 100644
--- a/drivers/staging/qlge/qlge_dbg.c
+++ b/drivers/staging/qlge/qlge_dbg.c
@@ -1333,16 +1333,16 @@ void ql_mpi_core_to_log(struct work_struct *work)
"Core is dumping to log file!\n");
for (i = 0; i < count; i += 8) {
- pr_err("%.08x: %.08x %.08x %.08x %.08x %.08x "
- "%.08x %.08x %.08x\n", i,
- tmp[i + 0],
- tmp[i + 1],
- tmp[i + 2],
- tmp[i + 3],
- tmp[i + 4],
- tmp[i + 5],
- tmp[i + 6],
- tmp[i + 7]);
+ pr_err("%.08x: %.08x %.08x %.08x %.08x %.08x %.08x %.08x
%.08x\n",
+ i,
+ tmp[i + 0],
+ tmp[i + 1],
+ tmp[i + 2],
+ tmp[i + 3],
+ tmp[i + 4],
+ tmp[i + 5],
+ tmp[i + 6],
+ tmp[i + 7]);
msleep(5);
}
}
--
2.17.1
___
devel mailing list
de...@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
注意：所有者のメールアドレス
注意：所有者のメールアドレス このプログラムは、中国のスロバキアで詐欺の被害者のためにトーゴフォーレグナシンベ大統領によって開始されました。 あなたのメールアドレスとあなたの名前が発見され、あなたは被害者の一人として受取人の一人であり、あなたの総補償基金は300,000,000ドル（3,000米ドル）です。このお金は現在、組織振替部を通じて請求されます。 あなたがしなければならないのは、5営業日以内にあなたの資金の処理とリリースのためにロメトーゴ本部に連絡することです。 ただし、お支払いは銀行振り込みによりお客様の国の直接銀行口座に合計300,000.00ドルで送金されることにご注意ください。 メールアドレスのみを使用して支払いを送信することはできません。必要なことは、次の情報を弊社本社にご連絡ください。 あなたのフルネーム …… 銀行の詳細 注：登録に120ユーロを超えて送金しないでください。銀行口座への300,000,000ドルの送金を受け取るために支払う必要がある唯一の手数料です。 電子メールでお問い合わせください：（orabanktransferserv...@gmail.com）... 有難う御座います。 セルジュ・ヌグサン博士 ___ devel mailing list de...@linuxdriverproject.org http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
注意：所有者のメールアドレス
注意：所有者のメールアドレス このプログラムは、中国のスロバキアで詐欺の被害者のためにトーゴフォーレグナシンベ大統領によって開始されました。 あなたのメールアドレスとあなたの名前が発見され、あなたは被害者の一人として受取人の一人であり、あなたの総補償基金は300,000,000ドル（3,000米ドル）です。このお金は現在、組織振替部を通じて請求されます。 あなたがしなければならないのは、5営業日以内にあなたの資金の処理とリリースのためにロメトーゴ本部に連絡することです。 ただし、お支払いは銀行振り込みによりお客様の国の直接銀行口座に合計300,000.00ドルで送金されることにご注意ください。 メールアドレスのみを使用して支払いを送信することはできません。必要なことは、次の情報を弊社本社にご連絡ください。 あなたのフルネーム …… 銀行の詳細 注：登録に120ユーロを超えて送金しないでください。銀行口座への300,000,000ドルの送金を受け取るために支払う必要がある唯一の手数料です。 電子メールでお問い合わせください：（orabanktransferserv...@gmail.com）... 有難う御座います。 セルジュ・ヌグサン博士 ___ devel mailing list de...@linuxdriverproject.org http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
Re: [PATCH 3/3] staging: pi433: overlay: Convert to sugar syntax
On Fri, Feb 21, 2020 at 6:21 AM Geert Uytterhoeven wrote: > > Using overlay sugar syntax makes the DTS overlay files easier to read > (and write). > > Signed-off-by: Geert Uytterhoeven > --- > Why are there two separate fragments for spi0? Can't they be combined? > Why do you need the spidev@1 entry? > --- > .../devicetree/pi433-overlay.dts | 79 --- > 1 file changed, 35 insertions(+), 44 deletions(-) > > diff --git a/drivers/staging/pi433/Documentation/devicetree/pi433-overlay.dts > b/drivers/staging/pi433/Documentation/devicetree/pi433-overlay.dts We have overlays in staging? Who sneaked this in? Maybe the path should be fixed at least as this isn't documentation. Rob ___ devel mailing list de...@linuxdriverproject.org http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
[PATCH] staging: wilc1000: use YAML schemas for DT binding documentation
From: Ajay Singh
Use YAML schemas for wilc1000 DT binding documentations. Currently, the
files are present in '/drivers/staging/wilc1000/' but these will be
moved to '/Documentation/devicetree/bindings/net/wireless/' later once
the driver move out-of-staging.
Signed-off-by: Ajay Singh
---
.../wilc1000/microchip,wilc1000,sdio.txt | 38 ---
.../wilc1000/microchip,wilc1000,sdio.yaml | 68 +++
.../wilc1000/microchip,wilc1000,spi.txt | 34 --
.../wilc1000/microchip,wilc1000,spi.yaml | 61 +
4 files changed, 129 insertions(+), 72 deletions(-)
delete mode 100644 drivers/staging/wilc1000/microchip,wilc1000,sdio.txt
create mode 100644 drivers/staging/wilc1000/microchip,wilc1000,sdio.yaml
delete mode 100644 drivers/staging/wilc1000/microchip,wilc1000,spi.txt
create mode 100644 drivers/staging/wilc1000/microchip,wilc1000,spi.yaml
diff --git a/drivers/staging/wilc1000/microchip,wilc1000,sdio.txt
b/drivers/staging/wilc1000/microchip,wilc1000,sdio.txt
deleted file mode 100644
index da5235950a70..
--- a/drivers/staging/wilc1000/microchip,wilc1000,sdio.txt
+++ /dev/null
@@ -1,38 +0,0 @@
-* Microchip WILC wireless SDIO device
-
-The wilc1000 chips can be connected via SDIO. The node is used to specifiy
-child node to the SDIO controller that connects the device to the system.
-
-Required properties:
-- compatible : Should be "microchip,wilc1000-spi"
-- irq-gpios: Connect to a host IRQ
-- reg : Slot ID used in the controller
-
-Optional:
-- bus-width: Number of data lines wired up the slot. Default 1 bit.
-- rtc_clk : Clock connected on the rtc clock line. Must be assigned
- a frequency with assigned-clocks property, and must be
- connected to a clock provider.
-
-Examples:
-mmc1: mmc@fc00 {
- pinctrl-names = "default";
- pinctrl-0 = <_mmc1_clk_cmd_dat0 _mmc1_dat1_3>;
- non-removable;
- vmmc-supply = <_mmc1_reg>;
- vqmmc-supply = <_3v3_reg>;
- status = "okay";
-
- wilc_sdio@0 {
- compatible = "microchip,wilc1000-sdio";
- irq-gpios = < 27 0>;
- clocks = <>;
- clock-names = "rtc_clk";
- assigned-clocks = <>;
- assigned-clock-rates = <32768>;
- status = "okay";
- reg = <0>;
- bus-width = <4>;
- }
- };
-}
diff --git a/drivers/staging/wilc1000/microchip,wilc1000,sdio.yaml
b/drivers/staging/wilc1000/microchip,wilc1000,sdio.yaml
new file mode 100644
index ..b338f569f7e2
--- /dev/null
+++ b/drivers/staging/wilc1000/microchip,wilc1000,sdio.yaml
@@ -0,0 +1,68 @@
+# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause)
+%YAML 1.2
+---
+$id: http://devicetree.org/schemas/net/wireless/microchip,wilc1000,sdio.yaml#
+$schema: http://devicetree.org/meta-schemas/core.yaml#
+
+title: Microchip WILC wireless SDIO devicetree bindings
+
+maintainers:
+ - Adham Abozaeid
+ - Ajay Singh
+
+description:
+ The wilc1000 chips can be connected via SDIO. The node is used to
+ specify child node to the SDIO controller that connects the device
+ to the system.
+
+properties:
+ compatible:
+const: microchip,wilc1000-sdio
+
+ irq-gpios:
+description: The GPIO phandle connect to a host IRQ.
+maxItems: 1
+
+ reg:
+description: Slot ID used in the controller.
+maxItems: 1
+
+ clocks:
+description: phandle to the clock connected on rtc clock line.
+maxItems: 1
+
+ bus-width:
+description: The number of data lines wired up the slot.
+allOf:
+ - $ref: /schemas/types.yaml#/definitions/uint32
+ - enum: [1, 4, 8]
+ - default: 1
+
+required:
+ - compatible
+ - irq-gpios
+ - reg
+
+examples:
+ - |
+mmc1: mmc@fc00 {
+ #address-cells = <1>;
+ #size-cells = <0>;
+ pinctrl-names = "default";
+ pinctrl-0 = <_mmc1_clk_cmd_dat0 _mmc1_dat1_3>;
+ non-removable;
+ vmmc-supply = <_mmc1_reg>;
+ vqmmc-supply = <_3v3_reg>;
+ status = "okay";
+ wilc_sdio@0 {
+compatible = "microchip,wilc1000-sdio";
+ irq-gpios = < 27 0>;
+ reg = <0>;
+ clocks = <>;
+ clock-names = "rtc_clk";
+ assigned-clocks = <>;
+ assigned-clock-rates = <32768>;
+ status = "okay";
+ bus-width = <4>;
+};
+};
diff --git a/drivers/staging/wilc1000/microchip,wilc1000,spi.txt
b/drivers/staging/wilc1000/microchip,wilc1000,spi.txt
deleted file mode 100644
index 34236932dbb6..
--- a/drivers/staging/wilc1000/microchip,wilc1000,spi.txt
+++ /dev/null
@@ -1,34 +0,0 @@
-* Microchip WILC wireless SPI device
-
-The wilc1000 chips can be connected via SPI. This document describes
-the binding
[PATCH 1/3] staging: pi433: overlay: Fix Broadcom vendor prefix
checkpatch.pl says:
WARNING: DT compatible string "bcm,bcm2708" appears un-documented -- check
./Documentation/devicetree/bindings/
The vendor prefix of Broadcom Corporation is "brcm", not "bcm".
Signed-off-by: Geert Uytterhoeven
---
Why do you need these 3 compatible values at the root of the overlay,
not referencing the actual root of the machine's DT?
Does the Raspbian overlay manager use this to check if the overlay is
applicable to the machine it is running on?
---
.../staging/pi433/Documentation/devicetree/pi433-overlay.dts| 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/staging/pi433/Documentation/devicetree/pi433-overlay.dts
b/drivers/staging/pi433/Documentation/devicetree/pi433-overlay.dts
index 61fad96818c28c5d..dfc9f974ac24ecc1 100644
--- a/drivers/staging/pi433/Documentation/devicetree/pi433-overlay.dts
+++ b/drivers/staging/pi433/Documentation/devicetree/pi433-overlay.dts
@@ -3,7 +3,7 @@
/plugin/;
/ {
- compatible = "bcm,bcm2835", "bcm,bcm2708", "bcm,bcm2709";
+ compatible = "brcm,bcm2835", "brcm,bcm2708", "brcm,bcm2709";
fragment@0 {
target = <>;
--
2.17.1
___
devel mailing list
de...@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
[PATCH 2/3] staging: pi433: overlay: Fix reg-related warnings
When running "scripts/dtc/dtc -@ -I dts -O dtb -o pi433-overlay.dtbo.1
drivers/staging/pi433/Documentation/devicetree/pi433-overlay.dts":
drivers/staging/pi433/Documentation/devicetree/pi433-overlay.dts:13.12-15.6:
Warning (unit_address_vs_reg): /fragment@0/__overlay__/spidev@0: node has a
unit name, but no reg property
drivers/staging/pi433/Documentation/devicetree/pi433-overlay.dts:17.12-19.6:
Warning (unit_address_vs_reg): /fragment@0/__overlay__/spidev@1: node has a
unit name, but no reg property
Add the missing "reg" properties to fix this.
drivers/staging/pi433/Documentation/devicetree/pi433-overlay.dts:14.5-15:
Warning (reg_format): /fragment@0/__overlay__/spidev@0:reg: property has
invalid length (4 bytes) (#address-cells == 2, #size-cells == 1)
drivers/staging/pi433/Documentation/devicetree/pi433-overlay.dts:19.5-15:
Warning (reg_format): /fragment@0/__overlay__/spidev@1:reg: property has
invalid length (4 bytes) (#address-cells == 2, #size-cells == 1)
Add the missing "#{address,size}-cells" to fix this.
Signed-off-by: Geert Uytterhoeven
---
.../staging/pi433/Documentation/devicetree/pi433-overlay.dts | 4
1 file changed, 4 insertions(+)
diff --git a/drivers/staging/pi433/Documentation/devicetree/pi433-overlay.dts
b/drivers/staging/pi433/Documentation/devicetree/pi433-overlay.dts
index dfc9f974ac24ecc1..b584180d78d019aa 100644
--- a/drivers/staging/pi433/Documentation/devicetree/pi433-overlay.dts
+++ b/drivers/staging/pi433/Documentation/devicetree/pi433-overlay.dts
@@ -8,13 +8,17 @@
fragment@0 {
target = <>;
__overlay__ {
+ #address-cells = <1>;
+ #size-cells = <0>;
status = "okay";
spidev@0{
+ reg = <0>;
status = "disabled";
};
spidev@1{
+ reg = <1>;
status = "disabled";
};
};
--
2.17.1
___
devel mailing list
de...@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
[PATCH 3/3] staging: pi433: overlay: Convert to sugar syntax
Using overlay sugar syntax makes the DTS overlay files easier to read
(and write).
Signed-off-by: Geert Uytterhoeven
---
Why are there two separate fragments for spi0? Can't they be combined?
Why do you need the spidev@1 entry?
---
.../devicetree/pi433-overlay.dts | 79 ---
1 file changed, 35 insertions(+), 44 deletions(-)
diff --git a/drivers/staging/pi433/Documentation/devicetree/pi433-overlay.dts
b/drivers/staging/pi433/Documentation/devicetree/pi433-overlay.dts
index b584180d78d019aa..096137fcd5cc0131 100644
--- a/drivers/staging/pi433/Documentation/devicetree/pi433-overlay.dts
+++ b/drivers/staging/pi433/Documentation/devicetree/pi433-overlay.dts
@@ -4,54 +4,45 @@
/ {
compatible = "brcm,bcm2835", "brcm,bcm2708", "brcm,bcm2709";
+};
+
+ {
+ #address-cells = <1>;
+ #size-cells = <0>;
+ status = "okay";
+
+ spidev@0{
+ reg = <0>;
+ status = "disabled";
+ };
- fragment@0 {
- target = <>;
- __overlay__ {
- #address-cells = <1>;
- #size-cells = <0>;
- status = "okay";
-
- spidev@0{
- reg = <0>;
- status = "disabled";
- };
-
- spidev@1{
- reg = <1>;
- status = "disabled";
- };
- };
+ spidev@1{
+ reg = <1>;
+ status = "disabled";
};
+};
- fragment@1 {
- target = <>;
- __overlay__ {
- pi433_pins: pi433_pins {
- brcm,pins = <7 25 24>;
- brcm,function = <0 0 0>; // in in in
- };
- };
+ {
+ pi433_pins: pi433_pins {
+ brcm,pins = <7 25 24>;
+ brcm,function = <0 0 0>; // in in in
};
+};
- fragment@2 {
- target = <>;
- __overlay__ {
- #address-cells = <1>;
- #size-cells = <0>;
- status = "okay";
-
- pi433: pi433@0 {
- compatible = "Smarthome-Wolf,pi433";
- reg = <0>;
- spi-max-frequency = <1000>;
- status = "okay";
-
- pinctrl-0 = <_pins>;
- DIO0-gpio = < 24 0>;
- DIO1-gpio = < 25 0>;
- DIO2-gpio = < 7 0>;
- };
- };
+ {
+ #address-cells = <1>;
+ #size-cells = <0>;
+ status = "okay";
+
+ pi433: pi433@0 {
+ compatible = "Smarthome-Wolf,pi433";
+ reg = <0>;
+ spi-max-frequency = <1000>;
+ status = "okay";
+
+ pinctrl-0 = <_pins>;
+ DIO0-gpio = < 24 0>;
+ DIO1-gpio = < 25 0>;
+ DIO2-gpio = < 7 0>;
};
};
--
2.17.1
___
devel mailing list
de...@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
[PATCH 0/3] staging: pi433: overlay: Convert to sugar syntax
Hi all,
This patch series fixes common errors in the overlay DTS for the Pi433
radio module, and converts it to overlay sugar syntax.
This has not been run-tested due to lack of hardware, but I did look at
the resulting changes using scripts/dtc/dtx_diff.
Thanks for your comments!
Geert Uytterhoeven (3):
staging: pi433: overlay: Fix Broadcom vendor prefix
staging: pi433: overlay: Fix reg-related warnings
staging: pi433: overlay: Convert to sugar syntax
.../devicetree/pi433-overlay.dts | 73 +--
1 file changed, 34 insertions(+), 39 deletions(-)
--
2.17.1
Gr{oetje,eeting}s,
Geert
--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- ge...@linux-m68k.org
In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
-- Linus Torvalds
___
devel mailing list
de...@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
[GIT PULL] Staging driver fixes for 5.6-rc3
The following changes since commit bb6d3fb354c5ee8d6bde2d576eb7220ea09862b9: Linux 5.6-rc1 (2020-02-09 16:08:48 -0800) are available in the Git repository at: git://git.kernel.org/pub/scm/linux/kernel/git/gregkh/staging.git tags/staging-5.6-rc3 for you to fetch changes up to 9a4556bd8f23209c29f152e6a930b6a893b0fc81: staging: rtl8723bs: Remove unneeded goto statements (2020-02-10 10:32:38 -0800) Staging driver fixes for 5.6-rc3 Here are some small staging driver fixes for 5.6-rc3, along with the removal of an unused/unneeded driver as well. The android vsoc driver is not needed anymore by anyone, so it was removed. The other driver fixes are: - ashmem bugfixes - greybus audio driver bugfix - wireless driver bugfixes and tiny cleanups to error paths All of these have been in linux-next for a while now with no reported issues. Signed-off-by: Greg Kroah-Hartman Alistair Delva (1): staging: android: Delete the 'vsoc' driver Colin Ian King (1): staging: rtl8723bs: fix copy of overlapping memory Dan Carpenter (1): staging: greybus: use after free in gb_audio_manager_remove_all() Larry Finger (6): staging: rtl8188eu: Fix potential security hole staging: rtl8723bs: Fix potential security hole staging: rtl8188eu: Fix potential overuse of kernel memory staging: rtl8723bs: Fix potential overuse of kernel memory staging: rtl8188eu: Remove some unneeded goto statements staging: rtl8723bs: Remove unneeded goto statements Malcolm Priestley (1): staging: vt6656: fix sign of rx_dbm to bb_pre_ed_rssi. Suren Baghdasaryan (1): staging: android: ashmem: Disallow ashmem memory from being remapped drivers/staging/android/Kconfig|8 - drivers/staging/android/Makefile |1 - drivers/staging/android/TODO |9 - drivers/staging/android/ashmem.c | 28 + drivers/staging/android/uapi/vsoc_shm.h| 295 -- drivers/staging/android/vsoc.c | 1149 drivers/staging/greybus/audio_manager.c|2 +- drivers/staging/rtl8188eu/os_dep/ioctl_linux.c | 40 +- drivers/staging/rtl8723bs/hal/rtl8723bs_xmit.c |5 +- drivers/staging/rtl8723bs/os_dep/ioctl_linux.c | 47 +- drivers/staging/vt6656/dpc.c |2 +- 11 files changed, 56 insertions(+), 1530 deletions(-) delete mode 100644 drivers/staging/android/uapi/vsoc_shm.h delete mode 100644 drivers/staging/android/vsoc.c ___ devel mailing list de...@linuxdriverproject.org http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
[PATCH] staging: wilc1000: avoid double unlocking of 'wilc->hif_cs' mutex
From: Ajay Singh
Possible double unlocking of 'wilc->hif_cs' mutex was identified by
smatch [1]. Removed the extra call to release_bus() in
wilc_wlan_handle_txq() which was missed in earlier commit fdc2ac1aafc6
("staging: wilc1000: support suspend/resume functionality").
[1].
https://lists.01.org/hyperkitty/list/kbuild-...@lists.01.org/thread/NOEVW7C3GV74EWXJO3XX6VT2NKVB2HMT/
Reported-by: kbuild test robot
Reported-by: Dan Carpenter
Signed-off-by: Ajay Singh
---
drivers/staging/wilc1000/wlan.c | 1 -
1 file changed, 1 deletion(-)
diff --git a/drivers/staging/wilc1000/wlan.c b/drivers/staging/wilc1000/wlan.c
index f633c6b9f0a9..3aeca882f431 100644
--- a/drivers/staging/wilc1000/wlan.c
+++ b/drivers/staging/wilc1000/wlan.c
@@ -575,7 +575,6 @@ int wilc_wlan_handle_txq(struct wilc *wilc, u32 *txq_count)
entries = FIELD_GET(WILC_VMM_ENTRY_COUNT, reg);
break;
}
- release_bus(wilc, WILC_BUS_RELEASE_ALLOW_SLEEP);
} while (--timeout);
if (timeout <= 0) {
ret = func->hif_write_reg(wilc, WILC_HOST_VMM_CTL, 0x0);
--
2.24.0
___
devel mailing list
de...@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
