[PATCH] staging: rtl8723bs: Use shared header constants
This is one of the 9 drivers redefining rfc1042_header.
Signed-off-by: Pascal Terjan
---
drivers/staging/rtl8723bs/core/rtw_recv.c | 15 ++-
drivers/staging/rtl8723bs/include/rtw_recv.h | 2 --
drivers/staging/rtl8723bs/os_dep/recv_linux.c | 5 +++--
3 files changed, 9 insertions(+), 13 deletions(-)
diff --git a/drivers/staging/rtl8723bs/core/rtw_recv.c
b/drivers/staging/rtl8723bs/core/rtw_recv.c
index 5245098b9ecf..dc58822924b4 100644
--- a/drivers/staging/rtl8723bs/core/rtw_recv.c
+++ b/drivers/staging/rtl8723bs/core/rtw_recv.c
@@ -10,14 +10,11 @@
#include
#include
#include
+#include
static u8 SNAP_ETH_TYPE_IPX[2] = {0x81, 0x37};
static u8 SNAP_ETH_TYPE_APPLETALK_AARP[2] = {0x80, 0xf3};
-u8 rtw_rfc1042_header[] = { 0xaa, 0xaa, 0x03, 0x00, 0x00, 0x00 };
-/* Bridge-Tunnel header (for EtherTypes ETH_P_AARP and ETH_P_IPX) */
-u8 rtw_bridge_tunnel_header[] = { 0xaa, 0xaa, 0x03, 0x00, 0x00, 0xf8 };
-
static void rtw_signal_stat_timer_hdl(struct timer_list *t);
void _rtw_init_sta_recv_priv(struct sta_recv_priv *psta_recvpriv)
@@ -1625,11 +1622,11 @@ sint wlanhdr_to_ethhdr(union recv_frame *precvframe)
psnap_type = ptr+pattrib->hdrlen + pattrib->iv_len+SNAP_SIZE;
/* convert hdr + possible LLC headers into Ethernet header */
/* eth_type = (psnap_type[0] << 8) | psnap_type[1]; */
- if ((!memcmp(psnap, rtw_rfc1042_header, SNAP_SIZE) &&
- (memcmp(psnap_type, SNAP_ETH_TYPE_IPX, 2)) &&
- (memcmp(psnap_type, SNAP_ETH_TYPE_APPLETALK_AARP, 2))) ||
- /* eth_type != ETH_P_AARP && eth_type != ETH_P_IPX) || */
-!memcmp(psnap, rtw_bridge_tunnel_header, SNAP_SIZE)) {
+ if ((!memcmp(psnap, rfc1042_header, SNAP_SIZE) &&
+memcmp(psnap_type, SNAP_ETH_TYPE_IPX, 2) &&
+memcmp(psnap_type, SNAP_ETH_TYPE_APPLETALK_AARP, 2)) ||
+ /* eth_type != ETH_P_AARP && eth_type != ETH_P_IPX) || */
+ !memcmp(psnap, bridge_tunnel_header, SNAP_SIZE)) {
/* remove RFC1042 or Bridge-Tunnel encapsulation and replace
EtherType */
bsnaphdr = true;
} else
diff --git a/drivers/staging/rtl8723bs/include/rtw_recv.h
b/drivers/staging/rtl8723bs/include/rtw_recv.h
index 98c3e92245b7..a851b818ef0e 100644
--- a/drivers/staging/rtl8723bs/include/rtw_recv.h
+++ b/drivers/staging/rtl8723bs/include/rtw_recv.h
@@ -38,8 +38,6 @@
#define RX_MAX_QUEUE 2
#define MAX_SUBFRAME_COUNT 64
-extern u8 rtw_rfc1042_header[];
-extern u8 rtw_bridge_tunnel_header[];
/* for Rx reordering buffer control */
struct recv_reorder_ctrl
diff --git a/drivers/staging/rtl8723bs/os_dep/recv_linux.c
b/drivers/staging/rtl8723bs/os_dep/recv_linux.c
index 2a7b9922b1d4..eb4d1c3008fe 100644
--- a/drivers/staging/rtl8723bs/os_dep/recv_linux.c
+++ b/drivers/staging/rtl8723bs/os_dep/recv_linux.c
@@ -9,6 +9,7 @@
#include
#include
#include
+#include
void rtw_os_free_recvframe(union recv_frame *precvframe)
{
@@ -71,9 +72,9 @@ _pkt *rtw_os_alloc_msdu_pkt(union recv_frame *prframe, u16
nSubframe_Length, u8
eth_type = RTW_GET_BE16(_skb->data[6]);
if (sub_skb->len >= 8 &&
- ((!memcmp(sub_skb->data, rtw_rfc1042_header, SNAP_SIZE) &&
+ ((!memcmp(sub_skb->data, rfc1042_header, SNAP_SIZE) &&
eth_type != ETH_P_AARP && eth_type != ETH_P_IPX) ||
-!memcmp(sub_skb->data, rtw_bridge_tunnel_header, SNAP_SIZE))) {
+!memcmp(sub_skb->data, bridge_tunnel_header, SNAP_SIZE))) {
/*
* remove RFC1042 or Bridge-Tunnel encapsulation and replace
* EtherType
--
2.27.0.rc0.183.gde8f92d652-goog
___
devel mailing list
de...@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
[staging:staging-next] BUILD SUCCESS bf04362fc3e41d0887090ce174a8373653811a7c
tree/branch: https://git.kernel.org/pub/scm/linux/kernel/git/gregkh/staging.git staging-next branch HEAD: bf04362fc3e41d0887090ce174a8373653811a7c staging: rtl8192e: Using comparison to true is error prone elapsed time: 3803m configs tested: 132 configs skipped: 2 The following configs have been built successfully. More configs may be tested in the coming days. arm defconfig arm allyesconfig arm allmodconfig arm allnoconfig arm64allyesconfig arm64 defconfig arm64allmodconfig arm64 allnoconfig sparcallyesconfig mips allyesconfig m68k allyesconfig arm eseries_pxa_defconfig riscvnommu_virt_defconfig powerpc mpc83xx_defconfig arm imote2_defconfig i386 allnoconfig i386 allyesconfig i386defconfig i386 debian-10.3 ia64 allmodconfig ia64defconfig ia64 allnoconfig ia64 allyesconfig m68k allmodconfig m68k allnoconfig m68k sun3_defconfig m68kdefconfig nios2 defconfig nios2allyesconfig openriscdefconfig c6x allyesconfig c6x allnoconfig openrisc allyesconfig nds32 defconfig nds32 allnoconfig csky allyesconfig cskydefconfig alpha defconfig alphaallyesconfig xtensa defconfig xtensa allyesconfig h8300allyesconfig h8300allmodconfig arc defconfig sh allmodconfig shallnoconfig microblazeallnoconfig arc allyesconfig mips allnoconfig mips allmodconfig pariscallnoconfig parisc defconfig parisc allyesconfig parisc allmodconfig powerpc defconfig powerpc allyesconfig powerpc rhel-kconfig powerpc allmodconfig powerpc allnoconfig i386 randconfig-a001-20200521 i386 randconfig-a004-20200521 i386 randconfig-a006-20200521 i386 randconfig-a003-20200521 i386 randconfig-a002-20200521 i386 randconfig-a005-20200521 i386 randconfig-a001-20200523 i386 randconfig-a004-20200523 i386 randconfig-a003-20200523 i386 randconfig-a006-20200523 i386 randconfig-a002-20200523 i386 randconfig-a005-20200523 x86_64 randconfig-a015-20200522 x86_64 randconfig-a013-20200522 x86_64 randconfig-a016-20200522 x86_64 randconfig-a012-20200522 x86_64 randconfig-a014-20200522 x86_64 randconfig-a011-20200522 x86_64 randconfig-a013-20200520 x86_64 randconfig-a015-20200520 x86_64 randconfig-a016-20200520 x86_64 randconfig-a012-20200520 x86_64 randconfig-a014-20200520 x86_64 randconfig-a011-20200520 x86_64 randconfig-a002-20200521 x86_64 randconfig-a006-20200521 x86_64 randconfig-a005-20200521 x86_64 randconfig-a004-20200521 x86_64 randconfig-a003-20200521 x86_64 randconfig-a001-20200521 i386 randconfig-a013-20200522 i386 randconfig-a012-20200522 i386 randconfig-a015-20200522 i386 randconfig-a011-20200522 i386 randconfig-a016-20200522 i386 randconfig-a014-20200522 i386 randconfig-a013-20200521 i386 randconfig-a012-20200521 i386 randconfig-a015-20200521 i386 randconfig-a011-20200521 i386 randconfig-a016-20200521 i386
[PATCH] staging: vt6656: Fix vnt_tx_usb_header static checker warning
drivers/staging/vt6656/rxtx.c:729 vnt_beacon_xmit()
warn: struct type mismatch 'vnt_beacon_buffer vs vnt_tx_usb_header'
Since the only part of vnt_beacon_buffer is used remove and
replace it with vnt_tx_usb_header.
Fixes: 9deca1e3e2b6 ("staging: vt6656: vnt_beacon_xmit use extra_tx_headroom.")
Reported-by: Dan Carpenter
Signed-off-by: Malcolm Priestley
---
drivers/staging/vt6656/rxtx.c | 12 ++--
drivers/staging/vt6656/rxtx.h | 5 -
2 files changed, 6 insertions(+), 11 deletions(-)
diff --git a/drivers/staging/vt6656/rxtx.c b/drivers/staging/vt6656/rxtx.c
index 9ee57f7c0c88..a1b16ef9b27f 100644
--- a/drivers/staging/vt6656/rxtx.c
+++ b/drivers/staging/vt6656/rxtx.c
@@ -634,7 +634,7 @@ int vnt_tx_packet(struct vnt_private *priv, struct sk_buff
*skb)
static int vnt_beacon_xmit(struct vnt_private *priv, struct sk_buff *skb)
{
- struct vnt_beacon_buffer *beacon_buffer;
+ struct vnt_tx_usb_header *usb;
struct vnt_tx_short_buf_head *short_head;
struct ieee80211_tx_info *info;
struct vnt_usb_send_context *context;
@@ -701,13 +701,13 @@ static int vnt_beacon_xmit(struct vnt_private *priv,
struct sk_buff *skb)
if (priv->seq_counter > 0x0fff)
priv->seq_counter = 0;
- beacon_buffer = skb_push(skb, sizeof(struct vnt_tx_usb_header));
- beacon_buffer->usb.tx_byte_count = cpu_to_le16(count);
- beacon_buffer->usb.pkt_no = context->pkt_no;
- beacon_buffer->usb.type = 0x01;
+ usb = skb_push(skb, sizeof(*usb));
+ usb->tx_byte_count = cpu_to_le16(count);
+ usb->pkt_no = context->pkt_no;
+ usb->type = 0x01;
context->type = CONTEXT_BEACON_PACKET;
- context->tx_buffer = beacon_buffer;
+ context->tx_buffer = usb;
context->buf_len = skb->len;
spin_lock_irqsave(>lock, flags);
diff --git a/drivers/staging/vt6656/rxtx.h b/drivers/staging/vt6656/rxtx.h
index fd64d0838e34..f3c7b99cda73 100644
--- a/drivers/staging/vt6656/rxtx.h
+++ b/drivers/staging/vt6656/rxtx.h
@@ -179,11 +179,6 @@ struct vnt_tx_short_buf_head {
__le16 time_stamp_off;
} __packed;
-struct vnt_beacon_buffer {
- struct vnt_tx_usb_header usb;
- struct vnt_tx_short_buf_head short_head;
-} __packed;
-
int vnt_tx_packet(struct vnt_private *priv, struct sk_buff *skb);
int vnt_beacon_make(struct vnt_private *priv, struct ieee80211_vif *vif);
int vnt_beacon_enable(struct vnt_private *priv, struct ieee80211_vif *vif,
--
2.27.0.rc0
___
devel mailing list
de...@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
Re: [GIT PULL] Staging/IIO driver fixes for 5.7-rc7
The pull request you sent on Sat, 23 May 2020 15:17:42 +0200: > git://git.kernel.org/pub/scm/linux/kernel/git/gregkh/staging.git > tags/staging-5.7-rc7 has been merged into torvalds/linux.git: https://git.kernel.org/torvalds/c/8f261041b18ee80ad8afdd1621c909c4df9f6cc3 Thank you! -- Deet-doot-dot, I am a bot. https://korg.wiki.kernel.org/userdoc/prtracker ___ devel mailing list de...@linuxdriverproject.org http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
[PATCH] staging: rtl8192e: Using comparison to true is error prone
clear below issues reported by checkpatch.pl:
CHECK: Using comparison to false is error prone
Signed-off-by: John Oldman
---
drivers/staging/rtl8192e/rtl819x_HTProc.c | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/drivers/staging/rtl8192e/rtl819x_HTProc.c
b/drivers/staging/rtl8192e/rtl819x_HTProc.c
index d83d72594312..8abc921ecb3e 100644
--- a/drivers/staging/rtl8192e/rtl819x_HTProc.c
+++ b/drivers/staging/rtl8192e/rtl819x_HTProc.c
@@ -371,7 +371,7 @@ void HTConstructInfoElement(struct rtllib_device *ieee, u8
*posHTInfo,
if ((ieee->iw_mode == IW_MODE_ADHOC) ||
(ieee->iw_mode == IW_MODE_MASTER)) {
pHTInfoEle->ControlChl = ieee->current_network.channel;
- pHTInfoEle->ExtChlOffset = ((pHT->bRegBW40MHz == false) ?
+ pHTInfoEle->ExtChlOffset = ((!pHT->bRegBW40MHz) ?
HT_EXTCHNL_OFFSET_NO_EXT :
(ieee->current_network.channel <= 6)
? HT_EXTCHNL_OFFSET_UPPER :
@@ -526,7 +526,7 @@ void HTOnAssocRsp(struct rtllib_device *ieee)
static u8 EWC11NHTCap[] = {0x00, 0x90, 0x4c, 0x33};
static u8 EWC11NHTInfo[] = {0x00, 0x90, 0x4c, 0x34};
- if (pHTInfo->bCurrentHTSupport == false) {
+ if (!pHTInfo->bCurrentHTSupport) {
netdev_warn(ieee->dev, "%s(): HT_DISABLE\n", __func__);
return;
}
@@ -873,7 +873,7 @@ void HTSetConnectBwMode(struct rtllib_device *ieee,
{
struct rt_hi_throughput *pHTInfo = ieee->pHTInfo;
- if (pHTInfo->bRegBW40MHz == false)
+ if (!pHTInfo->bRegBW40MHz)
return;
if (ieee->GetHalfNmodeSupportByAPsHandler(ieee->dev))
--
2.17.1
___
devel mailing list
de...@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
[GIT PULL] Staging/IIO driver fixes for 5.7-rc7
The following changes since commit 2ef96a5bb12be62ef75b5828c0aab838ebb29cb8: Linux 5.7-rc5 (2020-05-10 15:16:58 -0700) are available in the Git repository at: git://git.kernel.org/pub/scm/linux/kernel/git/gregkh/staging.git tags/staging-5.7-rc7 for you to fetch changes up to bcb392871813ef9e233645557d6dd85bb1a6f41a: Merge tag 'iio-fixes-for-5.7b' of https://git.kernel.org/pub/scm/linux/kernel/git/jic23/iio into staging-linus (2020-05-15 16:04:24 +0200) Staging/IIO fixes for 5.7-rc7 Here are some small staging and IIO driver fixes for 5.7-rc7 Nothing major, just a collection of IIO driver fixes for reported issues, and a few small staging driver fixes that people have found. Full details are in the shortlog. All of these have been in linux-next for a while with no reported issues. Signed-off-by: Greg Kroah-Hartman Christophe JAILLET (2): iio: dac: vf610: Fix an error handling path in 'vf610_dac_probe()' iio: sca3000: Remove an erroneous 'get_device()' Dan Carpenter (2): iio: imu: st_lsm6dsx: unlock on error in st_lsm6dsx_shub_write_raw() staging: wfx: unlock on error path Dragos Bogdan (1): staging: iio: ad2s1210: Fix SPI reading Fabrice Gasnier (2): iio: adc: stm32-adc: fix device used to request dma iio: adc: stm32-dfsdm: fix device used to request dma Greg Kroah-Hartman (1): Merge tag 'iio-fixes-for-5.7b' of https://git.kernel.org/.../jic23/iio into staging-linus Gregory CLEMENT (1): iio: adc: ti-ads8344: Fix channel selection Matt Ranostay (1): iio: chemical: atlas-sensor: correct DO-SM channels Oscar Carter (1): staging: greybus: Fix uninitialized scalar variable Wei Yongjun (1): staging: kpc2000: fix error return code in kp2000_pcie_probe() drivers/iio/accel/sca3000.c | 2 +- drivers/iio/adc/stm32-adc.c | 8 drivers/iio/adc/stm32-dfsdm-adc.c| 21 +++-- drivers/iio/adc/ti-ads8344.c | 8 +--- drivers/iio/chemical/atlas-sensor.c | 14 +- drivers/iio/dac/vf610_dac.c | 1 + drivers/iio/imu/st_lsm6dsx/st_lsm6dsx_shub.c | 7 +-- drivers/staging/greybus/uart.c | 4 ++-- drivers/staging/iio/resolver/ad2s1210.c | 17 - drivers/staging/kpc2000/kpc2000/core.c | 9 - drivers/staging/wfx/scan.c | 4 +++- 11 files changed, 61 insertions(+), 34 deletions(-) ___ devel mailing list de...@linuxdriverproject.org http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
[bug report] staging: vt6656: vnt_beacon_xmit use extra_tx_headroom.
Hello Malcolm Priestley,
The patch 9deca1e3e2b6: "staging: vt6656: vnt_beacon_xmit use
extra_tx_headroom." from May 16, 2020, leads to the following static
checker warning:
drivers/staging/vt6656/rxtx.c:729 vnt_beacon_xmit()
warn: struct type mismatch 'vnt_beacon_buffer vs vnt_tx_usb_header'
drivers/staging/vt6656/rxtx.c
660 static int vnt_beacon_xmit(struct vnt_private *priv, struct sk_buff
*skb)
661 {
662 struct vnt_beacon_buffer *beacon_buffer;
So far as I can see this could be declared as a "vnt_tx_usb_header".
The "vnt_tx_usb_header" is the first member of the "vnt_beacon_buffer"
beacon struct.
663 struct vnt_tx_short_buf_head *short_head;
664 struct ieee80211_tx_info *info;
665 struct vnt_usb_send_context *context;
666 struct ieee80211_mgmt *mgmt_hdr;
667 unsigned long flags;
668 u32 frame_size = skb->len + 4;
669 u16 current_rate, count;
670
671 spin_lock_irqsave(>lock, flags);
672
673 context = vnt_get_free_context(priv);
674 if (!context) {
675 dev_dbg(>usb->dev, "%s No free context!\n",
__func__);
676 spin_unlock_irqrestore(>lock, flags);
677 return -ENOMEM;
678 }
679
680 context->skb = skb;
681
682 spin_unlock_irqrestore(>lock, flags);
683
684 mgmt_hdr = (struct ieee80211_mgmt *)skb->data;
685 short_head = skb_push(skb, sizeof(*short_head));
686 count = skb->len;
687
688 if (priv->bb_type == BB_TYPE_11A) {
689 current_rate = RATE_6M;
690
691 /* Get SignalField,ServiceField,Length */
692 vnt_get_phy_field(priv, frame_size, current_rate,
693PK_TYPE_11A, _head->ab);
694
695 /* Get TimeStampOff */
696 short_head->time_stamp_off =
697 vnt_time_stamp_off(priv, current_rate);
698 } else {
699 current_rate = RATE_1M;
700 short_head->fifo_ctl |= cpu_to_le16(FIFOCTL_11B);
701
702 /* Get SignalField,ServiceField,Length */
703 vnt_get_phy_field(priv, frame_size, current_rate,
704PK_TYPE_11B, _head->ab);
705
706 /* Get TimeStampOff */
707 short_head->time_stamp_off =
708 vnt_time_stamp_off(priv, current_rate);
709 }
710
711 /* Get Duration */
712 short_head->duration = mgmt_hdr->duration;
713
714 /* time stamp always 0 */
715 mgmt_hdr->u.beacon.timestamp = 0;
716
717 info = IEEE80211_SKB_CB(skb);
718 if (info->flags & IEEE80211_TX_CTL_ASSIGN_SEQ) {
719 struct ieee80211_hdr *hdr = (struct ieee80211_hdr
*)mgmt_hdr;
720
721 hdr->duration_id = 0;
722 hdr->seq_ctrl = cpu_to_le16(priv->seq_counter << 4);
723 }
724
725 priv->seq_counter++;
726 if (priv->seq_counter > 0x0fff)
727 priv->seq_counter = 0;
728
729 beacon_buffer = skb_push(skb, sizeof(struct vnt_tx_usb_header));
730 beacon_buffer->usb.tx_byte_count = cpu_to_le16(count);
731 beacon_buffer->usb.pkt_no = context->pkt_no;
732 beacon_buffer->usb.type = 0x01;
We only need "beacon_buffer->usb".
733
734 context->type = CONTEXT_BEACON_PACKET;
735 context->tx_buffer = beacon_buffer;
^^
This is a void pointer.
736 context->buf_len = skb->len;
737
738 spin_lock_irqsave(>lock, flags);
739
740 if (vnt_tx_context(priv, context))
741 ieee80211_free_txskb(priv->hw, context->skb);
742
743 spin_unlock_irqrestore(>lock, flags);
744
745 return 0;
746 }
regards,
dan carpenter
___
devel mailing list
de...@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
Re: RTL8723BS driver doesn't work for,me but I can help testing
Resend html-format was inside email Am 21.05.2020 um 13:17 schrieb Tobias Baumann: Hi Martin first of all sorry for my short english writing Am 19.05.2020 um 22:16 schrieb Martin Blumenstingl: Hi Tobias, On Tue, May 19, 2020 at 8:21 AM Tobias Baumann<017623705...@o2online.de> wrote: good morning i got the new image from oleg(balbes150) 20200518 RC5 and some more feedback with my patch and oleg RC5 hotstart(shutdown now) do not work with my box ( wlan goes back to sleep mode always) I'm not sure what you mean here. if you run "shutdown now" then the system does not shut down and only wifi goes to sleep mode? i meant that after a reboot with "shutdown now" my box restart but the wifi chip is back in sleep mode , while the wifi chip was online befor the restart . with my patch chance 1 of 5 till 1 of 3 that my wlan is up and not sleep from cold start with oleg chance 1 of 2 till 1of 3 from cold start that wlan is up . (maybe because of phandle order?) i thing there is maybe a timming problem between wlan dis , sdio data and host wake up wlan . the power sequence driver supports the following two properties, see [0]: - post-power-on-delay-ms - power-off-delay-us Those are not set, meaning no delay is applied. For reference, these are the delays which are used on the Endless Mini (which also has a RTL8723BS module): [1] Do you know more about these delays (whether they are needed and how long they are supposed to be)? i read also the AP6330 and BCM4330 Datasheet for both of them is a start order inside the datashet ( i think that RTL8723BS should have same timming) . the time between 32k clock and WLAN_dis should be more than minimum 2 clock cycle (1/32kHZ * 2cycle = 0.06ms ) also that AP6330 has most identical pinout as RTL8723BS ( i did not get the pinout of BCM4330 because datasheet only has information to the chip and not the small extra pcb where the chip is mount) on Android 4.4 my box told me that GPIOAO_6 ist chip enable and GPIOX_11 ist wlan enable mybe a clue is that in the HArdkernel S805 Datasheet the GPIOAO_6 is also a 32k clock output (site 42 table 10 Func1 maybe (but i also found some Dts file from old S805 RTL8723bs box they use only GPIOX_11 and powerPin2 was comment out ) -> i have another question , do we use the same wifi.c file for the meson8m2 boxes as for endless mini ? i have taken a closer look at the file and the two delay information you are mention are not in the wifi. c is neither a function nor an instance, it just takes two fixed values "mdelay(200)" line 156 , furthermore we ignore the output level of wifi_power_gpio2 and automatically set it to "1" line 378 , so it is important which of the two pins is passed to the header file first (translate with DEEPL) <- it could be that GPIOAO_6 is the host wake up wlan ? is it possible to change the activation order for the gpio pins by change it in dts ? please check my previous mails. I think that GPIOX_21 is the wifi host wakeup pin because it is marked as "input" on the 3.10 kernel. you can change the order of the GPIOs inside the sdio_pwrseq node, but all GPIOs are managed together (meaning there's virtually no delay between enabling the first and the second one). I am not sure if using an MMC power sequence is the right thing to do, because the card is detected for me regardless of whether GPIOX_11 is HIGH or LOW. The RTL8723BS driver currently does not manage any GPIOs. Martin [0]https://github.com/torvalds/linux/blob/c477ebe21fabe0010a2ed324ce3a1762c757d867/Documentation/devicetree/bindings/mmc/mmc-pwrseq-simple.txt [1]https://github.com/endlessm/linux-meson/blob/4c76999c5c707fba9c390466efca093c3befa908/drivers/amlogic/wifi/wifi_dt.c#L153 You are right the chip has only wifi wake host and that should be GPIOX_21 as input ; maybe on your box the pin is alway high on the board ( direkt an 3.3V verdrahtet) thanks for the information Tobias -- Diese E-Mail wurde von AVG auf Viren geprüft. http://www.avg.com ___ devel mailing list de...@linuxdriverproject.org http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
