[driver-core:debugfs_remove_return_value] BUILD SUCCESS 636a3ba6ba05515c6a8627ab7d0009af118d0d51
tree/branch: https://git.kernel.org/pub/scm/linux/kernel/git/gregkh/driver-core.git debugfs_remove_return_value branch HEAD: 636a3ba6ba05515c6a8627ab7d0009af118d0d51 debugfs: remove return value of debugfs_create_bool() elapsed time: 724m configs tested: 123 configs skipped: 2 The following configs have been built successfully. More configs may be tested in the coming days. gcc tested configs: arm defconfig arm64allyesconfig arm64 defconfig arm allyesconfig arm allmodconfig powerpc64 defconfig mips pic32mzda_defconfig mips loongson1c_defconfig arm tct_hammer_defconfig armmvebu_v5_defconfig powerpcfsp2_defconfig arm ezx_defconfig sh landisk_defconfig powerpc tqm5200_defconfig xtensa common_defconfig h8300 defconfig sh se7619_defconfig powerpc mpc834x_mds_defconfig armspear6xx_defconfig pariscgeneric-32bit_defconfig armhisi_defconfig sparc64 alldefconfig powerpc asp8347_defconfig armrealview_defconfig arm h5000_defconfig ia64 bigsur_defconfig h8300 h8s-sim_defconfig mips tb0219_defconfig arm badge4_defconfig mips decstation_r4k_defconfig arm lpd270_defconfig powerpc tqm8xx_defconfig sh sh03_defconfig powerpc arches_defconfig arm tango4_defconfig powerpc mpc866_ads_defconfig arc defconfig arm gemini_defconfig m68kmvme147_defconfig mipsgpr_defconfig powerpcamigaone_defconfig sh sdk7786_defconfig shdreamcast_defconfig arm u8500_defconfig arm assabet_defconfig c6xevmc6472_defconfig xtensa alldefconfig microblaze defconfig sh se7705_defconfig mips cu1830-neo_defconfig arm imx_v6_v7_defconfig powerpc pseries_defconfig armmulti_v7_defconfig ia64 allmodconfig ia64defconfig ia64 allyesconfig m68k allmodconfig m68kdefconfig m68k allyesconfig nios2 defconfig arc allyesconfig nds32 allnoconfig c6x allyesconfig nds32 defconfig nios2allyesconfig cskydefconfig alpha defconfig alphaallyesconfig xtensa allyesconfig h8300allyesconfig sh allmodconfig parisc defconfig s390 allyesconfig s390 allmodconfig parisc allyesconfig s390defconfig i386 allyesconfig sparcallyesconfig sparc defconfig i386 tinyconfig i386defconfig mips allyesconfig mips allmodconfig powerpc allyesconfig powerpc allmodconfig powerpc allnoconfig i386 randconfig-a005-20210219 i386 randconfig-a003-20210219 i386 randconfig-a002-20210219 i386 randconfig-a004-20210219 i386 randconfig-a001-20210219 i386 randconfig-a006-20210219 x86_64 randconfig-a012-20210219 x86_64 randconfig-a016-20210219 x86_64 randconfig-a013-20210219 x86_64 randconfig-a015-20210219 x86_64 randconfig-a011-20210219 x86_64 randconfig-a014-20210219 i386 randconfig-a016-20210219 i386 randconfig-a012
[driver-core:driver-core-testing] BUILD SUCCESS 3e4c982f1ce75faf5314477b8da296d2d00919df
tree/branch: https://git.kernel.org/pub/scm/linux/kernel/git/gregkh/driver-core.git driver-core-testing branch HEAD: 3e4c982f1ce75faf5314477b8da296d2d00919df Revert "driver core: Set fw_devlink=on by default" elapsed time: 724m configs tested: 133 configs skipped: 3 The following configs have been built successfully. More configs may be tested in the coming days. gcc tested configs: arm defconfig arm64allyesconfig arm64 defconfig arm allyesconfig arm allmodconfig powerpc64 defconfig mips pic32mzda_defconfig mips loongson1c_defconfig powerpc pseries_defconfig arm tct_hammer_defconfig armmvebu_v5_defconfig powerpcfsp2_defconfig arm ezx_defconfig sh landisk_defconfig powerpc tqm5200_defconfig xtensa common_defconfig h8300 defconfig sh se7619_defconfig powerpc mpc834x_mds_defconfig sh kfr2r09-romimage_defconfig mipsqi_lb60_defconfig powerpc holly_defconfig arm simpad_defconfig arc nsimosci_hs_defconfig sh se7206_defconfig arm imx_v6_v7_defconfig sh microdev_defconfig powerpc rainier_defconfig arcnsim_700_defconfig sh rts7751r2dplus_defconfig armspear6xx_defconfig pariscgeneric-32bit_defconfig armhisi_defconfig sparc64 alldefconfig powerpc asp8347_defconfig armrealview_defconfig arm h5000_defconfig ia64 bigsur_defconfig h8300 h8s-sim_defconfig mips tb0219_defconfig arm badge4_defconfig mips decstation_r4k_defconfig arm lpd270_defconfig powerpc tqm8xx_defconfig sh sh03_defconfig powerpc arches_defconfig arm tango4_defconfig ia64defconfig powerpc mpc866_ads_defconfig arc defconfig arm gemini_defconfig m68kmvme147_defconfig mipsgpr_defconfig powerpcamigaone_defconfig sh sdk7786_defconfig shdreamcast_defconfig arm u8500_defconfig arm assabet_defconfig c6xevmc6472_defconfig xtensa alldefconfig microblaze defconfig sh se7705_defconfig mips cu1830-neo_defconfig armmulti_v7_defconfig ia64 allmodconfig ia64 allyesconfig m68k allmodconfig m68kdefconfig m68k allyesconfig nios2 defconfig arc allyesconfig nds32 allnoconfig c6x allyesconfig nds32 defconfig nios2allyesconfig cskydefconfig alpha defconfig alphaallyesconfig xtensa allyesconfig h8300allyesconfig sh allmodconfig parisc defconfig s390 allyesconfig s390 allmodconfig parisc allyesconfig s390defconfig i386 allyesconfig sparcallyesconfig sparc defconfig i386 tinyconfig i386defconfig mips allyesconfig mips allmodconfig powerpc allyesconfig powerpc allmodconfig powerpc allnoconfig i386 randconfig-a005-20210219 i386 randconfig-a003-20210219 i386 randconfig-a002-20210219 i386 randconfig-a004-202
Re: [PATCH] Staging: rtl8192e: fix kconfig dependency on CRYPTO
On Fri, Feb 19, 2021 at 06:14:57PM -0500, Julian Braha wrote: > commit 1a3f343027d7f5a6475a019aa20be89795b8c8e0 > Author: Julian Braha > Date: Fri Feb 19 17:02:24 2021 -0500 > > staging: rtl8192e: fix kconfig dependency on CRYPTO > > When RTLLIB_CRYPTO_TKIP is enabled and CRYPTO is disabled, > Kbuild gives the following warning: > > WARNING: unmet direct dependencies detected for CRYPTO_MICHAEL_MIC > Depends on [n]: CRYPTO [=n] > Selected by [m]: > - RTLLIB_CRYPTO_TKIP [=m] && STAGING [=y] && RTLLIB [=m] > > WARNING: unmet direct dependencies detected for CRYPTO_LIB_ARC4 > Depends on [n]: CRYPTO [=n] > Selected by [m]: > - RTLLIB_CRYPTO_TKIP [=m] && STAGING [=y] && RTLLIB [=m] > - RTLLIB_CRYPTO_WEP [=m] && STAGING [=y] && RTLLIB [=m] > > This is because RTLLIB_CRYPTO_TKIP selects CRYPTO_MICHAEL_MIC and > CRYPTO_LIB_ARC4, > without depending on or selecting CRYPTO, despite those config options > being subordinate to CRYPTO. > > Signed-off-by: Julian Braha > > diff --git a/drivers/staging/rtl8192e/Kconfig > b/drivers/staging/rtl8192e/Kconfig > index 03fcc23516fd..6e7d84ac06f5 100644 > --- a/drivers/staging/rtl8192e/Kconfig > +++ b/drivers/staging/rtl8192e/Kconfig > @@ -26,6 +26,7 @@ config RTLLIB_CRYPTO_CCMP > config RTLLIB_CRYPTO_TKIP > tristate "Support for rtllib TKIP crypto" > depends on RTLLIB > + select CRYPTO > select CRYPTO_LIB_ARC4 > select CRYPTO_MICHAEL_MIC > default y Odd indentation :( ___ devel mailing list de...@linuxdriverproject.org http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
Low-Cost Loans for SMEs & Investment Funding.
Spam detection software, running on the system "smtp1.osuosl.org", has identified this incoming email as possible spam. The original message has been attached to this so you can view it or label similar future email. If you have any questions, see the administrator of that system for details. Content preview: My name is Nicholas Toms, an investment portfolio manage. We offer the right loan Investment funding with low interest to finance your business or project ranging from US$1M to US$2BIllion. Kindly con [...] Content analysis details: (10.3 points, 5.0 required) pts rule name description -- -- 1.5 RCVD_IN_SORBS_WEB RBL: SORBS: sender is an abusable web server [103.99.1.174 listed in dnsbl.sorbs.net] 2.6 RCVD_IN_SBLRBL: Received via a relay in Spamhaus SBL [103.99.1.174 listed in zen.spamhaus.org] 0.0 SPF_HELO_NONE SPF: HELO does not publish an SPF Record -0.0 SPF_PASS SPF: sender matches SPF record 0.0 LOTS_OF_MONEY Huge... sums of money 1.3 RDNS_NONE Delivered to internal network by a host with no rDNS 0.1 MISSING_MIDMissing Message-Id: header 2.5 FREEMAIL_FORGED_REPLYTO Freemail in Reply-To, but not From 2.1 MONEY_NOHTML Lots of money in plain text 0.1 MONEY_FREEMAIL_REPTO Lots of money from someone using free email? --- Begin Message --- My name is Nicholas Toms, an investment portfolio manage. We offer the right loan Investment funding with low interest to finance your business or project ranging from US$1M to US$2BIllion. Kindly contact me for more details as I am open to questions. Sincerely, Nicholas Toms --- End Message --- ___ devel mailing list de...@linuxdriverproject.org http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
Low-Cost Loans for SMEs & Investment Funding.
Spam detection software, running on the system "smtp3.osuosl.org", has identified this incoming email as possible spam. The original message has been attached to this so you can view it or label similar future email. If you have any questions, see the administrator of that system for details. Content preview: My name is Nicholas Toms, an investment portfolio manage. We offer the right loan Investment funding with low interest to finance your business or project ranging from US$1M to US$2BIllion. Kindly con [...] Content analysis details: (8.1 points, 5.0 required) pts rule name description -- -- 0.8 BAYES_50 BODY: Bayes spam probability is 40 to 60% [score: 0.5005] 0.1 RCVD_IN_SBLRBL: Received via a relay in Spamhaus SBL [103.99.1.174 listed in zen.spamhaus.org] 0.0 SPF_HELO_NONE SPF: HELO does not publish an SPF Record -0.0 SPF_PASS SPF: sender matches SPF record 1.5 RCVD_IN_SORBS_WEB RBL: SORBS: sender is an abusable web server [103.99.1.174 listed in dnsbl.sorbs.net] 0.0 LOTS_OF_MONEY Huge... sums of money 0.5 MISSING_MIDMissing Message-Id: header 0.8 RDNS_NONE Delivered to internal network by a host with no rDNS 2.1 FREEMAIL_FORGED_REPLYTO Freemail in Reply-To, but not From 2.1 MONEY_NOHTML Lots of money in plain text 0.1 MONEY_FREEMAIL_REPTO Lots of money from someone using free email? --- Begin Message --- My name is Nicholas Toms, an investment portfolio manage. We offer the right loan Investment funding with low interest to finance your business or project ranging from US$1M to US$2BIllion. Kindly contact me for more details as I am open to questions. Sincerely, Nicholas Toms --- End Message --- ___ devel mailing list de...@linuxdriverproject.org http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
Low-Cost Loans for SMEs & Investment Funding.
My name is Nicholas Toms, an investment portfolio manage. We offer the right loan Investment funding with low interest to finance your business or project ranging from US$1M to US$2BIllion. Kindly contact me for more details as I am open to questions. Sincerely, Nicholas Toms ___ devel mailing list de...@linuxdriverproject.org http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
[PATCH] Staging: rtl8192e: fix kconfig dependency on CRYPTO
commit 1a3f343027d7f5a6475a019aa20be89795b8c8e0 Author: Julian Braha Date: Fri Feb 19 17:02:24 2021 -0500 staging: rtl8192e: fix kconfig dependency on CRYPTO When RTLLIB_CRYPTO_TKIP is enabled and CRYPTO is disabled, Kbuild gives the following warning: WARNING: unmet direct dependencies detected for CRYPTO_MICHAEL_MIC Depends on [n]: CRYPTO [=n] Selected by [m]: - RTLLIB_CRYPTO_TKIP [=m] && STAGING [=y] && RTLLIB [=m] WARNING: unmet direct dependencies detected for CRYPTO_LIB_ARC4 Depends on [n]: CRYPTO [=n] Selected by [m]: - RTLLIB_CRYPTO_TKIP [=m] && STAGING [=y] && RTLLIB [=m] - RTLLIB_CRYPTO_WEP [=m] && STAGING [=y] && RTLLIB [=m] This is because RTLLIB_CRYPTO_TKIP selects CRYPTO_MICHAEL_MIC and CRYPTO_LIB_ARC4, without depending on or selecting CRYPTO, despite those config options being subordinate to CRYPTO. Signed-off-by: Julian Braha diff --git a/drivers/staging/rtl8192e/Kconfig b/drivers/staging/rtl8192e/Kconfig index 03fcc23516fd..6e7d84ac06f5 100644 --- a/drivers/staging/rtl8192e/Kconfig +++ b/drivers/staging/rtl8192e/Kconfig @@ -26,6 +26,7 @@ config RTLLIB_CRYPTO_CCMP config RTLLIB_CRYPTO_TKIP tristate "Support for rtllib TKIP crypto" depends on RTLLIB + select CRYPTO select CRYPTO_LIB_ARC4 select CRYPTO_MICHAEL_MIC default y ___ devel mailing list de...@linuxdriverproject.org http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
[PATCH v3] staging: rtl8723bs: fix code style comparison warning
checkpatch gives the following WARNING:
WARNING: Comparisons should place the constant on the right side of the test
this patch fixes the coding style warning.
Signed-off-by: Kurt Manucredo
---
changes since previous version:
- put version chatter below the --- cut off line.
thank you very much for your help Mr. Dan Carpenter.
drivers/staging/rtl8723bs/core/rtw_wlan_util.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/staging/rtl8723bs/core/rtw_wlan_util.c
b/drivers/staging/rtl8723bs/core/rtw_wlan_util.c
index 975f2830e29e..96feced698ac 100644
--- a/drivers/staging/rtl8723bs/core/rtw_wlan_util.c
+++ b/drivers/staging/rtl8723bs/core/rtw_wlan_util.c
@@ -2146,7 +2146,7 @@ void rtw_get_sec_iv(struct adapter *padapter, u8
*pcur_dot11txpn, u8 *StaAddr)
struct security_priv *psecpriv = >securitypriv;
memset(pcur_dot11txpn, 0, 8);
- if (NULL == StaAddr)
+ if (!StaAddr)
return;
psta = rtw_get_stainfo(>stapriv, StaAddr);
DBG_871X("%s(): StaAddr: %02x %02x %02x %02x %02x %02x\n",
--
2.20.1
___
devel mailing list
de...@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
[PATCH] staging: gasket: removed unnecessary debug message to fix coding style warning
From: Ashish Vara
removed unnecessary out of memory message to fix coding style warning.
Signed-off-by: Ashish Vara
---
drivers/staging/gasket/gasket_page_table.c | 2 --
1 file changed, 2 deletions(-)
diff --git a/drivers/staging/gasket/gasket_page_table.c
b/drivers/staging/gasket/gasket_page_table.c
index 6f6273c83822..2dbf3d9b8f34 100644
--- a/drivers/staging/gasket/gasket_page_table.c
+++ b/drivers/staging/gasket/gasket_page_table.c
@@ -262,8 +262,6 @@ int gasket_page_table_init(struct gasket_page_table
**ppg_tbl,
if (bytes != 0) {
pg_tbl->entries = vzalloc(bytes);
if (!pg_tbl->entries) {
- dev_dbg(device,
- "No memory for address translation metadata\n");
kfree(pg_tbl);
*ppg_tbl = NULL;
return -ENOMEM;
--
2.25.1
___
devel mailing list
de...@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
[staging:staging-testing] BUILD SUCCESS 5fdd46f1d75e5d6f740faf26aa798fbd08a79029
allyesconfig powerpc allmodconfig powerpc allnoconfig i386 randconfig-a005-20210219 i386 randconfig-a003-20210219 i386 randconfig-a002-20210219 i386 randconfig-a004-20210219 i386 randconfig-a001-20210219 i386 randconfig-a006-20210219 x86_64 randconfig-a012-20210219 x86_64 randconfig-a016-20210219 x86_64 randconfig-a013-20210219 x86_64 randconfig-a015-20210219 x86_64 randconfig-a011-20210219 x86_64 randconfig-a014-20210219 i386 randconfig-a016-20210219 i386 randconfig-a012-20210219 i386 randconfig-a014-20210219 i386 randconfig-a013-20210219 i386 randconfig-a011-20210219 i386 randconfig-a015-20210219 riscvallyesconfig riscvnommu_virt_defconfig riscv allnoconfig riscv rv32_defconfig riscvallmodconfig x86_64 allyesconfig x86_64rhel-7.6-kselftests x86_64 defconfig x86_64 rhel-8.3 x86_64 rhel-8.3-kbuiltin x86_64 kexec clang tested configs: x86_64 randconfig-a003-20210219 x86_64 randconfig-a001-20210219 x86_64 randconfig-a004-20210219 x86_64 randconfig-a002-20210219 x86_64 randconfig-a005-20210219 x86_64 randconfig-a006-20210219 --- 0-DAY CI Kernel Test Service, Intel Corporation https://lists.01.org/hyperkitty/list/kbuild-...@lists.01.org ___ devel mailing list de...@linuxdriverproject.org http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
[PATCH 3/5] staging: rtl8192e: rename Reserved to reserved in delba_param_set union
This change uses lowercase for a field name to be more consistent with
the rest of the union.
Signed-off-by: William Durand
---
drivers/staging/rtl8192e/rtl819x_BA.h | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/staging/rtl8192e/rtl819x_BA.h
b/drivers/staging/rtl8192e/rtl819x_BA.h
index ae4f117c839b..a482cb3b081d 100644
--- a/drivers/staging/rtl8192e/rtl819x_BA.h
+++ b/drivers/staging/rtl8192e/rtl819x_BA.h
@@ -42,7 +42,7 @@ union delba_param_set {
u8 char_data[2];
u16 short_data;
struct {
- u16 Reserved:11;
+ u16 reserved:11;
u16 Initiator:1;
u16 TID:4;
} field;
--
2.30.0
___
devel mailing list
de...@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
[PATCH 2/5] staging: rtl8192e: rename shortData to short_data in delba_param_set union
Fixes a checkpatch CHECK message.
Signed-off-by: William Durand
---
drivers/staging/rtl8192e/rtl819x_BA.h | 2 +-
drivers/staging/rtl8192e/rtl819x_BAProc.c | 2 +-
2 files changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/staging/rtl8192e/rtl819x_BA.h
b/drivers/staging/rtl8192e/rtl819x_BA.h
index de41d2182ff5..ae4f117c839b 100644
--- a/drivers/staging/rtl8192e/rtl819x_BA.h
+++ b/drivers/staging/rtl8192e/rtl819x_BA.h
@@ -40,7 +40,7 @@ union ba_param_set {
union delba_param_set {
u8 char_data[2];
- u16 shortData;
+ u16 short_data;
struct {
u16 Reserved:11;
u16 Initiator:1;
diff --git a/drivers/staging/rtl8192e/rtl819x_BAProc.c
b/drivers/staging/rtl8192e/rtl819x_BAProc.c
index 1f697e87ae8d..46028f74776a 100644
--- a/drivers/staging/rtl8192e/rtl819x_BAProc.c
+++ b/drivers/staging/rtl8192e/rtl819x_BAProc.c
@@ -163,7 +163,7 @@ static struct sk_buff *rtllib_DELBA(struct rtllib_device
*ieee, u8 *dst,
*tag++ = ACT_DELBA;
- put_unaligned_le16(DelbaParamSet.shortData, tag);
+ put_unaligned_le16(DelbaParamSet.short_data, tag);
tag += 2;
put_unaligned_le16(ReasonCode, tag);
--
2.30.0
___
devel mailing list
de...@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
[PATCH 5/5] staging: rtl8192e: rename TID to tid in delba_param_set union
This change uses lowercase for a field name to be more consistent with
the rest of the union.
Signed-off-by: William Durand
---
drivers/staging/rtl8192e/rtl819x_BA.h | 2 +-
drivers/staging/rtl8192e/rtl819x_BAProc.c | 8
2 files changed, 5 insertions(+), 5 deletions(-)
diff --git a/drivers/staging/rtl8192e/rtl819x_BA.h
b/drivers/staging/rtl8192e/rtl819x_BA.h
index f94ce2d7d166..67574e26cdfc 100644
--- a/drivers/staging/rtl8192e/rtl819x_BA.h
+++ b/drivers/staging/rtl8192e/rtl819x_BA.h
@@ -44,7 +44,7 @@ union delba_param_set {
struct {
u16 reserved:11;
u16 initiator:1;
- u16 TID:4;
+ u16 tid:4;
} field;
};
diff --git a/drivers/staging/rtl8192e/rtl819x_BAProc.c
b/drivers/staging/rtl8192e/rtl819x_BAProc.c
index 3594d432b2a2..3455fd210372 100644
--- a/drivers/staging/rtl8192e/rtl819x_BAProc.c
+++ b/drivers/staging/rtl8192e/rtl819x_BAProc.c
@@ -142,7 +142,7 @@ static struct sk_buff *rtllib_DELBA(struct rtllib_device
*ieee, u8 *dst,
memset(, 0, 2);
DelbaParamSet.field.initiator = (TxRxSelect == TX_DIR) ? 1 : 0;
- DelbaParamSet.field.TID = pBA->BaParamSet.field.tid;
+ DelbaParamSet.field.tid = pBA->BaParamSet.field.tid;
skb = dev_alloc_skb(len + sizeof(struct rtllib_hdr_3addr));
if (!skb)
@@ -444,11 +444,11 @@ int rtllib_rx_DELBA(struct rtllib_device *ieee, struct
sk_buff *skb)
struct rx_ts_record *pRxTs;
if (!GetTs(ieee, (struct ts_common_info **), dst,
- (u8)pDelBaParamSet->field.TID, RX_DIR, false)) {
+ (u8)pDelBaParamSet->field.tid, RX_DIR, false)) {
netdev_warn(ieee->dev,
"%s(): can't get TS for RXTS. dst:%pM
TID:%d\n",
__func__, dst,
- (u8)pDelBaParamSet->field.TID);
+ (u8)pDelBaParamSet->field.tid);
return -1;
}
@@ -457,7 +457,7 @@ int rtllib_rx_DELBA(struct rtllib_device *ieee, struct
sk_buff *skb)
struct tx_ts_record *pTxTs;
if (!GetTs(ieee, (struct ts_common_info **), dst,
- (u8)pDelBaParamSet->field.TID, TX_DIR, false)) {
+ (u8)pDelBaParamSet->field.tid, TX_DIR, false)) {
netdev_warn(ieee->dev, "%s(): can't get TS for TXTS\n",
__func__);
return -1;
--
2.30.0
___
devel mailing list
de...@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
[PATCH 4/5] staging: rtl8192e: rename Initiator to initiator in delba_param_set union
Fixes a checkpatch CHECK message.
Signed-off-by: William Durand
---
drivers/staging/rtl8192e/rtl819x_BA.h | 2 +-
drivers/staging/rtl8192e/rtl819x_BAProc.c | 4 ++--
2 files changed, 3 insertions(+), 3 deletions(-)
diff --git a/drivers/staging/rtl8192e/rtl819x_BA.h
b/drivers/staging/rtl8192e/rtl819x_BA.h
index a482cb3b081d..f94ce2d7d166 100644
--- a/drivers/staging/rtl8192e/rtl819x_BA.h
+++ b/drivers/staging/rtl8192e/rtl819x_BA.h
@@ -43,7 +43,7 @@ union delba_param_set {
u16 short_data;
struct {
u16 reserved:11;
- u16 Initiator:1;
+ u16 initiator:1;
u16 TID:4;
} field;
};
diff --git a/drivers/staging/rtl8192e/rtl819x_BAProc.c
b/drivers/staging/rtl8192e/rtl819x_BAProc.c
index 46028f74776a..3594d432b2a2 100644
--- a/drivers/staging/rtl8192e/rtl819x_BAProc.c
+++ b/drivers/staging/rtl8192e/rtl819x_BAProc.c
@@ -141,7 +141,7 @@ static struct sk_buff *rtllib_DELBA(struct rtllib_device
*ieee, u8 *dst,
memset(, 0, 2);
- DelbaParamSet.field.Initiator = (TxRxSelect == TX_DIR) ? 1 : 0;
+ DelbaParamSet.field.initiator = (TxRxSelect == TX_DIR) ? 1 : 0;
DelbaParamSet.field.TID = pBA->BaParamSet.field.tid;
skb = dev_alloc_skb(len + sizeof(struct rtllib_hdr_3addr));
@@ -440,7 +440,7 @@ int rtllib_rx_DELBA(struct rtllib_device *ieee, struct
sk_buff *skb)
dst = (u8 *)(>addr2[0]);
pDelBaParamSet = (union delba_param_set *)>payload[2];
- if (pDelBaParamSet->field.Initiator == 1) {
+ if (pDelBaParamSet->field.initiator == 1) {
struct rx_ts_record *pRxTs;
if (!GetTs(ieee, (struct ts_common_info **), dst,
--
2.30.0
___
devel mailing list
de...@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
[PATCH 1/5] staging: rtl8192e: rename charData to char_data in delba_param_set union
Fixes a checkpatch CHECK message.
Signed-off-by: William Durand
---
drivers/staging/rtl8192e/rtl819x_BA.h | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/staging/rtl8192e/rtl819x_BA.h
b/drivers/staging/rtl8192e/rtl819x_BA.h
index 36280c62fa56..de41d2182ff5 100644
--- a/drivers/staging/rtl8192e/rtl819x_BA.h
+++ b/drivers/staging/rtl8192e/rtl819x_BA.h
@@ -39,7 +39,7 @@ union ba_param_set {
};
union delba_param_set {
- u8 charData[2];
+ u8 char_data[2];
u16 shortData;
struct {
u16 Reserved:11;
--
2.30.0
___
devel mailing list
de...@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
[PATCH 0/5] staging: rtl8192e: delba_param_set union cleanups
This patchset fixes the checkpatch issues related to the `delba_param_set` union defined in `rtl8192e/rtl819x_BA.h` (avoid camelcase). William Durand (5): staging: rtl8192e: rename charData to char_data in delba_param_set union staging: rtl8192e: rename shortData to short_data in delba_param_set union staging: rtl8192e: rename Reserved to reserved in delba_param_set union staging: rtl8192e: rename Initiator to initiator in delba_param_set union staging: rtl8192e: rename TID to tid in delba_param_set union drivers/staging/rtl8192e/rtl819x_BA.h | 10 +- drivers/staging/rtl8192e/rtl819x_BAProc.c | 14 +++--- 2 files changed, 12 insertions(+), 12 deletions(-) -- 2.30.0 ___ devel mailing list de...@linuxdriverproject.org http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
[PATCH] staging: wimax: Fix block comment style issue in stack.c
This change fixes a checkpatch warning for "Block comments
use * on subsequent lines".
Signed-off-by: Amrit Khera
---
drivers/staging/wimax/stack.c | 11 ++-
1 file changed, 6 insertions(+), 5 deletions(-)
diff --git a/drivers/staging/wimax/stack.c b/drivers/staging/wimax/stack.c
index ace24a6dfd2d..78142615 100644
--- a/drivers/staging/wimax/stack.c
+++ b/drivers/staging/wimax/stack.c
@@ -62,11 +62,12 @@ MODULE_PARM_DESC(debug,
* close to where the data is generated.
*/
/*
-static const struct nla_policy wimax_gnl_re_status_change[WIMAX_GNL_ATTR_MAX +
1] = {
- [WIMAX_GNL_STCH_STATE_OLD] = { .type = NLA_U8 },
- [WIMAX_GNL_STCH_STATE_NEW] = { .type = NLA_U8 },
-};
-*/
+ * static const struct nla_policy
+ * wimax_gnl_re_status_change[WIMAX_GNL_ATTR_MAX + 1] = {
+ * [WIMAX_GNL_STCH_STATE_OLD] = { .type = NLA_U8 },
+ * [WIMAX_GNL_STCH_STATE_NEW] = { .type = NLA_U8 },
+ * };
+ */
/*
--
2.20.1
___
devel mailing list
de...@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
[PATCH v2] staging: rtl8723bs: fix code style comparison warning
changes since previous version:
- change Subject line
- change commit message
- change commit message position to above signed-off-by
checkpatch gives the following WARNING:
WARNING: Comparisons should place the constant on the right side of the test
this patch fixes the coding style warning.
Signed-off-by: Kurt Manucredo
---
drivers/staging/rtl8723bs/core/rtw_wlan_util.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/staging/rtl8723bs/core/rtw_wlan_util.c
b/drivers/staging/rtl8723bs/core/rtw_wlan_util.c
index 975f2830e29e..96feced698ac 100644
--- a/drivers/staging/rtl8723bs/core/rtw_wlan_util.c
+++ b/drivers/staging/rtl8723bs/core/rtw_wlan_util.c
@@ -2146,7 +2146,7 @@ void rtw_get_sec_iv(struct adapter *padapter, u8
*pcur_dot11txpn, u8 *StaAddr)
struct security_priv *psecpriv = >securitypriv;
memset(pcur_dot11txpn, 0, 8);
- if (NULL == StaAddr)
+ if (!StaAddr)
return;
psta = rtw_get_stainfo(>stapriv, StaAddr);
DBG_871X("%s(): StaAddr: %02x %02x %02x %02x %02x %02x\n",
--
2.20.1
___
devel mailing list
de...@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
Re: [PATCH v2] staging: rtl8723bs: fix code style comparison warning
On Fri, Feb 19, 2021 at 02:50:53PM +, Kurt Manucredo wrote: > > > changes since previous version: > - change Subject line > - change commit message > - change commit message position to above signed-off-by This all goes below the --- line please. Please make a v3. thanks, greg k-h ___ devel mailing list de...@linuxdriverproject.org http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
[PATCH] staging: gasket Fix comparison with Null
From: Mayank Suman
Comparison with NULL is redundant
as pointer will evaluate to true if is non-NULL.
The change was suggested by checkpatch.pl.
Signed-off-by: Mayank Suman
---
drivers/staging/gasket/gasket_sysfs.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/staging/gasket/gasket_sysfs.c
b/drivers/staging/gasket/gasket_sysfs.c
index af26bc9f1..c5658fdf4 100644
--- a/drivers/staging/gasket/gasket_sysfs.c
+++ b/drivers/staging/gasket/gasket_sysfs.c
@@ -228,7 +228,7 @@ int gasket_sysfs_create_entries(struct device *device,
}
mutex_lock(>mutex);
- for (i = 0; attrs[i].attr.attr.name != NULL; i++) {
+ for (i = 0; attrs[i].attr.attr.name; i++) {
if (mapping->attribute_count == GASKET_SYSFS_MAX_NODES) {
dev_err(device,
"Maximum number of sysfs nodes reached for
device\n");
--
2.30.0
___
devel mailing list
de...@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
Re: [PATCH v2] staging: rtl8723bs: fix code style comparison warning
On Fri, Feb 19, 2021 at 02:50:53PM +, Kurt Manucredo wrote: > > > changes since previous version: > - change Subject line > - change commit message > - change commit message position to above signed-off-by > These comments need to go below the --- cut off line. > checkpatch gives the following WARNING: > WARNING: Comparisons should place the constant on the right side of the test > this patch fixes the coding style warning. > > Signed-off-by: Kurt Manucredo > --- ^^^ This one here. > drivers/staging/rtl8723bs/core/rtw_wlan_util.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > regards, dan carpenter ___ devel mailing list de...@linuxdriverproject.org http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
[PATCH] staging: octeon: cleanup unnecessary parentheses in ethernet-spmi.c
checkpatch.pl reported issue of unnecessary parentheses for the
expression. It has been removed to fix the report.
Signed-off-by: Shreesh Adiga <16567adigashre...@gmail.com>
---
drivers/staging/octeon/ethernet-spi.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/staging/octeon/ethernet-spi.c
b/drivers/staging/octeon/ethernet-spi.c
index c582403e6a1f..699c98c5ec13 100644
--- a/drivers/staging/octeon/ethernet-spi.c
+++ b/drivers/staging/octeon/ethernet-spi.c
@@ -202,7 +202,7 @@ int cvm_oct_spi_init(struct net_device *dev)
}
number_spi_ports++;
- if ((priv->port == 0) || (priv->port == 16)) {
+ if (priv->port == 0 || priv->port == 16) {
cvm_oct_spi_enable_error_reporting(INTERFACE(priv->port));
priv->poll = cvm_oct_spi_poll;
}
--
2.30.0
___
devel mailing list
de...@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
[PATCH v3 02/02] staging: kpc2000: code style: fix alignment issues
This patch fixes the following checkpatch.pl warning: WARNING: line length of 124 exceeds 100 columns in file kpc2000_i2c.c Signed-off-by: Nikolay Kyx --- Additionally some style warnings remain valid here and could be fixed by another patch. v2: Edited changelog, as suggested by Greg KH v3: Splitted patch in two parts, as suggested by Greg KH drivers/staging/kpc2000/kpc2000_i2c.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/drivers/staging/kpc2000/kpc2000_i2c.c b/drivers/staging/kpc2000/kpc2000_i2c.c index 25bb5c97dd21..68f5ec000365 100644 --- a/drivers/staging/kpc2000/kpc2000_i2c.c +++ b/drivers/staging/kpc2000/kpc2000_i2c.c @@ -200,7 +200,9 @@ static int i801_check_post(struct kpc_i2c *priv, int status, int timeout) outb_p(status & STATUS_FLAGS, SMBHSTSTS(priv)); status = inb_p(SMBHSTSTS(priv)) & STATUS_FLAGS; if (status) - dev_warn(>adapter.dev, "Failed clearing status flags at end of transaction (%02x)\n", status); + dev_warn(>adapter.dev, +"Failed clearing status flags at end of transaction (%02x)\n", +status); } return result; -- 2.30.1 ___ devel mailing list de...@linuxdriverproject.org http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
[PATCH v3 01/02] staging: kpc2000: code style: fix alignment issues
This patch fixes the following checkpatch.pl check:
CHECK: Alignment should match open parenthesis
in files kpc2000_i2c.c kpc2000_spi.c
Signed-off-by: Nikolay Kyx
---
Additionally some style warnings remain valid here and could be fixed by
another patch.
v2: Edited changelog, as suggested by Greg KH
v3: Splitted patch in two parts, as suggested by Greg KH
drivers/staging/kpc2000/kpc2000_i2c.c | 2 +-
drivers/staging/kpc2000/kpc2000_spi.c | 2 +-
2 files changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/staging/kpc2000/kpc2000_i2c.c
b/drivers/staging/kpc2000/kpc2000_i2c.c
index 25bb5c97dd21..3f1f833d3b51 100644
--- a/drivers/staging/kpc2000/kpc2000_i2c.c
+++ b/drivers/staging/kpc2000/kpc2000_i2c.c
@@ -269,7 +269,7 @@ static int i801_block_transaction_by_block(struct kpc_i2c
*priv,
}
status = i801_transaction(priv,
- I801_BLOCK_DATA | ENABLE_INT9 | I801_PEC_EN * hwpec);
+ I801_BLOCK_DATA | ENABLE_INT9 | I801_PEC_EN *
hwpec);
if (status)
return status;
diff --git a/drivers/staging/kpc2000/kpc2000_spi.c
b/drivers/staging/kpc2000/kpc2000_spi.c
index 44017d523da5..16ca18b8aa15 100644
--- a/drivers/staging/kpc2000/kpc2000_spi.c
+++ b/drivers/staging/kpc2000/kpc2000_spi.c
@@ -465,7 +465,7 @@ kp_spi_probe(struct platform_device *pldev)
}
kpspi->base = devm_ioremap(>dev, r->start,
- resource_size(r));
+ resource_size(r));
status = spi_register_master(master);
if (status < 0) {
--
2.30.1
___
devel mailing list
de...@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
[PATCH v3] staging: fwserial: match alignment with open parenthesis
This patch fixes the following checkpatch.pl check:
CHECK: Alignment should match open parenthesis
in file fwserial.c
Signed-off-by: Nikolay Kyx
---
Additionally some style warnings remain valid here and could be fixed by
another patch.
v2: Edited changelog, as suggested by Greg KH
v3: Moved comment about remaining warnings under the cut-off line,
as suggested by Dan Carpenter
drivers/staging/fwserial/fwserial.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/staging/fwserial/fwserial.c
b/drivers/staging/fwserial/fwserial.c
index c368082aae1a..137e97c9406c 100644
--- a/drivers/staging/fwserial/fwserial.c
+++ b/drivers/staging/fwserial/fwserial.c
@@ -1318,8 +1318,8 @@ static int fwtty_break_ctl(struct tty_struct *tty, int
state)
if (state == -1) {
set_bit(STOP_TX, >flags);
ret = wait_event_interruptible_timeout(port->wait_tx,
- !test_bit(IN_TX, >flags),
- 10);
+ !test_bit(IN_TX,
>flags),
+ 10);
if (ret == 0 || ret == -ERESTARTSYS) {
clear_bit(STOP_TX, >flags);
fwtty_restart_tx(port);
--
2.30.1
___
devel mailing list
de...@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
[PATCH v5 2/2] staging: rtl8192u: remove unnecessary return in r8190_rtl8256.c
remove the unnecessary return at the end of function phy_set_rf8256_ofdm_tx_power(), reported by scripts/checkpatch.pl. Signed-off-by: Du Cheng --- drivers/staging/rtl8192u/r8190_rtl8256.c | 1 - 1 file changed, 1 deletion(-) diff --git a/drivers/staging/rtl8192u/r8190_rtl8256.c b/drivers/staging/rtl8192u/r8190_rtl8256.c index 3e6bd6caf9da..54747fda552f 100644 --- a/drivers/staging/rtl8192u/r8190_rtl8256.c +++ b/drivers/staging/rtl8192u/r8190_rtl8256.c @@ -291,5 +291,4 @@ void phy_set_rf8256_ofdm_tx_power(struct net_device *dev, u8 powerlevel) } rtl8192_setBBreg(dev, RegOffset[index], 0x7f7f7f7f, writeVal); } - return; } -- 2.27.0 ___ devel mailing list de...@linuxdriverproject.org http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
[PATCH v5 1/2] staging: rtl8192u: fix RT_TRACE() in r8190_rtl8256.c
use MACRO __func__ instead of the literal names for RT_TRACE()
in phy_set_rf8256_bandwidth() and phy_rf8256_config_para_file(),
as reported by scripts/checkpatch.pl.
Signed-off-by: Du Cheng
---
changes v5:
* fixed subject lines to be distinct and more specific
changes v4:
* merge two similar patches into 1
changes v3:
* break up changes into 3 patches
changes v2:
* improvedescription
changes v1:
* fix coding style
drivers/staging/rtl8192u/r8190_rtl8256.c | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/drivers/staging/rtl8192u/r8190_rtl8256.c
b/drivers/staging/rtl8192u/r8190_rtl8256.c
index fee3bfb99075..3e6bd6caf9da 100644
--- a/drivers/staging/rtl8192u/r8190_rtl8256.c
+++ b/drivers/staging/rtl8192u/r8190_rtl8256.c
@@ -73,11 +73,11 @@ void phy_set_rf8256_bandwidth(struct net_device *dev, enum
ht_channel_width Band
else
rtl8192_phy_SetRFReg(dev, (enum
rf90_radio_path_e)eRFPath, 0x14, bMask12Bits, 0x5ab);
} else {
- RT_TRACE(COMP_ERR,
"phy_set_rf8256_bandwidth(): unknown hardware version\n");
+ RT_TRACE(COMP_ERR, "%s(): unknown
hardware version\n", __func__);
}
break;
default:
- RT_TRACE(COMP_ERR, "phy_set_rf8256_bandwidth():
unknown Bandwidth: %#X\n", Bandwidth);
+ RT_TRACE(COMP_ERR, "%s(): unknown Bandwidth:
%#X\n", __func__, Bandwidth);
break;
}
}
@@ -213,7 +213,7 @@ static void phy_rf8256_config_para_file(struct net_device
*dev)
}
if (ret) {
- RT_TRACE(COMP_ERR,
"phy_rf8256_config_para_file():Radio[%d] Fail!!", eRFPath);
+ RT_TRACE(COMP_ERR, "%s():Radio[%d] Fail!!", __func__,
eRFPath);
goto phy_RF8256_Config_ParaFile_Fail;
}
}
--
2.27.0
___
devel mailing list
de...@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
[PATCH] staging: greybus: Fix blank line style issue in sdio.c
This change fixes a checkpatch check for "Please don't use
multiple blank lines".
Signed-off-by: Amrit Khera
---
drivers/staging/greybus/sdio.c | 1 -
1 file changed, 1 deletion(-)
diff --git a/drivers/staging/greybus/sdio.c b/drivers/staging/greybus/sdio.c
index 0939f4a4c963..37bf04c22dbc 100644
--- a/drivers/staging/greybus/sdio.c
+++ b/drivers/staging/greybus/sdio.c
@@ -33,7 +33,6 @@ struct gb_sdio_host {
boolread_only;
};
-
#define GB_SDIO_RSP_R1_R5_R6_R7(GB_SDIO_RSP_PRESENT | GB_SDIO_RSP_CRC
| \
GB_SDIO_RSP_OPCODE)
#define GB_SDIO_RSP_R3_R4 (GB_SDIO_RSP_PRESENT)
--
2.20.1
___
devel mailing list
de...@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
[PATCH] staging: hikey9xx: Fix space tab style warnings
This patch fixes the checkpatch warnings such as:
hi6421-spmi-pmic.c:51: WARNING: please, no space before tabs
Signed-off-by: Lee Gibson
---
drivers/staging/hikey9xx/hi6421-spmi-pmic.c | 8
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/drivers/staging/hikey9xx/hi6421-spmi-pmic.c
b/drivers/staging/hikey9xx/hi6421-spmi-pmic.c
index 4ebcfea9f3bf..626140cb96f2 100644
--- a/drivers/staging/hikey9xx/hi6421-spmi-pmic.c
+++ b/drivers/staging/hikey9xx/hi6421-spmi-pmic.c
@@ -48,9 +48,9 @@ enum hi6421_spmi_pmic_irq_list {
/*
* The IRQs are mapped as:
*
- * == = =
- * IRQ MASK REGISTER IRQ REGISTERBIT
- * == = =
+ * == = =
+ * IRQ MASK REGISTER IRQ REGISTERBIT
+ * == = =
* OTMP0x0202 0x212 bit 0
* VBUS_CONNECT0x0202 0x212 bit 1
* VBUS_DISCONNECT 0x0202 0x212 bit 2
@@ -66,7 +66,7 @@ enum hi6421_spmi_pmic_irq_list {
* SIM0_HPD_F 0x0203 0x213 bit 3
* SIM1_HPD_R 0x0203 0x213 bit 4
* SIM1_HPD_F 0x0203 0x213 bit 5
- * == = =
+ * == = =
*/
#define SOC_PMIC_IRQ_MASK_0_ADDR 0x0202
#define SOC_PMIC_IRQ0_ADDR 0x0212
--
2.25.1
___
devel mailing list
de...@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
Re: [PATCH v2] staging: android: Fix const keyword style issue in ashmem.c
On Fri, Feb 19, 2021 at 01:12:49PM +0100, Greg KH wrote: > On Fri, Feb 19, 2021 at 05:12:38PM +0530, Amrit Khera wrote: > > This change fixes a checkpatch warning for "struct file_operations > > should normally be const". > > > > Signed-off-by: Amrit Khera > > --- > > Changes in v2: > > - Wrapped the commit description > > - Build tested > > If you tested it, what changed in the diff itself? Looks the same to > me... > After further investigating I found that the particular kernel module was not set in the config file. This did not build it when I built the kernel. This was making me think that the module was building correctly. After updating the config, the build indeed breaks. The reason is that the const keyword cannot be applied here without changing the structure and flow of the code as the particular variable is later being set in a condition. Hence, I will be dropping this path for now. Apologies for the inconvenience caused and thank you for the prompt replies. Best Regards, Amrit Khera ___ devel mailing list de...@linuxdriverproject.org http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
Re: [PATCH v2] staging: fwserial: fix alignment of function parameters
On Fri, Feb 19, 2021 at 04:21:12PM +0530, Prakash Dubey wrote:
> This patch fixes the following checkpatch.pl check:
>
> CHECK: Alignment should match open parenthesis
>
> Signed-off-by: Prakash Dubey
> ---
> drivers/staging/fwserial/fwserial.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/staging/fwserial/fwserial.c
> b/drivers/staging/fwserial/fwserial.c
> index a92741b8b6c6..137e97c9406c 100644
> --- a/drivers/staging/fwserial/fwserial.c
> +++ b/drivers/staging/fwserial/fwserial.c
> @@ -1318,8 +1318,8 @@ static int fwtty_break_ctl(struct tty_struct *tty, int
> state)
> if (state == -1) {
> set_bit(STOP_TX, >flags);
> ret = wait_event_interruptible_timeout(port->wait_tx,
> - !test_bit(IN_TX,
> >flags),
> - 10);
> +!test_bit(IN_TX,
> >flags),
> +10);
> if (ret == 0 || ret == -ERESTARTSYS) {
> clear_bit(STOP_TX, >flags);
> fwtty_restart_tx(port);
> --
> 2.25.1
Does not apply to my tree at all, please be sure to always work off of
linux-next or my staging-next tree so as not to duplicate work that
others have already done.
thanks,
greg k-h
___
devel mailing list
de...@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
Re: [PATCH] staging: vt6656: fixed a CamelCase coding style issue.
Hi Dan Carpenter
Thanks for the feedback, I'll work on the suggestion and come back with a fix.
Regards
Selvakumar Elangovan
On Fri, Feb 19, 2021 at 5:42 PM Dan Carpenter wrote:
>
> You're not asking the right questions.
>
> On Fri, Feb 19, 2021 at 03:28:35PM +0530, Selvakumar Elangovan wrote:
> > This patch renames CamelCase macros uVar and uModulo into u_var and
> > u_module in device.h
> >
>
> Is "u_var" a good name? What does the "u_" even mean?
>
> > This issue was reported by checkpatch.pl
> >
> > Signed-off-by: Selvakumar Elangovan
> > ---
> > drivers/staging/vt6656/device.h | 8
> > 1 file changed, 4 insertions(+), 4 deletions(-)
> >
> > diff --git a/drivers/staging/vt6656/device.h
> > b/drivers/staging/vt6656/device.h
> > index 947530fefe94..6615d356f74a 100644
> > --- a/drivers/staging/vt6656/device.h
> > +++ b/drivers/staging/vt6656/device.h
> > @@ -385,11 +385,11 @@ struct vnt_private {
> > struct ieee80211_low_level_stats low_stats;
> > };
> >
> > -#define ADD_ONE_WITH_WRAP_AROUND(uVar, uModulo) {\
> > - if ((uVar) >= ((uModulo) - 1)) \
> > - (uVar) = 0; \
> > +#define ADD_ONE_WITH_WRAP_AROUND(u_var, u_modulo) { \
> > + if ((u_var) >= ((u_modulo) - 1))\
>
> The \ is not aligned any more.
>
> > + (u_var) = 0;\
> > else\
> > - (uVar)++; \
> > + (u_var)++; \
> > }
>
>
> This macro is rubbish. How does the wrap around even make sense?
> I hope that if you review the code a bit I think you will find that the
> wrap around is impossible? Just fix the two callers and delete this
> macro.
>
> regards,
> dan carpenter
>
___
devel mailing list
de...@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
Re: [PATCH v2] staging: android: Fix const keyword style issue in ashmem.c
On Fri, Feb 19, 2021 at 05:12:38PM +0530, Amrit Khera wrote: > This change fixes a checkpatch warning for "struct file_operations > should normally be const". > > Signed-off-by: Amrit Khera > --- > Changes in v2: > - Wrapped the commit description > - Build tested If you tested it, what changed in the diff itself? Looks the same to me... ___ devel mailing list de...@linuxdriverproject.org http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
Re: [PATCH] staging: fwserial: Fix alignment of function parameters
On Fri, Feb 19, 2021 at 02:52:21PM +0300, Dan Carpenter wrote: > On Fri, Feb 19, 2021 at 11:39:27AM +0100, Greg KH wrote: > > On Fri, Feb 19, 2021 at 03:25:38PM +0530, 17UCS047_Prakash Dubey wrote: > > > I was unable to align it right below the opening parenthesis, just by > > > using > > > tabs. And when I did that with spaces, the checkpatch yelled at me for > > > using spaces. Any suggestions how to do this without using spaces? I am > > > using vim, I will try to find a workaround meanwhile. > > > > Your comment hasn't made it to the list yet. Sometimes there is a delay > or maybe it was blocked for some reason (html email?). > > You are allowed to use spaces but you can't have 8 consecutive spaces > and spaces are not allowed before a tab character. The way to align it > is: > > ret = wait_event_interruptible_timeout(port->wait_tx, > !test_bit(IN_TX, > >flags), > 10); > > [tab x6][space x7]!test_bit(IN_TX, >flags) > > regards, > dan carpenter Thank you Dan, I figured that out after a few failed attempts to align properly. I was replying through Gmail web client, as I am new to mutt. I am getting the hang of it. -- Regards, Prakash ___ devel mailing list de...@linuxdriverproject.org http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
Re: [PATCH] staging: vt6656: fixed a CamelCase coding style issue.
You're not asking the right questions.
On Fri, Feb 19, 2021 at 03:28:35PM +0530, Selvakumar Elangovan wrote:
> This patch renames CamelCase macros uVar and uModulo into u_var and
> u_module in device.h
>
Is "u_var" a good name? What does the "u_" even mean?
> This issue was reported by checkpatch.pl
>
> Signed-off-by: Selvakumar Elangovan
> ---
> drivers/staging/vt6656/device.h | 8
> 1 file changed, 4 insertions(+), 4 deletions(-)
>
> diff --git a/drivers/staging/vt6656/device.h b/drivers/staging/vt6656/device.h
> index 947530fefe94..6615d356f74a 100644
> --- a/drivers/staging/vt6656/device.h
> +++ b/drivers/staging/vt6656/device.h
> @@ -385,11 +385,11 @@ struct vnt_private {
> struct ieee80211_low_level_stats low_stats;
> };
>
> -#define ADD_ONE_WITH_WRAP_AROUND(uVar, uModulo) {\
> - if ((uVar) >= ((uModulo) - 1)) \
> - (uVar) = 0; \
> +#define ADD_ONE_WITH_WRAP_AROUND(u_var, u_modulo) { \
> + if ((u_var) >= ((u_modulo) - 1))\
The \ is not aligned any more.
> + (u_var) = 0;\
> else\
> - (uVar)++; \
> + (u_var)++; \
> }
This macro is rubbish. How does the wrap around even make sense?
I hope that if you review the code a bit I think you will find that the
wrap around is impossible? Just fix the two callers and delete this
macro.
regards,
dan carpenter
___
devel mailing list
de...@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
Re: [PATCH v2] staging: android: Fix const keyword style issue in ashmem.c
On Fri, Feb 19, 2021 at 05:12:38PM +0530, Amrit Khera wrote: > This change fixes a checkpatch warning for "struct file_operations > should normally be const". > > Signed-off-by: Amrit Khera > --- > Changes in v2: > - Wrapped the commit description > - Build tested Heh. Nope. This breaks the build. regards, dan carpenter ___ devel mailing list de...@linuxdriverproject.org http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
Re: [PATCH v4 2/2] staging: rtl8192u: fixed coding style of r8190_rtl8256.c
It's against the rules to send two patches with the same subject. Also both subjects are too vague. regards, dan carpenter ___ devel mailing list de...@linuxdriverproject.org http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
[PATCH v2] staging: android: Fix const keyword style issue in ashmem.c
This change fixes a checkpatch warning for "struct file_operations
should normally be const".
Signed-off-by: Amrit Khera
---
Changes in v2:
- Wrapped the commit description
- Build tested
---
drivers/staging/android/ashmem.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/staging/android/ashmem.c b/drivers/staging/android/ashmem.c
index d66a64e42273..7854fd410efa 100644
--- a/drivers/staging/android/ashmem.c
+++ b/drivers/staging/android/ashmem.c
@@ -376,7 +376,7 @@ ashmem_vmfile_get_unmapped_area(struct file *file, unsigned
long addr,
static int ashmem_mmap(struct file *file, struct vm_area_struct *vma)
{
- static struct file_operations vmfile_fops;
+ static const struct file_operations vmfile_fops;
struct ashmem_area *asma = file->private_data;
int ret = 0;
--
2.20.1
___
devel mailing list
de...@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
[PATCH v4 2/2] staging: rtl8192u: fixed coding style of r8190_rtl8256.c
remove the unnecessary return at the end of function phy_set_rf8256_ofdm_tx_power(), reported by scripts/checkpatch.pl. Signed-off-by: Du Cheng --- drivers/staging/rtl8192u/r8190_rtl8256.c | 1 - 1 file changed, 1 deletion(-) diff --git a/drivers/staging/rtl8192u/r8190_rtl8256.c b/drivers/staging/rtl8192u/r8190_rtl8256.c index 3e6bd6caf9da..54747fda552f 100644 --- a/drivers/staging/rtl8192u/r8190_rtl8256.c +++ b/drivers/staging/rtl8192u/r8190_rtl8256.c @@ -291,5 +291,4 @@ void phy_set_rf8256_ofdm_tx_power(struct net_device *dev, u8 powerlevel) } rtl8192_setBBreg(dev, RegOffset[index], 0x7f7f7f7f, writeVal); } - return; } -- 2.27.0 ___ devel mailing list de...@linuxdriverproject.org http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
[PATCH v4 1/2] staging: rtl8192u: fixed coding style of r8190_rtl8256.c
use MACRO __func__ instead of the literal names for RT_TRACE()
in phy_set_rf8256_bandwidth() and phy_rf8256_config_para_file(),
as reported by scripts/checkpatch.pl.
Signed-off-by: Du Cheng
---
changes v4:
* merge two similar patches into 1
changes v3:
* break up changes into 3 patches
changes v2:
* improvedescription
changes v1:
* fix coding style
drivers/staging/rtl8192u/r8190_rtl8256.c | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/drivers/staging/rtl8192u/r8190_rtl8256.c
b/drivers/staging/rtl8192u/r8190_rtl8256.c
index fee3bfb99075..3e6bd6caf9da 100644
--- a/drivers/staging/rtl8192u/r8190_rtl8256.c
+++ b/drivers/staging/rtl8192u/r8190_rtl8256.c
@@ -73,11 +73,11 @@ void phy_set_rf8256_bandwidth(struct net_device *dev, enum
ht_channel_width Band
else
rtl8192_phy_SetRFReg(dev, (enum
rf90_radio_path_e)eRFPath, 0x14, bMask12Bits, 0x5ab);
} else {
- RT_TRACE(COMP_ERR,
"phy_set_rf8256_bandwidth(): unknown hardware version\n");
+ RT_TRACE(COMP_ERR, "%s(): unknown
hardware version\n", __func__);
}
break;
default:
- RT_TRACE(COMP_ERR, "phy_set_rf8256_bandwidth():
unknown Bandwidth: %#X\n", Bandwidth);
+ RT_TRACE(COMP_ERR, "%s(): unknown Bandwidth:
%#X\n", __func__, Bandwidth);
break;
}
}
@@ -213,7 +213,7 @@ static void phy_rf8256_config_para_file(struct net_device
*dev)
}
if (ret) {
- RT_TRACE(COMP_ERR,
"phy_rf8256_config_para_file():Radio[%d] Fail!!", eRFPath);
+ RT_TRACE(COMP_ERR, "%s():Radio[%d] Fail!!", __func__,
eRFPath);
goto phy_RF8256_Config_ParaFile_Fail;
}
}
--
2.27.0
___
devel mailing list
de...@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
Re: [PATCH] staging: fwserial: Fix alignment of function parameters
On Fri, Feb 19, 2021 at 11:39:27AM +0100, Greg KH wrote: > On Fri, Feb 19, 2021 at 03:25:38PM +0530, 17UCS047_Prakash Dubey wrote: > > I was unable to align it right below the opening parenthesis, just by using > > tabs. And when I did that with spaces, the checkpatch yelled at me for > > using spaces. Any suggestions how to do this without using spaces? I am > > using vim, I will try to find a workaround meanwhile. > Your comment hasn't made it to the list yet. Sometimes there is a delay or maybe it was blocked for some reason (html email?). You are allowed to use spaces but you can't have 8 consecutive spaces and spaces are not allowed before a tab character. The way to align it is: ret = wait_event_interruptible_timeout(port->wait_tx, !test_bit(IN_TX, >flags), 10); [tab x6][space x7]!test_bit(IN_TX, >flags) regards, dan carpenter ___ devel mailing list de...@linuxdriverproject.org http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
Re: [PATCH v3 2/3] staging: rtl8192u: fixed coding style of r8190_rtl8256.c
On Fri, Feb 19, 2021 at 07:07:54PM +0800, Du Cheng wrote: > use MACRO __func__ instead of "phy_rf8256_config_para_file" for RT_TRACE() > inside phy_rf8256_config_para_file(), reported by scripts/checkpatch.pl. > > Signed-off-by: Du Cheng > --- > drivers/staging/rtl8192u/r8190_rtl8256.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) Why isn't this part of patch 1/3? It does the same thing, right? Please fix up and resend the series. thanks, greg k-h ___ devel mailing list de...@linuxdriverproject.org http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
[PATCH v3 1/3] staging: rtl8192u: fixed coding style of r8190_rtl8256.c
use MACRO __func__ instead of "phy_set_rf8256_bandwidth" for RT_TRACE()
inside phy_set_rf8256_bandwidth(), reported by scripts/checkpatch.pl.
Signed-off-by: Du Cheng
---
changes v3:
* break up changes into 3 patches
changes v2:
* improve description
changes v1:
* fix coding style
drivers/staging/rtl8192u/r8190_rtl8256.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/staging/rtl8192u/r8190_rtl8256.c
b/drivers/staging/rtl8192u/r8190_rtl8256.c
index fee3bfb99075..7294a3fbe205 100644
--- a/drivers/staging/rtl8192u/r8190_rtl8256.c
+++ b/drivers/staging/rtl8192u/r8190_rtl8256.c
@@ -73,11 +73,11 @@ void phy_set_rf8256_bandwidth(struct net_device *dev, enum
ht_channel_width Band
else
rtl8192_phy_SetRFReg(dev, (enum
rf90_radio_path_e)eRFPath, 0x14, bMask12Bits, 0x5ab);
} else {
- RT_TRACE(COMP_ERR,
"phy_set_rf8256_bandwidth(): unknown hardware version\n");
+ RT_TRACE(COMP_ERR, "%s(): unknown
hardware version\n", __func__);
}
break;
default:
- RT_TRACE(COMP_ERR, "phy_set_rf8256_bandwidth():
unknown Bandwidth: %#X\n", Bandwidth);
+ RT_TRACE(COMP_ERR, "%s(): unknown Bandwidth:
%#X\n", __func__, Bandwidth);
break;
}
}
--
2.27.0
___
devel mailing list
de...@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
[PATCH v3 3/3] staging: rtl8192u: fixed coding style of r8190_rtl8256.c
remove the unnecessary return at the end of function phy_set_rf8256_ofdm_tx_power(), reported by scripts/checkpatch.pl. Signed-off-by: Du Cheng --- drivers/staging/rtl8192u/r8190_rtl8256.c | 1 - 1 file changed, 1 deletion(-) diff --git a/drivers/staging/rtl8192u/r8190_rtl8256.c b/drivers/staging/rtl8192u/r8190_rtl8256.c index 3e6bd6caf9da..54747fda552f 100644 --- a/drivers/staging/rtl8192u/r8190_rtl8256.c +++ b/drivers/staging/rtl8192u/r8190_rtl8256.c @@ -291,5 +291,4 @@ void phy_set_rf8256_ofdm_tx_power(struct net_device *dev, u8 powerlevel) } rtl8192_setBBreg(dev, RegOffset[index], 0x7f7f7f7f, writeVal); } - return; } -- 2.27.0 ___ devel mailing list de...@linuxdriverproject.org http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
[PATCH v3 2/3] staging: rtl8192u: fixed coding style of r8190_rtl8256.c
use MACRO __func__ instead of "phy_rf8256_config_para_file" for RT_TRACE()
inside phy_rf8256_config_para_file(), reported by scripts/checkpatch.pl.
Signed-off-by: Du Cheng
---
drivers/staging/rtl8192u/r8190_rtl8256.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/staging/rtl8192u/r8190_rtl8256.c
b/drivers/staging/rtl8192u/r8190_rtl8256.c
index 7294a3fbe205..3e6bd6caf9da 100644
--- a/drivers/staging/rtl8192u/r8190_rtl8256.c
+++ b/drivers/staging/rtl8192u/r8190_rtl8256.c
@@ -213,7 +213,7 @@ static void phy_rf8256_config_para_file(struct net_device
*dev)
}
if (ret) {
- RT_TRACE(COMP_ERR,
"phy_rf8256_config_para_file():Radio[%d] Fail!!", eRFPath);
+ RT_TRACE(COMP_ERR, "%s():Radio[%d] Fail!!", __func__,
eRFPath);
goto phy_RF8256_Config_ParaFile_Fail;
}
}
--
2.27.0
___
devel mailing list
de...@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
[PATCH v2] staging: fwserial: fix alignment of function parameters
This patch fixes the following checkpatch.pl check:
CHECK: Alignment should match open parenthesis
Signed-off-by: Prakash Dubey
---
drivers/staging/fwserial/fwserial.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/staging/fwserial/fwserial.c
b/drivers/staging/fwserial/fwserial.c
index a92741b8b6c6..137e97c9406c 100644
--- a/drivers/staging/fwserial/fwserial.c
+++ b/drivers/staging/fwserial/fwserial.c
@@ -1318,8 +1318,8 @@ static int fwtty_break_ctl(struct tty_struct *tty, int
state)
if (state == -1) {
set_bit(STOP_TX, >flags);
ret = wait_event_interruptible_timeout(port->wait_tx,
- !test_bit(IN_TX,
>flags),
- 10);
+ !test_bit(IN_TX,
>flags),
+ 10);
if (ret == 0 || ret == -ERESTARTSYS) {
clear_bit(STOP_TX, >flags);
fwtty_restart_tx(port);
--
2.25.1
___
devel mailing list
de...@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
Re: [PATCH] staging: android: Fix const keyword style issue in ashmem.c
On Fri, Feb 19, 2021 at 03:43:39PM +0530, Amrit Khera wrote:
> This change fixes a checkpatch warning for "struct file_operations should
> normally be const".
>
> Signed-off-by: Amrit Khera
> ---
> drivers/staging/android/ashmem.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/staging/android/ashmem.c
> b/drivers/staging/android/ashmem.c
> index d66a64e42273..7854fd410efa 100644
> --- a/drivers/staging/android/ashmem.c
> +++ b/drivers/staging/android/ashmem.c
> @@ -376,7 +376,7 @@ ashmem_vmfile_get_unmapped_area(struct file *file,
> unsigned long addr,
>
> static int ashmem_mmap(struct file *file, struct vm_area_struct *vma)
> {
> - static struct file_operations vmfile_fops;
> + static const struct file_operations vmfile_fops;
> struct ashmem_area *asma = file->private_data;
> int ret = 0;
>
Always test-build your patches before sending them out, otherwise you
are wasting reviewer's time, right?
:(
___
devel mailing list
de...@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
Re: [PATCH] staging: vt6656: fixed a CamelCase coding style issue.
On Fri, Feb 19, 2021 at 03:28:35PM +0530, Selvakumar Elangovan wrote:
> This patch renames CamelCase macros uVar and uModulo into u_var and
> u_module in device.h
>
> This issue was reported by checkpatch.pl
>
> Signed-off-by: Selvakumar Elangovan
> ---
> drivers/staging/vt6656/device.h | 8
> 1 file changed, 4 insertions(+), 4 deletions(-)
>
> diff --git a/drivers/staging/vt6656/device.h b/drivers/staging/vt6656/device.h
> index 947530fefe94..6615d356f74a 100644
> --- a/drivers/staging/vt6656/device.h
> +++ b/drivers/staging/vt6656/device.h
> @@ -385,11 +385,11 @@ struct vnt_private {
> struct ieee80211_low_level_stats low_stats;
> };
>
> -#define ADD_ONE_WITH_WRAP_AROUND(uVar, uModulo) {\
> - if ((uVar) >= ((uModulo) - 1)) \
> - (uVar) = 0; \
> +#define ADD_ONE_WITH_WRAP_AROUND(u_var, u_modulo) { \
"u_" does not really make any sense, right?
Just use "var" and "modulo" please.
But first, why is this needed at all? Isn't there an in-kernel function
that should be used instead?
thanks,
greg k-h
___
devel mailing list
de...@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
Re: [PATCH] staging: fwserial: Fix alignment of function parameters
On Fri, Feb 19, 2021 at 03:25:38PM +0530, 17UCS047_Prakash Dubey wrote: > I was unable to align it right below the opening parenthesis, just by using > tabs. And when I did that with spaces, the checkpatch yelled at me for > using spaces. Any suggestions how to do this without using spaces? I am > using vim, I will try to find a workaround meanwhile. I have no context here for what you are asking about at all, sorry. greg k-h ___ devel mailing list de...@linuxdriverproject.org http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
[PATCH] staging: hikey9xx: fix warning styling issues
Fix "WARNING: please, no space before tabs" styling issue in
hi6421-spmi-pmic.c for lines 51,52,53 and 69.
Signed-off-by: Alaa Emad
---
drivers/staging/hikey9xx/hi6421-spmi-pmic.c | 8
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/drivers/staging/hikey9xx/hi6421-spmi-pmic.c
b/drivers/staging/hikey9xx/hi6421-spmi-pmic.c
index 4ebcfea9f3bf..626140cb96f2 100644
--- a/drivers/staging/hikey9xx/hi6421-spmi-pmic.c
+++ b/drivers/staging/hikey9xx/hi6421-spmi-pmic.c
@@ -48,9 +48,9 @@ enum hi6421_spmi_pmic_irq_list {
/*
* The IRQs are mapped as:
*
- * == = =
- * IRQ MASK REGISTER IRQ REGISTERBIT
- * == = =
+ * == = =
+ * IRQ MASK REGISTER IRQ REGISTERBIT
+ * == = =
* OTMP0x0202 0x212 bit 0
* VBUS_CONNECT0x0202 0x212 bit 1
* VBUS_DISCONNECT 0x0202 0x212 bit 2
@@ -66,7 +66,7 @@ enum hi6421_spmi_pmic_irq_list {
* SIM0_HPD_F 0x0203 0x213 bit 3
* SIM1_HPD_R 0x0203 0x213 bit 4
* SIM1_HPD_F 0x0203 0x213 bit 5
- * == = =
+ * == = =
*/
#define SOC_PMIC_IRQ_MASK_0_ADDR 0x0202
#define SOC_PMIC_IRQ0_ADDR 0x0212
--
2.25.1
___
devel mailing list
de...@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
[PATCH] staging: android: Fix const keyword style issue in ashmem.c
This change fixes a checkpatch warning for "struct file_operations should
normally be const".
Signed-off-by: Amrit Khera
---
drivers/staging/android/ashmem.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/staging/android/ashmem.c b/drivers/staging/android/ashmem.c
index d66a64e42273..7854fd410efa 100644
--- a/drivers/staging/android/ashmem.c
+++ b/drivers/staging/android/ashmem.c
@@ -376,7 +376,7 @@ ashmem_vmfile_get_unmapped_area(struct file *file, unsigned
long addr,
static int ashmem_mmap(struct file *file, struct vm_area_struct *vma)
{
- static struct file_operations vmfile_fops;
+ static const struct file_operations vmfile_fops;
struct ashmem_area *asma = file->private_data;
int ret = 0;
--
2.20.1
___
devel mailing list
de...@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
[PATCH 1/6] staging: rtl8192e: rename charData to char_data in ba_param_set union
Fixes a checkpatch CHECK message.
Signed-off-by: William Durand
---
drivers/staging/rtl8192e/rtl819x_BA.h | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/staging/rtl8192e/rtl819x_BA.h
b/drivers/staging/rtl8192e/rtl819x_BA.h
index b2a784fa051e..4fdff19bb4ae 100644
--- a/drivers/staging/rtl8192e/rtl819x_BA.h
+++ b/drivers/staging/rtl8192e/rtl819x_BA.h
@@ -28,7 +28,7 @@ union sequence_control {
};
union ba_param_set {
- u8 charData[2];
+ u8 char_data[2];
u16 shortData;
struct {
u16 AMSDU_Support:1;
--
2.30.0
___
devel mailing list
de...@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
[PATCH 3/6] staging: rtl8192e: rename BAPolicy to ba_policy in ba_param_set union
Fixes a checkpatch CHECK message.
Signed-off-by: William Durand
---
drivers/staging/rtl8192e/rtl819x_BA.h | 2 +-
drivers/staging/rtl8192e/rtl819x_BAProc.c | 8
2 files changed, 5 insertions(+), 5 deletions(-)
diff --git a/drivers/staging/rtl8192e/rtl819x_BA.h
b/drivers/staging/rtl8192e/rtl819x_BA.h
index 50e87ab1bbcf..a36e4488b849 100644
--- a/drivers/staging/rtl8192e/rtl819x_BA.h
+++ b/drivers/staging/rtl8192e/rtl819x_BA.h
@@ -32,7 +32,7 @@ union ba_param_set {
u16 short_data;
struct {
u16 AMSDU_Support:1;
- u16 BAPolicy:1;
+ u16 ba_policy:1;
u16 TID:4;
u16 BufferSize:10;
} field;
diff --git a/drivers/staging/rtl8192e/rtl819x_BAProc.c
b/drivers/staging/rtl8192e/rtl819x_BAProc.c
index 1d6fa6cae61c..b695a56a44b9 100644
--- a/drivers/staging/rtl8192e/rtl819x_BAProc.c
+++ b/drivers/staging/rtl8192e/rtl819x_BAProc.c
@@ -267,7 +267,7 @@ int rtllib_rx_ADDBAReq(struct rtllib_device *ieee, struct
sk_buff *skb)
}
pBA = >RxAdmittedBARecord;
- if (pBaParamSet->field.BAPolicy == BA_POLICY_DELAYED) {
+ if (pBaParamSet->field.ba_policy == BA_POLICY_DELAYED) {
rc = ADDBA_STATUS_INVALID_PARAM;
netdev_warn(ieee->dev, "%s(): BA Policy is not correct\n",
__func__);
@@ -300,7 +300,7 @@ int rtllib_rx_ADDBAReq(struct rtllib_device *ieee, struct
sk_buff *skb)
BA.BaParamSet = *pBaParamSet;
BA.BaTimeoutValue = *pBaTimeoutVal;
BA.DialogToken = *pDialogToken;
- BA.BaParamSet.field.BAPolicy = BA_POLICY_IMMEDIATE;
+ BA.BaParamSet.field.ba_policy = BA_POLICY_IMMEDIATE;
rtllib_send_ADDBARsp(ieee, dst, , rc);
return 0;
}
@@ -377,7 +377,7 @@ int rtllib_rx_ADDBARsp(struct rtllib_device *ieee, struct
sk_buff *skb)
if (*pStatusCode == ADDBA_STATUS_SUCCESS) {
- if (pBaParamSet->field.BAPolicy == BA_POLICY_DELAYED) {
+ if (pBaParamSet->field.ba_policy == BA_POLICY_DELAYED) {
pTS->bAddBaReqDelayed = true;
DeActivateBAEntry(ieee, pAdmittedBA);
ReasonCode = DELBA_REASON_END_BA;
@@ -484,7 +484,7 @@ void TsInitAddBA(struct rtllib_device *ieee, struct
tx_ts_record *pTS,
pBA->DialogToken++;
pBA->BaParamSet.field.AMSDU_Support = 0;
- pBA->BaParamSet.field.BAPolicy = Policy;
+ pBA->BaParamSet.field.ba_policy = Policy;
pBA->BaParamSet.field.TID =
pTS->TsCommonInfo.TSpec.f.TSInfo.field.ucTSID;
pBA->BaParamSet.field.BufferSize = 32;
--
2.30.0
___
devel mailing list
de...@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
[PATCH 5/6] staging: rtl8192e: rename AMSDU_Support to amsdu_support in ba_param_set union
This change does not fix a checkpatch issue but it is more consistent
with the rest of the union.
Signed-off-by: William Durand
---
drivers/staging/rtl8192e/rtl819x_BA.h | 2 +-
drivers/staging/rtl8192e/rtl819x_BAProc.c | 2 +-
2 files changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/staging/rtl8192e/rtl819x_BA.h
b/drivers/staging/rtl8192e/rtl819x_BA.h
index af25b4850975..1a8ca249ed23 100644
--- a/drivers/staging/rtl8192e/rtl819x_BA.h
+++ b/drivers/staging/rtl8192e/rtl819x_BA.h
@@ -31,7 +31,7 @@ union ba_param_set {
u8 char_data[2];
u16 short_data;
struct {
- u16 AMSDU_Support:1;
+ u16 amsdu_support:1;
u16 ba_policy:1;
u16 TID:4;
u16 buffer_size:10;
diff --git a/drivers/staging/rtl8192e/rtl819x_BAProc.c
b/drivers/staging/rtl8192e/rtl819x_BAProc.c
index 17520fcbc1bb..002ec9a7a8c0 100644
--- a/drivers/staging/rtl8192e/rtl819x_BAProc.c
+++ b/drivers/staging/rtl8192e/rtl819x_BAProc.c
@@ -483,7 +483,7 @@ void TsInitAddBA(struct rtllib_device *ieee, struct
tx_ts_record *pTS,
DeActivateBAEntry(ieee, pBA);
pBA->DialogToken++;
- pBA->BaParamSet.field.AMSDU_Support = 0;
+ pBA->BaParamSet.field.amsdu_support = 0;
pBA->BaParamSet.field.ba_policy = Policy;
pBA->BaParamSet.field.TID =
pTS->TsCommonInfo.TSpec.f.TSInfo.field.ucTSID;
--
2.30.0
___
devel mailing list
de...@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
[PATCH 2/6] staging: rtl8192e: rename shortData to short_data in ba_param_set union
Fixes a checkpatch CHECK message.
Signed-off-by: William Durand
---
drivers/staging/rtl8192e/rtl819x_BA.h | 2 +-
drivers/staging/rtl8192e/rtl819x_BAProc.c | 4 ++--
2 files changed, 3 insertions(+), 3 deletions(-)
diff --git a/drivers/staging/rtl8192e/rtl819x_BA.h
b/drivers/staging/rtl8192e/rtl819x_BA.h
index 4fdff19bb4ae..50e87ab1bbcf 100644
--- a/drivers/staging/rtl8192e/rtl819x_BA.h
+++ b/drivers/staging/rtl8192e/rtl819x_BA.h
@@ -29,7 +29,7 @@ union sequence_control {
union ba_param_set {
u8 char_data[2];
- u16 shortData;
+ u16 short_data;
struct {
u16 AMSDU_Support:1;
u16 BAPolicy:1;
diff --git a/drivers/staging/rtl8192e/rtl819x_BAProc.c
b/drivers/staging/rtl8192e/rtl819x_BAProc.c
index 07dade37d4eb..1d6fa6cae61c 100644
--- a/drivers/staging/rtl8192e/rtl819x_BAProc.c
+++ b/drivers/staging/rtl8192e/rtl819x_BAProc.c
@@ -58,7 +58,7 @@ static u8 RxTsDeleteBA(struct rtllib_device *ieee, struct
rx_ts_record *pRxTs)
void ResetBaEntry(struct ba_record *pBA)
{
pBA->bValid = false;
- pBA->BaParamSet.shortData = 0;
+ pBA->BaParamSet.short_data = 0;
pBA->BaTimeoutValue = 0;
pBA->DialogToken= 0;
pBA->BaStartSeqCtrl.short_data = 0;
@@ -107,7 +107,7 @@ static struct sk_buff *rtllib_ADDBA(struct rtllib_device
*ieee, u8 *Dst,
tag += 2;
}
- put_unaligned_le16(pBA->BaParamSet.shortData, tag);
+ put_unaligned_le16(pBA->BaParamSet.short_data, tag);
tag += 2;
put_unaligned_le16(pBA->BaTimeoutValue, tag);
--
2.30.0
___
devel mailing list
de...@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
[PATCH 6/6] staging: rtl8192e: rename TID to tid in ba_param_set union
This change uses lowercase for a field name to be more consistent with
the rest of the union.
Signed-off-by: William Durand
---
drivers/staging/rtl8192e/rtl819x_BA.h | 2 +-
drivers/staging/rtl8192e/rtl819x_BAProc.c | 9 -
2 files changed, 5 insertions(+), 6 deletions(-)
diff --git a/drivers/staging/rtl8192e/rtl819x_BA.h
b/drivers/staging/rtl8192e/rtl819x_BA.h
index 1a8ca249ed23..36280c62fa56 100644
--- a/drivers/staging/rtl8192e/rtl819x_BA.h
+++ b/drivers/staging/rtl8192e/rtl819x_BA.h
@@ -33,7 +33,7 @@ union ba_param_set {
struct {
u16 amsdu_support:1;
u16 ba_policy:1;
- u16 TID:4;
+ u16 tid:4;
u16 buffer_size:10;
} field;
};
diff --git a/drivers/staging/rtl8192e/rtl819x_BAProc.c
b/drivers/staging/rtl8192e/rtl819x_BAProc.c
index 002ec9a7a8c0..1f697e87ae8d 100644
--- a/drivers/staging/rtl8192e/rtl819x_BAProc.c
+++ b/drivers/staging/rtl8192e/rtl819x_BAProc.c
@@ -142,7 +142,7 @@ static struct sk_buff *rtllib_DELBA(struct rtllib_device
*ieee, u8 *dst,
memset(, 0, 2);
DelbaParamSet.field.Initiator = (TxRxSelect == TX_DIR) ? 1 : 0;
- DelbaParamSet.field.TID = pBA->BaParamSet.field.TID;
+ DelbaParamSet.field.TID = pBA->BaParamSet.field.tid;
skb = dev_alloc_skb(len + sizeof(struct rtllib_hdr_3addr));
if (!skb)
@@ -260,7 +260,7 @@ int rtllib_rx_ADDBAReq(struct rtllib_device *ieee, struct
sk_buff *skb)
goto OnADDBAReq_Fail;
}
if (!GetTs(ieee, (struct ts_common_info **)(), dst,
- (u8)(pBaParamSet->field.TID), RX_DIR, true)) {
+ (u8)(pBaParamSet->field.tid), RX_DIR, true)) {
rc = ADDBA_STATUS_REFUSED;
netdev_warn(ieee->dev, "%s(): can't get TS\n", __func__);
goto OnADDBAReq_Fail;
@@ -346,7 +346,7 @@ int rtllib_rx_ADDBARsp(struct rtllib_device *ieee, struct
sk_buff *skb)
if (!GetTs(ieee, (struct ts_common_info **)(), dst,
- (u8)(pBaParamSet->field.TID), TX_DIR, false)) {
+ (u8)(pBaParamSet->field.tid), TX_DIR, false)) {
netdev_warn(ieee->dev, "%s(): can't get TS\n", __func__);
ReasonCode = DELBA_REASON_UNKNOWN_BA;
goto OnADDBARsp_Reject;
@@ -485,8 +485,7 @@ void TsInitAddBA(struct rtllib_device *ieee, struct
tx_ts_record *pTS,
pBA->DialogToken++;
pBA->BaParamSet.field.amsdu_support = 0;
pBA->BaParamSet.field.ba_policy = Policy;
- pBA->BaParamSet.field.TID =
-pTS->TsCommonInfo.TSpec.f.TSInfo.field.ucTSID;
+ pBA->BaParamSet.field.tid =
pTS->TsCommonInfo.TSpec.f.TSInfo.field.ucTSID;
pBA->BaParamSet.field.buffer_size = 32;
pBA->BaTimeoutValue = 0;
pBA->BaStartSeqCtrl.field.seq_num = (pTS->TxCurSeq + 3) % 4096;
--
2.30.0
___
devel mailing list
de...@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
[PATCH 0/6] staging: rtl8192e: ba_param_set union cleanups
This patchset fixes the checkpatch issues related to the `ba_param_set` union defined in `rtl8192e/rtl819x_BA.h` (avoid camelcase). William Durand (6): staging: rtl8192e: rename charData to char_data in ba_param_set union staging: rtl8192e: rename shortData to short_data in ba_param_set union staging: rtl8192e: rename BAPolicy to ba_policy in ba_param_set union staging: rtl8192e: rename BufferSize to buffer_size in ba_param_set union staging: rtl8192e: rename AMSDU_Support to amsdu_support in ba_param_set union staging: rtl8192e: rename TID to tid in ba_param_set union drivers/staging/rtl8192e/rtl819x_BA.h | 12 +- drivers/staging/rtl8192e/rtl819x_BAProc.c | 29 +++ 2 files changed, 20 insertions(+), 21 deletions(-) -- 2.30.0 ___ devel mailing list de...@linuxdriverproject.org http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
[PATCH 4/6] staging: rtl8192e: rename BufferSize to buffer_size in ba_param_set union
Fixes a checkpatch CHECK message.
Signed-off-by: William Durand
---
drivers/staging/rtl8192e/rtl819x_BA.h | 2 +-
drivers/staging/rtl8192e/rtl819x_BAProc.c | 6 +++---
2 files changed, 4 insertions(+), 4 deletions(-)
diff --git a/drivers/staging/rtl8192e/rtl819x_BA.h
b/drivers/staging/rtl8192e/rtl819x_BA.h
index a36e4488b849..af25b4850975 100644
--- a/drivers/staging/rtl8192e/rtl819x_BA.h
+++ b/drivers/staging/rtl8192e/rtl819x_BA.h
@@ -34,7 +34,7 @@ union ba_param_set {
u16 AMSDU_Support:1;
u16 ba_policy:1;
u16 TID:4;
- u16 BufferSize:10;
+ u16 buffer_size:10;
} field;
};
diff --git a/drivers/staging/rtl8192e/rtl819x_BAProc.c
b/drivers/staging/rtl8192e/rtl819x_BAProc.c
index b695a56a44b9..17520fcbc1bb 100644
--- a/drivers/staging/rtl8192e/rtl819x_BAProc.c
+++ b/drivers/staging/rtl8192e/rtl819x_BAProc.c
@@ -284,9 +284,9 @@ int rtllib_rx_ADDBAReq(struct rtllib_device *ieee, struct
sk_buff *skb)
if (ieee->GetHalfNmodeSupportByAPsHandler(ieee->dev) ||
(ieee->pHTInfo->IOTAction & HT_IOT_ACT_ALLOW_PEER_AGG_ONE_PKT))
- pBA->BaParamSet.field.BufferSize = 1;
+ pBA->BaParamSet.field.buffer_size = 1;
else
- pBA->BaParamSet.field.BufferSize = 32;
+ pBA->BaParamSet.field.buffer_size = 32;
ActivateBAEntry(ieee, pBA, 0);
rtllib_send_ADDBARsp(ieee, dst, pBA, ADDBA_STATUS_SUCCESS);
@@ -487,7 +487,7 @@ void TsInitAddBA(struct rtllib_device *ieee, struct
tx_ts_record *pTS,
pBA->BaParamSet.field.ba_policy = Policy;
pBA->BaParamSet.field.TID =
pTS->TsCommonInfo.TSpec.f.TSInfo.field.ucTSID;
- pBA->BaParamSet.field.BufferSize = 32;
+ pBA->BaParamSet.field.buffer_size = 32;
pBA->BaTimeoutValue = 0;
pBA->BaStartSeqCtrl.field.seq_num = (pTS->TxCurSeq + 3) % 4096;
--
2.30.0
___
devel mailing list
de...@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
[PATCH] staging: sm750fb: added identifier names for function declarations
checkpatch.pl complains about not having identifiers names in
function declarations . This patch uses the same names as are
used in source file sm750_accel.c , but with snake case.
Signed-off-by: shivang upadhyay
---
drivers/staging/sm750fb/sm750.h | 30 ++
1 file changed, 18 insertions(+), 12 deletions(-)
diff --git a/drivers/staging/sm750fb/sm750.h b/drivers/staging/sm750fb/sm750.h
index 19823c7277a4..38b85a171182 100644
--- a/drivers/staging/sm750fb/sm750.h
+++ b/drivers/staging/sm750fb/sm750.h
@@ -55,23 +55,28 @@ struct lynx_accel {
volatile unsigned char __iomem *dpPortBase;
/* function pointers */
- void (*de_init)(struct lynx_accel *);
+ void (*de_init)(struct lynx_accel *accel);
int (*de_wait)(void);/* see if hardware ready to work */
- int (*de_fillrect)(struct lynx_accel *,
- u32, u32, u32, u32,
- u32, u32, u32, u32, u32);
+ int (*de_fillrect)(struct lynx_accel *accel,
+ u32 base, u32 pitch, u32 bpp,
+ u32 x, u32 y, u32 width, u32 height,
+ u32 color, u32 rop);
- int (*de_copyarea)(struct lynx_accel *,
- u32, u32, u32, u32,
- u32, u32, u32, u32,
- u32, u32, u32, u32);
- int (*de_imageblit)(struct lynx_accel *, const char *,
- u32, u32, u32, u32,
- u32, u32, u32, u32,
- u32, u32, u32, u32);
+ int (*de_copyarea)(struct lynx_accel *accel,
+ u32 s_base, u32 s_pitch,
+ u32 sx, u32 sy,
+ u32 d_base, u32 d_pitch,
+ u32 bpp, u32 dx, u32 dy,
+ u32 width, u32 height,
+ u32 rop2);
+
+ int (*de_imageblit)(struct lynx_accel *accel, const char *p_srcbuf,
+ u32 src_delta, u32 start_bit, u32 d_base, u32
d_pitch,
+ u32 byte_per_pixel, u32 dx, u32 dy, u32 width,
+ u32 height, u32 f_color, u32 b_color, u32 rop2);
};
--
2.27.0
___
devel mailing list
de...@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
[PATCH] staging: vt6656: fixed a CamelCase coding style issue.
This patch renames CamelCase macros uVar and uModulo into u_var and
u_module in device.h
This issue was reported by checkpatch.pl
Signed-off-by: Selvakumar Elangovan
---
drivers/staging/vt6656/device.h | 8
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/drivers/staging/vt6656/device.h b/drivers/staging/vt6656/device.h
index 947530fefe94..6615d356f74a 100644
--- a/drivers/staging/vt6656/device.h
+++ b/drivers/staging/vt6656/device.h
@@ -385,11 +385,11 @@ struct vnt_private {
struct ieee80211_low_level_stats low_stats;
};
-#define ADD_ONE_WITH_WRAP_AROUND(uVar, uModulo) { \
- if ((uVar) >= ((uModulo) - 1)) \
- (uVar) = 0; \
+#define ADD_ONE_WITH_WRAP_AROUND(u_var, u_modulo) {\
+ if ((u_var) >= ((u_modulo) - 1))\
+ (u_var) = 0;\
else\
- (uVar)++; \
+ (u_var)++; \
}
int vnt_init(struct vnt_private *priv);
--
2.17.1
___
devel mailing list
de...@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
RE: [PATCH] staging: comedi: cast to (unsigned int *)
From: Dan Carpenter
> Sent: 19 February 2021 09:26
>
> On Fri, Feb 19, 2021 at 09:03:59AM +, David Laight wrote:
> > > It's kind of moot anyway because the patch is outdated. But the reason
> > > for the ___force is that the same `struct comedi_cmd` is used in both
> > > user and kernel contexts. In user contexts, the `chanlist` member
> > > points to user memory and in kernel contexts it points to kernel memory
> > > (copied from userspace).
> >
> > Can't you use a union of the user and kernel pointers?
> > (Possibly even anonymous?)
> > Although, ideally, keeping them in separate fields is better.
> > 8 bytes for a pointer isn't going make a fat lot of difference.
> >
>
> Creating a union is worse than adding casts. With the casts, at least
> you know that you're doing something dangerous. It's good that it looks
> scary because it is scary.
>
> Keeping them in separate fields is a good idea, but this is part of the
> user space API so it's not possible.
>
> The best we can do is adding some more comments so people know why we
> are doing the scary casts.
Another option is to use a longer structure in the kernel with the kernel
pointer in the 'extension'.
So you could have:
struct kernel_foo {
struct foo;
void *kernel_pointer;
};
David
-
Registered Address Lakeside, Bramley Road, Mount Farm, Milton Keynes, MK1 1PT,
UK
Registration No: 1397386 (Wales)
___
devel mailing list
de...@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
Re: [PATCH] staging: comedi: cast to (unsigned int *)
On 19/02/2021 09:03, David Laight wrote: >> It's kind of moot anyway because the patch is outdated. But the reason >> for the ___force is that the same `struct comedi_cmd` is used in both >> user and kernel contexts. In user contexts, the `chanlist` member >> points to user memory and in kernel contexts it points to kernel memory >> (copied from userspace). > > Can't you use a union of the user and kernel pointers? > (Possibly even anonymous?) > Although, ideally, keeping them in separate fields is better. > 8 bytes for a pointer isn't going make a fat lot of difference. This is for a UAPI header (eventually), so cannot add a new field. For an anonymous union, one tagged with __user and one not, the __user tag would be removed during conversion from UAPI headers to /usr/include/linux headers, leaving a union of two identically typed members, which would look a bit odd. The union also kind of hides the problem. -- -=( Ian Abbott || MEV Ltd. is a company )=- -=( registered in England & Wales. Regd. number: 02862268. )=- -=( Regd. addr.: S11 & 12 Building 67, Europa Business Park, )=- -=( Bird Hall Lane, STOCKPORT, SK3 0XA, UK. || www.mev.co.uk )=- ___ devel mailing list de...@linuxdriverproject.org http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
Re: [PATCH v2] staging: fwserial: match alignment with open parenthesis
On Fri, Feb 19, 2021 at 12:03:18PM +0300, Nikolay Kyx wrote: > This patch fixes the following checkpatch.pl check: > > CHECK: Alignment should match open parenthesis > > in file fwserial.c > > Additionally some style warnings remain valid here and could be fixed by > another patch. > Don't put comments like this in the git log, put them under the --- cut off line. > Signed-off-by: Nikolay Kyx > --- > ___ devel mailing list de...@linuxdriverproject.org http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
Re: [PATCH] staging: comedi: cast to (unsigned int *)
On Fri, Feb 19, 2021 at 09:03:59AM +, David Laight wrote: > > It's kind of moot anyway because the patch is outdated. But the reason > > for the ___force is that the same `struct comedi_cmd` is used in both > > user and kernel contexts. In user contexts, the `chanlist` member > > points to user memory and in kernel contexts it points to kernel memory > > (copied from userspace). > > Can't you use a union of the user and kernel pointers? > (Possibly even anonymous?) > Although, ideally, keeping them in separate fields is better. > 8 bytes for a pointer isn't going make a fat lot of difference. > Creating a union is worse than adding casts. With the casts, at least you know that you're doing something dangerous. It's good that it looks scary because it is scary. Keeping them in separate fields is a good idea, but this is part of the user space API so it's not possible. The best we can do is adding some more comments so people know why we are doing the scary casts. regards, dan carpenter ___ devel mailing list de...@linuxdriverproject.org http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
[PATCH v2] staging: fwserial: match alignment with open parenthesis
This patch fixes the following checkpatch.pl check:
CHECK: Alignment should match open parenthesis
in file fwserial.c
Additionally some style warnings remain valid here and could be fixed by
another patch.
Signed-off-by: Nikolay Kyx
---
v2: Edited changelog, as suggested by Greg KH
drivers/staging/fwserial/fwserial.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/staging/fwserial/fwserial.c
b/drivers/staging/fwserial/fwserial.c
index c368082aae1a..137e97c9406c 100644
--- a/drivers/staging/fwserial/fwserial.c
+++ b/drivers/staging/fwserial/fwserial.c
@@ -1318,8 +1318,8 @@ static int fwtty_break_ctl(struct tty_struct *tty, int
state)
if (state == -1) {
set_bit(STOP_TX, >flags);
ret = wait_event_interruptible_timeout(port->wait_tx,
- !test_bit(IN_TX, >flags),
- 10);
+ !test_bit(IN_TX,
>flags),
+ 10);
if (ret == 0 || ret == -ERESTARTSYS) {
clear_bit(STOP_TX, >flags);
fwtty_restart_tx(port);
--
2.30.1
___
devel mailing list
de...@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
RE: [PATCH] staging: comedi: cast to (unsigned int *)
> It's kind of moot anyway because the patch is outdated. But the reason > for the ___force is that the same `struct comedi_cmd` is used in both > user and kernel contexts. In user contexts, the `chanlist` member > points to user memory and in kernel contexts it points to kernel memory > (copied from userspace). Can't you use a union of the user and kernel pointers? (Possibly even anonymous?) Although, ideally, keeping them in separate fields is better. 8 bytes for a pointer isn't going make a fat lot of difference. David - Registered Address Lakeside, Bramley Road, Mount Farm, Milton Keynes, MK1 1PT, UK Registration No: 1397386 (Wales) ___ devel mailing list de...@linuxdriverproject.org http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
Re: [PATCH v2] staging: kpc2000: code style: fix alignment issues
On Fri, Feb 19, 2021 at 11:04:51AM +0300, Nikolay Kyx wrote: > This patch fixes the following checkpatch.pl warnings: > > WARNING: line length of 124 exceeds 100 columns > CHECK: Alignment should match open parenthesis That's two different things, please make this two different patches. thanks, greg k-h ___ devel mailing list de...@linuxdriverproject.org http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
[PATCH v2] staging: kpc2000: code style: fix alignment issues
This patch fixes the following checkpatch.pl warnings:
WARNING: line length of 124 exceeds 100 columns
CHECK: Alignment should match open parenthesis
in files kpc2000_i2c.c kpc2000_spi.c
Additionally some style warnings remain valid here and could be fixed by
another patch.
Signed-off-by: Nikolay Kyx
---
v2: Edited changelog, as suggested by Greg KH
drivers/staging/kpc2000/kpc2000_i2c.c | 6 --
drivers/staging/kpc2000/kpc2000_spi.c | 2 +-
2 files changed, 5 insertions(+), 3 deletions(-)
diff --git a/drivers/staging/kpc2000/kpc2000_i2c.c
b/drivers/staging/kpc2000/kpc2000_i2c.c
index 25bb5c97dd21..14f7940fa4fb 100644
--- a/drivers/staging/kpc2000/kpc2000_i2c.c
+++ b/drivers/staging/kpc2000/kpc2000_i2c.c
@@ -200,7 +200,9 @@ static int i801_check_post(struct kpc_i2c *priv, int
status, int timeout)
outb_p(status & STATUS_FLAGS, SMBHSTSTS(priv));
status = inb_p(SMBHSTSTS(priv)) & STATUS_FLAGS;
if (status)
- dev_warn(>adapter.dev, "Failed clearing status
flags at end of transaction (%02x)\n", status);
+ dev_warn(>adapter.dev,
+"Failed clearing status flags at end of
transaction (%02x)\n",
+status);
}
return result;
@@ -269,7 +271,7 @@ static int i801_block_transaction_by_block(struct kpc_i2c
*priv,
}
status = i801_transaction(priv,
- I801_BLOCK_DATA | ENABLE_INT9 | I801_PEC_EN * hwpec);
+ I801_BLOCK_DATA | ENABLE_INT9 | I801_PEC_EN *
hwpec);
if (status)
return status;
diff --git a/drivers/staging/kpc2000/kpc2000_spi.c
b/drivers/staging/kpc2000/kpc2000_spi.c
index 44017d523da5..16ca18b8aa15 100644
--- a/drivers/staging/kpc2000/kpc2000_spi.c
+++ b/drivers/staging/kpc2000/kpc2000_spi.c
@@ -465,7 +465,7 @@ kp_spi_probe(struct platform_device *pldev)
}
kpspi->base = devm_ioremap(>dev, r->start,
- resource_size(r));
+ resource_size(r));
status = spi_register_master(master);
if (status < 0) {
--
2.30.1
___
devel mailing list
de...@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
Re: [PATCH] staging: fwserial: match alignment with open parenthesis
On Thu, Feb 18, 2021 at 10:43:33PM +0300, Nikolay Kyx wrote: > fwserial.c: Why is this here? > fix CHECK: Alignment should match open parenthesis What does this mean? Please read the section entitled "The canonical patch format" in the kernel file, Documentation/SubmittingPatches for what is needed in order to properly describe the change. thanks, greg k-h ___ devel mailing list de...@linuxdriverproject.org http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
Re: [PATCH] staging: fwserial: Fix alignment of function parameters
On Thu, Feb 18, 2021 at 03:58:51PM +0530, Prakash Dubey wrote:
> This patch fixes the following checkpatch.pl check:
>
> CHECK: Alignment should match open parenthesis
>
> Signed-off-by: Prakash Dubey
> ---
> drivers/staging/fwserial/fwserial.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/staging/fwserial/fwserial.c
> b/drivers/staging/fwserial/fwserial.c
> index c368082aae1a..a92741b8b6c6 100644
> --- a/drivers/staging/fwserial/fwserial.c
> +++ b/drivers/staging/fwserial/fwserial.c
> @@ -1318,8 +1318,8 @@ static int fwtty_break_ctl(struct tty_struct *tty, int
> state)
> if (state == -1) {
> set_bit(STOP_TX, >flags);
> ret = wait_event_interruptible_timeout(port->wait_tx,
> -!test_bit(IN_TX, >flags),
> -10);
> + !test_bit(IN_TX,
> >flags),
> + 10);
Shouldn't you make this line up with the ( above? This indents it a bit
further :(
thanks,
greg k-h
___
devel mailing list
de...@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
Re: [PATCH v2] staging: rtl8192u: fix coding style in r8190_rtl8256.c
On Tue, Feb 16, 2021 at 06:28:06PM +0800, Du Cheng wrote:
> use __func__ macro instead of literal function name in RT_TRACE() in
> * phy_set_rf8256_bandwidth()
> * phy_rf8256_config_para_file()
>
> remove unnecessary return at the end of phy_set_rf8256_ofdm_tx_power()
>
> these coding style issues are flagged as warnings by scripts/checkpatch.pl.
>
>
> Signed-off-by: Du Cheng
> ---
> changes v2:
> * improve description and subject
>
> changes v1:
> * fix coding style
>
> drivers/staging/rtl8192u/r8190_rtl8256.c | 7 +++
> 1 file changed, 3 insertions(+), 4 deletions(-)
>
> diff --git a/drivers/staging/rtl8192u/r8190_rtl8256.c
> b/drivers/staging/rtl8192u/r8190_rtl8256.c
> index fee3bfb99075..54747fda552f 100644
> --- a/drivers/staging/rtl8192u/r8190_rtl8256.c
> +++ b/drivers/staging/rtl8192u/r8190_rtl8256.c
> @@ -73,11 +73,11 @@ void phy_set_rf8256_bandwidth(struct net_device *dev,
> enum ht_channel_width Band
> else
> rtl8192_phy_SetRFReg(dev, (enum
> rf90_radio_path_e)eRFPath, 0x14, bMask12Bits, 0x5ab);
> } else {
> - RT_TRACE(COMP_ERR,
> "phy_set_rf8256_bandwidth(): unknown hardware version\n");
> + RT_TRACE(COMP_ERR, "%s(): unknown
> hardware version\n", __func__);
> }
> break;
> default:
> - RT_TRACE(COMP_ERR, "phy_set_rf8256_bandwidth():
> unknown Bandwidth: %#X\n", Bandwidth);
> + RT_TRACE(COMP_ERR, "%s(): unknown Bandwidth:
> %#X\n", __func__, Bandwidth);
> break;
> }
> }
> @@ -213,7 +213,7 @@ static void phy_rf8256_config_para_file(struct net_device
> *dev)
> }
>
> if (ret) {
> - RT_TRACE(COMP_ERR,
> "phy_rf8256_config_para_file():Radio[%d] Fail!!", eRFPath);
> + RT_TRACE(COMP_ERR, "%s():Radio[%d] Fail!!", __func__,
> eRFPath);
> goto phy_RF8256_Config_ParaFile_Fail;
> }
> }
> @@ -291,5 +291,4 @@ void phy_set_rf8256_ofdm_tx_power(struct net_device *dev,
> u8 powerlevel)
> }
> rtl8192_setBBreg(dev, RegOffset[index], 0x7f7f7f7f, writeVal);
> }
> - return;
> }
> --
> 2.27.0
Hi,
This is the friendly patch-bot of Greg Kroah-Hartman. You have sent him
a patch that has triggered this response. He used to manually respond
to these common problems, but in order to save his sanity (he kept
writing the same thing over and over, yet to different people), I was
created. Hopefully you will not take offence and will fix the problem
in your patch and resubmit it so that it can be accepted into the Linux
kernel tree.
You are receiving this message because of the following common error(s)
as indicated below:
- Your patch did many different things all at once, making it difficult
to review. All Linux kernel patches need to only do one thing at a
time. If you need to do multiple things (such as clean up all coding
style issues in a file/driver), do it in a sequence of patches, each
one doing only one thing. This will make it easier to review the
patches to ensure that they are correct, and to help alleviate any
merge issues that larger patches can cause.
- You did not write a descriptive Subject: for the patch, allowing Greg,
and everyone else, to know what this patch is all about. Please read
the section entitled "The canonical patch format" in the kernel file,
Documentation/SubmittingPatches for what a proper Subject: line should
look like.
If you wish to discuss this problem further, or you have questions about
how to resolve this issue, please feel free to respond to this email and
Greg will reply once he has dug out from the pending patches received
from other developers.
thanks,
greg k-h's patch email bot
___
devel mailing list
de...@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
Re: [PATCH v2] staging: hikey9xx: fix styling issues
On Tue, Feb 16, 2021 at 02:42:55PM +0200, Alaa Emad wrote: > In hi6421-spmi-pmic.c, there are some warnings and Check: > > "WARNING: please, no space before tabs" in lines 51,52,53 and 69. > "CHECK: Alignment should match open parenthesis" in lines 180 and 238. > > Signed-off-by: Alaa Emad That is doing 2 different things in the same patch, please make this a patch series and do only one type of logical thing per patch and resend them. thanks, greg k-h ___ devel mailing list de...@linuxdriverproject.org http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
Re: [PATCH] use explicit host byte-order types in comparison
On Fri, Feb 19, 2021 at 05:51:59AM +0530, karthik alapati wrote: > convert le32 types to host byte-order types before > comparison > Already fixed. Please work against staging-next or linux-next. regards, dan carpenter ___ devel mailing list de...@linuxdriverproject.org http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
Re: [PATCH] staging: removed unnecessary debug message to fix coding style warning
On Sun, Feb 14, 2021 at 07:44:52PM +0530, Ashish Vara wrote: > From: Ashish Vara > > removed unnecessary out of memory message to fix coding style warning. > > Signed-off-by: Ashish Vara > --- > drivers/staging/gasket/gasket_page_table.c | 2 -- > 1 file changed, 2 deletions(-) Your subject line should mention the driver name that you are modifying, right? Look at how other commits have been done for this file, and copy that format. Please fix up and resend. thanks, greg k-h ___ devel mailing list de...@linuxdriverproject.org http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
Re: [PATCH] staging: rtl8712: cleanup checkpatch.pl warnings
On Sun, Feb 14, 2021 at 03:56:01PM +0530, Shreesh Adiga wrote: > Cleanup warnings displayed by checkpatch.pl for the > file rtl8171x_mlme.c for the below warning: > WARNING: Avoid multiple line dereference > > Signed-off-by: Shreesh Adiga <16567adigashre...@gmail.com> > --- > drivers/staging/rtl8712/rtl871x_mlme.c | 112 + > 1 file changed, 39 insertions(+), 73 deletions(-) Always run checkpatch on your patch submission, to ensure that you got it correct. If you note, your Subject line is not ok... thanks, greg k-h ___ devel mailing list de...@linuxdriverproject.org http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
