[staging:staging-testing] BUILD SUCCESS f133717efc6f28052667daf682e99ffd4b3d7588
tree/branch: https://git.kernel.org/pub/scm/linux/kernel/git/gregkh/staging.git staging-testing branch HEAD: f133717efc6f28052667daf682e99ffd4b3d7588 staging: rtl8723bs: fix camel case in struct ndis_802_11_wep elapsed time: 940m configs tested: 130 configs skipped: 4 The following configs have been built successfully. More configs may be tested in the coming days. gcc tested configs: arm defconfig arm64allyesconfig arm64 defconfig arm allyesconfig arm allmodconfig i386 randconfig-c001-20210723 powerpc pasemi_defconfig mips pic32mzda_defconfig mips pistachio_defconfig powerpc ppc44x_defconfig sh polaris_defconfig powerpcsocrates_defconfig mips rm200_defconfig powerpc bamboo_defconfig shsh7785lcr_defconfig powerpc redwood_defconfig mips bmips_stb_defconfig arc tb10x_defconfig arm davinci_all_defconfig mipsworkpad_defconfig powerpcfsp2_defconfig arm vf610m4_defconfig powerpc ps3_defconfig m68k m5208evb_defconfig sh microdev_defconfig powerpc cm5200_defconfig arm pxa910_defconfig h8300allyesconfig arm gemini_defconfig microblaze defconfig arm axm55xx_defconfig mips loongson2k_defconfig sh sdk7780_defconfig powerpc mpc8560_ads_defconfig armxcep_defconfig ia64zx1_defconfig openrisc or1klitex_defconfig sh r7785rp_defconfig h8300alldefconfig powerpc mpc85xx_cds_defconfig sh rts7751r2d1_defconfig m68km5407c3_defconfig sh sh7770_generic_defconfig shshmin_defconfig shmigor_defconfig armhisi_defconfig arm orion5x_defconfig mips ci20_defconfig sh espt_defconfig powerpc tqm8555_defconfig alpha defconfig powerpcmpc7448_hpc2_defconfig powerpc canyonlands_defconfig ia64 allmodconfig ia64defconfig ia64 allyesconfig x86_64allnoconfig m68k allmodconfig m68kdefconfig m68k allyesconfig nios2 defconfig arc allyesconfig nds32 allnoconfig nds32 defconfig nios2allyesconfig cskydefconfig alphaallyesconfig xtensa allyesconfig arc defconfig sh allmodconfig parisc defconfig s390 allyesconfig s390 allmodconfig parisc allyesconfig s390defconfig i386 allyesconfig sparcallyesconfig sparc defconfig i386defconfig mips allyesconfig mips allmodconfig powerpc allyesconfig powerpc allmodconfig powerpc allnoconfig i386 randconfig-a005-20210722 i386 randconfig-a003-20210722 i386 randconfig-a004-20210722 i386 randconfig-a002-20210722 i386 randconfig-a001-20210722 i386 randconfig-a006-20210722 i386 randconfig-a005-20210723 i386 randconfig-a003-20210723 i386 randconfig-a004-20210723 i386 randconfig-a002-20210723 i386 randconfig-a001-20210723 i386 randconfig-a006-20210723 x86_64 randconfig-a011-20210723 x86_64 randconfig-a016-20210723 x86_64 randconfig-a013-20210723 x86_64 randconfig-a014-20210723
Re: [PATCH v3 1/3] drm/loongson: Add DRM Driver for Loongson 7A1000 bridge chip
On Fri, Jul 23, 2021 at 10:57:56AM +0200, Daniel Vetter wrote: > On Fri, Jul 23, 2021 at 11:12:49AM +0800, lichenyang wrote: > > From: Chenyang Li > > > > This patch adds an initial DRM driver for the Loongson LS7A1000 > > bridge chip(LS7A). The LS7A bridge chip contains two display > > controllers, support dual display output. The maximum support for > > each channel display is to 1920x1080@60Hz. > > At present, DC device detection and DRM driver registration are > > completed, the crtc/plane/encoder/connector objects has been > > implemented. > > On Loongson 3A4000 CPU and 7A1000 system, we have achieved the use > > of dual screen, and support dual screen clone mode and expansion > > mode. > > > > v9: > > - Optimize the error handling process. > > - Remove the useless flags parameter. > > - Fix some incorrect use of variables and constructs. > > ... > > Somehow this simple driver is at v9 and still not landed. Do you have > someone from the drm maintainers/committers who's guiding you through all > this? I'm not seeing you Cc: a specific person, without that there's good > chances your contribution gets lost. I'm swamped myself, which is why I've > ignored this and hope you'd fine someone else and stick to them. Hi Chenyang, Please cc: me on the next revision - then I will take a look. But I count on someone more familiar with atomic modesetting can also take a look. Thomas? Maxime? Sam ___ devel mailing list de...@linuxdriverproject.org http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
[driver-core:debugfs_cleanup] BUILD SUCCESS 8b9809c2242415ba32ef5e5108d2b1acdafeaaf0
tree/branch: https://git.kernel.org/pub/scm/linux/kernel/git/gregkh/driver-core.git debugfs_cleanup branch HEAD: 8b9809c2242415ba32ef5e5108d2b1acdafeaaf0 percpu: remove export of pcpu_base_addr elapsed time: 1251m configs tested: 131 configs skipped: 4 The following configs have been built successfully. More configs may be tested in the coming days. gcc tested configs: arm defconfig arm64allyesconfig arm64 defconfig arm allyesconfig arm allmodconfig i386 randconfig-c001-20210723 i386 randconfig-c001-20210722 powerpc tqm8541_defconfig powerpc xes_mpc85xx_defconfig mipsmaltaup_defconfig powerpcsam440ep_defconfig arm imx_v4_v5_defconfig arm tct_hammer_defconfig arm omap1_defconfig mips tb0226_defconfig sh rts7751r2d1_defconfig sparc sparc64_defconfig powerpc ppc40x_defconfig sh magicpanelr2_defconfig arm axm55xx_defconfig mips loongson2k_defconfig sh sdk7780_defconfig powerpc mpc8560_ads_defconfig armxcep_defconfig ia64zx1_defconfig powerpc mpc5200_defconfig nios2 10m50_defconfig mips ath25_defconfig shmigor_defconfig xtensa cadence_csp_defconfig nds32 defconfig armhisi_defconfig arm orion5x_defconfig mips ci20_defconfig ia64 allmodconfig ia64defconfig ia64 allyesconfig x86_64allnoconfig m68k allmodconfig m68kdefconfig m68k allyesconfig nios2 defconfig arc allyesconfig nds32 allnoconfig nios2allyesconfig cskydefconfig alpha defconfig alphaallyesconfig xtensa allyesconfig h8300allyesconfig arc defconfig sh allmodconfig parisc defconfig s390 allyesconfig s390 allmodconfig parisc allyesconfig s390defconfig i386 allyesconfig sparcallyesconfig sparc defconfig i386defconfig mips allyesconfig mips allmodconfig powerpc allyesconfig powerpc allmodconfig powerpc allnoconfig x86_64 randconfig-a003-20210722 x86_64 randconfig-a006-20210722 x86_64 randconfig-a001-20210722 x86_64 randconfig-a005-20210722 x86_64 randconfig-a004-20210722 x86_64 randconfig-a002-20210722 i386 randconfig-a005-20210722 i386 randconfig-a003-20210722 i386 randconfig-a004-20210722 i386 randconfig-a002-20210722 i386 randconfig-a001-20210722 i386 randconfig-a006-20210722 i386 randconfig-a005-20210723 i386 randconfig-a003-20210723 i386 randconfig-a004-20210723 i386 randconfig-a002-20210723 i386 randconfig-a001-20210723 i386 randconfig-a006-20210723 x86_64 randconfig-a011-20210723 x86_64 randconfig-a016-20210723 x86_64 randconfig-a013-20210723 x86_64 randconfig-a014-20210723 x86_64 randconfig-a012-20210723 x86_64 randconfig-a015-20210723 i386 randconfig-a016-20210723 i386 randconfig-a013-20210723 i386 randconfig-a012-20210723 i386 randconfig-a011-20210723 i386 randconfig-a014-20210723 i386 randconfig-a015-20210723 i386 randconfig-a016-20210722 i386 randconfig-a013-20210722 i386 randconfig-a012-20210722 i386 randconfig-a011-20210722 i386
[PATCH v2 3/3] staging: rtl8188eu: Remove blank line at core/rtw_ap.c:1143
This commit fixes the following checkpatch.pl CHECK:
CHECK: Blank lines aren't necessary after an open brace '{'
1143: FILE: drivers/staging/rtl8188eu/core/rtw_ap.c:1143:
+{
+
Signed-off-by: Benjamin Philip
---
drivers/staging/rtl8188eu/core/rtw_ap.c | 1 -
1 file changed, 1 deletion(-)
diff --git a/drivers/staging/rtl8188eu/core/rtw_ap.c
b/drivers/staging/rtl8188eu/core/rtw_ap.c
index ba3a6347976d..a2aeb78733d5 100644
--- a/drivers/staging/rtl8188eu/core/rtw_ap.c
+++ b/drivers/staging/rtl8188eu/core/rtw_ap.c
@@ -1138,7 +1138,6 @@ static void update_bcn_wps_ie(struct adapter *padapter)
static void update_bcn_vendor_spec_ie(struct adapter *padapter, u8 *oui)
{
-
if (!memcmp(WPS_OUI, oui, 4))
update_bcn_wps_ie(padapter);
}
--
2.31.1
___
devel mailing list
de...@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
[PATCH v2 2/3] staging: rtl8188eu: Remove blank line at core/rtw_ap.c:457
This commit fixes the following checkpatch.pl CHECK: CHECK: Blank lines aren't necessary before a close brace '}' 457: FILE: drivers/staging/rtl8188eu/core/rtw_ap.c:457: + + } Signed-off-by: Benjamin Philip --- drivers/staging/rtl8188eu/core/rtw_ap.c | 1 - 1 file changed, 1 deletion(-) diff --git a/drivers/staging/rtl8188eu/core/rtw_ap.c b/drivers/staging/rtl8188eu/core/rtw_ap.c index 215a0285005f..ba3a6347976d 100644 --- a/drivers/staging/rtl8188eu/core/rtw_ap.c +++ b/drivers/staging/rtl8188eu/core/rtw_ap.c @@ -452,7 +452,6 @@ static void update_bmc_sta(struct adapter *padapter) spin_lock_bh(&psta->lock); psta->state = _FW_LINKED; spin_unlock_bh(&psta->lock); - } } -- 2.31.1 ___ devel mailing list de...@linuxdriverproject.org http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
[PATCH v2 1/3] staging: rtl8188eu: Remove blank line at core/rtw_ap.c:385
This commit fixes the following checkpatch.pl CHECK: CHECK: Blank lines aren't necessary before a close brace '}' 385: FILE: drivers/staging/rtl8188eu/core/rtw_ap.c:385: + + } Signed-off-by: Benjamin Philip --- drivers/staging/rtl8188eu/core/rtw_ap.c | 1 - 1 file changed, 1 deletion(-) diff --git a/drivers/staging/rtl8188eu/core/rtw_ap.c b/drivers/staging/rtl8188eu/core/rtw_ap.c index b817aa8b9de4..215a0285005f 100644 --- a/drivers/staging/rtl8188eu/core/rtw_ap.c +++ b/drivers/staging/rtl8188eu/core/rtw_ap.c @@ -381,7 +381,6 @@ void add_RATid(struct adapter *padapter, struct sta_info *psta, u8 rssi_level) /* set ra_id, init_rate */ psta->raid = raid; psta->init_rate = init_rate; - } } -- 2.31.1 ___ devel mailing list de...@linuxdriverproject.org http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
[PATCH v2 0/3] Remove blank lines at drivers/rtl8188eu/core/rtw_ap.c
The following few patches remove some blank lines that before or after a brace. To test my changes, I have checked if it compiles (which it does). I also have checked the patch with checkpatch.pl, which does not pass any warnings of any sort. Changes in v2: * Tested by building (no changes code) This is my first patch to the linux kernel. I apologize for all the inconveniences caused by my unfamiliarity with the kernel workflow. I also have split each line I removed into a patch so that it is convenient for the maintainer. I hope it is so. Thanks, Benjamin Philip Benjamin Philip (3): staging: rtl8188eu: Remove blank line at core/rtw_ap.c:385 staging: rtl8188eu: Remove blank line at core/rtw_ap.c:457 staging: rtl8188eu: Remove blank line at core/rtw_ap.c:1143 drivers/staging/rtl8188eu/core/rtw_ap.c | 3 --- 1 file changed, 3 deletions(-) -- 2.31.1 ___ devel mailing list de...@linuxdriverproject.org http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
Re: [PATCH v3 1/3] drm/loongson: Add DRM Driver for Loongson 7A1000 bridge chip
On Fri, Jul 23, 2021 at 11:12:49AM +0800, lichenyang wrote: > From: Chenyang Li > > This patch adds an initial DRM driver for the Loongson LS7A1000 > bridge chip(LS7A). The LS7A bridge chip contains two display > controllers, support dual display output. The maximum support for > each channel display is to 1920x1080@60Hz. > At present, DC device detection and DRM driver registration are > completed, the crtc/plane/encoder/connector objects has been > implemented. > On Loongson 3A4000 CPU and 7A1000 system, we have achieved the use > of dual screen, and support dual screen clone mode and expansion > mode. > > v9: > - Optimize the error handling process. > - Remove the useless flags parameter. > - Fix some incorrect use of variables and constructs. > > v8: > - Update the atomic_update function interface. > > v7: > - The pixel clock is limited to less than 173000. > > v6: > - Remove spin_lock in mmio reg read and write. > - TO_UNCAC is replac with ioremap. > - Fix error arguments in crtc_atomic_enable/disable/mode_valid. > > v5: > - Change the name of the chip to LS7A. > - Change magic value in crtc to macros. > - Correct mistakes words. > - Change the register operation function prefix to ls7a. > > v4: > - Move the mode_valid function to the crtc. > > v3: > - Move the mode_valid function to the connector and optimize it. > - Fix num_crtc calculation method. > > v2: > - Complete the case of 32-bit color in CRTC. > > Signed-off-by: Chenyang Li Somehow this simple driver is at v9 and still not landed. Do you have someone from the drm maintainers/committers who's guiding you through all this? I'm not seeing you Cc: a specific person, without that there's good chances your contribution gets lost. I'm swamped myself, which is why I've ignored this and hope you'd fine someone else and stick to them. A few comments below. > --- > drivers/gpu/drm/Kconfig | 2 + > drivers/gpu/drm/Makefile | 1 + > drivers/gpu/drm/loongson/Kconfig | 14 + > drivers/gpu/drm/loongson/Makefile | 14 + > drivers/gpu/drm/loongson/loongson_connector.c | 46 +++ > drivers/gpu/drm/loongson/loongson_crtc.c | 249 > drivers/gpu/drm/loongson/loongson_device.c| 35 +++ > drivers/gpu/drm/loongson/loongson_drv.c | 278 ++ > drivers/gpu/drm/loongson/loongson_drv.h | 140 + > drivers/gpu/drm/loongson/loongson_encoder.c | 37 +++ > drivers/gpu/drm/loongson/loongson_plane.c | 97 ++ > 11 files changed, 913 insertions(+) > create mode 100644 drivers/gpu/drm/loongson/Kconfig > create mode 100644 drivers/gpu/drm/loongson/Makefile > create mode 100644 drivers/gpu/drm/loongson/loongson_connector.c > create mode 100644 drivers/gpu/drm/loongson/loongson_crtc.c > create mode 100644 drivers/gpu/drm/loongson/loongson_device.c > create mode 100644 drivers/gpu/drm/loongson/loongson_drv.c > create mode 100644 drivers/gpu/drm/loongson/loongson_drv.h > create mode 100644 drivers/gpu/drm/loongson/loongson_encoder.c > create mode 100644 drivers/gpu/drm/loongson/loongson_plane.c > > diff --git a/drivers/gpu/drm/Kconfig b/drivers/gpu/drm/Kconfig > index 7ff89690a976..08562d9be6e3 100644 > --- a/drivers/gpu/drm/Kconfig > +++ b/drivers/gpu/drm/Kconfig > @@ -365,6 +365,8 @@ source "drivers/gpu/drm/xen/Kconfig" > > source "drivers/gpu/drm/vboxvideo/Kconfig" > > +source "drivers/gpu/drm/loongson/Kconfig" > + > source "drivers/gpu/drm/lima/Kconfig" > > source "drivers/gpu/drm/panfrost/Kconfig" > diff --git a/drivers/gpu/drm/Makefile b/drivers/gpu/drm/Makefile > index a118692a6df7..29c05b8cf2ad 100644 > --- a/drivers/gpu/drm/Makefile > +++ b/drivers/gpu/drm/Makefile > @@ -119,6 +119,7 @@ obj-$(CONFIG_DRM_PL111) += pl111/ > obj-$(CONFIG_DRM_TVE200) += tve200/ > obj-$(CONFIG_DRM_XEN) += xen/ > obj-$(CONFIG_DRM_VBOXVIDEO) += vboxvideo/ > +obj-$(CONFIG_DRM_LOONGSON) += loongson/ > obj-$(CONFIG_DRM_LIMA) += lima/ > obj-$(CONFIG_DRM_PANFROST) += panfrost/ > obj-$(CONFIG_DRM_ASPEED_GFX) += aspeed/ > diff --git a/drivers/gpu/drm/loongson/Kconfig > b/drivers/gpu/drm/loongson/Kconfig > new file mode 100644 > index ..3cf42a4cca08 > --- /dev/null > +++ b/drivers/gpu/drm/loongson/Kconfig > @@ -0,0 +1,14 @@ > +# SPDX-License-Identifier: GPL-2.0-only > + > +config DRM_LOONGSON > + tristate "DRM support for LS7A bridge chipset" > + depends on DRM && PCI > + depends on CPU_LOONGSON64 > + select DRM_KMS_HELPER > + select DRM_VRAM_HELPER > + select DRM_TTM > + select DRM_TTM_HELPER > + default n > + help > + Support the display controllers found on the Loongson LS7A > + bridge. > diff --git a/drivers/gpu/drm/loongson/Makefile > b/drivers/gpu/drm/loongson/Makefile > new file mode 100644 > index ..22d063953b78 > --- /dev/null > +++ b/drivers/gpu/drm/loongson/Makefile > @@ -0,0 +1,14 @@ > +# SPDX-License-Identifier: GPL-2.0-only > +# > +# M
Re: [PATCH v3 1/3] drm/loongson: Add DRM Driver for Loongson 7A1000 bridge chip
On Fri, Jul 23, 2021 at 11:12:49AM +0800, lichenyang wrote:
> +static int loongson_drm_load(struct drm_device *dev)
> +{
> + struct loongson_device *ldev;
> + int ret;
> +
> + ldev = devm_kzalloc(dev->dev, sizeof(*ldev), GFP_KERNEL);
> + if (!ldev)
> + return -ENOMEM;
> +
> + dev->dev_private = ldev;
> + ldev->dev = dev;
> +
> + ret = loongson_device_init(dev);
> + if (ret)
> + goto err;
> +
> + ret = drmm_vram_helper_init(dev, ldev->vram_start, ldev->vram_size);
> + if (ret) {
> + drm_err(dev, "Error initializing vram %d\n", ret);
> + goto err;
> + }
> +
> + drm_mode_config_init(dev);
> + dev->mode_config.funcs = (void *)&loongson_mode_funcs;
> + dev->mode_config.min_width = 1;
> + dev->mode_config.min_height = 1;
> + dev->mode_config.max_width = 4096;
> + dev->mode_config.max_height = 4096;
> + dev->mode_config.preferred_depth = 32;
> + dev->mode_config.prefer_shadow = 1;
> + dev->mode_config.fb_base = ldev->vram_start;
> +
> + ret = loongson_modeset_init(ldev);
> + if (ret) {
> + drm_err(dev, "Fatal error during modeset init: %d\n", ret);
> + goto err;
> + }
> +
> + drm_kms_helper_poll_init(dev);
> + drm_mode_config_reset(dev);
> +
> + return 0;
> +
> +err:
> + kfree(ldev);
I'm sorry, in the earlier version I told you to add this kfree() but
this is devm_ allocated so the kfree() is wrong and will lead to a
double free. My bad. That's on me.
> + drm_err(dev, "failed to initialize drm driver: %d\n", ret);
> + return ret;
> +}
regards,
dan carpenter
___
devel mailing list
de...@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
