Re: [PATCH 03/10] staging: wfx: format comments on 100 columns
On Fri, 2022-02-25 at 12:23 +0100, Jerome Pouiller wrote:
> From: Jérôme Pouiller
>
> A few comments were not yet formatted on 100 columns.
IMO, none of these changes are necessary or good changes.
80 columns is preferred.
Really comments should most always use 80 columns, and
only occasionally should code be more than 80 columns
and almost never should code be more than 100 columns.
> diff --git a/drivers/staging/wfx/data_tx.c b/drivers/staging/wfx/data_tx.c
[]
> @@ -117,9 +117,7 @@ static int wfx_tx_policy_get(struct wfx_vif *wvif, struct
> ieee80211_tx_rate *rat
> if (idx >= 0) {
> *renew = false;
> } else {
> - /* If policy is not found create a new one using the oldest
> - * entry in "free" list
> - */
> + /* If policy is not found create a new one using the oldest
> entry in "free" list */
> *renew = true;
> entry = list_entry(cache->free.prev, struct wfx_tx_policy,
> link);
> memcpy(entry->rates, wanted.rates, sizeof(entry->rates));
> @@ -494,9 +492,7 @@ void wfx_tx_confirm_cb(struct wfx_dev *wdev, const struct
> wfx_hif_cnf_tx *arg)
> wfx_tx_fill_rates(wdev, tx_info, arg);
> skb_trim(skb, skb->len - tx_priv->icv_size);
>
> - /* From now, you can touch to tx_info->status, but do not touch to
> - * tx_priv anymore
> - */
> + /* From now, you can touch to tx_info->status, but do not touch to
> tx_priv anymore */
> /* FIXME: use ieee80211_tx_info_clear_status() */
> memset(tx_info->rate_driver_data, 0, sizeof(tx_info->rate_driver_data));
> memset(tx_info->pad, 0, sizeof(tx_info->pad));
> diff --git a/drivers/staging/wfx/queue.c b/drivers/staging/wfx/queue.c
[]
> @@ -210,8 +210,8 @@ bool wfx_tx_queues_has_cab(struct wfx_vif *wvif)
> if (wvif->vif->type != NL80211_IFTYPE_AP)
> return false;
> for (i = 0; i < IEEE80211_NUM_ACS; ++i)
> - /* Note: since only AP can have mcast frames in queue and only
> - * one vif can be AP, all queued frames has same interface id
> + /* Note: since only AP can have mcast frames in queue and only
> one vif can be AP,
> + * all queued frames has same interface id
>*/
> if (!skb_queue_empty_lockless(&wvif->tx_queue[i].cab))
> return true;
> @@ -253,9 +253,8 @@ static struct sk_buff *wfx_tx_queues_get_skb(struct
> wfx_dev *wdev)
> skb = skb_dequeue(&queues[i]->cab);
> if (!skb)
> continue;
> - /* Note: since only AP can have mcast frames in queue
> - * and only one vif can be AP, all queued frames has
> - * same interface id
> + /* Note: since only AP can have mcast frames in queue
> and only one vif can
> + * be AP, all queued frames has same interface id
>*/
> hif = (struct wfx_hif_msg *)skb->data;
> WARN_ON(hif->interface != wvif->id);
___
devel mailing list
de...@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
[staging:staging-next] BUILD SUCCESS dbbe23c31922ff773a0847a5c1d3c41050fe1c67
tree/branch: https://git.kernel.org/pub/scm/linux/kernel/git/gregkh/staging.git staging-next branch HEAD: dbbe23c31922ff773a0847a5c1d3c41050fe1c67 Merge 5.17-rc6 into staging-next elapsed time: 722m configs tested: 179 configs skipped: 5 The following configs have been built successfully. More configs may be tested in the coming days. gcc tested configs: arm defconfig arm64allyesconfig arm64 defconfig arm allyesconfig arm allmodconfig i386 randconfig-c001 i386 randconfig-c001-20220228 powerpcsam440ep_defconfig sparcallyesconfig mips xway_defconfig shsh7785lcr_defconfig mips db1xxx_defconfig arc nsimosci_hs_smp_defconfig shecovec24-romimage_defconfig m68kmac_defconfig sh sh7710voipgw_defconfig powerpc bamboo_defconfig pariscgeneric-32bit_defconfig powerpc pcm030_defconfig m68k m5208evb_defconfig openriscor1ksim_defconfig armtrizeps4_defconfig arc haps_hs_defconfig powerpc cm5200_defconfig arcnsim_700_defconfig xtensa alldefconfig powerpcamigaone_defconfig powerpc sequoia_defconfig alpha defconfig powerpc maple_defconfig powerpc currituck_defconfig m68k allyesconfig m68kmvme16x_defconfig sh se7619_defconfig powerpcadder875_defconfig mips fuloong2e_defconfig sh microdev_defconfig mips ci20_defconfig sh lboxre2_defconfig nios2 defconfig shsh7757lcr_defconfig powerpc motionpro_defconfig sh alldefconfig um x86_64_defconfig sh rts7751r2d1_defconfig sh polaris_defconfig sh sh03_defconfig xtensasmp_lx200_defconfig mipsar7_defconfig sh espt_defconfig xtensa common_defconfig armoxnas_v6_defconfig sh se7206_defconfig arcvdk_hs38_defconfig nds32 defconfig arm ezx_defconfig openrisc alldefconfig sh se7751_defconfig powerpc linkstation_defconfig arm badge4_defconfig arc axs101_defconfig powerpc chrp32_defconfig powerpc mgcoge_defconfig m68k amcore_defconfig powerpc taishan_defconfig sh urquell_defconfig powerpc rainier_defconfig arm pxa910_defconfig ia64 allmodconfig m68k apollo_defconfig armspear6xx_defconfig m68k amiga_defconfig arm viper_defconfig arm randconfig-c002-20220228 arm randconfig-c002-20220227 ia64defconfig ia64 allyesconfig m68kdefconfig m68k allmodconfig arc allyesconfig nds32 allnoconfig nios2allyesconfig cskydefconfig alphaallyesconfig xtensa allyesconfig h8300allyesconfig arc defconfig sh allmodconfig parisc defconfig s390 allyesconfig s390 allmodconfig parisc64defconfig parisc allyesconfig s390defconfig i386 allyesconfig sparc defconfig i386defconfig i386 debian-10.3-kselftests i386 debian-10.3 mips allyesconfig mips
[driver-core:kobject-const] BUILD SUCCESS 9b166123d295cb50f047601e80c6862d42b5d2be
tree/branch: https://git.kernel.org/pub/scm/linux/kernel/git/gregkh/driver-core.git kobject-const branch HEAD: 9b166123d295cb50f047601e80c6862d42b5d2be kobject: kobj_type: remove default_attrs elapsed time: 721m configs tested: 154 configs skipped: 3 The following configs have been built successfully. More configs may be tested in the coming days. gcc tested configs: arm defconfig arm64allyesconfig arm64 defconfig arm allyesconfig arm allmodconfig i386 randconfig-c001 i386 randconfig-c001-20220228 arcvdk_hs38_smp_defconfig xtensa nommu_kc705_defconfig openrisc or1klitex_defconfig arm rpc_defconfig powerpcsam440ep_defconfig sparcallyesconfig mips xway_defconfig shsh7785lcr_defconfig powerpc pcm030_defconfig m68k m5208evb_defconfig openriscor1ksim_defconfig armtrizeps4_defconfig arc haps_hs_defconfig powerpc cm5200_defconfig arcnsim_700_defconfig xtensa alldefconfig powerpcamigaone_defconfig powerpc sequoia_defconfig alpha defconfig arc tb10x_defconfig arm stm32_defconfig powerpc maple_defconfig powerpc currituck_defconfig m68k allyesconfig mips fuloong2e_defconfig mips ci20_defconfig powerpcadder875_defconfig sh lboxre2_defconfig sh microdev_defconfig sh polaris_defconfig sh sh03_defconfig xtensasmp_lx200_defconfig sh rts7751r2d1_defconfig mipsar7_defconfig sh espt_defconfig sh se7206_defconfig arcvdk_hs38_defconfig nds32 defconfig arm ezx_defconfig arc axs101_defconfig powerpc chrp32_defconfig powerpc mgcoge_defconfig m68k amcore_defconfig powerpc taishan_defconfig sh sh7710voipgw_defconfig sh urquell_defconfig m68kmvme16x_defconfig powerpc rainier_defconfig arm pxa910_defconfig arm randconfig-c002-20220227 arm randconfig-c002-20220228 ia64 allmodconfig ia64defconfig ia64 allyesconfig m68kdefconfig m68k allmodconfig nios2 defconfig arc allyesconfig nds32 allnoconfig nios2allyesconfig cskydefconfig alphaallyesconfig xtensa allyesconfig h8300allyesconfig arc defconfig sh allmodconfig parisc defconfig s390 allyesconfig s390 allmodconfig parisc64defconfig parisc allyesconfig s390defconfig i386 allyesconfig sparc defconfig i386defconfig i386 debian-10.3-kselftests i386 debian-10.3 mips allyesconfig mips allmodconfig powerpc allyesconfig powerpc allmodconfig powerpc allnoconfig x86_64 randconfig-a011-20220228 x86_64 randconfig-a015-20220228 x86_64 randconfig-a014-20220228 x86_64 randconfig-a013-20220228 x86_64 randconfig-a016-20220228 x86_64 randconfig-a012-20220228 i386 randconfig-a016-20220228 i386 randconfig-a012-20220228 i386 randconfig-a015-20220228 i386 randconfig-a011-20220228 i386 randconfig-a013-20220228 i386
[driver-core:driver-core-testing] BUILD SUCCESS 4a248f85b3dd8e010ff8335755c927130e9b0764
tree/branch: https://git.kernel.org/pub/scm/linux/kernel/git/gregkh/driver-core.git driver-core-testing branch HEAD: 4a248f85b3dd8e010ff8335755c927130e9b0764 Merge 5.17-rc6 into driver-core-next elapsed time: 721m configs tested: 187 configs skipped: 3 The following configs have been built successfully. More configs may be tested in the coming days. gcc tested configs: arm defconfig arm64allyesconfig arm64 defconfig arm allyesconfig arm allmodconfig i386 randconfig-c001 i386 randconfig-c001-20220228 powerpcsam440ep_defconfig sparcallyesconfig mips xway_defconfig shsh7785lcr_defconfig arm lpd270_defconfig m68k sun3_defconfig armzeus_defconfig mips ip32_defconfig mips loongson3_defconfig powerpc pcm030_defconfig m68k m5208evb_defconfig openriscor1ksim_defconfig armtrizeps4_defconfig arm pxa3xx_defconfig powerpc mpc8540_ads_defconfig m68k m5249evb_defconfig arc haps_hs_defconfig powerpc cm5200_defconfig arcnsim_700_defconfig xtensa alldefconfig arm aspeed_g5_defconfig sparc sparc64_defconfig powerpcamigaone_defconfig powerpc sequoia_defconfig alpha defconfig sh rsk7264_defconfig openrisc simple_smp_defconfig arc haps_hs_smp_defconfig arc tb10x_defconfig arm stm32_defconfig riscvallyesconfig armclps711x_defconfig sh kfr2r09-romimage_defconfig um defconfig powerpc maple_defconfig powerpc currituck_defconfig m68k allyesconfig powerpcadder875_defconfig mips fuloong2e_defconfig sh microdev_defconfig mips ci20_defconfig sh lboxre2_defconfig xtensa iss_defconfig arm integrator_defconfig m68kdefconfig sh rts7751r2d1_defconfig sh polaris_defconfig sh sh03_defconfig xtensasmp_lx200_defconfig sh espt_defconfig mipsar7_defconfig arcvdk_hs38_defconfig arm ezx_defconfig sh se7206_defconfig nds32 defconfig s390 zfcpdump_defconfig powerpc mgcoge_defconfig armpleb_defconfig armmulti_v7_defconfig arc axs101_defconfig powerpc chrp32_defconfig m68k amcore_defconfig powerpc taishan_defconfig sh sh7710voipgw_defconfig m68kmvme16x_defconfig sh urquell_defconfig powerpc rainier_defconfig arm pxa910_defconfig arm randconfig-c002-20220228 arm randconfig-c002-20220227 ia64 allmodconfig ia64defconfig ia64 allyesconfig m68k allmodconfig nios2 defconfig arc allyesconfig nds32 allnoconfig nios2allyesconfig cskydefconfig alphaallyesconfig arc defconfig sh allmodconfig h8300allyesconfig xtensa allyesconfig parisc defconfig s390 allyesconfig s390 allmodconfig parisc64defconfig parisc allyesconfig s390defconfig i386 allyesconfig sparc defconfig i386defconfig i386
Re: [PATCH v10 0/1] wfx: get out from the staging area
+ Rob
+ devicetree
On Saturday 26 February 2022 11:41:41 CET Kalle Valo wrote:
> + jakub
>
> Jerome Pouiller writes:
>
> > The firmware and the PDS files (= antenna configurations) are now a part of
> > the linux-firmware repository.
> >
> > All the issues have been fixed in staging tree. I think we are ready to get
> > out from the staging tree for the kernel 5.18.
>
> [...]
>
> > rename Documentation/devicetree/bindings/{staging =>
> > }/net/wireless/silabs,wfx.yaml (98%)
>
> I lost track, is this file acked by the DT maintainers now?
Indeed, it seems Greg applied this patch[1] before Rob acked it.
However, the is DT now included in "make dt_binding_check" (because
it is now located in Documentation/devicetree/bindings/) and Rob
haven't raised any red flag.
[1]:
https://lore.kernel.org/netdev/20220217103248.183770-1-jerome.pouil...@silabs.com/t/
> What I suggest is that we queue this for v5.19. After v5.18-rc1 is
> released I could create an immutable branch containing this one commit.
> Then I would merge the branch to wireless-next and Greg could merge it
> to the staging tree, that way we would minimise the chance of conflicts
> between trees.
Right.
> Greg, what do you think? Would this work for you? IIRC we did the same
> with wilc1000 back in 2020 and I recall it went without hiccups.
--
Jérôme Pouiller
___
devel mailing list
de...@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
