Re: [PATCH] Drivers:staging:octeon: Fixed checkpatch warning
Hello I sign the documents as Athira Lekshmi. Thanking You Athira Lekshmi ___ devel mailing list de...@linuxdriverproject.org http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
Re: [PATCH] Drivers:staging:octeon: Fixed checkpatch warning
Hello I have resend the patch signing off as Athira Lekshmi. Thanking You Athira Lekshmi ___ devel mailing list de...@linuxdriverproject.org http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
Re: [PATCH] Drivers:staging:octeon: Fixed checkpatch warning
C V is my initals . Can I just go with the name Athira Lekshmi ? Thanking You Athira Lekshmi C V On Thu, Nov 27, 2014 at 3:14 AM, Greg KH gre...@linuxfoundation.org wrote: On Wed, Nov 26, 2014 at 05:58:37PM +0530, Athira Lekshmi C V wrote: Fixed the checkpatch warning: WARNING: Missing a blank line after declarations Signed-off-by: Athira Lekshmi C V andnlnb...@gmail.com What is the C V at the end of the name here? Is that your full name? I need a real name, not initials. ___ devel mailing list de...@linuxdriverproject.org http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
[PATCH] Drivers:staging:speakup: Fixed checkpatch warning
Fixed the checkpatch warning:
WARNING: simple_strtoul is obsolete, use kstrtoul instead
Signed-off-by: Athira Lekshmi C V andnlnb...@gmail.com
---
drivers/staging/speakup/varhandlers.c |2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/staging/speakup/varhandlers.c
b/drivers/staging/speakup/varhandlers.c
index 1b0d1c0..00fd67e 100644
--- a/drivers/staging/speakup/varhandlers.c
+++ b/drivers/staging/speakup/varhandlers.c
@@ -324,7 +324,7 @@ char *spk_s2uchar(char *start, char *dest)
{
int val = 0;
- val = simple_strtoul(skip_spaces(start), start, 10);
+ val = kstrtoul(skip_spaces(start), start, 10);
if (*start == ',')
start++;
*dest = (u_char)val;
--
1.7.9.5
___
devel mailing list
de...@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
[PATCH] Drivers:staging:comedi:drivers: Fixed checkpatch warning
Fixed the checkpatch warning: WARNING: please, no space before tabs Signed-off-by: Athira Lekshmi C V andnlnb...@gmail.com --- drivers/staging/comedi/drivers/ni_at_a2150.c |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/staging/comedi/drivers/ni_at_a2150.c b/drivers/staging/comedi/drivers/ni_at_a2150.c index 69e543a..bff4852 100644 --- a/drivers/staging/comedi/drivers/ni_at_a2150.c +++ b/drivers/staging/comedi/drivers/ni_at_a2150.c @@ -108,7 +108,7 @@ TRIG_WAKE_EOS #define IRQ_LVL_BITS(x) (((x) 0xf) 4) /* sets irq level */ #define FIFO_INTR_EN_BIT 0x100 /* enable fifo interrupts */ #define FIFO_INTR_FHF_BIT0x200 /* interrupt fifo half full */ -#define DMA_INTR_EN_BIT 0x800 /* enable interrupt on dma terminal count */ +#define DMA_INTR_EN_BIT 0x800 /* enable interrupt on dma terminal count */ #define DMA_DEM_EN_BIT 0x1000 /* enables demand mode dma */ #define I8253_BASE_REG 0x14 #define I8253_MODE_REG 0x17 -- 1.7.9.5 ___ devel mailing list de...@linuxdriverproject.org http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
[PATCH] Drivers:staging:octeon: Fixed checkpatch warning
Fixed the checkpatch warning:
WARNING: Missing a blank line after declarations
Signed-off-by: Athira Lekshmi C V andnlnb...@gmail.com
---
drivers/staging/octeon/ethernet-rx.c |5 +
1 file changed, 5 insertions(+)
diff --git a/drivers/staging/octeon/ethernet-rx.c
b/drivers/staging/octeon/ethernet-rx.c
index 44e372f..f80d509 100644
--- a/drivers/staging/octeon/ethernet-rx.c
+++ b/drivers/staging/octeon/ethernet-rx.c
@@ -84,6 +84,7 @@ static int cvm_irq_cpu;
static void cvm_oct_enable_napi(void *_)
{
int cpu = smp_processor_id();
+
napi_schedule(cvm_oct_napi[cpu].napi);
}
@@ -169,6 +170,7 @@ static inline int cvm_oct_check_rcv_error(cvmx_wqe_t *work)
int interface = cvmx_helper_get_interface_num(work-ipprt);
int index = cvmx_helper_get_interface_index_num(work-ipprt);
union cvmx_gmxx_rxx_frm_ctl gmxx_rxx_frm_ctl;
+
gmxx_rxx_frm_ctl.u64 =
cvmx_read_csr(CVMX_GMXX_RXX_FRM_CTL(index, interface));
if (gmxx_rxx_frm_ctl.s.pre_chk == 0) {
@@ -272,6 +274,7 @@ static int cvm_oct_napi_poll(struct napi_struct *napi, int
budget)
did_work_request = 0;
if (work == NULL) {
union cvmx_pow_wq_int wq_int;
+
wq_int.u64 = 0;
wq_int.s.iq_dis = 1 pow_receive_group;
wq_int.s.wq_int = 1 pow_receive_group;
@@ -294,8 +297,10 @@ static int cvm_oct_napi_poll(struct napi_struct *napi, int
budget)
* CPU.
*/
union cvmx_pow_wq_int_cntx counts;
+
int backlog;
int cores_in_use = core_state.baseline_cores -
atomic_read(core_state.available_cores);
+
counts.u64 =
cvmx_read_csr(CVMX_POW_WQ_INT_CNTX(pow_receive_group));
backlog = counts.s.iq_cnt + counts.s.ds_cnt;
if (backlog budget * cores_in_use napi != NULL)
--
1.7.9.5
___
devel mailing list
de...@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
[PATCH] Drivers:staging:octeon: Fixed checkpatch warning
Fixed the checkpatch warning:
WARNING: Missing a blank line after declarations
Signed-off-by: Athira Lekshmi C V andnlnb...@gmail.com
---
drivers/staging/octeon/ethernet-rx.c |2 ++
1 file changed, 2 insertions(+)
diff --git a/drivers/staging/octeon/ethernet-rx.c
b/drivers/staging/octeon/ethernet-rx.c
index 44e372f..a7ff01c 100644
--- a/drivers/staging/octeon/ethernet-rx.c
+++ b/drivers/staging/octeon/ethernet-rx.c
@@ -84,6 +84,7 @@ static int cvm_irq_cpu;
static void cvm_oct_enable_napi(void *_)
{
int cpu = smp_processor_id();
+
napi_schedule(cvm_oct_napi[cpu].napi);
}
@@ -296,6 +297,7 @@ static int cvm_oct_napi_poll(struct napi_struct *napi, int
budget)
union cvmx_pow_wq_int_cntx counts;
int backlog;
int cores_in_use = core_state.baseline_cores -
atomic_read(core_state.available_cores);
+
counts.u64 =
cvmx_read_csr(CVMX_POW_WQ_INT_CNTX(pow_receive_group));
backlog = counts.s.iq_cnt + counts.s.ds_cnt;
if (backlog budget * cores_in_use napi != NULL)
--
1.7.9.5
___
devel mailing list
de...@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
[PATCH] Drivers:staging:wlan-ng: Fixed checkpatch warning
The following checkpatch warning was fixed
WARNING: line over 80 characters
Signed-off-by: Athira Lekshmi C V andnlnb...@gmail.com
---
drivers/staging/wlan-ng/prism2fw.c | 10 +++---
1 file changed, 7 insertions(+), 3 deletions(-)
diff --git a/drivers/staging/wlan-ng/prism2fw.c
b/drivers/staging/wlan-ng/prism2fw.c
index e907380..8e1da3c 100644
--- a/drivers/staging/wlan-ng/prism2fw.c
+++ b/drivers/staging/wlan-ng/prism2fw.c
@@ -238,7 +238,8 @@ static int prism2_fwtry(struct usb_device *udev,
wlandevice_t *wlandev)
* 0 - success
* ~0 - failure
*/
-static int prism2_fwapply(const struct ihex_binrec *rfptr, wlandevice_t
*wlandev)
+static int prism2_fwapply(const struct ihex_binrec *rfptr,
+ wlandevice_t *wlandev)
{
signed int result = 0;
struct p80211msg_dot11req_mibget getmsg;
@@ -707,7 +708,9 @@ static int plugimage(struct imgchunk *fchunk, unsigned int
nfchunks,
continue;
}
- /* Validate plug address against chunk data and identify chunk
*/
+ /* Validate plug address against chunk data and
+* identify chunk
+*/
for (c = 0; c nfchunks; c++) {
cstart = fchunk[c].addr;
cend = fchunk[c].addr + fchunk[c].len;
@@ -922,7 +925,8 @@ static int read_fwfile(const struct ihex_binrec *record)
rcnt,
s3info[ns3info].len,
s3info[ns3info].type);
- if (((s3info[ns3info].len - 1) * sizeof(u16))
sizeof(s3info[ns3info].info)) {
+ if (((s3info[ns3info].len - 1) * sizeof(u16))
+ sizeof(s3info[ns3info].info)) {
pr_err(S3 inforec length too long -
aborting\n);
return 1;
}
--
1.7.9.5
___
devel mailing list
de...@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
[PATCH] Drivers:staging:vt6656: Fixed checkpatch warning
Fixed the checkpatch warning:
WARNING: Prefer ether_addr_copy() over memcpy() if the Ethernet addresses are
__aligned(2)
Signed-off-by: Athira Lekshmi C V andnlnb...@gmail.com
---
drivers/staging/vt6656/rxtx.c | 18 +-
1 file changed, 9 insertions(+), 9 deletions(-)
diff --git a/drivers/staging/vt6656/rxtx.c b/drivers/staging/vt6656/rxtx.c
index ea5140a..ede71a4 100644
--- a/drivers/staging/vt6656/rxtx.c
+++ b/drivers/staging/vt6656/rxtx.c
@@ -392,8 +392,8 @@ static int vnt_fill_ieee80211_rts(struct
vnt_usb_send_context *tx_context,
rts-frame_control =
cpu_to_le16(IEEE80211_FTYPE_CTL | IEEE80211_STYPE_RTS);
- memcpy(rts-ra, hdr-addr1, ETH_ALEN);
- memcpy(rts-ta, hdr-addr2, ETH_ALEN);
+ ether_addr_copy(rts-ra, hdr-addr1);
+ ether_addr_copy(rts-ta, hdr-addr2);
return 0;
}
@@ -552,7 +552,7 @@ static u16 vnt_fill_cts_head(struct vnt_usb_send_context
*tx_context,
buf-data.frame_control =
cpu_to_le16(IEEE80211_FTYPE_CTL | IEEE80211_STYPE_CTS);
- memcpy(buf-data.ra, priv-current_net_addr, ETH_ALEN);
+ ether_addr_copy(buf-data.ra, priv-current_net_addr);
return vnt_rxtx_datahead_g_fb(tx_context, buf-data_head);
} else {
@@ -570,7 +570,7 @@ static u16 vnt_fill_cts_head(struct vnt_usb_send_context
*tx_context,
buf-data.frame_control =
cpu_to_le16(IEEE80211_FTYPE_CTL | IEEE80211_STYPE_CTS);
- memcpy(buf-data.ra, priv-current_net_addr, ETH_ALEN);
+ ether_addr_copy(buf-data.ra, priv-current_net_addr);
return vnt_rxtx_datahead_g(tx_context, buf-data_head);
}
@@ -739,7 +739,7 @@ static void vnt_fill_txkey(struct vnt_usb_send_context
*tx_context,
mic_hdr-id = 0x59;
mic_hdr-payload_len = cpu_to_be16(payload_len);
- memcpy(mic_hdr-mic_addr2, hdr-addr2, ETH_ALEN);
+ ether_addr_copy(mic_hdr-mic_addr2, hdr-addr2);
ieee80211_get_key_tx_seq(tx_key, seq);
@@ -750,9 +750,9 @@ static void vnt_fill_txkey(struct vnt_usb_send_context
*tx_context,
else
mic_hdr-hlen = cpu_to_be16(22);
- memcpy(mic_hdr-addr1, hdr-addr1, ETH_ALEN);
- memcpy(mic_hdr-addr2, hdr-addr2, ETH_ALEN);
- memcpy(mic_hdr-addr3, hdr-addr3, ETH_ALEN);
+ ether_addr_copy(mic_hdr-addr1, hdr-addr1);
+ ether_addr_copy(mic_hdr-addr2, hdr-addr2);
+ ether_addr_copy(mic_hdr-addr3, hdr-addr3);
mic_hdr-frame_control = cpu_to_le16(
le16_to_cpu(hdr-frame_control) 0xc78f);
@@ -760,7 +760,7 @@ static void vnt_fill_txkey(struct vnt_usb_send_context
*tx_context,
le16_to_cpu(hdr-seq_ctrl) 0xf);
if (ieee80211_has_a4(hdr-frame_control))
- memcpy(mic_hdr-addr4, hdr-addr4, ETH_ALEN);
+ ether_addr_copy(mic_hdr-addr4, hdr-addr4);
memcpy(key_buffer, tx_key-key, WLAN_KEY_LEN_CCMP);
--
1.7.9.5
___
devel mailing list
de...@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
[PATCH] Drivers:Staging:vt6656: Fixed checkpatch warning
Fixed the checkpatch warning:
WARNING: else is not generally useful after a break or return
Signed-off-by: Athira Lekshmi C V andnlnb...@gmail.com
---
drivers/staging/vt6656/rxtx.c | 35 ---
1 file changed, 16 insertions(+), 19 deletions(-)
diff --git a/drivers/staging/vt6656/rxtx.c b/drivers/staging/vt6656/rxtx.c
index ea5140a..af79be8 100644
--- a/drivers/staging/vt6656/rxtx.c
+++ b/drivers/staging/vt6656/rxtx.c
@@ -555,27 +555,24 @@ static u16 vnt_fill_cts_head(struct vnt_usb_send_context
*tx_context,
memcpy(buf-data.ra, priv-current_net_addr, ETH_ALEN);
return vnt_rxtx_datahead_g_fb(tx_context, buf-data_head);
- } else {
- struct vnt_cts *buf = head-cts_g;
- /* Get SignalField,ServiceField,Length */
- vnt_get_phy_field(priv, cts_frame_len,
- priv-top_cck_basic_rate, PK_TYPE_11B, buf-b);
- /* Get CTSDuration_ba */
- buf-duration_ba =
- vnt_get_rtscts_duration_le(tx_context, CTSDUR_BA,
- tx_context-pkt_type,
- current_rate);
- /*Get CTS Frame body*/
- buf-data.duration = buf-duration_ba;
- buf-data.frame_control =
- cpu_to_le16(IEEE80211_FTYPE_CTL | IEEE80211_STYPE_CTS);
-
- memcpy(buf-data.ra, priv-current_net_addr, ETH_ALEN);
-
- return vnt_rxtx_datahead_g(tx_context, buf-data_head);
}
+ struct vnt_cts *buf = head-cts_g;
+ /* Get SignalField,ServiceField,Length */
+ vnt_get_phy_field(priv, cts_frame_len,
+ priv-top_cck_basic_rate, PK_TYPE_11B, buf-b);
+ /* Get CTSDuration_ba */
+ buf-duration_ba =
+ vnt_get_rtscts_duration_le(tx_context, CTSDUR_BA,
+ tx_context-pkt_type,
+ current_rate);
+ /*Get CTS Frame body*/
+ buf-data.duration = buf-duration_ba;
+ buf-data.frame_control =
+ cpu_to_le16(IEEE80211_FTYPE_CTL | IEEE80211_STYPE_CTS);
- return 0;
+ memcpy(buf-data.ra, priv-current_net_addr, ETH_ALEN);
+
+ return vnt_rxtx_datahead_g(tx_context, buf-data_head);
}
static u16 vnt_rxtx_rts(struct vnt_usb_send_context *tx_context,
--
1.7.9.5
___
devel mailing list
de...@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
