[PATCH] staging: media: davinci_vpfe: use __func__ for function names

[Diwakar Sharma]

Checkpatch reported warnings for use of embedded function names.
Use __func__ instead of embedded function names.

Signed-off-by: Diwakar Sharma <sharmalxm...@gmail.com>
---
 drivers/staging/media/davinci_vpfe/dm365_ipipe.c | 10 +-
 drivers/staging/media/davinci_vpfe/vpfe_mc_capture.c |  8 
 2 files changed, 9 insertions(+), 9 deletions(-)

diff --git a/drivers/staging/media/davinci_vpfe/dm365_ipipe.c 
b/drivers/staging/media/davinci_vpfe/dm365_ipipe.c
index 6a3434c..a59ab6f 100644
--- a/drivers/staging/media/davinci_vpfe/dm365_ipipe.c
+++ b/drivers/staging/media/davinci_vpfe/dm365_ipipe.c
@@ -696,21 +696,21 @@ static int ipipe_get_gamma_params(struct 
vpfe_ipipe_device *ipipe, void *param)
 
if (!gamma->bypass_r && !gamma_param->table_r) {
dev_err(dev,
-   "ipipe_get_gamma_params: table ptr empty for R\n");
+   "%s: table ptr empty for R\n", __func__);
return -EINVAL;
}
memcpy(gamma_param->table_r, gamma->table_r,
   (table_size * sizeof(struct vpfe_ipipe_gamma_entry)));
 
if (!gamma->bypass_g && !gamma_param->table_g) {
-   dev_err(dev, "ipipe_get_gamma_params: table ptr empty for G\n");
+   dev_err(dev, "%s: table ptr empty for G\n", __func__);
return -EINVAL;
}
memcpy(gamma_param->table_g, gamma->table_g,
   (table_size * sizeof(struct vpfe_ipipe_gamma_entry)));
 
if (!gamma->bypass_b && !gamma_param->table_b) {
-   dev_err(dev, "ipipe_get_gamma_params: table ptr empty for B\n");
+   dev_err(dev, "%s: table ptr empty for B\n", __func__);
return -EINVAL;
}
memcpy(gamma_param->table_b, gamma->table_b,
@@ -743,7 +743,7 @@ static int ipipe_get_3d_lut_params(struct vpfe_ipipe_device 
*ipipe, void *param)
 
lut_param->en = lut->en;
if (!lut_param->table) {
-   dev_err(dev, "ipipe_get_3d_lut_params: Invalid table ptr\n");
+   dev_err(dev, "%s: Invalid table ptr\n", __func__);
return -EINVAL;
}
 
@@ -924,7 +924,7 @@ static int ipipe_get_gbce_params(struct vpfe_ipipe_device 
*ipipe, void *param)
gbce_param->en = gbce->en;
gbce_param->type = gbce->type;
if (!gbce_param->table) {
-   dev_err(dev, "ipipe_get_gbce_params: Invalid table ptr\n");
+   dev_err(dev, "%s: Invalid table ptr\n", __func__);
return -EINVAL;
}
 
diff --git a/drivers/staging/media/davinci_vpfe/vpfe_mc_capture.c 
b/drivers/staging/media/davinci_vpfe/vpfe_mc_capture.c
index bffe215..16e2e7e 100644
--- a/drivers/staging/media/davinci_vpfe/vpfe_mc_capture.c
+++ b/drivers/staging/media/davinci_vpfe/vpfe_mc_capture.c
@@ -161,7 +161,7 @@ static irqreturn_t vpfe_isr(int irq, void *dev_id)
 {
struct vpfe_device *vpfe_dev = dev_id;
 
-   v4l2_dbg(1, debug, _dev->v4l2_dev, "vpfe_isr\n");
+   v4l2_dbg(1, debug, _dev->v4l2_dev, "%s\n", __func__);
vpfe_isif_buffer_isr(_dev->vpfe_isif);
vpfe_resizer_buffer_isr(_dev->vpfe_resizer);
return IRQ_HANDLED;
@@ -172,7 +172,7 @@ static irqreturn_t vpfe_vdint1_isr(int irq, void *dev_id)
 {
struct vpfe_device *vpfe_dev = dev_id;
 
-   v4l2_dbg(1, debug, _dev->v4l2_dev, "vpfe_vdint1_isr\n");
+   v4l2_dbg(1, debug, _dev->v4l2_dev, "%s\n", __func__);
vpfe_isif_vidint1_isr(_dev->vpfe_isif);
return IRQ_HANDLED;
 }
@@ -182,7 +182,7 @@ static irqreturn_t vpfe_imp_dma_isr(int irq, void *dev_id)
 {
struct vpfe_device *vpfe_dev = dev_id;
 
-   v4l2_dbg(1, debug, _dev->v4l2_dev, "vpfe_imp_dma_isr\n");
+   v4l2_dbg(1, debug, _dev->v4l2_dev, "%s\n", __func__);
vpfe_ipipeif_ss_buffer_isr(_dev->vpfe_ipipeif);
vpfe_resizer_dma_isr(_dev->vpfe_resizer);
return IRQ_HANDLED;
@@ -693,7 +693,7 @@ static int vpfe_remove(struct platform_device *pdev)
 {
struct vpfe_device *vpfe_dev = platform_get_drvdata(pdev);
 
-   v4l2_info(pdev->dev.driver, "vpfe_remove\n");
+   v4l2_info(pdev->dev.driver, "%s\n", __func__);
 
kzfree(vpfe_dev->sd);
vpfe_detach_irq(vpfe_dev);
-- 
1.9.1

___
devel mailing list
de...@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel

[PATCH] staging: greybus: fix parenthesis alignments

[Diwakar Sharma]

Parenthesis alignment issues reported by checkpatch,
fixed here.

Signed-off-by: Diwakar Sharma <sharmalxm...@gmail.com>
---
 drivers/staging/greybus/interface.c | 40 ++---
 1 file changed, 20 insertions(+), 20 deletions(-)

diff --git a/drivers/staging/greybus/interface.c 
b/drivers/staging/greybus/interface.c
index a4fd516..71e5cc2 100644
--- a/drivers/staging/greybus/interface.c
+++ b/drivers/staging/greybus/interface.c
@@ -47,7 +47,7 @@
 static int gb_interface_refclk_set(struct gb_interface *intf, bool enable);
 
 static int gb_interface_dme_attr_get(struct gb_interface *intf,
-   u16 attr, u32 *val)
+u16 attr, u32 *val)
 {
return gb_svc_dme_peer_get(intf->hd->svc, intf->interface_id,
attr, DME_SELECTOR_INDEX_NULL, val);
@@ -64,7 +64,7 @@ static int gb_interface_read_ara_dme(struct gb_interface 
*intf)
 */
if (intf->ddbl1_manufacturer_id != TOSHIBA_DMID) {
dev_err(>dev, "unknown manufacturer %08x\n",
-   intf->ddbl1_manufacturer_id);
+   intf->ddbl1_manufacturer_id);
return -ENODEV;
}
 
@@ -110,7 +110,7 @@ static int gb_interface_read_dme(struct gb_interface *intf)
return ret;
 
if (intf->ddbl1_manufacturer_id == TOSHIBA_DMID &&
-   intf->ddbl1_product_id == TOSHIBA_ES2_BRIDGE_DPID) {
+   intf->ddbl1_product_id == TOSHIBA_ES2_BRIDGE_DPID) {
intf->quirks |= GB_INTERFACE_QUIRK_NO_GMP_IDS;
intf->quirks |= GB_INTERFACE_QUIRK_NO_INIT_STATUS;
}
@@ -144,7 +144,7 @@ static int gb_interface_route_create(struct gb_interface 
*intf)
ret = gb_svc_intf_device_id(svc, intf_id, device_id);
if (ret) {
dev_err(>dev, "failed to set device id %u: %d\n",
-   device_id, ret);
+   device_id, ret);
goto err_ida_remove;
}
 
@@ -205,21 +205,21 @@ static int gb_interface_legacy_mode_switch(struct 
gb_interface *intf)
 }
 
 void gb_interface_mailbox_event(struct gb_interface *intf, u16 result,
-   u32 mailbox)
+   u32 mailbox)
 {
mutex_lock(>mutex);
 
if (result) {
dev_warn(>dev,
-   "mailbox event with UniPro error: 0x%04x\n",
-   result);
+"mailbox event with UniPro error: 0x%04x\n",
+result);
goto err_disable;
}
 
if (mailbox != GB_SVC_INTF_MAILBOX_GREYBUS) {
dev_warn(>dev,
-   "mailbox event with unexpected value: 0x%08x\n",
-   mailbox);
+"mailbox event with unexpected value: 0x%08x\n",
+mailbox);
goto err_disable;
}
 
@@ -230,7 +230,7 @@ void gb_interface_mailbox_event(struct gb_interface *intf, 
u16 result,
 
if (!intf->mode_switch) {
dev_warn(>dev, "unexpected mailbox event: 0x%08x\n",
-   mailbox);
+mailbox);
goto err_disable;
}
 
@@ -299,7 +299,7 @@ static void gb_interface_mode_switch_work(struct 
work_struct *work)
ret = gb_interface_enable(intf);
if (ret) {
dev_err(>dev, "failed to re-enable interface: 
%d\n",
-   ret);
+   ret);
gb_interface_deactivate(intf);
}
}
@@ -619,7 +619,7 @@ static ssize_t interface_type_show(struct device *dev,
 };
 
 static umode_t interface_unipro_is_visible(struct kobject *kobj,
-   struct attribute *attr, int n)
+  struct attribute *attr, int n)
 {
struct device *dev = container_of(kobj, struct device, kobj);
struct gb_interface *intf = to_gb_interface(dev);
@@ -634,7 +634,7 @@ static umode_t interface_unipro_is_visible(struct kobject 
*kobj,
 }
 
 static umode_t interface_greybus_is_visible(struct kobject *kobj,
-   struct attribute *attr, int n)
+   struct attribute *attr, int n)
 {
struct device *dev = container_of(kobj, struct device, kobj);
struct gb_interface *intf = to_gb_interface(dev);
@@ -648,7 +648,7 @@ static umode_t interface_greybus_is_visible(struct kobject 
*ko