[PATCH] Staging: android: fix coding style issue for Eudyptula Challenge in timed_gpio.c

2014-05-06 Thread John Church


Signed-off-by: John Church j.chu...@ymail.com
--- linux-next/drivers/staging/android/timed_gpio.c.orig2014-05-07 
00:20:50.429090320 +0100
+++ linux-next/drivers/staging/android/timed_gpio.c 2014-05-07 
00:22:09.204795052 +0100
@@ -92,7 +92,7 @@ static int timed_gpio_probe(struct platf
return -EBUSY;
 
gpio_data = devm_kzalloc(pdev-dev,
-   sizeof(struct timed_gpio_data) * 
pdata-num_gpios,
+   sizeof(struct timed_gpio_data) * pdata-num_gpios,
GFP_KERNEL);
if (!gpio_data)
return -ENOMEM;
___
devel mailing list
de...@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel


Re: [PATCH] Staging: android: fix coding style issue for Eudyptula Challenge in timed_gpio.c

2014-05-06 Thread Greg KH
On Wed, May 07, 2014 at 12:44:31AM +0100, John Church wrote:
 

 Signed-off-by: John Church j.chu...@ymail.com


What coding style issue?

You need to be specific in your body of your email, and put a blank line
after the signed-off-by and before the patch, otherwise the tools can
complain.

And drop the Eudyptula challenge line in subject:, it's not needed at
all.

Can you redo this and resend?

thanks,

greg k-h
___
devel mailing list
de...@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel