[PATCH] Staging: gdm724x: gdm_lte.c: Fix warning of prefer ether_addr_copy()

[Kiran Padwal]

This patch fixes the following checkpatch.pl warnings:
WARNING: Prefer ether_addr_copy() over memcpy() if the Ethernet addresses are 
__aligned(2).

Signed-off-by: Kiran Padwal kiran.padwa...@gmail.com
---
 drivers/staging/gdm724x/gdm_lte.c |   10 +-
 1 file changed, 5 insertions(+), 5 deletions(-)

diff --git a/drivers/staging/gdm724x/gdm_lte.c 
b/drivers/staging/gdm724x/gdm_lte.c
index bc6d574..6df6c70 100644
--- a/drivers/staging/gdm724x/gdm_lte.c
+++ b/drivers/staging/gdm724x/gdm_lte.c
@@ -626,7 +626,7 @@ static void gdm_lte_netif_rx(struct net_device *dev, char 
*buf,
void *addr = buf + sizeof(struct iphdr) +
sizeof(struct udphdr) +
offsetof(struct dhcp_packet, chaddr);
-   memcpy(nic-dest_mac_addr, addr, ETH_ALEN);
+   ether_addr_copy(nic-dest_mac_addr, addr);
}
}
 
@@ -639,7 +639,7 @@ static void gdm_lte_netif_rx(struct net_device *dev, char 
*buf,
}
 
/* Format the data so that it can be put to skb */
-   memcpy(mac_header_data, nic-dest_mac_addr, ETH_ALEN);
+   ether_addr_copy(mac_header_data, nic-dest_mac_addr);
memcpy(mac_header_data + ETH_ALEN, nic-src_mac_addr, ETH_ALEN);
 
vlan_eth.h_vlan_TCI = htons(nic-vlan_id);
@@ -842,9 +842,9 @@ static void form_mac_address(u8 *dev_addr, u8 *nic_src, u8 
*nic_dest,
 {
/* Form the dev_addr */
if (!mac_address)
-   memcpy(dev_addr, gdm_lte_macaddr, ETH_ALEN);
+   ether_addr_copy(dev_addr, gdm_lte_macaddr);
else
-   memcpy(dev_addr, mac_address, ETH_ALEN);
+   ether_addr_copy(dev_addr, mac_address);
 
/* The last byte of the mac address
 * should be less than or equal to 0xFC
@@ -858,7 +858,7 @@ static void form_mac_address(u8 *dev_addr, u8 *nic_src, u8 
*nic_dest,
memcpy(nic_src, dev_addr, 3);
 
/* Copy the nic_dest from dev_addr*/
-   memcpy(nic_dest, dev_addr, ETH_ALEN);
+   ether_addr_copy(nic_dest, dev_addr);
 }
 
 static void validate_mac_address(u8 *mac_address)
-- 
1.7.9.5

___
devel mailing list
de...@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel

Re: [PATCH] Staging: gdm724x: gdm_lte.c: Fix warning of prefer ether_addr_copy()

[Greg KH]

On Tue, Jul 22, 2014 at 12:26:42PM +0530, Kiran Padwal wrote:
 This patch fixes the following checkpatch.pl warnings:
 WARNING: Prefer ether_addr_copy() over memcpy() if the Ethernet addresses 
 are __aligned(2).

Is that true here?

Have you tested this on the hardware to ensure it works properly?

I hate that checkpatch message...

thanks,

greg k-h
___
devel mailing list
de...@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel