Re: [PATCH] Staging: iio: addac: adt7316.c - style fix, octal permission

[Jonathan Cameron]

On 06/02/17 04:01, Derek Robson wrote:
> Changed file permissions to octal.
> Found with checkpatch.
> 
> Signed-off-by: Derek Robson 
Hi Derek,

Someone else got there first I'm afraid.  Already changed in the testing branch
of iio.git.

Thanks,

Jonathan
> ---
>  drivers/staging/iio/addac/adt7316.c | 108 
> ++--
>  1 file changed, 54 insertions(+), 54 deletions(-)
> 
> diff --git a/drivers/staging/iio/addac/adt7316.c 
> b/drivers/staging/iio/addac/adt7316.c
> index 6054c7298fce..aa251c245981 100644
> --- a/drivers/staging/iio/addac/adt7316.c
> +++ b/drivers/staging/iio/addac/adt7316.c
> @@ -267,7 +267,7 @@ static ssize_t adt7316_store_enabled(struct device *dev,
>   return len;
>  }
>  
> -static IIO_DEVICE_ATTR(enabled, S_IRUGO | S_IWUSR,
> +static IIO_DEVICE_ATTR(enabled, 0644,
>   adt7316_show_enabled,
>   adt7316_store_enabled,
>   0);
> @@ -311,7 +311,7 @@ static ssize_t adt7316_store_select_ex_temp(struct device 
> *dev,
>   return len;
>  }
>  
> -static IIO_DEVICE_ATTR(select_ex_temp, S_IRUGO | S_IWUSR,
> +static IIO_DEVICE_ATTR(select_ex_temp, 0644,
>   adt7316_show_select_ex_temp,
>   adt7316_store_select_ex_temp,
>   0);
> @@ -352,7 +352,7 @@ static ssize_t adt7316_store_mode(struct device *dev,
>   return len;
>  }
>  
> -static IIO_DEVICE_ATTR(mode, S_IRUGO | S_IWUSR,
> +static IIO_DEVICE_ATTR(mode, 0644,
>   adt7316_show_mode,
>   adt7316_store_mode,
>   0);
> @@ -364,7 +364,7 @@ static ssize_t adt7316_show_all_modes(struct device *dev,
>   return sprintf(buf, "single_channel\nround_robin\n");
>  }
>  
> -static IIO_DEVICE_ATTR(all_modes, S_IRUGO, adt7316_show_all_modes, NULL, 0);
> +static IIO_DEVICE_ATTR(all_modes, 0444, adt7316_show_all_modes, NULL, 0);
>  
>  static ssize_t adt7316_show_ad_channel(struct device *dev,
>   struct device_attribute *attr,
> @@ -446,7 +446,7 @@ static ssize_t adt7316_store_ad_channel(struct device 
> *dev,
>   return len;
>  }
>  
> -static IIO_DEVICE_ATTR(ad_channel, S_IRUGO | S_IWUSR,
> +static IIO_DEVICE_ATTR(ad_channel, 0644,
>   adt7316_show_ad_channel,
>   adt7316_store_ad_channel,
>   0);
> @@ -469,7 +469,7 @@ static ssize_t adt7316_show_all_ad_channels(struct device 
> *dev,
>   "2 - External Temperature\n");
>  }
>  
> -static IIO_DEVICE_ATTR(all_ad_channels, S_IRUGO,
> +static IIO_DEVICE_ATTR(all_ad_channels, 0444,
>   adt7316_show_all_ad_channels, NULL, 0);
>  
>  static ssize_t adt7316_show_disable_averaging(struct device *dev,
> @@ -506,7 +506,7 @@ static ssize_t adt7316_store_disable_averaging(struct 
> device *dev,
>   return len;
>  }
>  
> -static IIO_DEVICE_ATTR(disable_averaging, S_IRUGO | S_IWUSR,
> +static IIO_DEVICE_ATTR(disable_averaging, 0644,
>   adt7316_show_disable_averaging,
>   adt7316_store_disable_averaging,
>   0);
> @@ -545,7 +545,7 @@ static ssize_t adt7316_store_enable_smbus_timeout(struct 
> device *dev,
>   return len;
>  }
>  
> -static IIO_DEVICE_ATTR(enable_smbus_timeout, S_IRUGO | S_IWUSR,
> +static IIO_DEVICE_ATTR(enable_smbus_timeout, 0644,
>   adt7316_show_enable_smbus_timeout,
>   adt7316_store_enable_smbus_timeout,
>   0);
> @@ -583,7 +583,7 @@ static ssize_t adt7316_store_powerdown(struct device *dev,
>   return len;
>  }
>  
> -static IIO_DEVICE_ATTR(powerdown, S_IRUGO | S_IWUSR,
> +static IIO_DEVICE_ATTR(powerdown, 0644,
>   adt7316_show_powerdown,
>   adt7316_store_powerdown,
>   0);
> @@ -621,7 +621,7 @@ static ssize_t adt7316_store_fast_ad_clock(struct device 
> *dev,
>   return len;
>  }
>  
> -static IIO_DEVICE_ATTR(fast_ad_clock, S_IRUGO | S_IWUSR,
> +static IIO_DEVICE_ATTR(fast_ad_clock, 0644,
>   adt7316_show_fast_ad_clock,
>   adt7316_store_fast_ad_clock,
>   0);
> @@ -674,7 +674,7 @@ static ssize_t adt7316_store_da_high_resolution(struct 
> device *dev,
>   return len;
>  }
>  
> -static IIO_DEVICE_ATTR(da_high_resolution, S_IRUGO | S_IWUSR,
> +static IIO_DEVICE_ATTR(da_high_resolution, 0644,
>   adt7316_show_da_high_resolution,
>   adt7316_store_da_high_resolution,
>   0);
> @@ -720,7 +720,7 @@ static ssize_t adt7316_store_AIN_internal_Vref(struct 
> device *dev,
>   return len;
>  }
>  
> -static IIO_DEVICE_ATTR(AIN_internal_Vref, S_IRUGO | S_IWUSR,
> +static IIO_DEVICE_ATTR(AIN_internal_Vref, 0644,
>   adt7316_show_AIN_internal_Vref,
>   adt7316_store_AIN_internal_Vref,
>   0);
> @@ -760,7 +760,7 @@ static ssize_t adt7316_store_enable_prop_DACA(struct 
> device *dev,
>   return len;
>  }
>  
> -static IIO_DEVICE_ATTR(enable_proportion_DACA, S_IRUGO | S_IWUSR,
> +static 

[PATCH] Staging: iio: addac: adt7316.c - style fix, octal permission

[Derek Robson]

Changed file permissions to octal.
Found with checkpatch.

Signed-off-by: Derek Robson 
---
 drivers/staging/iio/addac/adt7316.c | 108 ++--
 1 file changed, 54 insertions(+), 54 deletions(-)

diff --git a/drivers/staging/iio/addac/adt7316.c 
b/drivers/staging/iio/addac/adt7316.c
index 6054c7298fce..aa251c245981 100644
--- a/drivers/staging/iio/addac/adt7316.c
+++ b/drivers/staging/iio/addac/adt7316.c
@@ -267,7 +267,7 @@ static ssize_t adt7316_store_enabled(struct device *dev,
return len;
 }
 
-static IIO_DEVICE_ATTR(enabled, S_IRUGO | S_IWUSR,
+static IIO_DEVICE_ATTR(enabled, 0644,
adt7316_show_enabled,
adt7316_store_enabled,
0);
@@ -311,7 +311,7 @@ static ssize_t adt7316_store_select_ex_temp(struct device 
*dev,
return len;
 }
 
-static IIO_DEVICE_ATTR(select_ex_temp, S_IRUGO | S_IWUSR,
+static IIO_DEVICE_ATTR(select_ex_temp, 0644,
adt7316_show_select_ex_temp,
adt7316_store_select_ex_temp,
0);
@@ -352,7 +352,7 @@ static ssize_t adt7316_store_mode(struct device *dev,
return len;
 }
 
-static IIO_DEVICE_ATTR(mode, S_IRUGO | S_IWUSR,
+static IIO_DEVICE_ATTR(mode, 0644,
adt7316_show_mode,
adt7316_store_mode,
0);
@@ -364,7 +364,7 @@ static ssize_t adt7316_show_all_modes(struct device *dev,
return sprintf(buf, "single_channel\nround_robin\n");
 }
 
-static IIO_DEVICE_ATTR(all_modes, S_IRUGO, adt7316_show_all_modes, NULL, 0);
+static IIO_DEVICE_ATTR(all_modes, 0444, adt7316_show_all_modes, NULL, 0);
 
 static ssize_t adt7316_show_ad_channel(struct device *dev,
struct device_attribute *attr,
@@ -446,7 +446,7 @@ static ssize_t adt7316_store_ad_channel(struct device *dev,
return len;
 }
 
-static IIO_DEVICE_ATTR(ad_channel, S_IRUGO | S_IWUSR,
+static IIO_DEVICE_ATTR(ad_channel, 0644,
adt7316_show_ad_channel,
adt7316_store_ad_channel,
0);
@@ -469,7 +469,7 @@ static ssize_t adt7316_show_all_ad_channels(struct device 
*dev,
"2 - External Temperature\n");
 }
 
-static IIO_DEVICE_ATTR(all_ad_channels, S_IRUGO,
+static IIO_DEVICE_ATTR(all_ad_channels, 0444,
adt7316_show_all_ad_channels, NULL, 0);
 
 static ssize_t adt7316_show_disable_averaging(struct device *dev,
@@ -506,7 +506,7 @@ static ssize_t adt7316_store_disable_averaging(struct 
device *dev,
return len;
 }
 
-static IIO_DEVICE_ATTR(disable_averaging, S_IRUGO | S_IWUSR,
+static IIO_DEVICE_ATTR(disable_averaging, 0644,
adt7316_show_disable_averaging,
adt7316_store_disable_averaging,
0);
@@ -545,7 +545,7 @@ static ssize_t adt7316_store_enable_smbus_timeout(struct 
device *dev,
return len;
 }
 
-static IIO_DEVICE_ATTR(enable_smbus_timeout, S_IRUGO | S_IWUSR,
+static IIO_DEVICE_ATTR(enable_smbus_timeout, 0644,
adt7316_show_enable_smbus_timeout,
adt7316_store_enable_smbus_timeout,
0);
@@ -583,7 +583,7 @@ static ssize_t adt7316_store_powerdown(struct device *dev,
return len;
 }
 
-static IIO_DEVICE_ATTR(powerdown, S_IRUGO | S_IWUSR,
+static IIO_DEVICE_ATTR(powerdown, 0644,
adt7316_show_powerdown,
adt7316_store_powerdown,
0);
@@ -621,7 +621,7 @@ static ssize_t adt7316_store_fast_ad_clock(struct device 
*dev,
return len;
 }
 
-static IIO_DEVICE_ATTR(fast_ad_clock, S_IRUGO | S_IWUSR,
+static IIO_DEVICE_ATTR(fast_ad_clock, 0644,
adt7316_show_fast_ad_clock,
adt7316_store_fast_ad_clock,
0);
@@ -674,7 +674,7 @@ static ssize_t adt7316_store_da_high_resolution(struct 
device *dev,
return len;
 }
 
-static IIO_DEVICE_ATTR(da_high_resolution, S_IRUGO | S_IWUSR,
+static IIO_DEVICE_ATTR(da_high_resolution, 0644,
adt7316_show_da_high_resolution,
adt7316_store_da_high_resolution,
0);
@@ -720,7 +720,7 @@ static ssize_t adt7316_store_AIN_internal_Vref(struct 
device *dev,
return len;
 }
 
-static IIO_DEVICE_ATTR(AIN_internal_Vref, S_IRUGO | S_IWUSR,
+static IIO_DEVICE_ATTR(AIN_internal_Vref, 0644,
adt7316_show_AIN_internal_Vref,
adt7316_store_AIN_internal_Vref,
0);
@@ -760,7 +760,7 @@ static ssize_t adt7316_store_enable_prop_DACA(struct device 
*dev,
return len;
 }
 
-static IIO_DEVICE_ATTR(enable_proportion_DACA, S_IRUGO | S_IWUSR,
+static IIO_DEVICE_ATTR(enable_proportion_DACA, 0644,
adt7316_show_enable_prop_DACA,
adt7316_store_enable_prop_DACA,
0);
@@ -799,7 +799,7 @@ static ssize_t adt7316_store_enable_prop_DACB(struct device 
*dev,
return len;
 }
 
-static IIO_DEVICE_ATTR(enable_proportion_DACB, S_IRUGO | S_IWUSR,
+static