RE: [PATCH] X86/UAPI: Use __u64 instead of u64 in hyperv.h

2018-02-20 Thread KY Srinivasan


> -Original Message-
> From: KarimAllah Ahmed <karah...@amazon.de>
> Sent: Monday, February 19, 2018 11:40 PM
> To: linux-ker...@vger.kernel.org; de...@linuxdriverproject.org;
> x...@kernel.org
> Cc: KarimAllah Ahmed <karah...@amazon.de>; KY Srinivasan
> <k...@microsoft.com>; Haiyang Zhang <haiya...@microsoft.com>; Stephen
> Hemminger <sthem...@microsoft.com>; Thomas Gleixner
> <t...@linutronix.de>; Ingo Molnar <mi...@redhat.com>; H . Peter Anvin
> <h...@zytor.com>
> Subject: [PATCH] X86/UAPI: Use __u64 instead of u64 in hyperv.h
> 
> ... since u64 has a hidden header dependency that was not there before
> using it (i.e. it breaks our VMM build). Also, __u64 is the right way to
> expose the data type through UAPI.
> 
> Fixes: 93286261 ("x86/hyperv: Reenlightenment notifications support")
> Signed-off-by: KarimAllah Ahmed <karah...@amazon.de>
> Cc: K. Y. Srinivasan <k...@microsoft.com>
> Cc: Haiyang Zhang <haiya...@microsoft.com>
> Cc: Stephen Hemminger <sthem...@microsoft.com>
> Cc: Thomas Gleixner <t...@linutronix.de>
> Cc: Ingo Molnar <mi...@redhat.com>
> Cc: H. Peter Anvin <h...@zytor.com>
> Cc: x...@kernel.org
> Cc: de...@linuxdriverproject.org
> Cc: linux-ker...@vger.kernel.org

Acked-by: K. Y. Srinivasan <k...@microsoft.com>
> ---
>  arch/x86/include/uapi/asm/hyperv.h | 18 +-
>  1 file changed, 9 insertions(+), 9 deletions(-)
> 
> diff --git a/arch/x86/include/uapi/asm/hyperv.h
> b/arch/x86/include/uapi/asm/hyperv.h
> index 197c2e6..0994143 100644
> --- a/arch/x86/include/uapi/asm/hyperv.h
> +++ b/arch/x86/include/uapi/asm/hyperv.h
> @@ -241,24 +241,24 @@
>  #define HV_X64_MSR_REENLIGHTENMENT_CONTROL   0x4106
> 
>  struct hv_reenlightenment_control {
> - u64 vector:8;
> - u64 reserved1:8;
> - u64 enabled:1;
> - u64 reserved2:15;
> - u64 target_vp:32;
> + __u64 vector:8;
> + __u64 reserved1:8;
> + __u64 enabled:1;
> + __u64 reserved2:15;
> + __u64 target_vp:32;
>  };
> 
>  #define HV_X64_MSR_TSC_EMULATION_CONTROL 0x4107
>  #define HV_X64_MSR_TSC_EMULATION_STATUS  0x4108
> 
>  struct hv_tsc_emulation_control {
> - u64 enabled:1;
> - u64 reserved:63;
> + __u64 enabled:1;
> + __u64 reserved:63;
>  };
> 
>  struct hv_tsc_emulation_status {
> - u64 inprogress:1;
> - u64 reserved:63;
> + __u64 inprogress:1;
> + __u64 reserved:63;
>  };
> 
>  #define HV_X64_MSR_HYPERCALL_ENABLE  0x0001
> --
> 2.7.4

___
devel mailing list
de...@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel


[PATCH] X86/UAPI: Use __u64 instead of u64 in hyperv.h

2018-02-19 Thread KarimAllah Ahmed
... since u64 has a hidden header dependency that was not there before
using it (i.e. it breaks our VMM build). Also, __u64 is the right way to
expose the data type through UAPI.

Fixes: 93286261 ("x86/hyperv: Reenlightenment notifications support")
Signed-off-by: KarimAllah Ahmed 
Cc: K. Y. Srinivasan 
Cc: Haiyang Zhang 
Cc: Stephen Hemminger 
Cc: Thomas Gleixner 
Cc: Ingo Molnar 
Cc: H. Peter Anvin 
Cc: x...@kernel.org
Cc: de...@linuxdriverproject.org
Cc: linux-ker...@vger.kernel.org
---
 arch/x86/include/uapi/asm/hyperv.h | 18 +-
 1 file changed, 9 insertions(+), 9 deletions(-)

diff --git a/arch/x86/include/uapi/asm/hyperv.h 
b/arch/x86/include/uapi/asm/hyperv.h
index 197c2e6..0994143 100644
--- a/arch/x86/include/uapi/asm/hyperv.h
+++ b/arch/x86/include/uapi/asm/hyperv.h
@@ -241,24 +241,24 @@
 #define HV_X64_MSR_REENLIGHTENMENT_CONTROL 0x4106
 
 struct hv_reenlightenment_control {
-   u64 vector:8;
-   u64 reserved1:8;
-   u64 enabled:1;
-   u64 reserved2:15;
-   u64 target_vp:32;
+   __u64 vector:8;
+   __u64 reserved1:8;
+   __u64 enabled:1;
+   __u64 reserved2:15;
+   __u64 target_vp:32;
 };
 
 #define HV_X64_MSR_TSC_EMULATION_CONTROL   0x4107
 #define HV_X64_MSR_TSC_EMULATION_STATUS0x4108
 
 struct hv_tsc_emulation_control {
-   u64 enabled:1;
-   u64 reserved:63;
+   __u64 enabled:1;
+   __u64 reserved:63;
 };
 
 struct hv_tsc_emulation_status {
-   u64 inprogress:1;
-   u64 reserved:63;
+   __u64 inprogress:1;
+   __u64 reserved:63;
 };
 
 #define HV_X64_MSR_HYPERCALL_ENABLE0x0001
-- 
2.7.4

___
devel mailing list
de...@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel