Re: [PATCH] checkpatch: Remove unnecessary + after {8,8}

[Sören Brinkmann]

Hi Joe,

On Fri, 2014-07-11 at 07:09PM -0700, Joe Perches wrote:
 There's a useless + use that needs to be removed as perl 5.20
 emits a Useless use of greediness modifier '+' message each
 time it's hit.

I saw this Perl warning today as well and wondered whether this patch is
coming or not. Apparently it's not in linux-next (yet).

Thanks,
Sören
___
devel mailing list
de...@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel

Re: [PATCH] checkpatch: Remove unnecessary + after {8,8}

[Greg KH]

On Fri, Jul 11, 2014 at 07:09:30PM -0700, Joe Perches wrote:
 There's a useless + use that needs to be removed as perl 5.20
 emits a Useless use of greediness modifier '+' message each
 time it's hit.
 
 Reported-by: Greg KH gre...@linuxfoundation.org
 Signed-off-by: Joe Perches j...@perches.com
 ---
 On Fri, 2014-07-11 at 19:05 -0700, Greg KH wrote:
  Ok, with linux-next I get the same thing:
 
 Thanks Greg.

Very nice, thanks for this:

Tested-by: Greg Kroah-Hartman gre...@linuxfoundation.org
___
devel mailing list
de...@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel

[PATCH] checkpatch: Remove unnecessary + after {8,8}

[Joe Perches]

There's a useless + use that needs to be removed as perl 5.20
emits a Useless use of greediness modifier '+' message each
time it's hit.

Reported-by: Greg KH gre...@linuxfoundation.org
Signed-off-by: Joe Perches j...@perches.com
---
On Fri, 2014-07-11 at 19:05 -0700, Greg KH wrote:
 Ok, with linux-next I get the same thing:

Thanks Greg.

 scripts/checkpatch.pl | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/scripts/checkpatch.pl b/scripts/checkpatch.pl
index d5ac001..370a974 100755
--- a/scripts/checkpatch.pl
+++ b/scripts/checkpatch.pl
@@ -2376,7 +2376,7 @@ sub process {
please, no space before tabs\n . $herevet) 
$fix) {
while ($fixed[$fixlinenr] =~
-  s/(^\+.*) {8,8}+\t/$1\t\t/) {}
+  s/(^\+.*) {8,8}\t/$1\t\t/) {}
while ($fixed[$fixlinenr] =~
   s/(^\+.*) +\t/$1\t/) {}
}


___
devel mailing list
de...@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel