Re: [PATCH] staging: ft1000: Replace printk with pr_info in ft1000_cs.c

2014-05-15 Thread Greg KH 
On Wed, May 14, 2014 at 10:12:46AM +0200, Tobias Klauser wrote:
 On 2014-05-13 at 16:43:57 +0200, Masanari Iida standby2...@gmail.com wrote:
  This patch replaced printk with pr_info.
 
 It would be even better to use dev_err(), since these are error messages
 and you can use the struct dev from link-dev. You can also drop the
 ft1000: prefix then.

I agree, that's the better fix here.

___
devel mailing list
de...@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel

Re: [PATCH] staging: ft1000: Replace printk with pr_info in ft1000_cs.c

2014-05-14 Thread Tobias Klauser 
On 2014-05-13 at 16:43:57 +0200, Masanari Iida standby2...@gmail.com wrote:
 This patch replaced printk with pr_info.

It would be even better to use dev_err(), since these are error messages
and you can use the struct dev from link-dev. You can also drop the
ft1000: prefix then.

Cheers
Tobias

 
 Signed-off-by: Masanari Iida standby2...@gmail.com
 ---
  drivers/staging/ft1000/ft1000-pcmcia/ft1000_cs.c | 6 +++---
  1 file changed, 3 insertions(+), 3 deletions(-)
 
 diff --git a/drivers/staging/ft1000/ft1000-pcmcia/ft1000_cs.c 
 b/drivers/staging/ft1000/ft1000-pcmcia/ft1000_cs.c
 index f376ca4..00c86db 100644
 --- a/drivers/staging/ft1000/ft1000-pcmcia/ft1000_cs.c
 +++ b/drivers/staging/ft1000/ft1000-pcmcia/ft1000_cs.c
 @@ -95,20 +95,20 @@ static int ft1000_config(struct pcmcia_device *link)
   /* setup IO window */
   ret = pcmcia_loop_config(link, ft1000_confcheck, NULL);
   if (ret) {
 - printk(KERN_INFO ft1000: Could not configure pcmcia\n);
 + pr_info(ft1000: Could not configure pcmcia\n);
   return -ENODEV;

   }
  
   /* configure device */
   ret = pcmcia_enable_device(link);
   if (ret) {
 - printk(KERN_INFO ft1000: could not enable pcmcia\n);
 + pr_info(ft1000: could not enable pcmcia\n);
   goto failed;
   }
  
   link-priv = init_ft1000_card(link, ft1000_reset);
   if (!link-priv) {
 - printk(KERN_INFO ft1000: Could not register as network 
 device\n);
 + pr_info(ft1000: Could not register as network device\n);
   goto failed;
   }
  
 -- 
 2.0.0.rc3.2.g998f840
 
 ___
 devel mailing list
 de...@linuxdriverproject.org
 http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
 
___
devel mailing list
de...@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel

[PATCH] staging: ft1000: Replace printk with pr_info in ft1000_cs.c

2014-05-13 Thread Masanari Iida 
This patch replaced printk with pr_info.

Signed-off-by: Masanari Iida standby2...@gmail.com
---
 drivers/staging/ft1000/ft1000-pcmcia/ft1000_cs.c | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)

diff --git a/drivers/staging/ft1000/ft1000-pcmcia/ft1000_cs.c 
b/drivers/staging/ft1000/ft1000-pcmcia/ft1000_cs.c
index f376ca4..00c86db 100644
--- a/drivers/staging/ft1000/ft1000-pcmcia/ft1000_cs.c
+++ b/drivers/staging/ft1000/ft1000-pcmcia/ft1000_cs.c
@@ -95,20 +95,20 @@ static int ft1000_config(struct pcmcia_device *link)
/* setup IO window */
ret = pcmcia_loop_config(link, ft1000_confcheck, NULL);
if (ret) {
-   printk(KERN_INFO ft1000: Could not configure pcmcia\n);
+   pr_info(ft1000: Could not configure pcmcia\n);
return -ENODEV;
}
 
/* configure device */
ret = pcmcia_enable_device(link);
if (ret) {
-   printk(KERN_INFO ft1000: could not enable pcmcia\n);
+   pr_info(ft1000: could not enable pcmcia\n);
goto failed;
}
 
link-priv = init_ft1000_card(link, ft1000_reset);
if (!link-priv) {
-   printk(KERN_INFO ft1000: Could not register as network 
device\n);
+   pr_info(ft1000: Could not register as network device\n);
goto failed;
}
 
-- 
2.0.0.rc3.2.g998f840

___
devel mailing list
de...@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel