Re: [PATCH] staging: greybus: tools: Remove function log_csv_error()

2019-06-26 Thread Bryan O'Donoghue

On 26/06/2019 07:44, Nishka Dasgupta wrote:

Remove unused function log_csv_error.
Issue found with Coccinelle.

Signed-off-by: Nishka Dasgupta 
---
  drivers/staging/greybus/tools/loopback_test.c | 6 --
  1 file changed, 6 deletions(-)

diff --git a/drivers/staging/greybus/tools/loopback_test.c 
b/drivers/staging/greybus/tools/loopback_test.c
index 2fa88092514d..cebc1d90a180 100644
--- a/drivers/staging/greybus/tools/loopback_test.c
+++ b/drivers/staging/greybus/tools/loopback_test.c
@@ -414,12 +414,6 @@ static int get_results(struct loopback_test *t)
return 0;
  }
  
-void log_csv_error(int len, int err)

-{
-   fprintf(stderr, "unable to write %d bytes to csv %s\n", len,
-   strerror(err));
-}
-
  int format_output(struct loopback_test *t,
  struct loopback_results *r,
  const char *dev_name,



Reviewed-by: Bryan O'Donoghue 
___
devel mailing list
de...@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel


[PATCH] staging: greybus: tools: Remove function log_csv_error()

2019-06-26 Thread Nishka Dasgupta
Remove unused function log_csv_error.
Issue found with Coccinelle.

Signed-off-by: Nishka Dasgupta 
---
 drivers/staging/greybus/tools/loopback_test.c | 6 --
 1 file changed, 6 deletions(-)

diff --git a/drivers/staging/greybus/tools/loopback_test.c 
b/drivers/staging/greybus/tools/loopback_test.c
index 2fa88092514d..cebc1d90a180 100644
--- a/drivers/staging/greybus/tools/loopback_test.c
+++ b/drivers/staging/greybus/tools/loopback_test.c
@@ -414,12 +414,6 @@ static int get_results(struct loopback_test *t)
return 0;
 }
 
-void log_csv_error(int len, int err)
-{
-   fprintf(stderr, "unable to write %d bytes to csv %s\n", len,
-   strerror(err));
-}
-
 int format_output(struct loopback_test *t,
  struct loopback_results *r,
  const char *dev_name,
-- 
2.19.1

___
devel mailing list
de...@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel