Re: [PATCH] staging: iio: adt7316: fix parenthesis alignment

[Jonathan Cameron]

On Thu, 4 Oct 2018 20:06:55 -0300
Renato Lui Geh  wrote:

> This patch fixes all "Alignment should match open parenthesis" check
> warnings found by checkpatch.pl in the addac/adt7316 driver.
> 
> Signed-off-by: Renato Lui Geh 
Hi,

Mostly good, but alignment doesn't override other considerations such
as consistency in argument naming.

Thanks,

Jonathan

> ---
>  drivers/staging/iio/addac/adt7316.c | 462 ++--
>  drivers/staging/iio/addac/adt7316.h |   2 +-
>  2 files changed, 233 insertions(+), 231 deletions(-)
> 
...
> @@ -1363,9 +1365,9 @@ static ssize_t 
> adt7316_show_in_analog_temp_offset(struct device *dev,
>  }
>  
>  static ssize_t adt7316_store_in_analog_temp_offset(struct device *dev,
> - struct device_attribute *attr,
> - const char *buf,
> - size_t len)
> +struct device_attribute *att,
I wasn't expecting to see a rename in here.  I know it's not a big thing 
as the parameter isn't even used, but it is better to have consistency
of naming than a minor improvement in alignment.

> +const char *buf,
> +size_t len)
>  {
>  
>  static ssize_t adt7316_store_ex_analog_temp_offset(struct device *dev,
> - struct device_attribute *attr,
> - const char *buf,
> - size_t len)
> +struct device_attribute *att,
Same here...

> +const char *buf,
> +size_t len)
>  {
>   struct iio_dev *dev_info = dev_to_iio_dev(dev);
>   struct adt7316_chip_info *chip = iio_priv(dev_info);

...
___
devel mailing list
de...@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel

[PATCH] staging: iio: adt7316: fix parenthesis alignment

[Renato Lui Geh]

This patch fixes all "Alignment should match open parenthesis" check
warnings found by checkpatch.pl in the addac/adt7316 driver.

Signed-off-by: Renato Lui Geh 
---
drivers/staging/iio/addac/adt7316.c | 462 ++--
drivers/staging/iio/addac/adt7316.h |   2 +-
2 files changed, 233 insertions(+), 231 deletions(-)

diff --git a/drivers/staging/iio/addac/adt7316.c 
b/drivers/staging/iio/addac/adt7316.c
index 3f22d1088713..7293a49830e7 100644
--- a/drivers/staging/iio/addac/adt7316.c
+++ b/drivers/staging/iio/addac/adt7316.c
@@ -217,8 +217,8 @@ struct adt7316_limit_regs {
};

static ssize_t adt7316_show_enabled(struct device *dev,
-   struct device_attribute *attr,
-   char *buf)
+   struct device_attribute *attr,
+   char *buf)
{
struct iio_dev *dev_info = dev_to_iio_dev(dev);
struct adt7316_chip_info *chip = iio_priv(dev_info);
@@ -227,7 +227,7 @@ static ssize_t adt7316_show_enabled(struct device *dev,
}

static ssize_t _adt7316_store_enabled(struct adt7316_chip_info *chip,
-   int enable)
+ int enable)
{
u8 config1;
int ret;
@@ -247,9 +247,9 @@ static ssize_t _adt7316_store_enabled(struct 
adt7316_chip_info *chip,
}

static ssize_t adt7316_store_enabled(struct device *dev,
-   struct device_attribute *attr,
-   const char *buf,
-   size_t len)
+struct device_attribute *attr,
+const char *buf,
+size_t len)
{
struct iio_dev *dev_info = dev_to_iio_dev(dev);
struct adt7316_chip_info *chip = iio_priv(dev_info);
@@ -272,8 +272,8 @@ static IIO_DEVICE_ATTR(enabled, 0644,
0);

static ssize_t adt7316_show_select_ex_temp(struct device *dev,
-   struct device_attribute *attr,
-   char *buf)
+  struct device_attribute *attr,
+  char *buf)
{
struct iio_dev *dev_info = dev_to_iio_dev(dev);
struct adt7316_chip_info *chip = iio_priv(dev_info);
@@ -285,9 +285,9 @@ static ssize_t adt7316_show_select_ex_temp(struct device 
*dev,
}

static ssize_t adt7316_store_select_ex_temp(struct device *dev,
-   struct device_attribute *attr,
-   const char *buf,
-   size_t len)
+   struct device_attribute *attr,
+   const char *buf,
+   size_t len)
{
struct iio_dev *dev_info = dev_to_iio_dev(dev);
struct adt7316_chip_info *chip = iio_priv(dev_info);
@@ -316,8 +316,8 @@ static IIO_DEVICE_ATTR(select_ex_temp, 0644,
0);

static ssize_t adt7316_show_mode(struct device *dev,
-   struct device_attribute *attr,
-   char *buf)
+struct device_attribute *attr,
+char *buf)
{
struct iio_dev *dev_info = dev_to_iio_dev(dev);
struct adt7316_chip_info *chip = iio_priv(dev_info);
@@ -329,9 +329,9 @@ static ssize_t adt7316_show_mode(struct device *dev,
}

static ssize_t adt7316_store_mode(struct device *dev,
-   struct device_attribute *attr,
-   const char *buf,
-   size_t len)
+ struct device_attribute *attr,
+ const char *buf,
+ size_t len)
{
struct iio_dev *dev_info = dev_to_iio_dev(dev);
struct adt7316_chip_info *chip = iio_priv(dev_info);
@@ -357,8 +357,8 @@ static IIO_DEVICE_ATTR(mode, 0644,
0);

static ssize_t adt7316_show_all_modes(struct device *dev,
-   struct device_attribute *attr,
-   char *buf)
+ struct device_attribute *attr,
+ char *buf)
{
return sprintf(buf, "single_channel\nround_robin\n");
}
@@ -366,8 +366,8 @@ static ssize_t adt7316_show_all_modes(struct device *dev,
static IIO_DEVICE_ATTR(all_modes, 0444, adt7316_show_all_modes, NULL, 0);

static ssize_t adt7316_show_ad_channel(struct device *dev,
-   struct device_attribute *attr,
-   char *buf)
+  struct device_attribute *attr,
+  char *buf)
{
struct iio_dev *dev_info = dev_to_iio_dev(dev);
struct adt7316_chip_info *chip = iio_priv(dev_info);
@@ -382,7 +382,7 @@ static ssize_t adt7316_show_ad_channel(struct device *dev,
return sprintf(buf, "1 - Internal Temperature\n");
case ADT7316_AD_SINGLE_CH_EX:
if (((chip->id & ID_FAMILY_MASK) == ID_ADT75XX) &&
-   (chip->config1 &