Re: [PATCH] staging: kpc2000: To make symbols static

[gre...@linuxfoundation.org]

On Mon, Jun 10, 2019 at 05:50:01AM +, Rishiraj Manwatkar wrote:
> This patch makes 4 symbols static as suggested by Sparse tool.
> 
> Signed-off-by: Rishiraj Manwatkar 

Your subject line is very odd, what does that really mean?

> ---
>  drivers/staging/kpc2000/kpc_dma/kpc_dma_driver.c | 8 
>  1 file changed, 4 insertions(+), 4 deletions(-)
> 
> diff --git a/drivers/staging/kpc2000/kpc_dma/kpc_dma_driver.c 
> b/drivers/staging/kpc2000/kpc_dma/kpc_dma_driver.c
> index cda057569163..e4056607af0b 100644
> --- a/drivers/staging/kpc2000/kpc_dma/kpc_dma_driver.c
> +++ b/drivers/staging/kpc2000/kpc_dma/kpc_dma_driver.c
> @@ -36,14 +36,14 @@ struct kpc_dma_device *kpc_dma_lookup_device(int minor)
>   return c;
>  }
>  
> -void  kpc_dma_add_device(struct kpc_dma_device *ldev)
> +static void  kpc_dma_add_device(struct kpc_dma_device *ldev)

This patch does not apply to my latest tree, can you rebase it against
the staging-next branch of staging.git on git.kernel.org and resend?

thanks,

greg k-h
___
devel mailing list
de...@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel

[PATCH] staging: kpc2000: To make symbols static

[Rishiraj Manwatkar]

This patch makes 4 symbols static as suggested by Sparse tool.

Signed-off-by: Rishiraj Manwatkar 
---
 drivers/staging/kpc2000/kpc_dma/kpc_dma_driver.c | 8 
 1 file changed, 4 insertions(+), 4 deletions(-)

diff --git a/drivers/staging/kpc2000/kpc_dma/kpc_dma_driver.c 
b/drivers/staging/kpc2000/kpc_dma/kpc_dma_driver.c
index cda057569163..e4056607af0b 100644
--- a/drivers/staging/kpc2000/kpc_dma/kpc_dma_driver.c
+++ b/drivers/staging/kpc2000/kpc_dma/kpc_dma_driver.c
@@ -36,14 +36,14 @@ struct kpc_dma_device *kpc_dma_lookup_device(int minor)
return c;
 }
 
-void  kpc_dma_add_device(struct kpc_dma_device *ldev)
+static void  kpc_dma_add_device(struct kpc_dma_device *ldev)
 {
mutex_lock(_dma_mtx);
list_add(>list, _dma_list);
mutex_unlock(_dma_mtx);
 }
 
-void kpc_dma_del_device(struct kpc_dma_device *ldev)
+static void kpc_dma_del_device(struct kpc_dma_device *ldev)
 {
mutex_lock(_dma_mtx);
list_del(>list);
@@ -88,7 +88,7 @@ static const struct attribute *ndd_attr_list[] = {
NULL,
 };
 
-struct class *kpc_dma_class;
+static struct class *kpc_dma_class;
 
 /**  Platform Driver Functions  **/
 static
@@ -196,7 +196,7 @@ int  kpc_dma_remove(struct platform_device *pldev)
 }
 
 /**  Driver Functions  **/
-struct platform_driver kpc_dma_plat_driver_i = {
+static struct platform_driver kpc_dma_plat_driver_i = {
.probe= kpc_dma_probe,
.remove   = kpc_dma_remove,
.driver = {
-- 
2.17.1

___
devel mailing list
de...@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel