[PATCH] staging: ks7010: enclosed complex macro definitions with parentheses

2021-02-11 Thread Pritthijit Nath 
kshostif.h

fixed ERROR: Macros with complex values should be enclosed in
paranthesis

Signed-off-by: Pritthijit Nath 
---
 drivers/staging/ks7010/ks_hostif.h | 24 
 1 file changed, 12 insertions(+), 12 deletions(-)

diff --git a/drivers/staging/ks7010/ks_hostif.h 
b/drivers/staging/ks7010/ks_hostif.h
index 39138191a556..c62a494ed6bb 100644
--- a/drivers/staging/ks7010/ks_hostif.h
+++ b/drivers/staging/ks7010/ks_hostif.h
@@ -498,20 +498,20 @@ struct hostif_mic_failure_request {
 #define TX_RATE_FIXED  5
 
 /* 11b rate */
-#define TX_RATE_1M (u8)(10 / 5)/* 11b 11g basic rate */
-#define TX_RATE_2M (u8)(20 / 5)/* 11b 11g basic rate */
-#define TX_RATE_5M (u8)(55 / 5)/* 11g basic rate */
-#define TX_RATE_11M(u8)(110 / 5)   /* 11g basic rate */
+#define TX_RATE_1M ((u8)(10 / 5))  /* 11b 11g basic rate */
+#define TX_RATE_2M ((u8)(20 / 5))  /* 11b 11g basic rate */
+#define TX_RATE_5M ((u8)(55 / 5))  /* 11g basic rate */
+#define TX_RATE_11M((u8)(110 / 5)) /* 11g basic rate */
 
 /* 11g rate */
-#define TX_RATE_6M (u8)(60 / 5)/* 11g basic rate */
-#define TX_RATE_12M(u8)(120 / 5)   /* 11g basic rate */
-#define TX_RATE_24M(u8)(240 / 5)   /* 11g basic rate */
-#define TX_RATE_9M (u8)(90 / 5)
-#define TX_RATE_18M(u8)(180 / 5)
-#define TX_RATE_36M(u8)(360 / 5)
-#define TX_RATE_48M(u8)(480 / 5)
-#define TX_RATE_54M(u8)(540 / 5)
+#define TX_RATE_6M ((u8)(60 / 5))  /* 11g basic rate */
+#define TX_RATE_12M((u8)(120 / 5)) /* 11g basic rate */
+#define TX_RATE_24M((u8)(240 / 5)) /* 11g basic rate */
+#define TX_RATE_9M ((u8)(90 / 5))
+#define TX_RATE_18M((u8)(180 / 5))
+#define TX_RATE_36M((u8)(360 / 5))
+#define TX_RATE_48M((u8)(480 / 5))
+#define TX_RATE_54M((u8)(540 / 5))
 
 static inline bool is_11b_rate(u8 rate)
 {
-- 
2.25.1

___
devel mailing list
de...@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel

Re: [PATCH] staging: ks7010: enclosed complex macro definitions with parentheses

2021-02-11 Thread Greg KH 
On Thu, Feb 11, 2021 at 04:26:36PM +0530, Pritthijit Nath wrote:
> kshostif.h

Why is this in the changelog text?

> 
> fixed ERROR: Macros with complex values should be enclosed in
> paranthesis

What does that mean?

> 
> Signed-off-by: Pritthijit Nath 
> ---
>  drivers/staging/ks7010/ks_hostif.h | 24 
>  1 file changed, 12 insertions(+), 12 deletions(-)
> 
> diff --git a/drivers/staging/ks7010/ks_hostif.h 
> b/drivers/staging/ks7010/ks_hostif.h
> index 39138191a556..c62a494ed6bb 100644
> --- a/drivers/staging/ks7010/ks_hostif.h
> +++ b/drivers/staging/ks7010/ks_hostif.h
> @@ -498,20 +498,20 @@ struct hostif_mic_failure_request {
>  #define TX_RATE_FIXED5
>  
>  /* 11b rate */
> -#define TX_RATE_1M   (u8)(10 / 5)/* 11b 11g basic rate */
> -#define TX_RATE_2M   (u8)(20 / 5)/* 11b 11g basic rate */
> -#define TX_RATE_5M   (u8)(55 / 5)/* 11g basic rate */
> -#define TX_RATE_11M  (u8)(110 / 5)   /* 11g basic rate */
> +#define TX_RATE_1M   ((u8)(10 / 5))  /* 11b 11g basic rate */
> +#define TX_RATE_2M   ((u8)(20 / 5))  /* 11b 11g basic rate */
> +#define TX_RATE_5M   ((u8)(55 / 5))  /* 11g basic rate */
> +#define TX_RATE_11M  ((u8)(110 / 5)) /* 11g basic rate */
>  
>  /* 11g rate */
> -#define TX_RATE_6M   (u8)(60 / 5)/* 11g basic rate */
> -#define TX_RATE_12M  (u8)(120 / 5)   /* 11g basic rate */
> -#define TX_RATE_24M  (u8)(240 / 5)   /* 11g basic rate */
> -#define TX_RATE_9M   (u8)(90 / 5)
> -#define TX_RATE_18M  (u8)(180 / 5)
> -#define TX_RATE_36M  (u8)(360 / 5)
> -#define TX_RATE_48M  (u8)(480 / 5)
> -#define TX_RATE_54M  (u8)(540 / 5)
> +#define TX_RATE_6M   ((u8)(60 / 5))  /* 11g basic rate */
> +#define TX_RATE_12M  ((u8)(120 / 5)) /* 11g basic rate */
> +#define TX_RATE_24M  ((u8)(240 / 5)) /* 11g basic rate */
> +#define TX_RATE_9M   ((u8)(90 / 5))
> +#define TX_RATE_18M  ((u8)(180 / 5))
> +#define TX_RATE_36M  ((u8)(360 / 5))
> +#define TX_RATE_48M  ((u8)(480 / 5))
> +#define TX_RATE_54M  ((u8)(540 / 5))
>  
>  static inline bool is_11b_rate(u8 rate)
>  {

Did you see the review comments on the list for this identical patch?
Please refer to that...

thanks,

greg k-h
___
devel mailing list
de...@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel