Re: [PATCH] staging: rtl8723bs: os_dep: Cleanup pointer casting code style

2020-05-06 Thread Dan Carpenter
On Sat, May 02, 2020 at 08:47:50AM +0800, Yu Jian Wu wrote:
> Cleanup by adding a space between type and pointer, in accordance with
> checkpatch.pl message "(foo*)" should be "(foo *)".
> 
> Signed-off-by: Yu Jian Wu 
> ---
>  .../staging/rtl8723bs/os_dep/ioctl_cfg80211.c| 16 
>  drivers/staging/rtl8723bs/os_dep/recv_linux.c|  2 +-
>  2 files changed, 9 insertions(+), 9 deletions(-)
> 
> diff --git a/drivers/staging/rtl8723bs/os_dep/ioctl_cfg80211.c 
> b/drivers/staging/rtl8723bs/os_dep/ioctl_cfg80211.c
> index b037868fbf22..8377bc75e308 100644
> --- a/drivers/staging/rtl8723bs/os_dep/ioctl_cfg80211.c
> +++ b/drivers/staging/rtl8723bs/os_dep/ioctl_cfg80211.c
> @@ -98,7 +98,7 @@ static struct ieee80211_channel rtw_2ghz_channels[] = {
>  
>  static void rtw_2g_channels_init(struct ieee80211_channel *channels)
>  {
> - memcpy((void*)channels, (void*)rtw_2ghz_channels,
> + memcpy((void *)channels, (void *)rtw_2ghz_channels,

These casts aren't required.  It would be better to remove them.

memcpy(channels, rtw_2ghz_channels,
   sizeof(*channel) * RTW_2G_CHANNELS_NUM);

Same for a bunch of the others as well.

regards,
dan carpenter

___
devel mailing list
de...@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel


[PATCH] staging: rtl8723bs: os_dep: Cleanup pointer casting code style

2020-05-01 Thread Yu Jian Wu
Cleanup by adding a space between type and pointer, in accordance with
checkpatch.pl message "(foo*)" should be "(foo *)".

Signed-off-by: Yu Jian Wu 
---
 .../staging/rtl8723bs/os_dep/ioctl_cfg80211.c| 16 
 drivers/staging/rtl8723bs/os_dep/recv_linux.c|  2 +-
 2 files changed, 9 insertions(+), 9 deletions(-)

diff --git a/drivers/staging/rtl8723bs/os_dep/ioctl_cfg80211.c 
b/drivers/staging/rtl8723bs/os_dep/ioctl_cfg80211.c
index b037868fbf22..8377bc75e308 100644
--- a/drivers/staging/rtl8723bs/os_dep/ioctl_cfg80211.c
+++ b/drivers/staging/rtl8723bs/os_dep/ioctl_cfg80211.c
@@ -98,7 +98,7 @@ static struct ieee80211_channel rtw_2ghz_channels[] = {
 
 static void rtw_2g_channels_init(struct ieee80211_channel *channels)
 {
-   memcpy((void*)channels, (void*)rtw_2ghz_channels,
+   memcpy((void *)channels, (void *)rtw_2ghz_channels,
sizeof(struct ieee80211_channel)*RTW_2G_CHANNELS_NUM
);
 }
@@ -133,8 +133,8 @@ static struct ieee80211_supported_band *rtw_spt_band_alloc(
if (!spt_band)
goto exit;
 
-   spt_band->channels = (struct ieee80211_channel*)(((u8 
*)spt_band)+sizeof(struct ieee80211_supported_band));
-   spt_band->bitrates = (struct ieee80211_rate*)(((u8 
*)spt_band->channels)+sizeof(struct ieee80211_channel)*n_channels);
+   spt_band->channels = (struct ieee80211_channel *)(((u8 
*)spt_band)+sizeof(struct ieee80211_supported_band));
+   spt_band->bitrates = (struct ieee80211_rate *)(((u8 
*)spt_band->channels)+sizeof(struct ieee80211_channel)*n_channels);
spt_band->band = band;
spt_band->n_channels = n_channels;
spt_band->n_bitrates = n_bitrates;
@@ -347,7 +347,7 @@ struct cfg80211_bss *rtw_cfg80211_inform_bss(struct adapter 
*padapter, struct wl
memcpy(pbuf, pnetwork->network.IEs, pnetwork->network.IELength);
len += pnetwork->network.IELength;
 
-   *((__le64*)pbuf) = cpu_to_le64(notify_timestamp);
+   *((__le64 *)pbuf) = cpu_to_le64(notify_timestamp);
 
bss = cfg80211_inform_bss_frame(wiphy, notify_channel, (struct 
ieee80211_mgmt *)buf,
len, notify_signal, GFP_ATOMIC);
@@ -1118,7 +1118,7 @@ static int cfg80211_rtw_add_key(struct wiphy *wiphy, 
struct net_device *ndev,
else if (check_fwstate(pmlmepriv, WIFI_AP_STATE) == true)
{
if (mac_addr)
-   memcpy(param->sta_addr, (void*)mac_addr, ETH_ALEN);
+   memcpy(param->sta_addr, (void *)mac_addr, ETH_ALEN);
 
ret = rtw_cfg80211_ap_set_encryption(ndev, param, param_len);
}
@@ -2474,7 +2474,7 @@ static netdev_tx_t 
rtw_cfg80211_monitor_if_xmit_entry(struct sk_buff *skb, struc
 * for two MAC addresses
 */
skb_pull(skb, dot11_hdr_len + qos_len + snap_len - 
sizeof(src_mac_addr) * 2);
-   pdata = (unsigned char*)skb->data;
+   pdata = (unsigned char *)skb->data;
memcpy(pdata, dst_mac_addr, sizeof(dst_mac_addr));
memcpy(pdata + sizeof(dst_mac_addr), src_mac_addr, 
sizeof(src_mac_addr));
 
@@ -2529,7 +2529,7 @@ static netdev_tx_t 
rtw_cfg80211_monitor_if_xmit_entry(struct sk_buff *skb, struc
 
pframe = (u8 *)(pmgntframe->buf_addr) + TXDESC_OFFSET;
 
-   memcpy(pframe, (void*)buf, len);
+   memcpy(pframe, (void *)buf, len);
pattrib->pktlen = len;
 
pwlanhdr = (struct ieee80211_hdr *)pframe;
@@ -3019,7 +3019,7 @@ static int _cfg80211_rtw_mgmt_tx(struct adapter 
*padapter, u8 tx_ch, const u8 *b
 
pframe = (u8 *)(pmgntframe->buf_addr) + TXDESC_OFFSET;
 
-   memcpy(pframe, (void*)buf, len);
+   memcpy(pframe, (void *)buf, len);
pattrib->pktlen = len;
 
pwlanhdr = (struct ieee80211_hdr *)pframe;
diff --git a/drivers/staging/rtl8723bs/os_dep/recv_linux.c 
b/drivers/staging/rtl8723bs/os_dep/recv_linux.c
index 60c35d92ba29..0535dabc1bf5 100644
--- a/drivers/staging/rtl8723bs/os_dep/recv_linux.c
+++ b/drivers/staging/rtl8723bs/os_dep/recv_linux.c
@@ -230,7 +230,7 @@ static void rtw_os_ksocket_send(struct adapter *padapter, 
union recv_frame *prec
 
if (rx_pid == psta->pid) {
int i;
-   u16 len = *(u16*)(skb->data+ETH_HLEN+2);
+   u16 len = *(u16 *)(skb->data+ETH_HLEN+2);
DBG_871X("eth, RC: len = 0x%x\n", len);
 
for (i = 0; i < len; i++)
-- 
2.17.1


___
devel mailing list
de...@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel