Re: [PATCH] staging: rtl8723bs: remove obsolete commented out code
On Thu, Feb 11, 2021 at 4:16 PM Greg Kroah-Hartman wrote: > > A: http://en.wikipedia.org/wiki/Top_post > Q: Were do I find info about this thing called top-posting? > A: Because it messes up the order in which people normally read text. > Q: Why is top-posting such a bad thing? > A: Top-posting. > Q: What is the most annoying thing in e-mail? > > A: No. > Q: Should I include quotations after my reply? > > http://daringfireball.net/2007/07/on_top > > On Thu, Feb 11, 2021 at 04:00:04PM +0530, karthek wrote: > > Should i send them as patch series? > > Please do. > > thanks, > > greg k-h Yeah, it is clearly mentioned in lfd103 which i do remember but i want you to know that it's purely accidental ___ devel mailing list de...@linuxdriverproject.org http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
Re: [PATCH] staging: rtl8723bs: remove obsolete commented out code
A: http://en.wikipedia.org/wiki/Top_post Q: Were do I find info about this thing called top-posting? A: Because it messes up the order in which people normally read text. Q: Why is top-posting such a bad thing? A: Top-posting. Q: What is the most annoying thing in e-mail? A: No. Q: Should I include quotations after my reply? http://daringfireball.net/2007/07/on_top On Thu, Feb 11, 2021 at 04:00:04PM +0530, karthek wrote: > Should i send them as patch series? Please do. thanks, greg k-h ___ devel mailing list de...@linuxdriverproject.org http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
Re: [PATCH] staging: rtl8723bs: remove obsolete commented out code
Should i send them as patch series? On Thu, Feb 11, 2021 at 1:27 PM Dan Carpenter wrote: > > On Thu, Feb 11, 2021 at 12:40:41AM +0530, karthik alapati wrote: > > @@ -867,10 +845,8 @@ static void PHY_HandleSwChnlAndSetBW8723B( > > if (bSetBandWidth) > > pHalData->bSetChnlBW = true; > > > > - if (!pHalData->bSetChnlBW && !pHalData->bSwChnl) { > > - /* DBG_871X("<= PHY_HandleSwChnlAndSetBW8812: bSwChnl %d, > > bSetChnlBW %d\n", pHalData->bSwChnl, pHalData->bSetChnlBW); */ > > + if (!pHalData->bSetChnlBW && !pHalData->bSwChnl) > > return; > > - } > > In this case, the + line is correct. Good job. > > > > > > > if (pHalData->bSwChnl) { > > @@ -929,9 +905,7 @@ void PHY_SetSwChnlBWMode8723B( > > u8 Offset80 > > ) > > { > > - /* DBG_871X("%s() ===>\n", __func__); */ > > > > PHY_HandleSwChnlAndSetBW8723B(Adapter, true, true, channel, > > Bandwidth, Offset40, Offset80, channel); > > > > - /* DBG_871X("<==%s()\n", __func__); */ > > Please delete the blank lines as well. > > regards, > dan carpenter > ___ devel mailing list de...@linuxdriverproject.org http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
Re: [PATCH] staging: rtl8723bs: remove obsolete commented out code
On Thu, Feb 11, 2021 at 12:40:41AM +0530, karthik alapati wrote: > @@ -867,10 +845,8 @@ static void PHY_HandleSwChnlAndSetBW8723B( > if (bSetBandWidth) > pHalData->bSetChnlBW = true; > > - if (!pHalData->bSetChnlBW && !pHalData->bSwChnl) { > - /* DBG_871X("<= PHY_HandleSwChnlAndSetBW8812: bSwChnl %d, > bSetChnlBW %d\n", pHalData->bSwChnl, pHalData->bSetChnlBW); */ > + if (!pHalData->bSetChnlBW && !pHalData->bSwChnl) > return; > - } In this case, the + line is correct. Good job. > > > if (pHalData->bSwChnl) { > @@ -929,9 +905,7 @@ void PHY_SetSwChnlBWMode8723B( > u8 Offset80 > ) > { > - /* DBG_871X("%s() ===>\n", __func__); */ > > PHY_HandleSwChnlAndSetBW8723B(Adapter, true, true, channel, Bandwidth, > Offset40, Offset80, channel); > > - /* DBG_871X("<==%s()\n", __func__); */ Please delete the blank lines as well. regards, dan carpenter ___ devel mailing list de...@linuxdriverproject.org http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
Re: [PATCH] staging: rtl8723bs: remove obsolete commented out code
On Thu, Feb 11, 2021 at 12:40:41AM +0530, karthik alapati wrote: > fix some checkpatch "Block comments use * on subsequent lines" > warnings and remove obsolete code > This isn't the correct commit message. It should say something like: "There is a bunch of messy, commented out code. Just delete it." > Suggested-by: Dan Carpenter > Signed-off-by: karthik alapati > --- > .../staging/rtl8723bs/hal/rtl8723b_phycfg.c | 44 --- > 1 file changed, 9 insertions(+), 35 deletions(-) > > diff --git a/drivers/staging/rtl8723bs/hal/rtl8723b_phycfg.c > b/drivers/staging/rtl8723bs/hal/rtl8723b_phycfg.c > index 1fd504181..3d22bd304 100644 > --- a/drivers/staging/rtl8723bs/hal/rtl8723b_phycfg.c > +++ b/drivers/staging/rtl8723bs/hal/rtl8723b_phycfg.c > @@ -57,8 +57,6 @@ u32 PHY_QueryBBReg_8723B(struct adapter *Adapter, u32 > RegAddr, u32 BitMask) > return 0; > #endif > > - /* RT_TRACE(COMP_RF, DBG_TRACE, ("--->PHY_QueryBBReg(): RegAddr(%#lx), > BitMask(%#lx)\n", RegAddr, BitMask)); */ > - > OriginalValue = rtw_read32(Adapter, RegAddr); > BitShift = phy_CalculateBitShift(BitMask); > > @@ -94,8 +92,6 @@ void PHY_SetBBReg_8723B( > return; > #endif > > - /* RT_TRACE(COMP_RF, DBG_TRACE, ("--->PHY_SetBBReg(): RegAddr(%#lx), > BitMask(%#lx), Data(%#lx)\n", RegAddr, BitMask, Data)); */ > - > if (BitMask != bMaskDWord) { /* if not "double word" write */ > OriginalValue = rtw_read32(Adapter, RegAddr); > BitShift = phy_CalculateBitShift(BitMask); > @@ -159,13 +155,9 @@ static u32 phy_RFSerialRead_8723B( > if (RfPiEnable) { > /* Read from BBreg8b8, 12 bits for 8190, 20bits for T65 RF */ > retValue = PHY_QueryBBReg(Adapter, > pPhyReg->rfLSSIReadBackPi|MaskforPhySet, bLSSIReadBackData); > - > - /* RT_DISP(FINIT, INIT_RF, ("Readback from RF-PI : 0x%x\n", > retValue)); */ > } else { > /* Read from BBreg8a0, 12 bits for 8190, 20 bits for T65 RF */ > retValue = PHY_QueryBBReg(Adapter, > pPhyReg->rfLSSIReadBack|MaskforPhySet, bLSSIReadBackData); > - > - /* RT_DISP(FINIT, INIT_RF, ("Readback from RF-SI : 0x%x\n", > retValue)); */ > } > return retValue; > > @@ -230,15 +222,13 @@ static void phy_RFSerialWrite_8723B( > /* */ > /* Put write addr in [5:0] and write data in [31:16] */ > /* */ > - /* DataAndAddr = (Data<<16) | (NewOffset&0x3f); */ > - DataAndAddr = ((NewOffset<<20) | (Data&0x000f)) & 0x0fff; > /* T65 RF */ > + DataAndAddr = ((NewOffset<<20) | (Data&0x000f)) & 0x0fff; > + /* T65 RF */ The patch is supposed to be deleting code so we don't want any + lines which change code. Only deletes. Also don't put the coment after the the code which it's commenting on. > @@ -761,20 +745,20 @@ static void phy_PostSetBwMode8723B(struct adapter > *Adapter) > > PHY_SetBBReg(Adapter, rFPGA1_RFMOD, bRFMOD, 0x1); > > - /* Set Control channel to upper or lower. These settings are > required only for 40MHz */ > + /** > + * Set Control channel to upper or lower. These settings are > required only > + * for 40MHz > + */ Yeah. Get rid of these plus lines and resend. regards, dan carpenter ___ devel mailing list de...@linuxdriverproject.org http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
Re: [PATCH] staging: rtl8723bs: remove obsolete commented out code
On Thu, Feb 11, 2021 at 12:49:30AM +0530, karthek wrote: > Hey dan, > check this out too I have no idea what you're talking about. Anyway, I just read my inbox in chronological order. That means I tend to send my replies before reading Greg's comments and before seeing the v2 patches. Just be patient and I will get to it. regards, dan carpenter ___ devel mailing list de...@linuxdriverproject.org http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
Re: [PATCH] staging: rtl8723bs: remove obsolete commented out code
Hey dan, check this out too ___ devel mailing list de...@linuxdriverproject.org http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
[PATCH] staging: rtl8723bs: remove obsolete commented out code
fix some checkpatch "Block comments use * on subsequent lines" warnings and remove obsolete code Suggested-by: Dan Carpenter Signed-off-by: karthik alapati --- .../staging/rtl8723bs/hal/rtl8723b_phycfg.c | 44 --- 1 file changed, 9 insertions(+), 35 deletions(-) diff --git a/drivers/staging/rtl8723bs/hal/rtl8723b_phycfg.c b/drivers/staging/rtl8723bs/hal/rtl8723b_phycfg.c index 1fd504181..3d22bd304 100644 --- a/drivers/staging/rtl8723bs/hal/rtl8723b_phycfg.c +++ b/drivers/staging/rtl8723bs/hal/rtl8723b_phycfg.c @@ -57,8 +57,6 @@ u32 PHY_QueryBBReg_8723B(struct adapter *Adapter, u32 RegAddr, u32 BitMask) return 0; #endif - /* RT_TRACE(COMP_RF, DBG_TRACE, ("--->PHY_QueryBBReg(): RegAddr(%#lx), BitMask(%#lx)\n", RegAddr, BitMask)); */ - OriginalValue = rtw_read32(Adapter, RegAddr); BitShift = phy_CalculateBitShift(BitMask); @@ -94,8 +92,6 @@ void PHY_SetBBReg_8723B( return; #endif - /* RT_TRACE(COMP_RF, DBG_TRACE, ("--->PHY_SetBBReg(): RegAddr(%#lx), BitMask(%#lx), Data(%#lx)\n", RegAddr, BitMask, Data)); */ - if (BitMask != bMaskDWord) { /* if not "double word" write */ OriginalValue = rtw_read32(Adapter, RegAddr); BitShift = phy_CalculateBitShift(BitMask); @@ -159,13 +155,9 @@ static u32 phy_RFSerialRead_8723B( if (RfPiEnable) { /* Read from BBreg8b8, 12 bits for 8190, 20bits for T65 RF */ retValue = PHY_QueryBBReg(Adapter, pPhyReg->rfLSSIReadBackPi|MaskforPhySet, bLSSIReadBackData); - - /* RT_DISP(FINIT, INIT_RF, ("Readback from RF-PI : 0x%x\n", retValue)); */ } else { /* Read from BBreg8a0, 12 bits for 8190, 20 bits for T65 RF */ retValue = PHY_QueryBBReg(Adapter, pPhyReg->rfLSSIReadBack|MaskforPhySet, bLSSIReadBackData); - - /* RT_DISP(FINIT, INIT_RF, ("Readback from RF-SI : 0x%x\n", retValue)); */ } return retValue; @@ -230,15 +222,13 @@ static void phy_RFSerialWrite_8723B( /* */ /* Put write addr in [5:0] and write data in [31:16] */ /* */ - /* DataAndAddr = (Data<<16) | (NewOffset&0x3f); */ - DataAndAddr = ((NewOffset<<20) | (Data&0x000f)) & 0x0fff; /* T65 RF */ + DataAndAddr = ((NewOffset<<20) | (Data&0x000f)) & 0x0fff; + /* T65 RF */ /* */ /* Write Operation */ /* */ PHY_SetBBReg(Adapter, pPhyReg->rf3wireOffset, bMaskDWord, DataAndAddr); - /* RTPRINT(FPHY, PHY_RFW, ("RFW-%d Addr[0x%lx]= 0x%lx\n", eRFPath, pPhyReg->rf3wireOffset, DataAndAddr)); */ - } @@ -473,7 +463,6 @@ int PHY_RFConfig8723B(struct adapter *Adapter) rtStatus = PHY_RF6052_Config8723B(Adapter); phy_LCK_8723B(Adapter); - /* PHY_BB8723B_Config_1T(Adapter); */ return rtStatus; } @@ -580,8 +569,6 @@ u8 PHY_GetTxPowerIndex( s8 txPower = 0, powerDiffByRate = 0, limit = 0; bool bIn24G = false; - /* DBG_871X("===>%s\n", __func__); */ - txPower = (s8) PHY_GetTxPowerIndexBase(padapter, RFPath, Rate, BandWidth, Channel, &bIn24G); powerDiffByRate = PHY_GetTxPowerByRate(padapter, BAND_ON_2_4G, ODM_RF_PATH_A, RF_1TX, Rate); @@ -603,7 +590,6 @@ u8 PHY_GetTxPowerIndex( if (txPower > MAX_POWER_INDEX) txPower = MAX_POWER_INDEX; - /* DBG_871X("Final Tx Power(RF-%c, Channel: %d) = %d(0x%X)\n", ((RFPath == 0)?'A':'B'), Channel, txPower, txPower)); */ return (u8) txPower; } @@ -750,8 +736,6 @@ static void phy_PostSetBwMode8723B(struct adapter *Adapter) PHY_SetBBReg(Adapter, rFPGA1_RFMOD, bRFMOD, 0x0); -/* PHY_SetBBReg(Adapter, rFPGA0_AnalogParameter2, BIT10, 1); */ - PHY_SetBBReg(Adapter, rOFDM0_TxPseudoNoiseWgt, (BIT31|BIT30), 0x0); break; @@ -761,20 +745,20 @@ static void phy_PostSetBwMode8723B(struct adapter *Adapter) PHY_SetBBReg(Adapter, rFPGA1_RFMOD, bRFMOD, 0x1); - /* Set Control channel to upper or lower. These settings are required only for 40MHz */ + /** +* Set Control channel to upper or lower. These settings are required only +* for 40MHz +*/ PHY_SetBBReg(Adapter, rCCK0_System, bCCKSideBand, (pHalData->nCur40MhzPrimeSC>>1)); PHY_SetBBReg(Adapter, rOFDM1_LSTF, 0xC00, pHalData->nCur40MhzPrimeSC); -/* PHY_SetBBReg(Adapter, rFPGA0_AnalogParameter2, BIT10, 0); */ - PHY_SetBBReg(Adapter, 0x818, (BIT26|BIT27), (pHalData->nCur40MhzPrimeSC == HAL_PRIME_CHNL_OFFSET_LOWER) ? 2 : 1); break; default: - /*RT_TRACE(COMP_DBG, DBG_LOUD, ("phy_SetBWMode8723B(): unknown Bandwidth: %#X\n"\ - , pHalData->CurrentChannelBW));*/ + break; } @@ -787,