Re: [PATCH] staging: unisys: Remove chanstub files
On Fri, Nov 07, 2014 at 10:17:40AM -0800, Greg KH wrote: On Fri, Nov 07, 2014 at 12:58:24PM -0500, Ken Depro wrote: While fixing the CamelCase checks for the functions in the chanstub source and header files, I discovered they are no longer being used. This patch removes the two chanstub files, and deletes the #include of these files from uislib.c and uisqueue.c. It also removes the chanstub.o from the channels Makefile. Are you sure this patch is correct? You now have no MODULE_LICENSE or other MODULE_* information for this module, and you have no module_init() or _exit calls. You might not need the init/exit calls, but you will need the MODULE_LICENSE macro. Given that you seem to be ignoring my emails, I'll just go dump the pending patches you have sent me for this driver, as there seems to be a problem in the feedback loop here. Please resend all of your pending patches after fixing this. greg k-h ___ devel mailing list de...@linuxdriverproject.org http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
[PATCH] staging: unisys: Remove chanstub files While fixing the CamelCase checks for the functions in the chanstub source and header files, I discovered they are no longer being used. This patch remov
Signed-off-by: Ken Depro kenneth.de...@unisys.com
---
drivers/staging/unisys/channels/Makefile |2 +-
drivers/staging/unisys/channels/chanstub.c | 75
drivers/staging/unisys/channels/chanstub.h | 23 -
drivers/staging/unisys/uislib/uislib.c |1 -
drivers/staging/unisys/uislib/uisqueue.c |2 -
5 files changed, 1 insertion(+), 102 deletions(-)
delete mode 100644 drivers/staging/unisys/channels/chanstub.c
delete mode 100644 drivers/staging/unisys/channels/chanstub.h
diff --git a/drivers/staging/unisys/channels/Makefile
b/drivers/staging/unisys/channels/Makefile
index adc1842..0929a8e 100644
--- a/drivers/staging/unisys/channels/Makefile
+++ b/drivers/staging/unisys/channels/Makefile
@@ -4,7 +4,7 @@
obj-$(CONFIG_UNISYS_CHANNELSTUB) += visorchannelstub.o
-visorchannelstub-y := channel.o chanstub.o
+visorchannelstub-y := channel.o
ccflags-y += -Idrivers/staging/unisys/include
ccflags-y += -Idrivers/staging/unisys/common-spar/include
diff --git a/drivers/staging/unisys/channels/chanstub.c
b/drivers/staging/unisys/channels/chanstub.c
deleted file mode 100644
index b6fd126..000
--- a/drivers/staging/unisys/channels/chanstub.c
+++ /dev/null
@@ -1,75 +0,0 @@
-/* Copyright (C) 2010 - 2013 UNISYS CORPORATION
- * All rights reserved.
- *
- * This program is free software; you can redistribute it and/or modify
- * it under the terms of the GNU General Public License as published by
- * the Free Software Foundation; either version 2 of the License, or (at
- * your option) any later version.
- *
- * This program is distributed in the hope that it will be useful, but
- * WITHOUT ANY WARRANTY; without even the implied warranty of
- * MERCHANTABILITY OR FITNESS FOR A PARTICULAR PURPOSE, GOOD TITLE or
- * NON INFRINGEMENT. See the GNU General Public License for more
- * details.
- */
-
-#define EXPORT_SYMTAB
-#include linux/kernel.h
-#ifdef CONFIG_MODVERSIONS
-#include config/modversions.h
-#endif
-#include linux/module.h
-#include linux/init.h/* for module_init and module_exit */
-#include linux/slab.h/* for memcpy */
-#include linux/types.h
-
-#include channel.h
-#include chanstub.h
-#include timskmod.h
-#include version.h
-
-static __init int
-channel_mod_init(void)
-{
- if (!unisys_spar_platform)
- return -ENODEV;
- return 0;
-}
-
-static __exit void
-channel_mod_exit(void)
-{
-}
-
-unsigned char
-SignalInsert_withLock(struct channel_header __iomem *pChannel, u32 Queue,
- void *pSignal, spinlock_t *lock)
-{
- unsigned char result;
- unsigned long flags;
-
- spin_lock_irqsave(lock, flags);
- result = spar_signal_insert(pChannel, Queue, pSignal);
- spin_unlock_irqrestore(lock, flags);
- return result;
-}
-
-unsigned char
-SignalRemove_withLock(struct channel_header __iomem *pChannel, u32 Queue,
- void *pSignal, spinlock_t *lock)
-{
- unsigned char result;
-
- spin_lock(lock);
- result = spar_signal_remove(pChannel, Queue, pSignal);
- spin_unlock(lock);
- return result;
-}
-
-module_init(channel_mod_init);
-module_exit(channel_mod_exit);
-
-MODULE_LICENSE(GPL);
-MODULE_AUTHOR(Bryan Glaudel);
-MODULE_ALIAS(uischan);
- /* this is extracted during depmod and kept in modules.dep */
diff --git a/drivers/staging/unisys/channels/chanstub.h
b/drivers/staging/unisys/channels/chanstub.h
deleted file mode 100644
index 1531759..000
--- a/drivers/staging/unisys/channels/chanstub.h
+++ /dev/null
@@ -1,23 +0,0 @@
-/* Copyright (C) 2010 - 2013 UNISYS CORPORATION
- * All rights reserved.
- *
- * This program is free software; you can redistribute it and/or modify
- * it under the terms of the GNU General Public License as published by
- * the Free Software Foundation; either version 2 of the License, or (at
- * your option) any later version.
- *
- * This program is distributed in the hope that it will be useful, but
- * WITHOUT ANY WARRANTY; without even the implied warranty of
- * MERCHANTABILITY OR FITNESS FOR A PARTICULAR PURPOSE, GOOD TITLE or
- * NON INFRINGEMENT. See the GNU General Public License for more
- * details.
- */
-
-#ifndef __CHANSTUB_H__
-#define __CHANSTUB_H__
-unsigned char SignalInsert_withLock(struct channel_header __iomem *pChannel,
- u32 Queue, void *pSignal, spinlock_t *lock);
-unsigned char SignalRemove_withLock(struct channel_header __iomem *pChannel,
- u32 Queue, void *pSignal, spinlock_t *lock);
-
-#endif
diff --git a/drivers/staging/unisys/uislib/uislib.c
b/drivers/staging/unisys/uislib/uislib.c
index 7c87452..9bcaa0f 100644
--- a/drivers/staging/unisys/uislib/uislib.c
+++ b/drivers/staging/unisys/uislib/uislib.c
@@ -41,7 +41,6 @@
#include sparstop.h
#include visorchipset.h
-#include chanstub.h
#include version.h
#include guestlinuxdebug.h
diff --git
[PATCH] staging: unisys: Remove chanstub files
While fixing the CamelCase checks for the functions in the chanstub
source and header files, I discovered they are no longer being used.
This patch removes the two chanstub files, and deletes the #include
of these files from uislib.c and uisqueue.c. It also removes the
chanstub.o from the channels Makefile.
Signed-off-by: Ken Depro kenneth.de...@unisys.com
---
drivers/staging/unisys/channels/Makefile |2 +-
drivers/staging/unisys/channels/chanstub.c | 75
drivers/staging/unisys/channels/chanstub.h | 23 -
drivers/staging/unisys/uislib/uislib.c |1 -
drivers/staging/unisys/uislib/uisqueue.c |2 -
5 files changed, 1 insertion(+), 102 deletions(-)
delete mode 100644 drivers/staging/unisys/channels/chanstub.c
delete mode 100644 drivers/staging/unisys/channels/chanstub.h
diff --git a/drivers/staging/unisys/channels/Makefile
b/drivers/staging/unisys/channels/Makefile
index adc1842..0929a8e 100644
--- a/drivers/staging/unisys/channels/Makefile
+++ b/drivers/staging/unisys/channels/Makefile
@@ -4,7 +4,7 @@
obj-$(CONFIG_UNISYS_CHANNELSTUB) += visorchannelstub.o
-visorchannelstub-y := channel.o chanstub.o
+visorchannelstub-y := channel.o
ccflags-y += -Idrivers/staging/unisys/include
ccflags-y += -Idrivers/staging/unisys/common-spar/include
diff --git a/drivers/staging/unisys/channels/chanstub.c
b/drivers/staging/unisys/channels/chanstub.c
deleted file mode 100644
index b6fd126..000
--- a/drivers/staging/unisys/channels/chanstub.c
+++ /dev/null
@@ -1,75 +0,0 @@
-/* Copyright (C) 2010 - 2013 UNISYS CORPORATION
- * All rights reserved.
- *
- * This program is free software; you can redistribute it and/or modify
- * it under the terms of the GNU General Public License as published by
- * the Free Software Foundation; either version 2 of the License, or (at
- * your option) any later version.
- *
- * This program is distributed in the hope that it will be useful, but
- * WITHOUT ANY WARRANTY; without even the implied warranty of
- * MERCHANTABILITY OR FITNESS FOR A PARTICULAR PURPOSE, GOOD TITLE or
- * NON INFRINGEMENT. See the GNU General Public License for more
- * details.
- */
-
-#define EXPORT_SYMTAB
-#include linux/kernel.h
-#ifdef CONFIG_MODVERSIONS
-#include config/modversions.h
-#endif
-#include linux/module.h
-#include linux/init.h/* for module_init and module_exit */
-#include linux/slab.h/* for memcpy */
-#include linux/types.h
-
-#include channel.h
-#include chanstub.h
-#include timskmod.h
-#include version.h
-
-static __init int
-channel_mod_init(void)
-{
- if (!unisys_spar_platform)
- return -ENODEV;
- return 0;
-}
-
-static __exit void
-channel_mod_exit(void)
-{
-}
-
-unsigned char
-SignalInsert_withLock(struct channel_header __iomem *pChannel, u32 Queue,
- void *pSignal, spinlock_t *lock)
-{
- unsigned char result;
- unsigned long flags;
-
- spin_lock_irqsave(lock, flags);
- result = spar_signal_insert(pChannel, Queue, pSignal);
- spin_unlock_irqrestore(lock, flags);
- return result;
-}
-
-unsigned char
-SignalRemove_withLock(struct channel_header __iomem *pChannel, u32 Queue,
- void *pSignal, spinlock_t *lock)
-{
- unsigned char result;
-
- spin_lock(lock);
- result = spar_signal_remove(pChannel, Queue, pSignal);
- spin_unlock(lock);
- return result;
-}
-
-module_init(channel_mod_init);
-module_exit(channel_mod_exit);
-
-MODULE_LICENSE(GPL);
-MODULE_AUTHOR(Bryan Glaudel);
-MODULE_ALIAS(uischan);
- /* this is extracted during depmod and kept in modules.dep */
diff --git a/drivers/staging/unisys/channels/chanstub.h
b/drivers/staging/unisys/channels/chanstub.h
deleted file mode 100644
index 1531759..000
--- a/drivers/staging/unisys/channels/chanstub.h
+++ /dev/null
@@ -1,23 +0,0 @@
-/* Copyright (C) 2010 - 2013 UNISYS CORPORATION
- * All rights reserved.
- *
- * This program is free software; you can redistribute it and/or modify
- * it under the terms of the GNU General Public License as published by
- * the Free Software Foundation; either version 2 of the License, or (at
- * your option) any later version.
- *
- * This program is distributed in the hope that it will be useful, but
- * WITHOUT ANY WARRANTY; without even the implied warranty of
- * MERCHANTABILITY OR FITNESS FOR A PARTICULAR PURPOSE, GOOD TITLE or
- * NON INFRINGEMENT. See the GNU General Public License for more
- * details.
- */
-
-#ifndef __CHANSTUB_H__
-#define __CHANSTUB_H__
-unsigned char SignalInsert_withLock(struct channel_header __iomem *pChannel,
- u32 Queue, void *pSignal, spinlock_t *lock);
-unsigned char SignalRemove_withLock(struct channel_header __iomem *pChannel,
- u32 Queue, void *pSignal, spinlock_t *lock);
-
-#endif
diff --git a/drivers/staging/unisys/uislib/uislib.c
Re: [PATCH] staging: unisys: Remove chanstub files While fixing the CamelCase checks for the functions in the chanstub source and header files, I discovered they are no longer being used. This patch r
On Fri, Nov 07, 2014 at 12:51:34PM -0500, Ken Depro wrote: Signed-off-by: Ken Depro kenneth.de...@unisys.com Your Subject: is a bit long... ___ devel mailing list de...@linuxdriverproject.org http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
RE: [PATCH] staging: unisys: Remove chanstub files While fixing the CamelCase checks for the functions [...]
Subject: [PATCH] staging: unisys: Remove chanstub files While fixing the CamelCase checks for the functions in the chanstub source and header files, I discovered they are no longer being used. This patch removes the two chanstub files, and deletes the #include ... [...] -- 1.7.9.5 Resubmitted to fix inadvertent patch subject/comment merge. ___ devel mailing list de...@linuxdriverproject.org http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
RE: [PATCH] staging: unisys: Remove chanstub files While fixing the CamelCase checks for the functions in the chanstub source and header files, I discovered they are no longer being used. This patch r
On Fri, Nov 07, 2014 at 12:51:34PM -0500, Ken Depro wrote: Signed-off-by: Ken Depro kenneth.de...@unisys.com Your Subject: is a bit long... Sorry about that. I noticed it after it was posted. I resubmitted the patch after fixing up the Subject/comment merge. Ken ___ devel mailing list de...@linuxdriverproject.org http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
Re: [PATCH] staging: unisys: Remove chanstub files
On Fri, Nov 07, 2014 at 12:58:24PM -0500, Ken Depro wrote: While fixing the CamelCase checks for the functions in the chanstub source and header files, I discovered they are no longer being used. This patch removes the two chanstub files, and deletes the #include of these files from uislib.c and uisqueue.c. It also removes the chanstub.o from the channels Makefile. Are you sure this patch is correct? You now have no MODULE_LICENSE or other MODULE_* information for this module, and you have no module_init() or _exit calls. You might not need the init/exit calls, but you will need the MODULE_LICENSE macro. thanks, greg k-h ___ devel mailing list de...@linuxdriverproject.org http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
