Re: [PATCH] staging: wusbcore: Fix build error without CONFIG_USB

[Greg KH]

On Fri, Aug 09, 2019 at 06:21:50PM +0800, YueHaibing wrote:
> USB_WUSB should depends on CONFIG_USB, otherwise building fails
> 
> drivers/staging/wusbcore/wusbhc.o: In function `wusbhc_giveback_urb':
> wusbhc.c:(.text+0xa28): undefined reference to `usb_hcd_giveback_urb'
> 
> Reported-by: Hulk Robot 
> Fixes: 71ed79b0e4be ("USB: Move wusbcore and UWB to staging as it is 
> obsolete")
> Signed-off-by: YueHaibing 
> ---
>  drivers/staging/wusbcore/Kconfig | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/staging/wusbcore/Kconfig 
> b/drivers/staging/wusbcore/Kconfig
> index 056c60b..a559d02 100644
> --- a/drivers/staging/wusbcore/Kconfig
> +++ b/drivers/staging/wusbcore/Kconfig
> @@ -4,7 +4,7 @@
>  #
>  config USB_WUSB
>   tristate "Enable Wireless USB extensions"
> - depends on UWB
> + depends on UWB && USB
>   select CRYPTO
>   select CRYPTO_AES
>   select CRYPTO_CCM
> -- 
> 2.7.4

Ah, good catch, sorry about that!

greg k-h
___
devel mailing list
de...@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel

[PATCH] staging: wusbcore: Fix build error without CONFIG_USB

[YueHaibing]

USB_WUSB should depends on CONFIG_USB, otherwise building fails

drivers/staging/wusbcore/wusbhc.o: In function `wusbhc_giveback_urb':
wusbhc.c:(.text+0xa28): undefined reference to `usb_hcd_giveback_urb'

Reported-by: Hulk Robot 
Fixes: 71ed79b0e4be ("USB: Move wusbcore and UWB to staging as it is obsolete")
Signed-off-by: YueHaibing 
---
 drivers/staging/wusbcore/Kconfig | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/staging/wusbcore/Kconfig b/drivers/staging/wusbcore/Kconfig
index 056c60b..a559d02 100644
--- a/drivers/staging/wusbcore/Kconfig
+++ b/drivers/staging/wusbcore/Kconfig
@@ -4,7 +4,7 @@
 #
 config USB_WUSB
tristate "Enable Wireless USB extensions"
-   depends on UWB
+   depends on UWB && USB
select CRYPTO
select CRYPTO_AES
select CRYPTO_CCM
-- 
2.7.4


___
devel mailing list
de...@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel