Re: [PATCH 0/2] staging: erofs: fixed -Wmissing-prototype warnings.
On 2019/1/8 17:08, Jeremy Sowden wrote: > On 2019-01-08, at 09:46:18 +0800, Gao Xiang wrote: >> On 2019/1/8 2:25, Jeremy Sowden wrote: >>> Fixes for -Wmissing-prototype warnings in the erofs driver. One >>> group of functions have been made static; for the second, prototypes >>> have been moved to a head >> Is -Wmissing-prototypes required for the current linux kernel? >> I cannot see this warning in my personal kernel compilation... >> >> Functions your fix have already been added proper erofs prefix, >> therefore it wouldn't pollute the global namespace: >> z_erofs_vle_work_release >> z_erofs_unzip_lz4 >> erofs_try_to_release_workgroup >> >> erofs_workgroup_free_rcu >> z_erofs_map_blocks_iter > There was a request for help to fix these warnings on the > driverdev-devel mailing list last Novemeber (I've also attached the > message): > > > http://driverdev.linuxdriverproject.org/pipermail/driverdev-devel/2018-November/128432.html > > Currently, the flag is only enabled by passing W=1 to make, but since it > is useful, the idea is to fix all the current warnings and enable it in > the main build. OK, it is fine with me personally too since it has no logic change. I will also take care of W=1 from now on, and thanks for your explanation ;) Thanks, Gao Xiang > > J. ___ devel mailing list de...@linuxdriverproject.org http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
Re: [PATCH 0/2] staging: erofs: fixed -Wmissing-prototype warnings.
Hi Jeremy, On 2019/1/8 2:25, Jeremy Sowden wrote: > Fixes for -Wmissing-prototype warnings in the erofs driver. One group of > functions have been made static; for the second, prototypes have been moved > to a > head Is -Wmissing-prototypes required for the current linux kernel? I cannot see this warning in my personal kernel compilation... Functions your fix have already been added proper erofs prefix, therefore it wouldn't pollute the global namespace: z_erofs_vle_work_release z_erofs_unzip_lz4 erofs_try_to_release_workgroup erofs_workgroup_free_rcu z_erofs_map_blocks_iter some thought? Thanks, Gao Xiang ___ devel mailing list de...@linuxdriverproject.org http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
[PATCH 0/2] staging: erofs: fixed -Wmissing-prototype warnings.
Fixes for -Wmissing-prototype warnings in the erofs driver. One group of functions have been made static; for the second, prototypes have been moved to a head Jeremy Sowden (2): staging: erofs: fixed -Wmissing-prototype warnings. staging: erofs: fixed -Wmissing-prototype warnings. drivers/staging/erofs/data.c | 6 -- drivers/staging/erofs/internal.h | 7 +++ drivers/staging/erofs/unzip_vle.c | 2 +- drivers/staging/erofs/unzip_vle_lz4.c | 2 +- drivers/staging/erofs/utils.c | 14 ++ 5 files changed, 15 insertions(+), 16 deletions(-) base-commit: c8c2702409430a6a2fd928e857f15773aaafcc99 -- 2.20.1 ___ devel mailing list de...@linuxdriverproject.org http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
