Re: [PATCH 0/5] staging: rtl8192e: Clean up tests if NULL returned on failure

2017-03-12 Thread SIMRAN SINGHAL 
On Sun, Mar 12, 2017 at 7:12 PM, Greg KH  wrote:
> On Sat, Mar 11, 2017 at 05:10:34PM +0530, SIMRAN SINGHAL wrote:
>> On Sat, Mar 11, 2017 at 5:01 PM, Dan Carpenter  
>> wrote:
>> > On Sat, Mar 11, 2017 at 08:07:01AM +0530, SIMRAN SINGHAL wrote:
>> >> On Sat, Mar 11, 2017 at 2:43 AM, Dan Carpenter  
>> >> wrote:
>> >> > Don't resend, but next time if you wanted to fold all these patches and
>> >> > send them as one patch that would be fine.
>> >> >
>> >>
>> >> Hi Dan,
>> >>
>> >> Before I sent this patches as single patch only, but then greg asked
>> >> me to resend
>> >> them as different patches.
>> >
>> > It took me a few minute to find the email because you didn't give me
>> > a URL or subject to look for.
>> >
>> > https://lkml.org/lkml/2017/3/9/587
>> >
>> > Greg said to break it up by driver.  He didn't say to break it up by
>> > file.  These files are all a part of the same driver.
>> >
>> OOPS, My bad!
>> Thank you for correcting me, will keep this in mind from next time.
>> Should I resend it?
>
> Yes please, I've now dropped this patch series from my queue.
>
I should resend it with the change Dan mentioned.

> greg k-h
___
devel mailing list
de...@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel

Re: [PATCH 0/5] staging: rtl8192e: Clean up tests if NULL returned on failure

2017-03-12 Thread Greg KH 
On Sat, Mar 11, 2017 at 05:10:34PM +0530, SIMRAN SINGHAL wrote:
> On Sat, Mar 11, 2017 at 5:01 PM, Dan Carpenter  
> wrote:
> > On Sat, Mar 11, 2017 at 08:07:01AM +0530, SIMRAN SINGHAL wrote:
> >> On Sat, Mar 11, 2017 at 2:43 AM, Dan Carpenter  
> >> wrote:
> >> > Don't resend, but next time if you wanted to fold all these patches and
> >> > send them as one patch that would be fine.
> >> >
> >>
> >> Hi Dan,
> >>
> >> Before I sent this patches as single patch only, but then greg asked
> >> me to resend
> >> them as different patches.
> >
> > It took me a few minute to find the email because you didn't give me
> > a URL or subject to look for.
> >
> > https://lkml.org/lkml/2017/3/9/587
> >
> > Greg said to break it up by driver.  He didn't say to break it up by
> > file.  These files are all a part of the same driver.
> >
> OOPS, My bad!
> Thank you for correcting me, will keep this in mind from next time.
> Should I resend it?

Yes please, I've now dropped this patch series from my queue.

greg k-h
___
devel mailing list
de...@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel

Re: [PATCH 0/5] staging: rtl8192e: Clean up tests if NULL returned on failure

2017-03-11 Thread SIMRAN SINGHAL 
On Sat, Mar 11, 2017 at 5:01 PM, Dan Carpenter  wrote:
> On Sat, Mar 11, 2017 at 08:07:01AM +0530, SIMRAN SINGHAL wrote:
>> On Sat, Mar 11, 2017 at 2:43 AM, Dan Carpenter  
>> wrote:
>> > Don't resend, but next time if you wanted to fold all these patches and
>> > send them as one patch that would be fine.
>> >
>>
>> Hi Dan,
>>
>> Before I sent this patches as single patch only, but then greg asked
>> me to resend
>> them as different patches.
>
> It took me a few minute to find the email because you didn't give me
> a URL or subject to look for.
>
> https://lkml.org/lkml/2017/3/9/587
>
> Greg said to break it up by driver.  He didn't say to break it up by
> file.  These files are all a part of the same driver.
>
OOPS, My bad!
Thank you for correcting me, will keep this in mind from next time.
Should I resend it?

> regards,
> dan carpenter
___
devel mailing list
de...@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel

Re: [PATCH 0/5] staging: rtl8192e: Clean up tests if NULL returned on failure

2017-03-11 Thread Dan Carpenter 
On Sat, Mar 11, 2017 at 08:07:01AM +0530, SIMRAN SINGHAL wrote:
> On Sat, Mar 11, 2017 at 2:43 AM, Dan Carpenter  
> wrote:
> > Don't resend, but next time if you wanted to fold all these patches and
> > send them as one patch that would be fine.
> >
> 
> Hi Dan,
> 
> Before I sent this patches as single patch only, but then greg asked
> me to resend
> them as different patches.

It took me a few minute to find the email because you didn't give me
a URL or subject to look for.

https://lkml.org/lkml/2017/3/9/587

Greg said to break it up by driver.  He didn't say to break it up by
file.  These files are all a part of the same driver.

regards,
dan carpenter
___
devel mailing list
de...@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel

Re: [PATCH 0/5] staging: rtl8192e: Clean up tests if NULL returned on failure

2017-03-10 Thread SIMRAN SINGHAL 
On Sat, Mar 11, 2017 at 2:43 AM, Dan Carpenter  wrote:
> Don't resend, but next time if you wanted to fold all these patches and
> send them as one patch that would be fine.
>

Hi Dan,

Before I sent this patches as single patch only, but then greg asked
me to resend
them as different patches.

Thanks,
Simran Singhal

> regards,
> dan carpenter
___
devel mailing list
de...@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel

Re: [PATCH 0/5] staging: rtl8192e: Clean up tests if NULL returned on failure

2017-03-10 Thread Dan Carpenter 
Don't resend, but next time if you wanted to fold all these patches and
send them as one patch that would be fine.

regards,
dan carpenter
___
devel mailing list
de...@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel

[PATCH 0/5] staging: rtl8192e: Clean up tests if NULL returned on failure

2017-03-09 Thread simran singhal 
This patch series tests if functions like kmalloc/kzalloc return NULL
on failure. When NULL represents failure, !x is commonly used.

simran singhal (5):
  staging: rtllib_crypt_ccmp: Clean up tests if NULL returned on failure
  staging: rtllib_crypt_tkip: Clean up tests if NULL returned on failure
  staging: rtllib_crypt_wep: Clean up tests if NULL returned on failure
  staging: rtllib_softmac: Clean up tests if NULL returned on failure
  staging: rtllib_wx: Clean up tests if NULL returned on failure

 drivers/staging/rtl8192e/rtllib_crypt_ccmp.c | 2 +-
 drivers/staging/rtl8192e/rtllib_crypt_tkip.c | 2 +-
 drivers/staging/rtl8192e/rtllib_crypt_wep.c  | 2 +-
 drivers/staging/rtl8192e/rtllib_softmac.c| 2 +-
 drivers/staging/rtl8192e/rtllib_wx.c | 4 ++--
 5 files changed, 6 insertions(+), 6 deletions(-)

-- 
2.7.4

___
devel mailing list
de...@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel