Re: [PATCH 0/6] Staging: unisys: code cleanup patches
On Wed, May 28, 2014 at 06:01:17AM -0500, Ken Cox wrote: On 05/23/2014 06:18 AM, Greg KH wrote: On Thu, May 22, 2014 at 12:31:08PM -0500, Ken Cox wrote: This series of patches cleans up the unisys driver code in various ways: -fix sparse warnings related to accessing I/O space -fix sparse warnings related to dereferencing noderef types -add static to function declration -remove unused functions and macros How are you testing any of these given that the driver is still marked BROKEN? I'll send a patch to remove BROKEN from the Kconfig Are you sure that it is ok now? Are the issues that required that to be added now resolved? And why did I have to ask for this? You didn't answer my original question here... greg k-h ___ devel mailing list de...@linuxdriverproject.org http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
Re: [PATCH 0/6] Staging: unisys: code cleanup patches
On 05/28/2014 09:17 AM, Greg KH wrote: On Wed, May 28, 2014 at 06:01:17AM -0500, Ken Cox wrote: On 05/23/2014 06:18 AM, Greg KH wrote: On Thu, May 22, 2014 at 12:31:08PM -0500, Ken Cox wrote: This series of patches cleans up the unisys driver code in various ways: -fix sparse warnings related to accessing I/O space -fix sparse warnings related to dereferencing noderef types -add static to function declration -remove unused functions and macros How are you testing any of these given that the driver is still marked BROKEN? I'll send a patch to remove BROKEN from the Kconfig Are you sure that it is ok now? Are the issues that required that to be added now resolved? And why did I have to ask for this? You didn't answer my original question here... I tested these with a patch that has not been submitted which removes BROKEN from the Kconfig. The original problem reported by Fengguang Wu was that the kernel panicked when running on a virtual machine because the platform detection logic was not sufficient to determine that the proper hardware was not present. That was fixed in commit fcd0157 Staging: unisys: detect s-Par firmware. I was not able to reproduce the panic after this commit. ___ devel mailing list de...@linuxdriverproject.org http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
Re: [PATCH 0/6] Staging: unisys: code cleanup patches
On Thu, May 22, 2014 at 12:31:08PM -0500, Ken Cox wrote: This series of patches cleans up the unisys driver code in various ways: -fix sparse warnings related to accessing I/O space -fix sparse warnings related to dereferencing noderef types -add static to function declration -remove unused functions and macros How are you testing any of these given that the driver is still marked BROKEN? ___ devel mailing list de...@linuxdriverproject.org http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
[PATCH 0/6] Staging: unisys: code cleanup patches
This series of patches cleans up the unisys driver code in various ways: -fix sparse warnings related to accessing I/O space -fix sparse warnings related to dereferencing noderef types -add static to function declration -remove unused functions and macros ___ devel mailing list de...@linuxdriverproject.org http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
