Re: [PATCH 05/20] staging: lustre: lnet: net_fault: mark expected switch fall-through

2017-10-17 Thread Dilger, Andreas 
On Oct 12, 2017, at 10:16, Gustavo A. R. Silva  wrote:
> 
> In preparation to enabling -Wimplicit-fallthrough, mark switch cases
> where we are expecting to fall through.
> 
> Signed-off-by: Gustavo A. R. Silva 

This could also just be "continue;", but doesn't appear harmful.

Reviewed-by: Andreas Dilger 

> ---
> drivers/staging/lustre/lnet/lnet/net_fault.c | 1 +
> 1 file changed, 1 insertion(+)
> 
> diff --git a/drivers/staging/lustre/lnet/lnet/net_fault.c 
> b/drivers/staging/lustre/lnet/lnet/net_fault.c
> index 03f3d18..7391e16 100644
> --- a/drivers/staging/lustre/lnet/lnet/net_fault.c
> +++ b/drivers/staging/lustre/lnet/lnet/net_fault.c
> @@ -629,6 +629,7 @@ delayed_msg_process(struct list_head *msg_list, bool drop)
>   case LNET_CREDIT_OK:
>   lnet_ni_recv(ni, msg->msg_private, msg, 0,
>0, msg->msg_len, msg->msg_len);
> + /* fall through */
>   case LNET_CREDIT_WAIT:
>   continue;
>   default: /* failures */
> -- 
> 2.7.4
> 

Cheers, Andreas
--
Andreas Dilger
Lustre Principal Architect
Intel Corporation







___
devel mailing list
de...@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel

[PATCH 05/20] staging: lustre: lnet: net_fault: mark expected switch fall-through

2017-10-12 Thread Gustavo A. R. Silva 
In preparation to enabling -Wimplicit-fallthrough, mark switch cases
where we are expecting to fall through.

Signed-off-by: Gustavo A. R. Silva 
---
 drivers/staging/lustre/lnet/lnet/net_fault.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/drivers/staging/lustre/lnet/lnet/net_fault.c 
b/drivers/staging/lustre/lnet/lnet/net_fault.c
index 03f3d18..7391e16 100644
--- a/drivers/staging/lustre/lnet/lnet/net_fault.c
+++ b/drivers/staging/lustre/lnet/lnet/net_fault.c
@@ -629,6 +629,7 @@ delayed_msg_process(struct list_head *msg_list, bool drop)
case LNET_CREDIT_OK:
lnet_ni_recv(ni, msg->msg_private, msg, 0,
 0, msg->msg_len, msg->msg_len);
+   /* fall through */
case LNET_CREDIT_WAIT:
continue;
default: /* failures */
-- 
2.7.4

___
devel mailing list
de...@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel