Re: [PATCH 10/15] arm64: dts: allwinner: a64: Add support for the SRAM C1 section

2018-11-15 Thread Chen-Yu Tsai
On Thu, Nov 15, 2018 at 10:50 PM Paul Kocialkowski
 wrote:
>
> Add the description for the SRAM C1 section to the A64 device-tree.
>
> Signed-off-by: Paul Kocialkowski 
> ---
>  arch/arm64/boot/dts/allwinner/sun50i-a64.dtsi | 14 ++
>  1 file changed, 14 insertions(+)
>
> diff --git a/arch/arm64/boot/dts/allwinner/sun50i-a64.dtsi 
> b/arch/arm64/boot/dts/allwinner/sun50i-a64.dtsi
> index f3a66f888205..88b3e9110833 100644
> --- a/arch/arm64/boot/dts/allwinner/sun50i-a64.dtsi
> +++ b/arch/arm64/boot/dts/allwinner/sun50i-a64.dtsi
> @@ -277,6 +277,20 @@
> reg = <0x 0x28000>;
> };
> };
> +
> +   sram_c1: sram@1d0 {
> +   compatible = "mmio-sram";
> +   reg = <0x01d0 0x8>;

I can confirm that this SRAM region is indeed at this address. However the
size is only 0x4, not 0x8. The address ranges should be fixed.

One hiccup is that the VE reset has to be de-asserted and the VE bus clock
has to be ungated for the CPU to access this region when it's mapped to the
CPU.

One other thing I find interesting is that in the previous SoCs, the bits
that control this mapping says 50K, but in reality it is 512K for the older
SoCs, and 256K for this one.

ChenYu

> +   #address-cells = <1>;
> +   #size-cells = <1>;
> +   ranges = <0 0x01d0 0x8>;
> +
> +   ve_sram: sram-section@0 {
> +   compatible = 
> "allwinner,sun50i-a64-sram-c1",
> +
> "allwinner,sun4i-a10-sram-c1";
> +   reg = <0x00 0x8>;
> +   };
> +   };
> };
>
> dma: dma-controller@1c02000 {
> --
> 2.19.1
>
___
devel mailing list
de...@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel


[PATCH 10/15] arm64: dts: allwinner: a64: Add support for the SRAM C1 section

2018-11-15 Thread Paul Kocialkowski
Add the description for the SRAM C1 section to the A64 device-tree.

Signed-off-by: Paul Kocialkowski 
---
 arch/arm64/boot/dts/allwinner/sun50i-a64.dtsi | 14 ++
 1 file changed, 14 insertions(+)

diff --git a/arch/arm64/boot/dts/allwinner/sun50i-a64.dtsi 
b/arch/arm64/boot/dts/allwinner/sun50i-a64.dtsi
index f3a66f888205..88b3e9110833 100644
--- a/arch/arm64/boot/dts/allwinner/sun50i-a64.dtsi
+++ b/arch/arm64/boot/dts/allwinner/sun50i-a64.dtsi
@@ -277,6 +277,20 @@
reg = <0x 0x28000>;
};
};
+
+   sram_c1: sram@1d0 {
+   compatible = "mmio-sram";
+   reg = <0x01d0 0x8>;
+   #address-cells = <1>;
+   #size-cells = <1>;
+   ranges = <0 0x01d0 0x8>;
+
+   ve_sram: sram-section@0 {
+   compatible = 
"allwinner,sun50i-a64-sram-c1",
+
"allwinner,sun4i-a10-sram-c1";
+   reg = <0x00 0x8>;
+   };
+   };
};
 
dma: dma-controller@1c02000 {
-- 
2.19.1

___
devel mailing list
de...@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel