Re: [PATCH 14/20] staging: lustre: lnet: selftest: mark expected switch fall-throughs

[Dilger, Andreas]

On Oct 12, 2017, at 10:17, Gustavo A. R. Silva  wrote:
> 
> 
> In preparation to enabling -Wimplicit-fallthrough, mark switch cases
> where we are expecting to fall through.
> 
> Signed-off-by: Gustavo A. R. Silva 

Reviewed-by: Andreas Dilger 

> ---
> drivers/staging/lustre/lnet/selftest/module.c | 5 -
> 1 file changed, 4 insertions(+), 1 deletion(-)
> 
> diff --git a/drivers/staging/lustre/lnet/selftest/module.c 
> b/drivers/staging/lustre/lnet/selftest/module.c
> index b5d556f..fa1bccc 100644
> --- a/drivers/staging/lustre/lnet/selftest/module.c
> +++ b/drivers/staging/lustre/lnet/selftest/module.c
> @@ -57,10 +57,13 @@ lnet_selftest_exit(void)
>   switch (lst_init_step) {
>   case LST_INIT_CONSOLE:
>   lstcon_console_fini();
> + /* fall through */
>   case LST_INIT_FW:
>   sfw_shutdown();
> + /* fall through */
>   case LST_INIT_RPC:
>   srpc_shutdown();
> + /* fall through */
>   case LST_INIT_WI_TEST:
>   for (i = 0;
>i < cfs_cpt_number(lnet_cpt_table()); i++) {
> @@ -72,7 +75,7 @@ lnet_selftest_exit(void)
>   sizeof(lst_sched_test[0]) *
>   cfs_cpt_number(lnet_cpt_table()));
>   lst_sched_test = NULL;
> -
> + /* fall through */
>   case LST_INIT_WI_SERIAL:
>   cfs_wi_sched_destroy(lst_sched_serial);
>   lst_sched_serial = NULL;
> -- 
> 2.7.4
> 

Cheers, Andreas
--
Andreas Dilger
Lustre Principal Architect
Intel Corporation







___
devel mailing list
de...@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel

[PATCH 14/20] staging: lustre: lnet: selftest: mark expected switch fall-throughs

[Gustavo A. R. Silva]

In preparation to enabling -Wimplicit-fallthrough, mark switch cases
where we are expecting to fall through.

Signed-off-by: Gustavo A. R. Silva 
---
 drivers/staging/lustre/lnet/selftest/module.c | 5 -
 1 file changed, 4 insertions(+), 1 deletion(-)

diff --git a/drivers/staging/lustre/lnet/selftest/module.c 
b/drivers/staging/lustre/lnet/selftest/module.c
index b5d556f..fa1bccc 100644
--- a/drivers/staging/lustre/lnet/selftest/module.c
+++ b/drivers/staging/lustre/lnet/selftest/module.c
@@ -57,10 +57,13 @@ lnet_selftest_exit(void)
switch (lst_init_step) {
case LST_INIT_CONSOLE:
lstcon_console_fini();
+   /* fall through */
case LST_INIT_FW:
sfw_shutdown();
+   /* fall through */
case LST_INIT_RPC:
srpc_shutdown();
+   /* fall through */
case LST_INIT_WI_TEST:
for (i = 0;
 i < cfs_cpt_number(lnet_cpt_table()); i++) {
@@ -72,7 +75,7 @@ lnet_selftest_exit(void)
sizeof(lst_sched_test[0]) *
cfs_cpt_number(lnet_cpt_table()));
lst_sched_test = NULL;
-
+   /* fall through */
case LST_INIT_WI_SERIAL:
cfs_wi_sched_destroy(lst_sched_serial);
lst_sched_serial = NULL;
-- 
2.7.4

___
devel mailing list
de...@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel