Re: [PATCH 2/2] staging: erofs: remove redundant unlikely annotation in unzip_vle.c

2019-02-13 Thread Gao Xiang 
Hi Chengguang,

On 2019/2/13 22:50, cgxu519 wrote:
>
> On 2/13/19 2:36 PM, Chao Yu wrote:
>> On 2019/2/12 11:24, Chengguang Xu wrote:
>>> unlikely has already included in IS_ERR(),
>>> so just remove it.
>>>
>>> Signed-off-by: Chengguang Xu 
>> It looks like we don't need to send two patch to fix two similar
>> issues, if you can merge them, it will be better.
> I agree with you but I noticed the patches have already merged to Greg's 
> staging tree,
> so I'm not sure if it cause inconvenience to his management.
>

I personally think it is not a big problem since that is indeed cleanup patches 
and

thanks for applying erofs patches and happy hacking :)


Thanks,

Gao Xiang


> Thanks,
> Chengguang
>
>
___
devel mailing list
de...@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel

Re: [PATCH 2/2] staging: erofs: remove redundant unlikely annotation in unzip_vle.c

2019-02-13 Thread cgxu519 



On 2/13/19 2:36 PM, Chao Yu wrote:

On 2019/2/12 11:24, Chengguang Xu wrote:

unlikely has already included in IS_ERR(),
so just remove it.

Signed-off-by: Chengguang Xu 

It looks like we don't need to send two patch to fix two similar
issues, if you can merge them, it will be better.
I agree with you but I noticed the patches have already merged to Greg's 
staging tree,

so I'm not sure if it cause inconvenience to his management.

Thanks,
Chengguang


___
devel mailing list
de...@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel

Re: [PATCH 2/2] staging: erofs: remove redundant unlikely annotation in unzip_vle.c

2019-02-12 Thread Chao Yu 
On 2019/2/12 11:24, Chengguang Xu wrote:
> unlikely has already included in IS_ERR(),
> so just remove it.
> 
> Signed-off-by: Chengguang Xu 

It looks like we don't need to send two patch to fix two similar
issues, if you can merge them, it will be better.

Reviewed-by: Chao Yu 

Thanks,

___
devel mailing list
de...@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel

Re: [PATCH 2/2] staging: erofs: remove redundant unlikely annotation in unzip_vle.c

2019-02-11 Thread Gao Xiang 


On 2019/2/12 11:24, Chengguang Xu wrote:
> unlikely has already included in IS_ERR(),
> so just remove it.
>
> Signed-off-by: Chengguang Xu 


Reviewed-by: Gao Xiang 


Thanks,

Gao Xiang

___
devel mailing list
de...@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel

[PATCH 2/2] staging: erofs: remove redundant unlikely annotation in unzip_vle.c

2019-02-11 Thread Chengguang Xu 
unlikely has already included in IS_ERR(),
so just remove it.

Signed-off-by: Chengguang Xu 
---
 drivers/staging/erofs/unzip_vle.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/staging/erofs/unzip_vle.c 
b/drivers/staging/erofs/unzip_vle.c
index 4ac1099a39c6..7cd2d4d9c264 100644
--- a/drivers/staging/erofs/unzip_vle.c
+++ b/drivers/staging/erofs/unzip_vle.c
@@ -539,7 +539,7 @@ static int z_erofs_vle_work_iter_begin(struct 
z_erofs_vle_work_builder *builder,
if (unlikely(work == ERR_PTR(-EAGAIN)))
goto repeat;
 
-   if (unlikely(IS_ERR(work)))
+   if (IS_ERR(work))
return PTR_ERR(work);
 got_it:
z_erofs_pagevec_ctor_init(>vector,
-- 
2.20.1

___
devel mailing list
de...@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel