[PATCH 2/2] staging: vt6556: Cleanup coding style issues

2014-07-13 Thread Peter Senna Tschudin
This patch cleanup coding style issues reported by checkpatch.

Tested by compilation only.

Signed-off-by: Peter Senna Tschudin peter.se...@gmail.com
---
Based on latest staging-next.

 drivers/staging/vt6656/main_usb.c | 118 +-
 1 file changed, 54 insertions(+), 64 deletions(-)

diff --git a/drivers/staging/vt6656/main_usb.c 
b/drivers/staging/vt6656/main_usb.c
index 4cdf29e..13be8b2 100644
--- a/drivers/staging/vt6656/main_usb.c
+++ b/drivers/staging/vt6656/main_usb.c
@@ -62,7 +62,7 @@
 #include int.h
 
 /* static int msglevel = MSG_LEVEL_DEBUG; */
-static int  msglevel=MSG_LEVEL_INFO;
+static int msglevel = MSG_LEVEL_INFO;
 
 /*
  * define module options
@@ -75,18 +75,18 @@ MODULE_AUTHOR(DRIVER_AUTHOR);
 MODULE_LICENSE(GPL);
 MODULE_DESCRIPTION(DEVICE_FULL_DRV_NAM);
 
-#define DEVICE_PARAM(N,D) \
-static int N[MAX_UINTS]=OPTION_DEFAULT;\
-module_param_array(N, int, NULL, 0);\
-MODULE_PARM_DESC(N, D);
+#define DEVICE_PARAM(N, D) \
+   static int N[MAX_UINTS] = OPTION_DEFAULT;   \
+   module_param_array(N, int, NULL, 0);\
+   MODULE_PARM_DESC(N, D)
 
-#define RX_DESC_DEF0 64
-DEVICE_PARAM(RxDescriptors0,Number of receive usb desc buffer);
+#define RX_DESC_DEF0 64
+DEVICE_PARAM(RxDescriptors0, Number of receive usb desc buffer);
 
-#define TX_DESC_DEF0 64
-DEVICE_PARAM(TxDescriptors0,Number of transmit usb desc buffer);
+#define TX_DESC_DEF0 64
+DEVICE_PARAM(TxDescriptors0, Number of transmit usb desc buffer);
 
-#define CHANNEL_DEF 6
+#define CHANNEL_DEF 6
 DEVICE_PARAM(Channel, Channel number);
 
 /* PreambleType[] is the preamble length used for transmit.
@@ -177,13 +177,12 @@ static struct usb_device_id vt6656_table[] = {
 /* frequency list (map channels to frequencies) */
 /*
 static const long frequency_list[] = {
-2412, 2417, 2422, 2427, 2432, 2437, 2442, 2447, 2452, 2457, 2462, 2467, 
2472, 2484,
-4915, 4920, 4925, 4935, 4940, 4945, 4960, 4980,
-5035, 5040, 5045, 5055, 5060, 5080, 5170, 5180, 5190, 5200, 5210, 5220, 
5230, 5240,
-5260, 5280, 5300, 5320, 5500, 5520, 5540, 5560, 5580, 5600, 5620, 5640, 
5660, 5680,
-5700, 5745, 5765, 5785, 5805, 5825
-   };
-
+   2412, 2417, 2422, 2427, 2432, 2437, 2442, 2447, 2452, 2457, 2462, 2467,
+   2472, 2484, 4915, 4920, 4925, 4935, 4940, 4945, 4960, 4980, 5035, 5040,
+   5045, 5055, 5060, 5080, 5170, 5180, 5190, 5200, 5210, 5220, 5230, 5240,
+   5260, 5280, 5300, 5320, 5500, 5520, 5540, 5560, 5580, 5600, 5620, 5640,
+   5660, 5680, 5700, 5745, 5765, 5785, 5805, 5825
+};
 */
 
 static int vt6656_probe(struct usb_interface *intf,
@@ -206,16 +205,16 @@ static void usb_device_reset(struct vnt_private *pDevice);
 
 static void
 device_set_options(struct vnt_private *pDevice) {
-pDevice-cbTD = TX_DESC_DEF0;
-pDevice-cbRD = RX_DESC_DEF0;
-pDevice-byShortRetryLimit = SHORT_RETRY_DEF;
-pDevice-byLongRetryLimit = LONG_RETRY_DEF;
-pDevice-op_mode = NL80211_IFTYPE_UNSPECIFIED;
-pDevice-byBBType = BBP_TYPE_DEF;
-pDevice-byPacketType = pDevice-byBBType;
-pDevice-byAutoFBCtrl = AUTO_FB_0;
-pDevice-byPreambleType = 0;
-pDevice-bExistSWNetAddr = false;
+   pDevice-cbTD = TX_DESC_DEF0;
+   pDevice-cbRD = RX_DESC_DEF0;
+   pDevice-byShortRetryLimit = SHORT_RETRY_DEF;
+   pDevice-byLongRetryLimit = LONG_RETRY_DEF;
+   pDevice-op_mode = NL80211_IFTYPE_UNSPECIFIED;
+   pDevice-byBBType = BBP_TYPE_DEF;
+   pDevice-byPacketType = pDevice-byBBType;
+   pDevice-byAutoFBCtrl = AUTO_FB_0;
+   pDevice-byPreambleType = 0;
+   pDevice-bExistSWNetAddr = false;
 }
 
 /*
@@ -383,38 +382,40 @@ static int device_init_registers(struct vnt_private 
*pDevice)
/* load vt3266 calibration parameters in EEPROM */
if (pDevice-byRFType == RF_VT3226D0) {
if ((pDevice-abyEEPROM[EEP_OFS_MAJOR_VER] == 0x1) 
-   (pDevice-abyEEPROM[EEP_OFS_MINOR_VER] = 0x4)) {
+  (pDevice-abyEEPROM[EEP_OFS_MINOR_VER] = 0x4)) {
 
byCalibTXIQ = pDevice-abyEEPROM[EEP_OFS_CALIB_TX_IQ];
byCalibTXDC = pDevice-abyEEPROM[EEP_OFS_CALIB_TX_DC];
byCalibRXIQ = pDevice-abyEEPROM[EEP_OFS_CALIB_RX_IQ];
if (byCalibTXIQ || byCalibTXDC || byCalibRXIQ) {
-   /* CR255, enable TX/RX IQ and DC compensation mode */
+   /* CR255, enable TX/RX IQ and
+  DC compensation mode */
vnt_control_out_u8(pDevice,
-   MESSAGE_REQUEST_BBREG,
-   0xff,
-   0x03);
-   /* CR251, TX I/Q Imbalance Calibration */
+  MESSAGE_REQUEST_BBREG,
+

Re: [PATCH 2/2] staging: vt6556: Cleanup coding style issues

2014-07-13 Thread Greg KH
On Sun, Jul 13, 2014 at 05:39:55PM +0200, Peter Senna Tschudin wrote:
 This patch cleanup coding style issues reported by checkpatch.
 
 Tested by compilation only.
 
 Signed-off-by: Peter Senna Tschudin peter.se...@gmail.com
 ---
 Based on latest staging-next.

You just sent me 4 patches, all with the same subject (but at least 2 of
them had the order in which to apply them in, which is nice.)

Please redo these such that they have a unique subject, and I can tell
which order to apply them in, as I really have no idea about the second
two.

thanks,

greg k-h
___
devel mailing list
de...@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel