Re: [PATCH 21/29] media: atomisp: Avoid comma separated statements

2020-09-04 Thread Kieran Bingham 
On 25/08/2020 05:56, Joe Perches wrote:
> Use semicolons and braces.
> 
> Signed-off-by: Joe Perches 

Reviewed-by: Kieran Bingham 

> ---
>  drivers/staging/media/atomisp/pci/atomisp_subdev.c | 6 --
>  1 file changed, 4 insertions(+), 2 deletions(-)
> 
> diff --git a/drivers/staging/media/atomisp/pci/atomisp_subdev.c 
> b/drivers/staging/media/atomisp/pci/atomisp_subdev.c
> index 6ba817f15655..52b9fb18c87f 100644
> --- a/drivers/staging/media/atomisp/pci/atomisp_subdev.c
> +++ b/drivers/staging/media/atomisp/pci/atomisp_subdev.c
> @@ -410,8 +410,10 @@ int atomisp_subdev_set_selection(struct v4l2_subdev *sd,
>  
>   if (atomisp_subdev_format_conversion(isp_sd,
>isp_sd->capture_pad)
> - && crop[pad]->width && crop[pad]->height)
> - crop[pad]->width -= padding_w, crop[pad]->height -= 
> padding_h;
> + && crop[pad]->width && crop[pad]->height) {
> + crop[pad]->width -= padding_w;
> + crop[pad]->height -= padding_h;
> + }
>  
>   /* if subdev type is SOC camera,we do not need to set DVS */
>   if (isp->inputs[isp_sd->input_curr].type == SOC_CAMERA)
> 

___
devel mailing list
de...@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel

[PATCH 21/29] media: atomisp: Avoid comma separated statements

2020-08-24 Thread Joe Perches 
Use semicolons and braces.

Signed-off-by: Joe Perches 
---
 drivers/staging/media/atomisp/pci/atomisp_subdev.c | 6 --
 1 file changed, 4 insertions(+), 2 deletions(-)

diff --git a/drivers/staging/media/atomisp/pci/atomisp_subdev.c 
b/drivers/staging/media/atomisp/pci/atomisp_subdev.c
index 6ba817f15655..52b9fb18c87f 100644
--- a/drivers/staging/media/atomisp/pci/atomisp_subdev.c
+++ b/drivers/staging/media/atomisp/pci/atomisp_subdev.c
@@ -410,8 +410,10 @@ int atomisp_subdev_set_selection(struct v4l2_subdev *sd,
 
if (atomisp_subdev_format_conversion(isp_sd,
 isp_sd->capture_pad)
-   && crop[pad]->width && crop[pad]->height)
-   crop[pad]->width -= padding_w, crop[pad]->height -= 
padding_h;
+   && crop[pad]->width && crop[pad]->height) {
+   crop[pad]->width -= padding_w;
+   crop[pad]->height -= padding_h;
+   }
 
/* if subdev type is SOC camera,we do not need to set DVS */
if (isp->inputs[isp_sd->input_curr].type == SOC_CAMERA)
-- 
2.26.0

___
devel mailing list
de...@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel