Re: [PATCH 3/5] staging: vt6656: limit reg output to block size

2020-01-03 Thread Dan Carpenter 
On Fri, Dec 20, 2019 at 09:15:24PM +, Malcolm Priestley wrote:
> vnt_control_out appears to fail when BBREG is greater than 64 writes.
> 
> Create new function that will relay an array in no larger than
> the indicated block size.
> 
> It appears that this command has always failed but was ignored by
> driver until the introduction of error checking.
> 
> Cc: stable  # v5.3+

Please add the Fixes tag.

> Signed-off-by: Malcolm Priestley 
> ---
>  drivers/staging/vt6656/baseband.c |  4 ++--
>  drivers/staging/vt6656/usbpipe.c  | 17 +
>  drivers/staging/vt6656/usbpipe.h  |  5 +
>  3 files changed, 24 insertions(+), 2 deletions(-)
> 
> diff --git a/drivers/staging/vt6656/baseband.c 
> b/drivers/staging/vt6656/baseband.c
> index 8d19ae71e7cc..4e651b698617 100644
> --- a/drivers/staging/vt6656/baseband.c
> +++ b/drivers/staging/vt6656/baseband.c
> @@ -449,8 +449,8 @@ int vnt_vt3184_init(struct vnt_private *priv)
>  
>   memcpy(array, addr, length);
>  
> - ret = vnt_control_out(priv, MESSAGE_TYPE_WRITE, 0,
> -   MESSAGE_REQUEST_BBREG, length, array);
> + ret = vnt_control_out_blocks(priv, VNT_REG_BLOCK_SIZE,
> +  MESSAGE_REQUEST_BBREG, length, array);
>   if (ret)
>   goto end;
>  
> diff --git a/drivers/staging/vt6656/usbpipe.c 
> b/drivers/staging/vt6656/usbpipe.c
> index 488ebd98773d..d977d4777e4f 100644
> --- a/drivers/staging/vt6656/usbpipe.c
> +++ b/drivers/staging/vt6656/usbpipe.c
> @@ -76,6 +76,23 @@ int vnt_control_out_u8(struct vnt_private *priv, u8 reg, 
> u8 reg_off, u8 data)
>  reg_off, reg, sizeof(u8), );
>  }
>  
> +int vnt_control_out_blocks(struct vnt_private *priv,
> +u16 block, u8 reg, u16 length, u8 *data)
> +{
> + int ret = 0, i;
> +
> + for (i = 0; i < length; i += block) {
> + u16 len = min_t(int, length - i, block);
> +
> + ret = vnt_control_out(priv, MESSAGE_TYPE_WRITE,
> +   i, reg, len, data + i);
> + if (ret)
> + goto end;
> + }
> +end:
> + return ret;

Just do a direct return.  Goto end is pointless.  It hurts readability
because with direct returns we can immediately see that this returns
zero on success.

regards,
dan carpenter

___
devel mailing list
de...@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel

[PATCH 3/5] staging: vt6656: limit reg output to block size

2019-12-20 Thread Malcolm Priestley 
vnt_control_out appears to fail when BBREG is greater than 64 writes.

Create new function that will relay an array in no larger than
the indicated block size.

It appears that this command has always failed but was ignored by
driver until the introduction of error checking.

Cc: stable  # v5.3+
Signed-off-by: Malcolm Priestley 
---
 drivers/staging/vt6656/baseband.c |  4 ++--
 drivers/staging/vt6656/usbpipe.c  | 17 +
 drivers/staging/vt6656/usbpipe.h  |  5 +
 3 files changed, 24 insertions(+), 2 deletions(-)

diff --git a/drivers/staging/vt6656/baseband.c 
b/drivers/staging/vt6656/baseband.c
index 8d19ae71e7cc..4e651b698617 100644
--- a/drivers/staging/vt6656/baseband.c
+++ b/drivers/staging/vt6656/baseband.c
@@ -449,8 +449,8 @@ int vnt_vt3184_init(struct vnt_private *priv)
 
memcpy(array, addr, length);
 
-   ret = vnt_control_out(priv, MESSAGE_TYPE_WRITE, 0,
- MESSAGE_REQUEST_BBREG, length, array);
+   ret = vnt_control_out_blocks(priv, VNT_REG_BLOCK_SIZE,
+MESSAGE_REQUEST_BBREG, length, array);
if (ret)
goto end;
 
diff --git a/drivers/staging/vt6656/usbpipe.c b/drivers/staging/vt6656/usbpipe.c
index 488ebd98773d..d977d4777e4f 100644
--- a/drivers/staging/vt6656/usbpipe.c
+++ b/drivers/staging/vt6656/usbpipe.c
@@ -76,6 +76,23 @@ int vnt_control_out_u8(struct vnt_private *priv, u8 reg, u8 
reg_off, u8 data)
   reg_off, reg, sizeof(u8), );
 }
 
+int vnt_control_out_blocks(struct vnt_private *priv,
+  u16 block, u8 reg, u16 length, u8 *data)
+{
+   int ret = 0, i;
+
+   for (i = 0; i < length; i += block) {
+   u16 len = min_t(int, length - i, block);
+
+   ret = vnt_control_out(priv, MESSAGE_TYPE_WRITE,
+ i, reg, len, data + i);
+   if (ret)
+   goto end;
+   }
+end:
+   return ret;
+}
+
 int vnt_control_in(struct vnt_private *priv, u8 request, u16 value,
   u16 index, u16 length, u8 *buffer)
 {
diff --git a/drivers/staging/vt6656/usbpipe.h b/drivers/staging/vt6656/usbpipe.h
index 95147ec7b96a..b65d9c01a211 100644
--- a/drivers/staging/vt6656/usbpipe.h
+++ b/drivers/staging/vt6656/usbpipe.h
@@ -18,6 +18,8 @@
 
 #include "device.h"
 
+#define VNT_REG_BLOCK_SIZE 64
+
 int vnt_control_out(struct vnt_private *priv, u8 request, u16 value,
u16 index, u16 length, u8 *buffer);
 int vnt_control_in(struct vnt_private *priv, u8 request, u16 value,
@@ -26,6 +28,9 @@ int vnt_control_in(struct vnt_private *priv, u8 request, u16 
value,
 int vnt_control_out_u8(struct vnt_private *priv, u8 reg, u8 ref_off, u8 data);
 int vnt_control_in_u8(struct vnt_private *priv, u8 reg, u8 reg_off, u8 *data);
 
+int vnt_control_out_blocks(struct vnt_private *priv,
+  u16 block, u8 reg, u16 len, u8 *data);
+
 int vnt_start_interrupt_urb(struct vnt_private *priv);
 int vnt_submit_rx_urb(struct vnt_private *priv, struct vnt_rcb *rcb);
 int vnt_tx_context(struct vnt_private *priv,
-- 
2.24.0
___
devel mailing list
de...@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel