Re: [PATCH 4/5] staging: emxx_udc: add missing usb_ep_set_maxpacket_limit()
Hello. On 7/7/2015 5:02 PM, Robert Baldyga wrote: Should use usb_ep_set_maxpacket_limit instead of setting maxpacket value manually. Signed-off-by: Robert Baldyga r.bald...@samsung.com --- drivers/staging/emxx_udc/emxx_udc.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/drivers/staging/emxx_udc/emxx_udc.c b/drivers/staging/emxx_udc/emxx_udc.c index 4178d96..f50bf5d 100644 --- a/drivers/staging/emxx_udc/emxx_udc.c +++ b/drivers/staging/emxx_udc/emxx_udc.c @@ -3203,7 +3203,8 @@ static void __init nbu2ss_drv_ep_init(struct nbu2ss_udc *udc) ep-ep.name = gp_ep_name[i]; ep-ep.ops = nbu2ss_ep_ops; - ep-ep.maxpacket = (i == 0 ? EP0_PACKETSIZE : EP_PACKETSIZE); + usb_ep_set_maxpacket_limit(ep-ep, + (i == 0 ? EP0_PACKETSIZE : EP_PACKETSIZE)); Inner () not needed. [...] WBR, Sergei ___ devel mailing list de...@linuxdriverproject.org http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
[PATCH 4/5] staging: emxx_udc: add missing usb_ep_set_maxpacket_limit()
Should use usb_ep_set_maxpacket_limit instead of setting maxpacket value manually. Signed-off-by: Robert Baldyga r.bald...@samsung.com --- drivers/staging/emxx_udc/emxx_udc.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/drivers/staging/emxx_udc/emxx_udc.c b/drivers/staging/emxx_udc/emxx_udc.c index 4178d96..f50bf5d 100644 --- a/drivers/staging/emxx_udc/emxx_udc.c +++ b/drivers/staging/emxx_udc/emxx_udc.c @@ -3203,7 +3203,8 @@ static void __init nbu2ss_drv_ep_init(struct nbu2ss_udc *udc) ep-ep.name = gp_ep_name[i]; ep-ep.ops = nbu2ss_ep_ops; - ep-ep.maxpacket = (i == 0 ? EP0_PACKETSIZE : EP_PACKETSIZE); + usb_ep_set_maxpacket_limit(ep-ep, + (i == 0 ? EP0_PACKETSIZE : EP_PACKETSIZE)); list_add_tail(ep-ep.ep_list, udc-gadget.ep_list); INIT_LIST_HEAD(ep-queue); -- 1.9.1 ___ devel mailing list de...@linuxdriverproject.org http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
Re: [PATCH 4/5] staging: emxx_udc: add missing usb_ep_set_maxpacket_limit()
On Tue, Jul 07, 2015 at 04:02:52PM +0200, Robert Baldyga wrote: Should use usb_ep_set_maxpacket_limit instead of setting maxpacket value manually. Same question. regards, dan carpenter ___ devel mailing list de...@linuxdriverproject.org http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
